[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2018-08-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. Th

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-08-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. T

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-08-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio has an issue affecting its community integration. Th

[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...

2018-08-18 Thread spyhunter99
Github user spyhunter99 commented on the issue: https://github.com/apache/tomcat/pull/119 Yup i'm on it. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomca

[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...

2018-08-18 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/119 Please have a look what @ChristopherSchultz has proposed on the ticket. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa

[GitHub] tomcat pull request #119: API change for Realm and AuthenticatorBase to make...

2018-08-18 Thread spyhunter99
Github user spyhunter99 closed the pull request at: https://github.com/apache/tomcat/pull/119 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...

2018-08-18 Thread spyhunter99
Github user spyhunter99 commented on the issue: https://github.com/apache/tomcat/pull/119 OK. i'll see if i can get to work on that --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional comma

[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...

2018-08-18 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/119 I'd really like to go with listeners as proposed just like the Spring Secutiry framework does. You will be able to do whatever your want with that information. --- --

[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...

2018-08-18 Thread spyhunter99
Github user spyhunter99 commented on the issue: https://github.com/apache/tomcat/pull/119 next best option is to add a new method signature which will also impact the public api. It's slightly less impactful for users that have extended any of the base classes but if they have impleme

[Bug 59750] Amend "authenticate" method with context by means of HttpServletRequest

2018-08-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59750 --- Comment #3 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Christopher Schultz from comment #2) > Created attachment 35824 [details] > Draft patch to give an idea of the proposal > > See this draft patch for something that might w

[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...

2018-08-18 Thread michael-o
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/119 Oh hell, this will break the public API in a patch release. Especially for custom components. They won't retrain backward compat. Isn't there a better way for this? ---

[GitHub] tomcat pull request #119: API change for Realm and AuthenticatorBase to make...

2018-08-18 Thread spyhunter99
GitHub user spyhunter99 opened a pull request: https://github.com/apache/tomcat/pull/119 API change for Realm and AuthenticatorBase to make remote ip addresses available Related to Bug 59750 https://bz.apache.org/bugzilla/show_bug.cgi?id=59750 Goal: for the LockedRealm, be

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-08-18 Thread Bill Barker
n-1.1.1-SNAPSHOT.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20180818/bin/openssl -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar -Dexecute.test.apr=false -Dtest.exc