https://bz.apache.org/bugzilla/show_bug.cgi?id=62515
--- Comment #8 from Mark Thomas ---
Good catch on bindState. I've tweaked that part and also fixed a bug in the NIO
handling.
I don't think this can be added as part of pause() and resume() as my
understanding of those methods is that they are
On 05/07/18 18:13, Gunnar Brand wrote:
> That aside, setting “Vary: Origin” is of course very bad for caching. But
> then the CorsFilter should probably only be mapped to APIs called remotely.
> As improvement, since with Bug 62343 allowed.origins = ‘*’ will always set
> Access-Control-Allow-O
Author: markt
Date: Fri Jul 6 17:20:05 2018
New Revision: 1835271
URL: http://svn.apache.org/viewvc?rev=1835271&view=rev
Log:
Fix cache interoperability problem.
Note: Always adding this header reduces the usefulness of caches significantly.
Next task is to look at possible optimisations.
Modif
Author: markt
Date: Fri Jul 6 17:17:30 2018
New Revision: 1835270
URL: http://svn.apache.org/viewvc?rev=1835270&view=rev
Log:
Header is now lower case after Vary refactoring
Modified:
tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java
Modified: tomcat/trunk/test/org/apac
Author: markt
Date: Fri Jul 6 17:17:04 2018
New Revision: 1835269
URL: http://svn.apache.org/viewvc?rev=1835269&view=rev
Log:
TestCORSFilter needs this to return an empty collection (as per the Servlet
spec) rather than null.
Modified:
tomcat/trunk/test/org/apache/catalina/filters/TesterHtt
The Buildbot has detected a new failure on builder tomcat-trunk while building
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3441
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler schedu
Author: markt
Date: Fri Jul 6 16:25:40 2018
New Revision: 1835264
URL: http://svn.apache.org/viewvc?rev=1835264&view=rev
Log:
Refactor code that adds an additional header name to the Vary HTTP response
header to use a common utility method that addresses several additional edge
cases.
Modified
Author: markt
Date: Fri Jul 6 16:20:19 2018
New Revision: 1835263
URL: http://svn.apache.org/viewvc?rev=1835263&view=rev
Log:
Expand code for adding Vary header value to support all current potential uses
in Tomcat code base.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/ResponseU
The Apache Tomcat team announces the immediate availability of Apache
Tomcat 8.0.53.
Please note that Apache Tomcat 8.0.x has reached end of life!
Apache Tomcat 8.0 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language and Java
WebSock
Author: markt
Date: Fri Jul 6 15:26:30 2018
New Revision: 1835261
URL: http://svn.apache.org/viewvc?rev=1835261&view=rev
Log:
Add a utility method (and associated test cases) that adds updates / creates a
Vary header with a given field name. Multiple headers will be collapsed and
invalid values
Author: violetagg
Date: Fri Jul 6 15:07:47 2018
New Revision: 1835260
URL: http://svn.apache.org/viewvc?rev=1835260&view=rev
Log:
Update docs for Apache Tomcat 8.0.53 release.
[This commit notification would consist of 79 parts,
which exceeds the limit of 50 ones, so it was shortened to the su
Author: violetagg
Date: Fri Jul 6 14:54:57 2018
New Revision: 1835258
URL: http://svn.apache.org/viewvc?rev=1835258&view=rev
Log:
Updates (excluding docs) for 8.0.53 release
Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/
https://bz.apache.org/bugzilla/show_bug.cgi?id=62453
--- Comment #10 from Remy Maucherat ---
That sounds like the best hack ever.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mai
https://bz.apache.org/bugzilla/show_bug.cgi?id=62453
--- Comment #9 from Konstantin Kolinko ---
One more idea:
The public classes in Java Platform API all follow the naming conventions and
start with an uppercase character A-Z.
Attribute names usually start with a lowercase character.
--
You a
Author: markt
Date: Fri Jul 6 13:00:06 2018
New Revision: 1835246
URL: http://svn.apache.org/viewvc?rev=1835246&view=rev
Log:
Improve parsing
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Vary.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/parser/Vary.java
URL
https://bz.apache.org/bugzilla/show_bug.cgi?id=62515
--- Comment #7 from Remy Maucherat ---
(In reply to Remy Maucherat from comment #6)
> But then we'll probably refactor it, since maybe this should simply go into
> pause/resume (resume could reopen the server socket ?). I'm pretty sure the
> bi
https://bz.apache.org/bugzilla/show_bug.cgi?id=62515
--- Comment #6 from Remy Maucherat ---
Also +1, you should commit it as it's a useful change.
But then we'll probably refactor it, since maybe this should simply go into
pause/resume (resume could reopen the server socket ?). I'm pretty sure t
Author: markt
Date: Fri Jul 6 10:39:44 2018
New Revision: 1835229
URL: http://svn.apache.org/viewvc?rev=1835229&view=rev
Log:
Add a (currently unused) Vary header parser and associated test case.
Added:
tomcat/trunk/java/org/apache/tomcat/util/http/parser/Vary.java (with
props)
tomcat
On 06/07/18 08:24, Mark Thomas wrote:
> Agreed. That should be an easy change to make. I'll also review the code
> to see if we use the Vary header anywhere else that needs a similar tweak.
There are a couple of places where we modify the Vary header, both for
compression. The DefaultServlet
https://bz.apache.org/bugzilla/show_bug.cgi?id=62515
Mark Thomas changed:
What|Removed |Added
Attachment #36012|0 |1
is obsolete|
On 05/07/18 18:13, Gunnar Brand wrote:
> I believe that for all URLs the CorsFilter matches, any unique Origin
> header’s value is a variant, since the returned access control headers
> differ. But also its absence is a variant (allowed headers are missing
> altogether) and thus warrants a “V
21 matches
Mail list logo
