[Bug 61751] NIO2 connector cuts incoming request

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 --- Comment #19 from Markus Dörschmidt --- Thank you very much. The bug is fixed! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

[Bug 62048] Missing logout function in Manager and Host-Manager webapps

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62048 Konstantin Kolinko changed: What|Removed |Added CC||ma...@apache.org --- Comment #9 f

[Bug 44299] Provide manager app with a logout button

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=44299 Konstantin Kolinko changed: What|Removed |Added Resolution|WONTFIX |DUPLICATE Summary|Prov

svn commit: r1824264 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java webapps/docs/changelog.xml

2018-02-14 Thread remm
Author: remm Date: Wed Feb 14 18:06:40 2018 New Revision: 1824264 URL: http://svn.apache.org/viewvc?rev=1824264&view=rev Log: Minor OpenSSL engine cleanups. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

svn commit: r1824263 - in /tomcat/trunk: java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java webapps/docs/changelog.xml

2018-02-14 Thread remm
Author: remm Date: Wed Feb 14 18:05:36 2018 New Revision: 1824263 URL: http://svn.apache.org/viewvc?rev=1824263&view=rev Log: Minor OpenSSL engine cleanups. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java tomcat/trunk/webapps/docs/changelog.xml Modified:

Re: h2test

2018-02-14 Thread Rémy Maucherat
On Wed, Feb 14, 2018 at 6:27 PM, Mark Thomas wrote: > If you are testing PING (or anything else) you probably need to disable > the keep-alive PINGs else they mess up the test. > > You want the hidden option initiatePingDisabled="false" on the > Http2Protocol > It didn't work as it is the defaul

Re: h2test

2018-02-14 Thread Mark Thomas
On 14/02/18 17:21, Rémy Maucherat wrote: > On Wed, Feb 14, 2018 at 6:09 PM, Mark Thomas wrote: > >> On 14/02/18 15:41, Rémy Maucherat wrote: >>> Hi, >>> >>> I'm using h2test on and off to see what's going on. It helps me find a >>> significant issue sometimes (like this one r1823670). >> >> I've

[Bug 62048] Missing logout function in Manager and Host-Manager webapps

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62048 --- Comment #8 from Mark Thomas --- I think it is worth a try. I also have some suggested changes to the patch: - Move the logout button to the next row down and ensure it appears on other screens with a similar banner. - rather than display a

Re: h2test

2018-02-14 Thread Rémy Maucherat
On Wed, Feb 14, 2018 at 6:09 PM, Mark Thomas wrote: > On 14/02/18 15:41, Rémy Maucherat wrote: > > Hi, > > > > I'm using h2test on and off to see what's going on. It helps me find a > > significant issue sometimes (like this one r1823670). > > I've been using h2spec which also found a number of i

Re: h2test

2018-02-14 Thread Mark Thomas
On 14/02/18 15:41, Rémy Maucherat wrote: > Hi, > > I'm using h2test on and off to see what's going on. It helps me find a > significant issue sometimes (like this one r1823670). I've been using h2spec which also found a number of issues. Generally, test suites are very helpful. > Now, it almost

buildbot success in on tomcat-trunk

2018-02-14 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3063 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1824256 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

2018-02-14 Thread remm
Author: remm Date: Wed Feb 14 16:00:33 2018 New Revision: 1824256 URL: http://svn.apache.org/viewvc?rev=1824256&view=rev Log: Replace accepted int hack by an enum. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine

svn commit: r1824254 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

2018-02-14 Thread remm
Author: remm Date: Wed Feb 14 15:58:43 2018 New Revision: 1824254 URL: http://svn.apache.org/viewvc?rev=1824254&view=rev Log: Replace accepted int hack by an enum. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java Modified: tomcat/trunk/java/org/apache/tomcat

[Bug 62048] Missing logout function in Manager and Host-Manager webapps

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62048 --- Comment #7 from Marek Czernek --- Hi Mark, that is fair. However, would you lean towards accepting the PR if I managed to execute the logout with Javascript? I believe it might be possible to enforce the logout on other clients by sending

Re: [Git migration] How to handle svn:external used by Tomcat Native

2018-02-14 Thread Emmanuel Bourg
Le 11/02/2018 à 21:36, Mark Thomas a écrit : > Thoughts? comments? I'd like to suggest an alternative: what about packaging the Java part of tomcat-native into a jar (and potentially publishing it to Maven Central) and then adding it to the Tomcat dependencies? Emmanuel Bourg --

[Bug 62048] Missing logout function in Manager and Host-Manager webapps

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62048 --- Comment #6 from Mark Thomas --- Chrome (desktop and mobile) and the Android clients I have easy access to (i.e. anything controlled by Google) handle this as described and the logout works. Safari (desktop and mobile), Firefox (desktop), I

h2test

2018-02-14 Thread Rémy Maucherat
Hi, I'm using h2test on and off to see what's going on. It helps me find a significant issue sometimes (like this one r1823670). Now, it almost looks ok, with a few oddities left: - The ping flag may be inverted (ack is supposed to be 0, not 1, from what I read in the spec). Did I miss something

Apache EU Roadshow CFP Closing Soon (23 February)

2018-02-14 Thread Sharan F
Hello Everyone This is an initial reminder to let you all know that we are holding an Apache EU Roadshow co-located with FOSS Backstage in Berlin on 13^th and 14^th June 2018. https://s.apache.org/tCHx The Call for Proposals (CFP) for the Apache EU Roadshow is currently open and will close a

buildbot failure in on tomcat-trunk

2018-02-14 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3062 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

svn commit: r1824236 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

2018-02-14 Thread remm
Author: remm Date: Wed Feb 14 13:16:45 2018 New Revision: 1824236 URL: http://svn.apache.org/viewvc?rev=1824236&view=rev Log: Remove todo. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.ja

[Bug 62048] Missing logout function in Manager and Host-Manager webapps

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62048 --- Comment #5 from Mark Thomas --- I'm pleasantly surprised at how clean this fix was. Nice. However, I am concerned that the behaviour is not mandated by any specification. RFC7235, section 6.2 explicitly states that HTTP does NOT provide a

[ANN] Apache Tomcat 7.0.85 released

2018-02-14 Thread Violeta Georgieva
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.85. Apache Tomcat is an open source software implementation of the Java Servlet, JavaServer Pages, Java Expression Language and Java WebSocket technologies. This release contains a number of bug fixes and improvement

Re: How to proceed on the CSP issue.

2018-02-14 Thread Mark Thomas
On 14/02/18 11:51, Harrison & Wells wrote: > Sorry to disturb you. Not at all. > I read the Contributing.md > on your > github mirror and even found the beginner issues >

[ANN] Apache Tomcat 8.0.50 released

2018-02-14 Thread Violeta Georgieva
The Apache Tomcat team announces the immediate availability of Apache Tomcat 8.0.50. Please note that Apache Tomcat 8.x users should normally be using 8.5.x releases in preference to 8.0.x releases. The Apache Tomcat team announced that support for Apache Tomcat 8.0.x will end on 30 June 2018. Ap

svn commit: r1824233 - in /tomcat/site/trunk: docs/doap_Tomcat.rdf docs/whichversion.html xdocs/doap_Tomcat.rdf xdocs/whichversion.xml

2018-02-14 Thread violetagg
Author: violetagg Date: Wed Feb 14 12:27:38 2018 New Revision: 1824233 URL: http://svn.apache.org/viewvc?rev=1824233&view=rev Log: Missed version update in "doap" files & "whichversion" files Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/docs/whichversion.html tom

svn commit: r25055 - /release/tomcat/tomcat-7/v7.0.84/

2018-02-14 Thread violetagg
Author: violetagg Date: Wed Feb 14 12:20:33 2018 New Revision: 25055 Log: Remove 7.0.84 Removed: release/tomcat/tomcat-7/v7.0.84/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

svn commit: r1824232 - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2018-02-14 Thread violetagg
Author: violetagg Date: Wed Feb 14 12:19:27 2018 New Revision: 1824232 URL: http://svn.apache.org/viewvc?rev=1824232&view=rev Log: Update docs for Apache Tomcat 7.0.85 release. [This commit notification would consist of 58 parts, which exceeds the limit of 50 ones, so it was shortened to the su

Re: [Git migration] How to handle svn:external used by Tomcat Native

2018-02-14 Thread Rainer Jung
Am 14.02.2018 um 12:15 schrieb Emmanuel Bourg: Le 12/02/2018 à 19:43, Christopher Schultz a écrit : Is there also option 3) amend the build process to fetch the source from svn? This would be a bit inconvenient for Linux distributions like Debian that build Tomcat in offline mode. I guess w

svn commit: r1824230 - in /tomcat/site/trunk: ./ docs/ xdocs/

2018-02-14 Thread violetagg
Author: violetagg Date: Wed Feb 14 12:07:17 2018 New Revision: 1824230 URL: http://svn.apache.org/viewvc?rev=1824230&view=rev Log: Updates (excluding docs) for 7.0.85 release Modified: tomcat/site/trunk/build.properties.default tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/

[Bug 61751] NIO2 connector cuts incoming request

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

svn commit: r1824229 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/Nio2Endpoint.java

2018-02-14 Thread markt
Author: markt Date: Wed Feb 14 11:59:15 2018 New Revision: 1824229 URL: http://svn.apache.org/viewvc?rev=1824229&view=rev Log: Revert r1823263, the workaround for https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 that is now unnecessary. Modified: tomcat/tc8.5.x/trunk/ (props changed)

svn commit: r1824228 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2018-02-14 Thread markt
Author: markt Date: Wed Feb 14 11:57:28 2018 New Revision: 1824228 URL: http://svn.apache.org/viewvc?rev=1824228&view=rev Log: Revert r1823262, the workaround for https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 that is now unnecessary. Modified: tomcat/trunk/java/org/apache/tomcat/util/

svn commit: r25054 - in /release/tomcat/tomcat-8: v8.0.49/ v8.5.27/

2018-02-14 Thread violetagg
Author: violetagg Date: Wed Feb 14 11:51:16 2018 New Revision: 25054 Log: Remove 8.0.49 & 8.5.27 Removed: release/tomcat/tomcat-8/v8.0.49/ release/tomcat/tomcat-8/v8.5.27/ - To unsubscribe, e-mail: dev-unsubscr...@tomca

How to proceed on the CSP issue.

2018-02-14 Thread Harrison & Wells
Sorry to disturb you. I read the Contributing.md on your github mirror and even found the beginner issues

svn commit: r1824227 - in /tomcat/site/trunk/docs/tomcat-8.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2018-02-14 Thread violetagg
Author: violetagg Date: Wed Feb 14 11:45:47 2018 New Revision: 1824227 URL: http://svn.apache.org/viewvc?rev=1824227&view=rev Log: Update docs for Apache Tomcat 8.0.50 release. [This commit notification would consist of 60 parts, which exceeds the limit of 50 ones, so it was shortened to the su

svn commit: r1824224 - in /tomcat/site/trunk: ./ docs/ xdocs/

2018-02-14 Thread violetagg
Author: violetagg Date: Wed Feb 14 11:33:36 2018 New Revision: 1824224 URL: http://svn.apache.org/viewvc?rev=1824224&view=rev Log: Updates (excluding docs) for 8.0.50 release Modified: tomcat/site/trunk/build.properties.default tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/

Re: JDK 10: First Release Candidate - JDK 10 b43

2018-02-14 Thread Mark Thomas
Mostly as a note to myself, this RC is affected by: https://bugs.openjdk.java.net/browse/JDK-8195096 It doesn't look like the fix is going to be back-ported to Java 10 so we are probably stuck with the current workaround[1] for some time. Mark [1] https://svn.apache.org/viewvc?view=revision&revi

Re: [Git migration] How to handle svn:external used by Tomcat Native

2018-02-14 Thread Emmanuel Bourg
Le 12/02/2018 à 19:43, Christopher Schultz a écrit : > Is there also option 3) amend the build process to fetch the source > from svn? This would be a bit inconvenient for Linux distributions like Debian that build Tomcat in offline mode. Emmanuel Bourg -

buildbot success in on tomcat-trunk

2018-02-14 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3059 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1824215 - /tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java

2018-02-14 Thread markt
Author: markt Date: Wed Feb 14 10:33:47 2018 New Revision: 1824215 URL: http://svn.apache.org/viewvc?rev=1824215&view=rev Log: Fix IDE nag Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java URL: http://sv

[Bug 41007] Can't define customized 503 error page

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=41007 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1824210 - in /tomcat/trunk: java/org/apache/catalina/util/ java/org/apache/catalina/valves/ webapps/docs/ webapps/docs/config/

2018-02-14 Thread markt
Author: markt Date: Wed Feb 14 10:17:19 2018 New Revision: 1824210 URL: http://svn.apache.org/viewvc?rev=1824210&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=41007 Add the ability to specify static HTML responses for specific error codes and/or exception types with the ErrorRe

[Bug 61751] NIO2 connector cuts incoming request

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 Mark Thomas changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

buildbot failure in on tomcat-trunk

2018-02-14 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3058 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

[Bug 61751] NIO2 connector cuts incoming request

2018-02-14 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61751 --- Comment #16 from Remy Maucherat --- I added a follow up: http://svn.apache.org/viewvc?rev=1824201&view=rev As this didn't happen with the regular JSSE engine, I think the missing underflow status is the root cause (the unwrap loops in Secu

svn commit: r1824204 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java webapps/docs/changelog.xml

2018-02-14 Thread remm
Author: remm Date: Wed Feb 14 08:35:30 2018 New Revision: 1824204 URL: http://svn.apache.org/viewvc?rev=1824204&view=rev Log: Follow up for 61751 as underflow should be returned when no app bytes are produced but all encrypted input bytes have been consumed. Handshake remains specific as app byt

svn commit: r1824201 - in /tomcat/trunk: java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java webapps/docs/changelog.xml

2018-02-14 Thread remm
Author: remm Date: Wed Feb 14 08:30:28 2018 New Revision: 1824201 URL: http://svn.apache.org/viewvc?rev=1824201&view=rev Log: Follow up for 61751 as underflow should be returned when no app bytes are produced but all encrypted input bytes have been consumed. Handshake remains specific as app byt