Re: svn commit: r1801198 - /tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java

On Fri, Jul 7, 2017 at 12:37 PM, wrote: > Author: remm > Date: Fri Jul 7 17:37:12 2017 > New Revision: 1801198 > > URL: http://svn.apache.org/viewvc?rev=1801198&view=rev > Log: > Refactor propertySource as final. > And I prefer not backporting it since people could be taking advantage of the ha

svn commit: r1801198 - /tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java

Author: remm Date: Fri Jul 7 17:37:12 2017 New Revision: 1801198 URL: http://svn.apache.org/viewvc?rev=1801198&view=rev Log: Refactor propertySource as final. Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Modified: tomcat/trunk/java/org/apache/tomcat/util/digeste

buildbot success in on tomcat-7-trunk

The Buildbot has detected a restored build on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/808 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1801196 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

Author: remm Date: Fri Jul 7 16:37:32 2017 New Revision: 1801196 URL: http://svn.apache.org/viewvc?rev=1801196&view=rev Log: Fix some bad sync in OpenSSLEngine, any async use of the ssl pointer could cause a crash. It shouldn't happen as the engine is not directly accessible, but the cost is ve

svn commit: r1801195 - /tomcat/trunk/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java

Author: remm Date: Fri Jul 7 16:35:26 2017 New Revision: 1801195 URL: http://svn.apache.org/viewvc?rev=1801195&view=rev Log: Fix some bad sync in OpenSSLEngine, any async use of the ssl pointer could cause a crash. It shouldn't happen as the engine is not directly accessible, but the cost is ve

svn commit: r1801186 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java

Author: markt Date: Fri Jul 7 16:13:38 2017 New Revision: 1801186 URL: http://svn.apache.org/viewvc?rev=1801186&view=rev Log: Follow-up to r1801151 There is a setResources() method in this class and the super class. The patch needed to make sure the right setResources() was called. Modified:

Re: buildbot failure in on tomcat-7-trunk

On 07/07/17 14:37, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-7-trunk while > building . Full details are available at: > https://ci.apache.org/builders/tomcat-7-trunk/builds/803 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Buil

svn commit: r1801180 - in /tomcat/tc7.0.x/trunk: java/org/apache/naming/resources/ConcurrentDateFormat.java java/org/apache/naming/resources/ResourceAttributes.java res/findbugs/filter-false-positives

Author: markt Date: Fri Jul 7 15:13:11 2017 New Revision: 1801180 URL: http://svn.apache.org/viewvc?rev=1801180&view=rev Log: FindBugs: Make use of SimpleDateFormat instances thread-safe. Added: tomcat/tc7.0.x/trunk/java/org/apache/naming/resources/ConcurrentDateFormat.java - copied,

svn commit: r1801175 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/websocket/server/TesterWsCloseClient.java

Author: markt Date: Fri Jul 7 14:56:49 2017 New Revision: 1801175 URL: http://svn.apache.org/viewvc?rev=1801175&view=rev Log: Fix one FindBugs and one Javadoc warning Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/server/TesterWsC

svn commit: r1801174 - /tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml

Author: markt Date: Fri Jul 7 14:55:12 2017 New Revision: 1801174 URL: http://svn.apache.org/viewvc?rev=1801174&view=rev Log: Move exclusions for test code to the correct section Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/tc7.0.x/trunk/res/findbu

svn commit: r1801173 - /tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml

Author: markt Date: Fri Jul 7 14:54:14 2017 New Revision: 1801173 URL: http://svn.apache.org/viewvc?rev=1801173&view=rev Log: FindBugs: false positives Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.x

svn commit: r1801172 - in /tomcat/tc7.0.x/trunk: ./ res/findbugs/filter-false-positives.xml test/org/apache/tomcat/unittest/TesterLeakingServlet1.java

Author: markt Date: Fri Jul 7 14:49:29 2017 New Revision: 1801172 URL: http://svn.apache.org/viewvc?rev=1801172&view=rev Log: Remove code. It isn't necessary and FindBugs doesn't like it. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/res/findbugs/filter-false-pos

svn commit: r1801163 - in /tomcat/tc7.0.x/trunk: ./ res/findbugs/filter-false-positives.xml test/org/apache/catalina/core/TestStandardWrapper.java

Author: markt Date: Fri Jul 7 13:47:07 2017 New Revision: 1801163 URL: http://svn.apache.org/viewvc?rev=1801163&view=rev Log: Refactor to silence some FindBugs warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml tomc

svn commit: r1801162 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/JspCompilationContext.java

Author: markt Date: Fri Jul 7 13:41:20 2017 New Revision: 1801162 URL: http://svn.apache.org/viewvc?rev=1801162&view=rev Log: Simplify and silence a FindBugs report (Note: there would not have been a problem if an increment has been lost) Modified: tomcat/tc7.0.x/trunk/ (props changed)

buildbot failure in on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/803 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1801160 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java

Author: markt Date: Fri Jul 7 13:36:50 2017 New Revision: 1801160 URL: http://svn.apache.org/viewvc?rev=1801160&view=rev Log: FindBugs: Thread-safe update Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/transport/bio/util/FastQueue.

svn commit: r1801159 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardWrapperValve.java res/findbugs/filter-false-positives.xml

Author: markt Date: Fri Jul 7 13:30:44 2017 New Revision: 1801159 URL: http://svn.apache.org/viewvc?rev=1801159&view=rev Log: Fix a FindBugs warning (increment of volatile not atomic) Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/Sta

svn commit: r1801158 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/

Author: markt Date: Fri Jul 7 13:20:03 2017 New Revision: 1801158 URL: http://svn.apache.org/viewvc?rev=1801158&view=rev Log: Remove unused code reported by FindBugs Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/

svn commit: r1801157 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/TagFileProcessor.java

Author: markt Date: Fri Jul 7 13:17:34 2017 New Revision: 1801157 URL: http://svn.apache.org/viewvc?rev=1801157&view=rev Log: Remove unused code identified by FindBugs Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/TagFileProcessor.

svn commit: r1801156 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ res/findbugs/

Author: markt Date: Fri Jul 7 13:13:00 2017 New Revision: 1801156 URL: http://svn.apache.org/viewvc?rev=1801156&view=rev Log: FindBugs: Simplify locking code Mark remaining issues as false positives Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/modules/jdbc-pool

svn commit: r1801153 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/tribes/transport/nio/NioSender.java

Author: markt Date: Fri Jul 7 13:06:01 2017 New Revision: 1801153 URL: http://svn.apache.org/viewvc?rev=1801153&view=rev Log: FindBugs: Sync mis-match Reduce size of sync block and make current volatile so updates are seen consistently Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1801152 - in /tomcat/tc7.0.x/trunk: ./ res/findbugs/filter-false-positives.xml test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java

Author: markt Date: Fri Jul 7 12:58:31 2017 New Revision: 1801152 URL: http://svn.apache.org/viewvc?rev=1801152&view=rev Log: Fix FindBugs warnings in test code Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml tomcat/tc7.

svn commit: r1801151 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ContainerBase.java java/org/apache/catalina/core/StandardContext.java

Author: markt Date: Fri Jul 7 12:55:29 2017 New Revision: 1801151 URL: http://svn.apache.org/viewvc?rev=1801151&view=rev Log: Fix FindBugs warnings. Sync only on setter. Use ReadWriteLock instead. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/cata

svn commit: r1801137 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsIntrospectionSource.java

Author: markt Date: Fri Jul 7 09:57:19 2017 New Revision: 1801137 URL: http://svn.apache.org/viewvc?rev=1801137&view=rev Log: Findbugs: Remove pointless null check. Refactor. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/modeler/modul

svn commit: r1801136 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/JspDocumentParser.java

Author: markt Date: Fri Jul 7 09:55:36 2017 New Revision: 1801136 URL: http://svn.apache.org/viewvc?rev=1801136&view=rev Log: FindBugs: Remove unnecessary null check Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/JspDocumentParser.j

svn commit: r1801132 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/TestHostConfigAutomaticDeployment.java

Author: markt Date: Fri Jul 7 08:53:48 2017 New Revision: 1801132 URL: http://svn.apache.org/viewvc?rev=1801132&view=rev Log: FindBugs: Fix possible NPE Correct method name Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/TestHostConfigAutomaticDeployment.java Modified: tom

svn commit: r1801130 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/VirtualWebappLoader.java

Author: markt Date: Fri Jul 7 08:43:14 2017 New Revision: 1801130 URL: http://svn.apache.org/viewvc?rev=1801130&view=rev Log: FindBugs: Fix possible NPE Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/VirtualWebappLoader.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/c

svn commit: r1801129 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java

Author: markt Date: Fri Jul 7 08:41:22 2017 New Revision: 1801129 URL: http://svn.apache.org/viewvc?rev=1801129&view=rev Log: Remove naked notify (resolving a FindBugs issue) as I can't find any locations where wait() is called with the Poller as the monitor. Modified: tomcat/tc7.0.x/trunk/

[Bug 61264] New: Default charset used when Content-Type request header specifies invalid charset

https://bz.apache.org/bugzilla/show_bug.cgi?id=61264 Bug ID: 61264 Summary: Default charset used when Content-Type request header specifies invalid charset Product: Tomcat 8 Version: 8.5.15 Hardware: PC Status:

svn commit: r1801126 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReportJmx.java

Author: markt Date: Fri Jul 7 08:35:07 2017 New Revision: 1801126 URL: http://svn.apache.org/viewvc?rev=1801126&view=rev Log: Fix FindBugs warning: Incorrect lazy initialization of static field Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/

svn commit: r1801125 - in /tomcat/tc7.0.x/trunk: ./ webapps/examples/WEB-INF/classes/compressionFilters/

Author: markt Date: Fri Jul 7 08:33:26 2017 New Revision: 1801125 URL: http://svn.apache.org/viewvc?rev=1801125&view=rev Log: Clean-up: FindBugs warnings - use of Arrays.toString() Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/co