Re: [VOTE] Release Apache Tomcat 9.0.0.M23

Hi, The proposed 9.0.0.M23 release is: [ ] Broken - do not release [ X ] Alpha - go ahead and release as 9.0.0.M23 Unit test passed. Our test web app works fine. -- From:Mark Thomas Time:2017 Jul 4 (Tue) 16:19 To:Tomcat Developers

svn commit: r1801109 - /tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml

Author: markt Date: Thu Jul 6 20:56:39 2017 New Revision: 1801109 URL: http://svn.apache.org/viewvc?rev=1801109&view=rev Log: FindBugs: More false positives Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positi

svn commit: r1801107 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java

Author: markt Date: Thu Jul 6 20:45:26 2017 New Revision: 1801107 URL: http://svn.apache.org/viewvc?rev=1801107&view=rev Log: Fix some warnings: - Findbugs - not serializable Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apach

svn commit: r1801106 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ modules/jdbc-pool/sr

Author: markt Date: Thu Jul 6 20:40:03 2017 New Revision: 1801106 URL: http://svn.apache.org/viewvc?rev=1801106&view=rev Log: Fix some Eclipse / Javadoc warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/SmapUtil.java tomca

svn commit: r1801105 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java

Author: markt Date: Thu Jul 6 20:36:03 2017 New Revision: 1801105 URL: http://svn.apache.org/viewvc?rev=1801105&view=rev Log: Reformat to clear a couple of FindBugs warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache

svn commit: r1801104 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/bugs/ modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/

Author: markt Date: Thu Jul 6 20:33:15 2017 New Revision: 1801104 URL: http://svn.apache.org/viewvc?rev=1801104&view=rev Log: Clean-up - fix indentation - silence a handful of fairly pointless FindBugs warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/mod

buildbot success in on tomcat-7-trunk

The Buildbot has detected a restored build on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/797 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1801082 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Author: markt Date: Thu Jul 6 17:12:09 2017 New Revision: 1801082 URL: http://svn.apache.org/viewvc?rev=1801082&view=rev Log: Fix broken merge Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/view

[Bug 61255] PropertySource implementations log to stdout instead of the log on shutdown

https://bz.apache.org/bugzilla/show_bug.cgi?id=61255 Remy Maucherat changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Bug 61255] New: PropertySource implementations log to stdout instead of the log on shutdown

https://bz.apache.org/bugzilla/show_bug.cgi?id=61255 Bug ID: 61255 Summary: PropertySource implementations log to stdout instead of the log on shutdown Product: Tomcat 8 Version: 8.5.x-trunk Hardware: PC OS:

buildbot failure in on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/796 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1801059 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/tribes/group/ test/org/apache/catalina/tribes/group/interceptors/

Author: markt Date: Thu Jul 6 14:10:10 2017 New Revision: 1801059 URL: http://svn.apache.org/viewvc?rev=1801059&view=rev Log: Re-organise to silence some FindBugs warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/group/TestGr

svn commit: r1801056 - in /tomcat/tc7.0.x/trunk: ./ webapps/examples/WEB-INF/jsp/applet/Clock2.java

Author: markt Date: Thu Jul 6 14:06:56 2017 New Revision: 1801056 URL: http://svn.apache.org/viewvc?rev=1801056&view=rev Log: Silence a findbugs warning Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/jsp/applet/Clock2.java Propchange: tom

svn commit: r1801055 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/servlets/WebdavServlet.java java/org/apache/catalina/util/ConcurrentDateFormat.java

Author: markt Date: Thu Jul 6 14:01:51 2017 New Revision: 1801055 URL: http://svn.apache.org/viewvc?rev=1801055&view=rev Log: Fix Find Bugs warnings - thread safety of data formatting Added: tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/ConcurrentDateFormat.java - copied, changed

svn commit: r1801053 - /tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml

Author: markt Date: Thu Jul 6 13:54:38 2017 New Revision: 1801053 URL: http://svn.apache.org/viewvc?rev=1801053&view=rev Log: FindBugs: More false positives Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positi

svn commit: r1801052 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/tomcat/util/http/ test/org/apache/tomcat/websocket/ webapps/docs/

Author: markt Date: Thu Jul 6 13:54:17 2017 New Revision: 1801052 URL: http://svn.apache.org/viewvc?rev=1801052&view=rev Log: FindBugs: Fix unused code by implementing the TODO associated with it Added: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/ResponseUtil.java - copied un

[Bug 61253] Tomcat's Digester silently ignore's failed property replacement

https://bz.apache.org/bugzilla/show_bug.cgi?id=61253 --- Comment #3 from Remy Maucherat --- As I see it, when a property doesn't exist (without errors) in the property source (SystemPropertySource), it should return null and the substitution isn't made. The source throwing an exception should mea

svn commit: r1801049 - /tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/JavacErrorDetail.java

Author: markt Date: Thu Jul 6 13:39:21 2017 New Revision: 1801049 URL: http://svn.apache.org/viewvc?rev=1801049&view=rev Log: Refactor to avoid FindBugs NPE warning Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/JavacErrorDetail.java Modified: tomcat/tc7.0.x/trunk/java/org/

Re: [VOTE] Release Apache Tomcat 8.5.17

2017-07-04 11:40 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 8.5.17 release is now available for voting. > > The major changes compared to the 8.5.17 release are: > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any registered Asyn

[Bug 61212] Slow application boot time due to constant jar file content read

https://bz.apache.org/bugzilla/show_bug.cgi?id=61212 --- Comment #6 from Adrianas --- We checked all FasterStartUp hints none of them gave material improvement. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 61212] Slow application boot time due to constant jar file content read

https://bz.apache.org/bugzilla/show_bug.cgi?id=61212 --- Comment #5 from Mark Thomas --- Slow startup issues with unpacked web applications are most likely a configuration issue. See https://wiki.apache.org/tomcat/HowTo/FasterStartUp and follow up on the users list if you need further assistance

svn commit: r1801041 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/JspUtil.java

Author: markt Date: Thu Jul 6 12:35:43 2017 New Revision: 1801041 URL: http://svn.apache.org/viewvc?rev=1801041&view=rev Log: Fix FindBugs NPE warning Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/JspUtil.java Propchange: tomcat/t

[Bug 61212] Slow application boot time due to constant jar file content read

https://bz.apache.org/bugzilla/show_bug.cgi?id=61212 --- Comment #4 from Adrianas --- We face this issue with unpacked war so I'm not sure if this is a duplicate -- You are receiving this mail because: You are the assignee for the bug. ---

svn commit: r1801040 - /tomcat/tc7.0.x/trunk/res/findbugs/filter-post-7.0.x-fixes.xml

Author: markt Date: Thu Jul 6 12:26:42 2017 New Revision: 1801040 URL: http://svn.apache.org/viewvc?rev=1801040&view=rev Log: Add some issues deprecated code to the exclusions Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-post-7.0.x-fixes.xml Modified: tomcat/tc7.0.x/trunk/res/findbugs

svn commit: r1801039 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/InputBuffer.java java/org/apache/catalina/connector/OutputBuffer.java

Author: markt Date: Thu Jul 6 12:26:15 2017 New Revision: 1801039 URL: http://svn.apache.org/viewvc?rev=1801039&view=rev Log: Fix error handling (non IOException were swallowed) Identified by FindBugs Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/

svn commit: r1801038 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

Author: markt Date: Thu Jul 6 12:24:40 2017 New Revision: 1801038 URL: http://svn.apache.org/viewvc?rev=1801038&view=rev Log: Fix NPE reported by FindBugs Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.j

svn commit: r1801037 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/valves/TestRequestFilterValve.java

Author: markt Date: Thu Jul 6 12:16:22 2017 New Revision: 1801037 URL: http://svn.apache.org/viewvc?rev=1801037&view=rev Log: Refactor test to stop IDE and FindBugs complaining about possible NPEs. Also requires slightly less code. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomca

svn commit: r1801036 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/IntrospectionUtils.java

Author: markt Date: Thu Jul 6 12:13:55 2017 New Revision: 1801036 URL: http://svn.apache.org/viewvc?rev=1801036&view=rev Log: Fix warnings in IntrospectionUtils. One functional change to replace a debug message and a subsequent NPE with an IAE Modified: tomcat/tc7.0.x/trunk/ (props change

svn commit: r1801035 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/PageInfo.java

Author: markt Date: Thu Jul 6 12:10:05 2017 New Revision: 1801035 URL: http://svn.apache.org/viewvc?rev=1801035&view=rev Log: Clean-up - fix false positive NPE warnings by removing redundant code and suppressing remaining warning Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/

svn commit: r1801033 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ContainerBase.java java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

Author: markt Date: Thu Jul 6 12:00:13 2017 New Revision: 1801033 URL: http://svn.apache.org/viewvc?rev=1801033&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56784 Fix a couple of rare but theoretically possible atomicity bugs. Also fixes a FindBugs warning Modified: t

svn commit: r1801031 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/FastHttpDateFormat.java

Author: markt Date: Thu Jul 6 11:51:49 2017 New Revision: 1801031 URL: http://svn.apache.org/viewvc?rev=1801031&view=rev Log: Remove unnecessary syncs identified by FindBugs Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/FastHttpD

svn commit: r1801029 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/HTMLManagerServlet.java

Author: markt Date: Thu Jul 6 11:48:17 2017 New Revision: 1801029 URL: http://svn.apache.org/viewvc?rev=1801029&view=rev Log: Compare integers as integers not Dates. Fixes warning reported by FindBugs Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache

buildbot failure in on tomcat-8-trunk

The Buildbot has detected a new failure on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/1065 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sc

svn commit: r1801024 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Thu Jul 6 10:44:20 2017 New Revision: 1801024 URL: http://svn.apache.org/viewvc?rev=1801024&view=rev Log: Replicate the equals() and hashCode() strategy from MessageBytes to silence some FindBugs warnings Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

sis-2.7-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170706.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20170706/bin/openssl -Dexecute.test.nio=false -Dhamcrest.jar=/srv/gump/packages/ha

svn commit: r1801021 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java

Author: markt Date: Thu Jul 6 10:36:09 2017 New Revision: 1801021 URL: http://svn.apache.org/viewvc?rev=1801021&view=rev Log: Use correct syntax Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor

svn commit: r1801020 - /tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java

Author: markt Date: Thu Jul 6 10:35:49 2017 New Revision: 1801020 URL: http://svn.apache.org/viewvc?rev=1801020&view=rev Log: Use correct syntax Modified: tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java Modified: tomcat/tc8.

svn commit: r1801019 - in /tomcat/tc7.0.x/trunk: ./ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java

Author: markt Date: Thu Jul 6 10:34:23 2017 New Revision: 1801019 URL: http://svn.apache.org/viewvc?rev=1801019&view=rev Log: (empty) Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementC

svn commit: r1801017 - /tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java

Author: markt Date: Thu Jul 6 10:31:57 2017 New Revision: 1801017 URL: http://svn.apache.org/viewvc?rev=1801017&view=rev Log: Replace broken, deprecated code with a simple return null Modified: tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/Stat

svn commit: r1801018 - /tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestStatementCache.java

Author: markt Date: Thu Jul 6 10:32:18 2017 New Revision: 1801018 URL: http://svn.apache.org/viewvc?rev=1801018&view=rev Log: Remove unnecessary warning Modified: tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestStatementCache.java Modified: tomcat/tc8.

svn commit: r1801008 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/OutputBuffer.java

Author: markt Date: Thu Jul 6 09:58:39 2017 New Revision: 1801008 URL: http://svn.apache.org/viewvc?rev=1801008&view=rev Log: Fix error handling (non IOException were swallowed) Identified by FindBugs Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/OutputBuffer.java Modifi

svn commit: r1801007 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java

Author: markt Date: Thu Jul 6 09:57:49 2017 New Revision: 1801007 URL: http://svn.apache.org/viewvc?rev=1801007&view=rev Log: Fix error handling (non IOException were swallowed) Identified by FindBugs Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/InputBuffer.java Modifie

symmetry of get/set property in endpoint?

Hi guys, is it intended org.apache.tomcat.util.net.AbstractEndpoint#setProperty and its getter are not symmetric? getter uses only attributes whereas setter uses a socket or this through reflection. Asking cause setProperty(x, y) implies most likely getProperty(x) != y which sounds weird Romain

svn commit: r1801006 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/InputBuffer.java res/findbugs/filter-false-positives.xml

Author: markt Date: Thu Jul 6 09:51:56 2017 New Revision: 1801006 URL: http://svn.apache.org/viewvc?rev=1801006&view=rev Log: Small simplification Use 'conv == null' to indicate that conv has not been set rather than a separate flag. Modified: tomcat/tc8.0.x/trunk/ (props changed) tom

buildbot success in on tomcat-8-trunk

The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/1061 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1801005 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java

Author: markt Date: Thu Jul 6 09:31:38 2017 New Revision: 1801005 URL: http://svn.apache.org/viewvc?rev=1801005&view=rev Log: Use '&&' rather than '&'. Identified by FindBugs Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java Modified: tomcat

svn commit: r1801004 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/storeconfig/StoreAppender.java

Author: markt Date: Thu Jul 6 09:29:33 2017 New Revision: 1801004 URL: http://svn.apache.org/viewvc?rev=1801004&view=rev Log: FindBugs pos doesn't need to be static. It gets reset from indent at the beginning of every line and a StoreAppender instance is always responsible for an entire line so

svn commit: r1801003 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

Author: markt Date: Thu Jul 6 09:27:51 2017 New Revision: 1801003 URL: http://svn.apache.org/viewvc?rev=1801003&view=rev Log: Fix NPE reported by FindBugs Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.j

svn commit: r1800999 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/tomcat/unittest/TesterLeakingServlet1.java

Author: markt Date: Thu Jul 6 09:06:38 2017 New Revision: 1800999 URL: http://svn.apache.org/viewvc?rev=1800999&view=rev Log: Remove code. It isn't necessary and FindBugs doesn't like it. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/test/org/apache/tomcat/unitt

svn commit: r1800998 - /tomcat/tc8.0.x/trunk/test/org/apache/tomcat/websocket/server/TesterWsCloseClient.java

Author: markt Date: Thu Jul 6 09:05:20 2017 New Revision: 1800998 URL: http://svn.apache.org/viewvc?rev=1800998&view=rev Log: Fix one FindBugs and one Javadoc warning Modified: tomcat/tc8.0.x/trunk/test/org/apache/tomcat/websocket/server/TesterWsCloseClient.java Modified: tomcat/tc8.0.x/t

buildbot failure in on tomcat-8-trunk

The Buildbot has detected a new failure on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/1060 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sc

svn commit: r1800994 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/catalina/connector/LocalStrings.properties

Author: markt Date: Thu Jul 6 08:55:51 2017 New Revision: 1800994 URL: http://svn.apache.org/viewvc?rev=1800994&view=rev Log: Simplify. Use Charset in preference to String. Fixes FindBugs warning Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catal

svn commit: r1800992 - /tomcat/trunk/java/org/apache/catalina/tribes/jmx/JmxRegistry.java

Author: markt Date: Thu Jul 6 08:42:29 2017 New Revision: 1800992 URL: http://svn.apache.org/viewvc?rev=1800992&view=rev Log: Fix a FindBugs nag and add an explanatory comment. Modified: tomcat/trunk/java/org/apache/catalina/tribes/jmx/JmxRegistry.java Modified: tomcat/trunk/java/org/apache

svn commit: r1800993 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/tribes/jmx/JmxRegistry.java

Author: markt Date: Thu Jul 6 08:42:56 2017 New Revision: 1800993 URL: http://svn.apache.org/viewvc?rev=1800993&view=rev Log: Fix a FindBugs nag and add an explanatory comment. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/jmx/JmxR

svn commit: r1800981 - /tomcat/trunk/java/org/apache/juli/FileHandler.java

Author: markt Date: Thu Jul 6 08:29:11 2017 New Revision: 1800981 URL: http://svn.apache.org/viewvc?rev=1800981&view=rev Log: Avoid possible NPE. Reported by FindBugs. Modified: tomcat/trunk/java/org/apache/juli/FileHandler.java Modified: tomcat/trunk/java/org/apache/juli/FileHandler.java U

svn commit: r1800990 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/juli/TestFileHandler.java

Author: markt Date: Thu Jul 6 08:37:23 2017 New Revision: 1800990 URL: http://svn.apache.org/viewvc?rev=1800990&view=rev Log: Fix NPE and dead store warnings. Reported by FindBugs. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/test/org/apache/juli/TestFileHandler

svn commit: r1800991 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/juli/TestFileHandler.java

Author: markt Date: Thu Jul 6 08:37:49 2017 New Revision: 1800991 URL: http://svn.apache.org/viewvc?rev=1800991&view=rev Log: Fix NPE and dead store warnings. Reported by FindBugs. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/juli/TestFileHandler

svn commit: r1800989 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/juli/TestFileHandler.java

Author: markt Date: Thu Jul 6 08:37:02 2017 New Revision: 1800989 URL: http://svn.apache.org/viewvc?rev=1800989&view=rev Log: Fix NPE and dead store warnings. Reported by FindBugs. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/juli/TestFileHandler

svn commit: r1800988 - /tomcat/trunk/test/org/apache/juli/TestFileHandler.java

Author: markt Date: Thu Jul 6 08:36:33 2017 New Revision: 1800988 URL: http://svn.apache.org/viewvc?rev=1800988&view=rev Log: Fix NPE and dead store warnings. Reported by FindBugs. Modified: tomcat/trunk/test/org/apache/juli/TestFileHandler.java Modified: tomcat/trunk/test/org/apache/juli/T

svn commit: r1800987 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/core/TestAsyncContextImpl.java

Author: markt Date: Thu Jul 6 08:33:35 2017 New Revision: 1800987 URL: http://svn.apache.org/viewvc?rev=1800987&view=rev Log: Fix possible name confusion. Reported by FindBugs. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncC

svn commit: r1800986 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/core/TestAsyncContextImpl.java

Author: markt Date: Thu Jul 6 08:32:56 2017 New Revision: 1800986 URL: http://svn.apache.org/viewvc?rev=1800986&view=rev Log: Fix possible name confusion. Reported by FindBugs. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/test/org/apache/catalina/core/TestAsyncC

svn commit: r1800985 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/core/TestAsyncContextImpl.java

Author: markt Date: Thu Jul 6 08:32:36 2017 New Revision: 1800985 URL: http://svn.apache.org/viewvc?rev=1800985&view=rev Log: Fix possible name confusion. Reported by FindBugs. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestAsyncC

svn commit: r1800984 - /tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java

Author: markt Date: Thu Jul 6 08:32:07 2017 New Revision: 1800984 URL: http://svn.apache.org/viewvc?rev=1800984&view=rev Log: Fix possible name confusion. Reported by FindBugs. Modified: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Modified: tomcat/trunk/test/org/apa

svn commit: r1800983 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/juli/FileHandler.java

Author: markt Date: Thu Jul 6 08:30:06 2017 New Revision: 1800983 URL: http://svn.apache.org/viewvc?rev=1800983&view=rev Log: Avoid possible NPE. Reported by FindBugs. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/juli/FileHandler.java Propchange

svn commit: r1800982 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/juli/FileHandler.java

Author: markt Date: Thu Jul 6 08:29:35 2017 New Revision: 1800982 URL: http://svn.apache.org/viewvc?rev=1800982&view=rev Log: Avoid possible NPE. Reported by FindBugs. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/juli/FileHandler.java Propchange

svn commit: r1800980 - /tomcat/trunk/java/org/apache/catalina/valves/LoadBalancerDrainingValve.java

Author: markt Date: Thu Jul 6 08:18:11 2017 New Revision: 1800980 URL: http://svn.apache.org/viewvc?rev=1800980&view=rev Log: Remove unnecessary code identified by FindBugs Modified: tomcat/trunk/java/org/apache/catalina/valves/LoadBalancerDrainingValve.java Modified: tomcat/trunk/java/org