Re: [VOTE] Release Apache Tomcat 9.0.0.M23

2017-07-05 Thread Violeta Georgieva
2017-07-04 11:19 GMT+03:00 Mark Thomas : > > The proposed Apache Tomcat 9.0.0.M23 release is now available for voting. > > This is a milestone release for the 9.0.x branch. It should be > noted that, as a milestone release: > - Servlet 4.0 is not finalised > - The EGs have not started work on JSP 2

Re: [VOTE] Release Apache Tomcat 9.0.0.M23

2017-07-05 Thread Felix Schumacher
Am 4. Juli 2017 10:19:05 MESZ schrieb Mark Thomas : >The proposed Apache Tomcat 9.0.0.M23 release is now available for >voting. > >This is a milestone release for the 9.0.x branch. It should be >noted that, as a milestone release: >- Servlet 4.0 is not finalised >- The EGs have not started work o

Re: [VOTE] Release Apache Tomcat 8.5.17

2017-07-05 Thread Felix Schumacher
Am 4. Juli 2017 10:40:41 MESZ schrieb Mark Thomas : >The proposed Apache Tomcat 8.5.17 release is now available for voting. > >The major changes compared to the 8.5.17 release are: > >- Make asynchronous error handling more robust. In particular ensure > that onError() is called for any register

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2017-07-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. Th

Re: ApacheCon slides with .odp extension

2017-07-05 Thread Huxing Zhang
Hi Chris, Works for me, thanks! -- From:Christopher Schultz Time:2017 Jul 5 (Wed) 23:47 To:dev Subject:Re: ApacheCon slides with .odp extension -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Huxing, On 6/20/17 10:48 PM, Huxing

[Bug 60963] Optimize class loading for unpackWARs=false case

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60963 --- Comment #23 from Thomas Meyer --- I was told that all tomcats are run with unpackWARs=false for security reasons. I really tried to convince the ops from changing the parameter to true, but no chance. I think you can run Tomcat with ro file

[Bug 60963] Optimize class loading for unpackWARs=false case

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60963 --- Comment #22 from Mark Thomas --- Unfortunately, Boot depends on the outer JAR/WAR being uncompressed. Tomcat does not have the option to require that. My current test (a WAR that just contains all the JAR files from Jira 7.3.4) takes ~3s t

svn commit: r1800915 - in /tomcat/trunk/java/org/apache/catalina/webresources: AbstractArchiveResourceSet.java AbstractSingleArchiveResourceSet.java JarWarResourceSet.java

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 19:16:39 2017 New Revision: 1800915 URL: http://svn.apache.org/viewvc?rev=1800915&view=rev Log: Use Map rather than a specific implementation Modified: tomcat/trunk/java/org/apache/catalina/webresources/AbstractArchiveResourceSet.java tomcat/trunk/java/org

Re: [VOTE] Release Apache Tomcat 8.5.17

2017-07-05 Thread Coty Sutherland
On Tue, Jul 4, 2017 at 4:40 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.17 release is now available for voting. > > The major changes compared to the 8.5.17 release are: > > - Make asynchronous error handling more robust. In particular ensure > that onError() is called for any regist

[Bug 61253] Tomcat's Digester silently ignore's failed property replacement

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61253 --- Comment #2 from Konstantin Kolinko --- Bad idea. The end user does not need to know that somebody tried a property substitution here. It is not an error to write literal ${foo}. The correct substitution for "${foo}" if foo does not exist i

Re: How long should we give Beginner bugs on Bugzilla before fixing them?

2017-07-05 Thread Mark Thomas
On 05/07/17 18:29, Coty Sutherland wrote: > Hi all, > > I've been on a mission of sorts to find some small bugs in Tomcat and > file them in BZ for new contributors to fix. I think that's a good > entry ramp for new contributors to see how the process works, etc. The > reason for this email though

[Bug 61210] When using the Security Manager, Tomcat prints warning about a non-existent file

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61210 --- Comment #10 from Mark Thomas --- A slightly bigger hint: JULI cannot have any external dependencies. The "Does this file exist?" test needs to happen in a privileged block. That privileged block needs to be located in a class in a JAR that

[Bug 61210] When using the Security Manager, Tomcat prints warning about a non-existent file

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61210 --- Comment #9 from Coty Sutherland --- I've been meaning to circle back to this (and a few others...) but haven't been able to make time just yet. I do recall being a bit confused by your last hint because I couldn't see the correlation betwee

How long should we give Beginner bugs on Bugzilla before fixing them?

2017-07-05 Thread Coty Sutherland
Hi all, I've been on a mission of sorts to find some small bugs in Tomcat and file them in BZ for new contributors to fix. I think that's a good entry ramp for new contributors to see how the process works, etc. The reason for this email though is that I'm not sure how long we should wait to see i

[Bug 61253] Tomcat's Digester silently ignore's failed property replacement

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61253 --- Comment #1 from Christopher Schultz --- +1000 I believe that any empty catch block is a bug, unless it's one of those "never happen" exceptions, and even those should be logged at an ERROR/FATAL level. -- You are receiving this mail beca

[Bug 61210] When using the Security Manager, Tomcat prints warning about a non-existent file

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61210 --- Comment #8 from Mark Thomas --- Coty, I have a patch for this but I thought you might want to figure this out for yourself. If you want another hint (or just want me to apply my patch), let me know. -- You are receiving this mail because:

[Bug 61253] Tomcat's Digester silently ignore's failed property replacement

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61253 Coty Sutherland changed: What|Removed |Added Keywords||Beginner -- You are receiving this

[Bug 61253] New: Tomcat's Digester silently ignore's failed property replacement

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61253 Bug ID: 61253 Summary: Tomcat's Digester silently ignore's failed property replacement Product: Tomcat 8 Version: 8.5.x-trunk Hardware: PC OS: Linux

svn commit: r1800891 - in /tomcat/site/trunk: docs/presentations.html xdocs/presentations.xml

2017-07-05 Thread schultz
Author: schultz Date: Wed Jul 5 15:49:33 2017 New Revision: 1800891 URL: http://svn.apache.org/viewvc?rev=1800891&view=rev Log: Change .odp -> .pdf for presentation slides. Modified: tomcat/site/trunk/docs/presentations.html tomcat/site/trunk/xdocs/presentations.xml Modified: tomcat/sit

Re: ApacheCon slides with .odp extension

2017-07-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Huxing, On 6/20/17 10:48 PM, Huxing Zhang wrote: > These two pdf files are not accessible to me: > http://people.apache.org/~schultz/ApacheCon%20NA%202017/Let's%20Encryp t%20Apache%20Tomcat.pdf > > http://people.apache.org/~schultz/ApacheCon%20NA%

buildbot success in on tomcat-trunk

2017-07-05 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2530 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

buildbot failure in on tomcat-trunk

2017-07-05 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2529 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

svn commit: r1800886 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/jsse/JSSEUtil.java java/org/apache/tomcat/util/net/jsse/LocalStrings.properties

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 14:22:45 2017 New Revision: 1800886 URL: http://svn.apache.org/viewvc?rev=1800886&view=rev Log: Follow-up to r1800868 Better handling for when user does not specify an alias to use Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/o

svn commit: r1800885 - in /tomcat/trunk/java/org/apache/tomcat/util/net/jsse: JSSEUtil.java LocalStrings.properties

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 14:21:56 2017 New Revision: 1800885 URL: http://svn.apache.org/viewvc?rev=1800885&view=rev Log: Follow-up to r1800867 Better handling for when user does not specify an alias to use Modified: tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEUtil.java tom

Re: svn commit: r1800874 - in /tomcat/trunk/java/org/apache/tomcat/util/net: jsse/JSSEKeyManager.java jsse/JSSEUtil.java openssl/OpenSSLContext.java

2017-07-05 Thread Mark Thomas
On 05/07/17 14:54, Rémy Maucherat wrote: > On Wed, Jul 5, 2017 at 8:51 AM, wrote: > >> Author: markt >> Date: Wed Jul 5 13:51:27 2017 >> New Revision: 1800874 >> >> URL: http://svn.apache.org/viewvc?rev=1800874&view=rev >> Log: >> Follow-up to r1800867 >> Avoid NPE when no alias is specified. >>

Re: svn commit: r1800874 - in /tomcat/trunk/java/org/apache/tomcat/util/net: jsse/JSSEKeyManager.java jsse/JSSEUtil.java openssl/OpenSSLContext.java

2017-07-05 Thread Rémy Maucherat
On Wed, Jul 5, 2017 at 8:51 AM, wrote: > Author: markt > Date: Wed Jul 5 13:51:27 2017 > New Revision: 1800874 > > URL: http://svn.apache.org/viewvc?rev=1800874&view=rev > Log: > Follow-up to r1800867 > Avoid NPE when no alias is specified. > Now an in memory key store with a single key is used,

svn commit: r1800875 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/jsse/JSSEKeyManager.java java/org/apache/tomcat/util/net/jsse/JSSEUtil.java java/org/apache/tomcat/util/net/openssl/

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 13:53:49 2017 New Revision: 1800875 URL: http://svn.apache.org/viewvc?rev=1800875&view=rev Log: Follow-up to r1800867 Avoid NPE when no alias is specified. Now an in memory key store with a single key is used, there is no need for the JSSEKeyManager - so deprecate i

svn commit: r1800874 - in /tomcat/trunk/java/org/apache/tomcat/util/net: jsse/JSSEKeyManager.java jsse/JSSEUtil.java openssl/OpenSSLContext.java

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 13:51:27 2017 New Revision: 1800874 URL: http://svn.apache.org/viewvc?rev=1800874&view=rev Log: Follow-up to r1800867 Avoid NPE when no alias is specified. Now an in memory key store with a single key is used, there is no need for the JSSEKeyManager - so remove it.

[Bug 61250] Disabling shutdown port exit tomcat with System.exit(1) causes issue

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61250 --- Comment #7 from Veeru --- Yes I have tried it. But that time I was seeing another issue that Error 1503. I would suggest , It would be better to invoke system.exit(0) as we are doing intentionally in case of port is disabled. Thanks agai

svn commit: r1800868 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/jsse/JSSEUtil.java webapps/docs/changelog.xml

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 12:18:54 2017 New Revision: 1800868 URL: http://svn.apache.org/viewvc?rev=1800868&view=rev Log: Enable TLS connectors to use Java key stores that contain multiple keys where each key has a separate password. Based on a patch by Frank Taffelt. Modified: tomcat/t

svn commit: r1800867 - in /tomcat/trunk: java/org/apache/tomcat/util/net/jsse/JSSEUtil.java webapps/docs/changelog.xml

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 12:18:26 2017 New Revision: 1800867 URL: http://svn.apache.org/viewvc?rev=1800867&view=rev Log: Enable TLS connectors to use Java key stores that contain multiple keys where each key has a separate password. Based on a patch by Frank Taffelt. Modified: tomcat/t

svn commit: r1800865 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/http.xml

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 12:13:28 2017 New Revision: 1800865 URL: http://svn.apache.org/viewvc?rev=1800865&view=rev Log: Revert r1800851. A better solution has been suggested on the users list. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/webapps/docs/chang

svn commit: r1800864 - in /tomcat/trunk/webapps/docs: changelog.xml config/http.xml

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 12:12:47 2017 New Revision: 1800864 URL: http://svn.apache.org/viewvc?rev=1800864&view=rev Log: Revert r1800850. A better solution has been suggested on the users list. Modified: tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/config/http.x

[Bug 61250] Disabling shutdown port exit tomcat with System.exit(1) causes issue

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61250 --- Comment #6 from Mark Thomas --- I've never used WinRun4J. I'd suggest the simplest solution is to configure a shutdown port with a strong shutdown password and ensure that server.xml is appropriately protected. If you need further help/adv

Re: [VOTE] Release Apache Tomcat 8.5.17

2017-07-05 Thread Emmanuel Bourg
Le 4/07/2017 à 10:40, Mark Thomas a écrit : > The proposed 8.5.17 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.17 +1, tested on Debian with OpenJDK 8u131. Emmanuel Bourg - To unsubscribe,

[Bug 61250] Disabling shutdown port exit tomcat with System.exit(1) causes issue

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61250 --- Comment #5 from Veeru --- Thanks for quick response. I am using WinRun4J.jar to start my tomcat as a windows service. I am not sure where to set this jvm mode. And I am disabling shutdown port by setting port="-1" in server.xml. Since

[Bug 61250] Disabling shutdown port exit tomcat with System.exit(1) causes issue

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61250 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Bug 61171] Add port offset attribute (portOffset?) to Server configuration in server.xml

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61171 --- Comment #6 from Mark Thomas --- My suggestion is as follows: Add a new getter for every getPort() or equivalent named getPortWithOffset() and use it in place of getPort() whenever code needs to get the actual port number to open. That woul

svn commit: r1800851 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/http.xml

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 08:54:02 2017 New Revision: 1800851 URL: http://svn.apache.org/viewvc?rev=1800851&view=rev Log: Clarify the documentation for certificateKeyPassword with information on the lack of support for multiple keys in a single key store, each with a separate password. Mod

svn commit: r1800850 - in /tomcat/trunk/webapps/docs: changelog.xml config/http.xml

2017-07-05 Thread markt
Author: markt Date: Wed Jul 5 08:52:54 2017 New Revision: 1800850 URL: http://svn.apache.org/viewvc?rev=1800850&view=rev Log: Clarify the documentation for certificateKeyPassword with information on the lack of support for multiple keys in a single key store, each with a separate password. Mod

[Bug 61250] Disabling shutdown port exit tomcat with System.exit(1) causes issue

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61250 --- Comment #3 from Veeru --- Thanks you very much. Waiting for your input. At present I build the catalina.jar with system.exit(0) as 0 represent success. 0 -- success 1 -- exception -1 -- Error -- You are receiving this mail because: You a

[Bug 61250] Disabling shutdown port exit tomcat with System.exit(1) causes issue

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61250 --- Comment #2 from Mark Thomas --- The exit code of -1 is correct in that case. The user is trying to use the shutdown command when the port is disabled. We need to look at how we integrate with Commons Daemon and how Daemon handles this to s

[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2017-07-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497 --- Comment #10 from M. Manna --- Hello, We would like to go for TC 8.5.14 or 8.5.15. Will this patch be available there? -- You are receiving this mail because: You are the assignee for the bug. -