Github user KeiichiFujino commented on the issue:
https://github.com/apache/tomcat/pull/56
I confirmed. there is no problem.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
@KeiichiFujino p.s. This is the last commit that addresses the issues
above:
https://github.com/apache/tomcat/pull/56/commits/192d2eb13e9ec9448e183dcc3b166f7d3577c250
---
If your project is set up f
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
@KeiichiFujino Thank you for your prompt review.
>you need to add BackupManager mbean definitions ... in
org/apache/catalina/ha/session/mbeans-descriptors.xml
Thank you for providing t
Github user KeiichiFujino commented on the issue:
https://github.com/apache/tomcat/pull/56
There are two comments.
you need to add BackupManager mbean definitions.
```
```
in org/apache/catalina/ha/session/mbeans-descriptors.xml
There is a typo in
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
--- Comment #6 from Huxing Zhang ---
Hi,
> There was no concern expressed about the log files that are currently not
> rolled (generally, I suspect, because well written apps won;t trigger content
> to those files).
We do have concerns about
Hi,
> There was no concern expressed about the log files that are currently not
> rolled (generally, I suspect, because well written apps won;t trigger content
> to those files).
We do have concerns about rotate the output to stdout/stderr.
In most of our cases, this is due to logging framework c
https://bz.apache.org/bugzilla/show_bug.cgi?id=61154
--- Comment #2 from Konstantin Kolinko ---
Two ideas:
A. Move manager and host-manager out of webapps,
and deploy them via a context file?
- It was like that in Tomcat 5.5
- I use this configuration when running with separate CATALINA_BASE a
When I set the `test` directory as a Test root dir in IntelliJ IDEA, I
get errors like:
E:\Workspace\git\tomcat\test\org\apache\coyote\http2\TestStream.java
Error:(33, 16) java: package trailers does not exist
Error:(90, 49) java: cannot find symbol
symbol: class ResponseTrailers
location:
Author: markt
Date: Thu Jun 8 21:37:19 2017
New Revision: 1798128
URL: http://svn.apache.org/viewvc?rev=1798128&view=rev
Log:
Remove deprecated code
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardWrapper
Author: markt
Date: Thu Jun 8 21:36:43 2017
New Revision: 1798127
URL: http://svn.apache.org/viewvc?rev=1798127&view=rev
Log:
Remove / deprecate unnecessary code
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
Pro
Author: markt
Date: Thu Jun 8 21:36:10 2017
New Revision: 1798126
URL: http://svn.apache.org/viewvc?rev=1798126&view=rev
Log:
Remove / deprecate unnecessary code
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardWrapper.java
Modified: tomcat/trunk/java/org/apache/catalina/core/St
Author: markt
Date: Thu Jun 8 21:33:26 2017
New Revision: 1798125
URL: http://svn.apache.org/viewvc?rev=1798125&view=rev
Log:
No need for SetCharacterEncodingFilter in these cases with Java EE 8
Modified:
tomcat/trunk/webapps/examples/WEB-INF/web.xml
tomcat/trunk/webapps/host-manager/WEB
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
@ChristopherSchultz I updated the patch according to your feedback:
https://github.com/apache/tomcat/pull/56/commits/f0c3968570f70823d30cf18144e82591a7ee0cee
I was actually trying at first to g
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
Thanks @Igal for your patience with this PR review. I know we've been a bit
of a pain. But this work will make the contribution that much more useful.
---
If your project is set up for it,
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
I'm waiting on a final review from @KeiichiFujino before I commit.
In the meantime there are 2 `@return` javadoc annotations with no value.
Could you complete those?
---
If your p
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
I'll change it. Please wait.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
@isapir FYI `1 << bit` is the same as `(int)Math.pow(2, bit)` and probably
slightly more efficient. Better yet, it's less code to read. No particular
reason to change the patch. I'm already
https://bz.apache.org/bugzilla/show_bug.cgi?id=61154
--- Comment #1 from Mark Thomas ---
The RemoteAddrVale we can replace with the equivalent filter. The privileged
attribute is trickier. Still thinking about that.
--
You are receiving this mail because:
You are the assignee for the bug.
-
Author: markt
Date: Thu Jun 8 20:18:21 2017
New Revision: 1798121
URL: http://svn.apache.org/viewvc?rev=1798121&view=rev
Log:
No need for SetCharacterEncodingFilter in this case with Java EE 8
Modified:
tomcat/trunk/webapps/manager/WEB-INF/web.xml
Modified: tomcat/trunk/webapps/manager/WEB-
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
@KeiichiFujino @ChristopherSchultz I added:
* a method to translate the int value to a string list:
https://github.com/apache/tomcat/pull/56/files#diff-5c721c838c78fa7c31f9eb62c27863ceR439
Github user isapir commented on the issue:
https://github.com/apache/tomcat/pull/56
>Even if updating the type of channelStartOptions from int to String in
mbeans-descriptor,
it will display int format values.
Because the channelSendOptions is always set to int format.
if y
Github user ChristopherSchultz commented on the issue:
https://github.com/apache/tomcat/pull/56
@KeiichiFujino Okay, so we'd have a synthetic mbean attribute that we can
re-construct from the int value we store internally? Or, do you think we should
save the string that was used in co
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594
--- Comment #26 from Lulseged Zerfu ---
Hi
We don't see anyway out when millions of terminals are not working and that
tomcat restricted '"' from being a part of request URL.
Terminals will not comply overnight but are starting to comply sl
Author: ebourg
Date: Thu Jun 8 09:53:45 2017
New Revision: 1798038
URL: http://svn.apache.org/viewvc?rev=1798038&view=rev
Log:
Fixed some typos
Modified:
tomcat/site/trunk/xdocs/oldnews-2016.xml
tomcat/site/trunk/xdocs/security-7.xml
tomcat/site/trunk/xdocs/security-8.xml
tomcat/
Github user KeiichiFujino commented on the issue:
https://github.com/apache/tomcat/pull/56
Sorry for the late reply.
I do not think it work as expected.
Even if updating the type of channelStartOptions from int to String in
mbeans-descriptor,
it will display int forma
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594
--- Comment #25 from Mark Thomas ---
I'm neutral on adding '<' and '>' as allowed options.
I think '"' is in the same category. i.e. there is the risk that unexpected
reverse proxy behaviour will trigger a CVE-2016-6816 like issue, no parsing
https://bz.apache.org/bugzilla/show_bug.cgi?id=60594
--- Comment #24 from Lulseged Zerfu ---
Hi
A reverse proxy is not an option and I would like to make a case where we
allow double quotes in request URLs as '{', '}' and '|' are allowed today by
configuring:
tomcat.util.http.parser.HttpParser
27 matches
Mail list logo
