svn commit: r1797729 - in /tomcat/tc8.5.x/trunk: java/org/apache/catalina/tribes/ java/org/apache/catalina/tribes/group/ java/org/apache/catalina/tribes/group/interceptors/ java/org/apache/catalina/tr

2017-06-05 Thread kfujino
Author: kfujino Date: Tue Jun 6 05:38:44 2017 New Revision: 1797729 URL: http://svn.apache.org/viewvc?rev=1797729&view=rev Log: Backport the JMX support for Tribes component. Added: tomcat/tc8.5.x/trunk/java/org/apache/catalina/tribes/JmxChannel.java (with props) tomcat/tc8.5.x/trunk

[Bug 61156] ExpiresFilter is not working

2017-06-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61156 Felix Schumacher changed: What|Removed |Added OS||All Status|NEW

[Bug 61156] New: ExpiresFilter is not working

2017-06-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61156 Bug ID: 61156 Summary: ExpiresFilter is not working Product: Tomcat 8 Version: 8.5.15 Hardware: PC Status: NEW Severity: major Priority: P2 Component

[GitHub] tomcat pull request #59: add some useful note

2017-06-05 Thread powerYao
GitHub user powerYao opened a pull request: https://github.com/apache/tomcat/pull/59 add some useful note You can merge this pull request into a Git repository by running: $ git pull https://github.com/powerYao/tomcat trunk Alternatively you can review and apply these changes

Re: SMAP plans for 9.0.x

2017-06-05 Thread Mark Thomas
On 05/06/17 21:48, Christopher Schultz wrote: > Mark, > > On 6/3/17 4:25 PM, Mark Thomas wrote: >> All, > >> I wanted to provide a little more context to the SMAP changes I >> have started working on. > >> The primary driver for all of this is this bug: >> https://bz.apache.org/bugzilla/show_bu

svn commit: r1797709 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/SSLValve.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:59:29 2017 New Revision: 1797709 URL: http://svn.apache.org/viewvc?rev=1797709&view=rev Log: Tweak comment Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/SSLValve.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/SSLValve.ja

svn commit: r1797707 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/SSLValve.java test/org/apache/catalina/valves/TestSSLValve.java webapps/docs/changelog.xml

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:55:18 2017 New Revision: 1797707 URL: http://svn.apache.org/viewvc?rev=1797707&view=rev Log: Improve the SSLValve so it is able to handle client certificate headers from Nginx. Note that Java 7 isn't quite as tolerant as Java 8. Based on a patch by Lucas Ventura

Re: SMAP plans for 9.0.x

2017-06-05 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 6/3/17 4:25 PM, Mark Thomas wrote: > All, > > I wanted to provide a little more context to the SMAP changes I > have started working on. > > The primary driver for all of this is this bug: > https://bz.apache.org/bugzilla/show_bug.cgi?id

svn commit: r1797704 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java test/org/apache/tomcat/unittest/TesterLogValidationFilter.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:41:44 2017 New Revision: 1797704 URL: http://svn.apache.org/viewvc?rev=1797704&view=rev Log: Enable TesterLogValidationFilter to test log levels and throwables as well as messages. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/t

svn commit: r1797703 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java test/org/apache/tomcat/unittest/TesterLogValidationFilter.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:38:48 2017 New Revision: 1797703 URL: http://svn.apache.org/viewvc?rev=1797703&view=rev Log: Extract log message validation filter to a separate class where it can be used by any unit test. Added: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/unittest/TesterL

svn commit: r1797702 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/SSLValve.java test/org/apache/catalina/valves/TestSSLValve.java webapps/docs/changelog.xml

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:36:15 2017 New Revision: 1797702 URL: http://svn.apache.org/viewvc?rev=1797702&view=rev Log: Improve the SSLValve so it is able to handle client certificate headers from Nginx. Note that Java 7 isn't quite as tolerant as Java 8. Based on a patch by Lucas Ventura

svn commit: r1797701 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java test/org/apache/tomcat/unittest/TesterLogValidationFilter.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:34:16 2017 New Revision: 1797701 URL: http://svn.apache.org/viewvc?rev=1797701&view=rev Log: Enable TesterLogValidationFilter to test log levels and throwables as well as messages. Fix some test errors when running the disabled memory leak tests. Modified: t

svn commit: r1797700 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java test/org/apache/tomcat/unittest/TesterLogValidationFilter.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:32:57 2017 New Revision: 1797700 URL: http://svn.apache.org/viewvc?rev=1797700&view=rev Log: Extract log message validation filter to a separate class where it can be used by any unit test. Added: tomcat/tc8.0.x/trunk/test/org/apache/tomcat/unittest/TesterL

svn commit: r1797699 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/SSLValve.java test/org/apache/catalina/valves/TestSSLValve.java webapps/docs/changelog.xml

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:31:42 2017 New Revision: 1797699 URL: http://svn.apache.org/viewvc?rev=1797699&view=rev Log: Improve the SSLValve so it is able to handle client certificate headers from Nginx. Note that Java 7 isn't quite as tolerant as Java 8. Based on a patch by Lucas Ventura

svn commit: r1797698 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java test/org/apache/tomcat/unittest/TesterLogValidationFilter.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:15:52 2017 New Revision: 1797698 URL: http://svn.apache.org/viewvc?rev=1797698&view=rev Log: Enable TesterLogValidationFilter to test log levels and throwables as well as messages. Fix some test errors when running the disabled memory leak tests. Modified: t

svn commit: r1797697 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java test/org/apache/tomcat/unittest/TesterLogValidationFilter.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:14:51 2017 New Revision: 1797697 URL: http://svn.apache.org/viewvc?rev=1797697&view=rev Log: Extract log message validation filter to a separate class where it can be used by any unit test. Added: tomcat/tc8.5.x/trunk/test/org/apache/tomcat/unittest/TesterL

svn commit: r1797696 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/coyote/http2/TestHttp2Section_5_3.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:13:40 2017 New Revision: 1797696 URL: http://svn.apache.org/viewvc?rev=1797696&view=rev Log: Remove temporary debug code Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_3.java Propcha

svn commit: r1797694 - in /tomcat/trunk: java/org/apache/catalina/valves/SSLValve.java test/org/apache/catalina/valves/TestSSLValve.java webapps/docs/changelog.xml

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:10:43 2017 New Revision: 1797694 URL: http://svn.apache.org/viewvc?rev=1797694&view=rev Log: Improve the SSLValve so it is able to handle client certificate headers from Nginx. Based on a patch by Lucas Ventura Carro. Added: tomcat/trunk/test/org/apache/cata

svn commit: r1797692 - in /tomcat/trunk/test/org/apache: catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java tomcat/unittest/TesterLogValidationFilter.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 20:07:56 2017 New Revision: 1797692 URL: http://svn.apache.org/viewvc?rev=1797692&view=rev Log: Enable TesterLogValidationFilter to test log levels and throwables as well as messages. Fix some test errors when running the disabled memory leak tests. Modified:

[Bug 61105] Roll log files by default

2017-06-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105 --- Comment #2 from Mark Thomas --- The conversation at TomcatCon was around putting a (relatively large) limit on the number of files that are kept by default. Picking a number of of thin air, how does 90 days sound? There was no concern expr

[Bug 61105] Roll log files by default

2017-06-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61105 --- Comment #1 from Violeta Georgieva --- Hi, Currently the log files (except catalina.out which is available on OSes != Windows) are rotated by default based on the date. We can introduce in addition a configuration for the file size and also

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable channelSendOptions ...

2017-06-05 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/56 >If you configure channelSendOptions in string form, you should also expose it to JMX in string format. You can see org/apache/catalina/ha/tcp/mbeans-descriptors.xml I updated the type from

svn commit: r1797678 - in /tomcat/trunk/test/org/apache: catalina/loader/TestWebappClassLoaderThreadLocalMemoryLeak.java tomcat/unittest/TesterLogValidationFilter.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 17:30:52 2017 New Revision: 1797678 URL: http://svn.apache.org/viewvc?rev=1797678&view=rev Log: Extract log message validation filter to a separate class where it can be used by any unit test. Added: tomcat/trunk/test/org/apache/tomcat/unittest/TesterLogValidat

svn commit: r1797677 - /tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_3.java

2017-06-05 Thread markt
Author: markt Date: Mon Jun 5 17:24:53 2017 New Revision: 1797677 URL: http://svn.apache.org/viewvc?rev=1797677&view=rev Log: Remove temporary debug code Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_5_3.java Modified: tomcat/trunk/test/org/apache/coyote/http2/TestHtt

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable channelSendOptions ...

2017-06-05 Thread isapir
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/56 >It is necessary to fix configuration docs (webapps/config/cluster.xml). Added >The patch needs to include fix for mapSendOptions. BackupManager use mapSendOptions instead of channelS

Time for 9.0.x and 8.5.x

2017-06-05 Thread Mark Thomas
All, I'm going to start going through the open bugs now, with a view to tagging 9.0.x and 8.5.x as soon as I can (probably in the next few days). A number of the open bugs are marked as beginner or others have indicated that they are going to work on them. I'd rather not fix these myself but neit

Re: Timescale for 8.0.x EOL

2017-06-05 Thread Emmanuel Bourg
Le 5/06/2017 à 15:51, Mark Thomas a écrit : > +1, for #1 and #3 assuming that we make this 30 June 2018. > > I'm neutral on #2 since it is unlikely to be me doing the releases. I've > no objection to monthly releases if someone wants to take that on. I > suspect every 2 to 3 months would be suffi

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable channelSendOptions ...

2017-06-05 Thread ChristopherSchultz
Github user ChristopherSchultz commented on the issue: https://github.com/apache/tomcat/pull/56 @KeiichiFujino Is this patch acceptable as-is, with additional patches for your items listed above? I think it's okay to add this feature only to channelSendOptions as a first commit. Addin

Re: Timescale for 8.0.x EOL

2017-06-05 Thread Mark Thomas
On 19/05/17 23:19, Christopher Schultz wrote: > My proposal, adapted from the thread before discussion ceased last summer: > > 1. Set Tomcat 8.0.x EOL date for 31 May 2018 > 2. Discontinue monthly release cadence for Tomcat 8.0.x after 8.0.45 > 3. Make these announcements as soon as we have agr

[GitHub] tomcat pull request #58: add nioendpoint note

2017-06-05 Thread markt-asf
Github user markt-asf closed the pull request at: https://github.com/apache/tomcat/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] tomcat issue #58: add nioendpoint note

2017-06-05 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/58 Given the name of the method call, the proposed comment adds no value. The patch also uses tabs rather than spaces. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] tomcat pull request #58: add nioendpoint note

2017-06-05 Thread powerYao
GitHub user powerYao opened a pull request: https://github.com/apache/tomcat/pull/58 add nioendpoint note You can merge this pull request into a Git repository by running: $ git pull https://github.com/powerYao/tomcat trunk Alternatively you can review and apply these changes

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable channelSendOptions ...

2017-06-05 Thread KeiichiFujino
Github user KeiichiFujino commented on the issue: https://github.com/apache/tomcat/pull/56 Hi, some comments : - SimpleTcpCluster exposes the configuration via JMX. If you configure channelSendOptions in string form, you should also expose it to JMX in string for

Re: asyncError() is not valid while in Async state DISPATCHING

2017-06-05 Thread Violeta Georgieva
Hi, 2017-06-02 23:44 GMT+03:00 Mark Thomas : > > On 02/06/2017 10:46, Violeta Georgieva wrote: > > 2017-06-02 12:37 GMT+03:00 Mark Thomas : > >> > >> On 02/06/2017 10:23, Violeta Georgieva wrote: > >>> Hi Mark, > >>> > >>> 2017-05-22 14:28 GMT+03:00 Mark Thomas : > >> > >> > >> > I'm leaning