svn commit: r1771849 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/connector/TestSendFile.java

2016-11-28 Thread violetagg
Author: violetagg Date: Tue Nov 29 07:50:45 2016 New Revision: 1771849 URL: http://svn.apache.org/viewvc?rev=1771849&view=rev Log: Unit test that reproduces the exceptions reported with bug 60409. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/catal

svn commit: r1771848 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/catalina/connector/TestSendFile.java

2016-11-28 Thread violetagg
Author: violetagg Date: Tue Nov 29 07:35:41 2016 New Revision: 1771848 URL: http://svn.apache.org/viewvc?rev=1771848&view=rev Log: Format the code Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/catalina/connector/TestSendFile.java Propchange: tomca

[Bug 60429] windows service ended unexpectedly.

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60429 jitender srivastava changed: What|Removed |Added OS||All -- You are receiving this m

[Bug 60429] New: windows service ended unexpectedly.

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60429 Bug ID: 60429 Summary: windows service ended unexpectedly. Product: Tomcat 6 Version: unspecified Hardware: PC Status: NEW Severity: critical Priority: P2

buildbot success in on tomcat-8-trunk

2016-11-28 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/856 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1771838 - in /tomcat/tc7.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ webapps/docs/

2016-11-28 Thread kfujino
Author: kfujino Date: Tue Nov 29 02:47:21 2016 New Revision: 1771838 URL: http://svn.apache.org/viewvc?rev=1771838&view=rev Log: Add the statistics for released connection by an idle check and removeAbandoned. Modified: tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/j

svn commit: r1771837 - in /tomcat/tc8.0.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ webapps/docs/

2016-11-28 Thread kfujino
Author: kfujino Date: Tue Nov 29 02:46:16 2016 New Revision: 1771837 URL: http://svn.apache.org/viewvc?rev=1771837&view=rev Log: Add the statistics for released connection by an idle check and removeAbandoned. Modified: tomcat/tc8.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/j

svn commit: r1771836 - in /tomcat/tc8.5.x/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ webapps/docs/

2016-11-28 Thread kfujino
Author: kfujino Date: Tue Nov 29 02:44:58 2016 New Revision: 1771836 URL: http://svn.apache.org/viewvc?rev=1771836&view=rev Log: Add the statistics for released connection by an idle check and removeAbandoned. Modified: tomcat/tc8.5.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/j

svn commit: r1771834 - in /tomcat/trunk: modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ webapps/docs/

2016-11-28 Thread kfujino
Author: kfujino Date: Tue Nov 29 02:43:30 2016 New Revision: 1771834 URL: http://svn.apache.org/viewvc?rev=1771834&view=rev Log: Add the statistics for released connection by an idle check and removeAbandoned. Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool

[Bug 60409] IllegalArgumentException at java.nio.Buffer.position at SocketWrapperBase.transfer()

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60409 --- Comment #14 from Evgenij Ryazanov --- Hi. I don't see such strange exceptions in journal any more. 16 hours may be not enough to be fully sure, however. But in previous runs (with sendfile) first NPE or IAE appears in a half an hour or so.

[Bug 60385] ServletRequestListener.requestDestroyed not invoked after exception in requestInitialized

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60385 --- Comment #7 from Todd West --- (In reply to Mark Thomas from comment #6) > There is additional specification language that supports Tomcat's > implementation in the Javadoc for ServletRequestListener: > > A ServletRequest is defined as comi

[Bug 60409] IllegalArgumentException at java.nio.Buffer.position at SocketWrapperBase.transfer()

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60409 --- Comment #13 from Violeta Georgieva --- Hi Evgenij, (In reply to Evgenij Ryazanov from comment #8) > I've appended useSendfile="false" to all HTTP connectors for testing > purposes. Do you have already some results with "send file" disable

[Bug 60409] IllegalArgumentException at java.nio.Buffer.position at SocketWrapperBase.transfer()

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60409 --- Comment #12 from Remy Maucherat --- (In reply to Mark Thomas from comment #10) > Created attachment 34486 [details] > Alternative patch > > My initial impression looking at that patch was that it was fixing the > symptom rather than the ca

[Bug 60409] IllegalArgumentException at java.nio.Buffer.position at SocketWrapperBase.transfer()

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60409 --- Comment #11 from Violeta Georgieva --- (In reply to Mark Thomas from comment #10) > Created attachment 34486 [details] > Alternative patch > > My initial impression looking at that patch was that it was fixing the > symptom rather than the

svn commit: r1771752 - /tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 14:39:12 2016 New Revision: 1771752 URL: http://svn.apache.org/viewvc?rev=1771752&view=rev Log: Fix IDE nag Modified: tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java Modified: tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java U

[Bug 60409] IllegalArgumentException at java.nio.Buffer.position at SocketWrapperBase.transfer()

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60409 --- Comment #10 from Mark Thomas --- Created attachment 34486 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34486&action=edit Alternative patch My initial impression looking at that patch was that it was fixing the symptom rather than

buildbot failure in on tomcat-8-trunk

2016-11-28 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/855 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

[Bug 60413] RewriteValve: empty capturing group results in null backreference instead of "" (empty string)

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60413 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1771745 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/rewrite/Substitution.java test/org/apache/catalina/valves/rewrite/TestRewriteValve.java webapps/docs/changelog.xml

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 14:06:12 2016 New Revision: 1771745 URL: http://svn.apache.org/viewvc?rev=1771745&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60413 In the RewriteValve write empty capture groups as the empty string rather "null" when generating the re-written U

svn commit: r1771744 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/rewrite/Substitution.java test/org/apache/catalina/valves/rewrite/TestRewriteValve.java webapps/docs/changelog.xml

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 14:06:00 2016 New Revision: 1771744 URL: http://svn.apache.org/viewvc?rev=1771744&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60413 In the RewriteValve write empty capture groups as the empty string rather "null" when generating the re-written U

svn commit: r1771743 - in /tomcat/trunk: java/org/apache/catalina/valves/rewrite/Substitution.java test/org/apache/catalina/valves/rewrite/TestRewriteValve.java webapps/docs/changelog.xml

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 14:05:11 2016 New Revision: 1771743 URL: http://svn.apache.org/viewvc?rev=1771743&view=rev Log: In the RewriteValve write empty capture groups as the empty string rather "null" when generating the re-written URL. Based on a patch by Michael Osipov. Modified: to

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2016-11-28 Thread Bill Barker
ump/public/workspace/objenesis/main/target/objenesis-2.5-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20161128.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20161128/bin/openssl -Dex

[Bug 60409] IllegalArgumentException at java.nio.Buffer.position at SocketWrapperBase.transfer()

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60409 --- Comment #9 from Violeta Georgieva --- Created attachment 34485 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34485&action=edit Patch proposal Hi Mark, (In reply to Mark Thomas from comment #6) > To date, the design decision has b

svn commit: r1771730 - /tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java

2016-11-28 Thread violetagg
Author: violetagg Date: Mon Nov 28 12:46:23 2016 New Revision: 1771730 URL: http://svn.apache.org/viewvc?rev=1771730&view=rev Log: Update unit test that reproduces the exceptions reported with bug 60409. Modified: tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java Modified: to

[Bug 60412] RewriteValve documentation does not tell about comment support (#)

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60412 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1771726 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/rewrite.xml

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 12:23:32 2016 New Revision: 1771726 URL: http://svn.apache.org/viewvc?rev=1771726&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60412 Add information on the comment syntax for the RewriteValve configuration. Modified: tomcat/tc8.0.x/trunk/ (

svn commit: r1771725 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/rewrite.xml

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 12:22:58 2016 New Revision: 1771725 URL: http://svn.apache.org/viewvc?rev=1771725&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60412 Add information on the comment syntax for the RewriteValve configuration. Modified: tomcat/tc8.5.x/trunk/ (

svn commit: r1771724 - /tomcat/trunk/webapps/docs/changelog.xml

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 12:22:33 2016 New Revision: 1771724 URL: http://svn.apache.org/viewvc?rev=1771724&view=rev Log: Fix typo. Place in correct section. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/v

svn commit: r1771723 - in /tomcat/trunk/webapps/docs: changelog.xml rewrite.xml

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 12:16:06 2016 New Revision: 1771723 URL: http://svn.apache.org/viewvc?rev=1771723&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60412 Add information on the comment sytax for the RewriteValve configuration. Modified: tomcat/trunk/webapps/docs/

[Bug 60411] Rewrite's redirect implementation does not correspond to the documentation

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60411 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1771720 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/valves/rewrite/ test/org/apache/catalina/valves/rewrite/ webapps/docs/

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 11:56:05 2016 New Revision: 1771720 URL: http://svn.apache.org/viewvc?rev=1771720&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60411 Implement support in the RewriteValve for symbolic names to specify the redirect code to use when returning a red

svn commit: r1771719 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/rewrite/ test/org/apache/catalina/valves/rewrite/ webapps/docs/

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 11:55:28 2016 New Revision: 1771719 URL: http://svn.apache.org/viewvc?rev=1771719&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60411 Implement support in the RewriteValve for symbolic names to specify the redirect code to use when returning a red

svn commit: r1771718 - in /tomcat/trunk: java/org/apache/catalina/valves/rewrite/ test/org/apache/catalina/valves/rewrite/ webapps/docs/

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 11:54:23 2016 New Revision: 1771718 URL: http://svn.apache.org/viewvc?rev=1771718&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60411 Implement support in the RewriteValve for symbolic names to specify the redirect code to use when returning a red

[Bug 60410] Stream closed when reading war entry

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60410 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1771714 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/webresources/AbstractArchiveResource.java test/org/apache/catalina/webresources/TestJarInputStreamWrapper.java webapps/docs

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 11:15:49 2016 New Revision: 1771714 URL: http://svn.apache.org/viewvc?rev=1771714&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60410 Ensure that multiple calls to JarInputStreamWrapper#close() do not incorrectly trigger the closure of the underly

svn commit: r1771712 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/webresources/AbstractArchiveResource.java test/org/apache/catalina/webresources/TestJarInputStreamWrapper.java webapps/docs

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 11:15:14 2016 New Revision: 1771712 URL: http://svn.apache.org/viewvc?rev=1771712&view=rev Log: Ensure that multiple calls to JarInputStreamWrapper#close() do not incorrectly trigger the closure of the underlying JAR or WAR file. Added: tomcat/tc8.5.x/trunk/te

svn commit: r1771711 - in /tomcat/trunk: java/org/apache/catalina/webresources/AbstractArchiveResource.java test/org/apache/catalina/webresources/TestJarInputStreamWrapper.java webapps/docs/changelog.

2016-11-28 Thread markt
Author: markt Date: Mon Nov 28 11:14:29 2016 New Revision: 1771711 URL: http://svn.apache.org/viewvc?rev=1771711&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=60410 Ensure that multiple calls to JarInputStreamWrapper#close() do not incorrectly trigger the closure of the und

[Bug 60425] problem if pipe (|) exist in url requaet

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60425 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 60425] New: problem if pipe (|) exist in url requaet

2016-11-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60425 Bug ID: 60425 Summary: problem if pipe (|) exist in url requaet Product: Tomcat 8 Version: 8.5.8 Hardware: PC OS: Windows NT Status: NEW Severity: norma