[GitHub] tomcat issue #33: Clear up confusion about mbeans-descriptors.xml in docs; f...

Github user violetagg commented on the issue: https://github.com/apache/tomcat/pull/33 Hi, Your patch was applied with r1755717. Regards, Violeta --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[Bug 59823] HttpServletRequest#authenticate does not invoke JASPIC SAM

https://bz.apache.org/bugzilla/show_bug.cgi?id=59823 --- Comment #6 from Arjan Tijms --- >It was. It isn't any more. Great! Does it return false now or is an exception thrown? (i.e. does it behave like GlassFish or like JBoss?) JBoss' behaviour is not because of some kind of bug or oversight bt

buildbot failure in on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/1576 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler schedu

buildbot failure in on tomcat-8-trunk

The Buildbot has detected a new failure on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/716 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1756057 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/authenticator/AuthenticatorBase.java

Author: markt Date: Thu Aug 11 21:59:17 2016 New Revision: 1756057 URL: http://svn.apache.org/viewvc?rev=1756057&view=rev Log: Follow-up for https://bz.apache.org/bugzilla/show_bug.cgi?id=59823 HttpServletRequest#authenticate() should return false for a null Principal Modified: tomcat/tc8.5.x

svn commit: r1756056 - /tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java

Author: markt Date: Thu Aug 11 21:58:21 2016 New Revision: 1756056 URL: http://svn.apache.org/viewvc?rev=1756056&view=rev Log: Follow-up for https://bz.apache.org/bugzilla/show_bug.cgi?id=59823 HttpServletRequest#authenticate() should return false for a null Principal Modified: tomcat/trunk/j

[GitHub] tomcat issue #33: Clear up confusion about mbeans-descriptors.xml in docs; f...

Github user rhusar commented on the issue: https://github.com/apache/tomcat/pull/33 My thinking is that first, we need to stop perpetuating the wrong name "mbeans-descriptor" which is the name of the page, and more importantly, the page gives such a bad advice that it deserves a rena

svn commit: r1756055 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

Author: markt Date: Thu Aug 11 21:47:16 2016 New Revision: 1756055 URL: http://svn.apache.org/viewvc?rev=1756055&view=rev Log: Restore r1753084 Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java tomcat/tc8.0

svn commit: r1756053 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

Author: markt Date: Thu Aug 11 21:45:41 2016 New Revision: 1756053 URL: http://svn.apache.org/viewvc?rev=1756053&view=rev Log: Restore r1753081 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java tomcat/tc8.5

svn commit: r1756052 - in /tomcat/trunk: java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

Author: markt Date: Thu Aug 11 21:43:59 2016 New Revision: 1756052 URL: http://svn.apache.org/viewvc?rev=1756052&view=rev Log: Restore r1753080 Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/j

[Bug 59862] Allow Nested Jar Scanning to be Filtered with System Property

https://bz.apache.org/bugzilla/show_bug.cgi?id=59862 --- Comment #6 from Mark Thomas --- It was me that voiced concerns over this that led to the original commits being reverted. I've now found the time to come back to this. As far as the Servlet spec is concerned, JARs are located in WEB-INF/li

svn commit: r1756044 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/deploy/ErrorPage.java test/org/apache/catalina/core/TestStandardHostValve.java webapps/docs/changelog.xml

Author: markt Date: Thu Aug 11 20:17:20 2016 New Revision: 1756044 URL: http://svn.apache.org/viewvc?rev=1756044&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59966 Fail Context if error page configuration in web.xml is broken. Modified: tomcat/tc7.0.x/trunk/ (props chang

[Bug 59966] Wrong configured error-page elements in deployment descriptor will become the fallback error-page

https://bz.apache.org/bugzilla/show_bug.cgi?id=59966 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1756041 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/descriptor/web/ErrorPage.java test/org/apache/catalina/core/TestStandardHostValve.java webapps/docs/changelog.xml

Author: markt Date: Thu Aug 11 20:14:22 2016 New Revision: 1756041 URL: http://svn.apache.org/viewvc?rev=1756041&view=rev Log: Fail Context if error page configuration in web.xml is broken. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util

svn commit: r1756040 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/descriptor/web/ErrorPage.java test/org/apache/catalina/core/TestStandardHostValve.java webapps/docs/changelog.xml

Author: markt Date: Thu Aug 11 20:13:48 2016 New Revision: 1756040 URL: http://svn.apache.org/viewvc?rev=1756040&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59966 Fail Context if error page configuration in web.xml is broken. Modified: tomcat/tc8.5.x/trunk/ (props chang

svn commit: r1756039 - in /tomcat/trunk: java/org/apache/tomcat/util/descriptor/web/ErrorPage.java test/org/apache/catalina/core/TestStandardHostValve.java webapps/docs/changelog.xml

Author: markt Date: Thu Aug 11 20:13:03 2016 New Revision: 1756039 URL: http://svn.apache.org/viewvc?rev=1756039&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59966 Fail Context if error page configuration in web.xml is broken. Modified: tomcat/trunk/java/org/apache/tomcat/

[Bug 59904] memory leak--ServerCookie

https://bz.apache.org/bugzilla/show_bug.cgi?id=59904 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1756037 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/http/ webapps/docs/ webapps/docs/conf

Author: markt Date: Thu Aug 11 19:48:31 2016 New Revision: 1756037 URL: http://svn.apache.org/viewvc?rev=1756037&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59904 Add a limit (default 200) for the number of cookies allowed per request. Based on a patch by gehui. Modified:

svn commit: r1756036 - in /tomcat/tc6.0.x/trunk/java/org/apache/coyote: ajp/ http11/

Author: markt Date: Thu Aug 11 19:44:39 2016 New Revision: 1756036 URL: http://svn.apache.org/viewvc?rev=1756036&view=rev Log: Clean-up No functional change Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java tomcat/tc6.0.x/trunk/java/org/apache/coyote/ajp/AjpAp

svn commit: r1756030 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/http/ webapps/docs/ webapps/docs/conf

Author: markt Date: Thu Aug 11 18:57:23 2016 New Revision: 1756030 URL: http://svn.apache.org/viewvc?rev=1756030&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59904 Add a limit (default 200) for the number of cookies allowed per request. Based on a patch by gehui. Modified:

svn commit: r1756020 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/http/ServerCookies.java

Author: markt Date: Thu Aug 11 18:06:30 2016 New Revision: 1756020 URL: http://svn.apache.org/viewvc?rev=1756020&view=rev Log: StringManager should be private static final Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/ServerCookie

svn commit: r1756021 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/http/ServerCookies.java

Author: markt Date: Thu Aug 11 18:06:38 2016 New Revision: 1756021 URL: http://svn.apache.org/viewvc?rev=1756021&view=rev Log: StringManager should be private static final Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/http/ServerCookie

svn commit: r1756019 - /tomcat/trunk/java/org/apache/tomcat/util/http/ServerCookies.java

Author: markt Date: Thu Aug 11 18:06:04 2016 New Revision: 1756019 URL: http://svn.apache.org/viewvc?rev=1756019&view=rev Log: StringManager should be private static final Modified: tomcat/trunk/java/org/apache/tomcat/util/http/ServerCookies.java Modified: tomcat/trunk/java/org/apache/tomca

svn commit: r1756018 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/http/ webapps/docs/ webapps/docs/conf

Author: markt Date: Thu Aug 11 17:54:42 2016 New Revision: 1756018 URL: http://svn.apache.org/viewvc?rev=1756018&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59904 Add a limit (default 200) for the number of cookies allowed per request. Based on a patch by gehui. Modified:

svn commit: r1756014 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/http/ webapps/docs/ webapps/docs/conf

Author: markt Date: Thu Aug 11 17:12:22 2016 New Revision: 1756014 URL: http://svn.apache.org/viewvc?rev=1756014&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59904 Add a limit (default 200) for the number of cookies allowed per request. Based on a patch by gehui. Modified:

svn commit: r1756013 - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/http/ webapps/docs/ webapps/docs/config/

Author: markt Date: Thu Aug 11 17:09:25 2016 New Revision: 1756013 URL: http://svn.apache.org/viewvc?rev=1756013&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59904 Add a limit (default 200) for the number of cookies allowed per request. Based on a patch by gehui. Modified:

svn commit: r1755994 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/Http2UpgradeHandler.java

Author: markt Date: Thu Aug 11 14:18:03 2016 New Revision: 1755994 URL: http://svn.apache.org/viewvc?rev=1755994&view=rev Log: Reduce duplication. Ensure current concurrency is correctly tracked. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote

svn commit: r1755993 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

Author: markt Date: Thu Aug 11 14:17:32 2016 New Revision: 1755993 URL: http://svn.apache.org/viewvc?rev=1755993&view=rev Log: Reduce duplication. Ensure current concurrency is correctly tracked. Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Modified: tomcat/tr

svn commit: r1755971 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/Request.java

Author: markt Date: Thu Aug 11 12:28:51 2016 New Revision: 1755971 URL: http://svn.apache.org/viewvc?rev=1755971&view=rev Log: Fix typo Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/coyote/Request.java Propchange: tomcat/tc8.5.x/trunk/ ---

svn commit: r1755970 - /tomcat/trunk/java/org/apache/coyote/Request.java

Author: markt Date: Thu Aug 11 12:28:22 2016 New Revision: 1755970 URL: http://svn.apache.org/viewvc?rev=1755970&view=rev Log: Fix typo Modified: tomcat/trunk/java/org/apache/coyote/Request.java Modified: tomcat/trunk/java/org/apache/coyote/Request.java URL: http://svn.apache.org/viewvc/tom

[Bug 59904] memory leak--ServerCookie

https://bz.apache.org/bugzilla/show_bug.cgi?id=59904 Chuck Caldarale changed: What|Removed |Added Summary|memery leak--ServerCookie |memory leak--ServerCookie -- You ar

svn commit: r1755961 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/http/TestMimeHeadersIntegration.java

Author: markt Date: Thu Aug 11 12:00:48 2016 New Revision: 1755961 URL: http://svn.apache.org/viewvc?rev=1755961&view=rev Log: Fix broken test Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/http/TestMimeHeadersIntegration.java Propchan

svn commit: r1755960 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestMimeHeadersIntegration.java

Author: markt Date: Thu Aug 11 12:00:08 2016 New Revision: 1755960 URL: http://svn.apache.org/viewvc?rev=1755960&view=rev Log: Fix broken test Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestMimeHeadersIntegration.java Modified: tomcat/trunk/test/org/apache/tomcat/util/http/Tes

svn commit: r1755959 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/Connector.java

Author: markt Date: Thu Aug 11 11:55:42 2016 New Revision: 1755959 URL: http://svn.apache.org/viewvc?rev=1755959&view=rev Log: Clean-up - fix indentation (4 rather than 5 spaces) - remove unnecessary whitespace - use longer lines where possible - copy properties to protocol handler consistently -

svn commit: r1755958 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java

Author: markt Date: Thu Aug 11 11:55:11 2016 New Revision: 1755958 URL: http://svn.apache.org/viewvc?rev=1755958&view=rev Log: Clean-up - fix indentation (4 rather than 5 spaces) - remove unnecessary whitespace - use longer lines where possible - copy properties to protocol handler consistently -

svn commit: r1755947 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/FutureToSendHandler.java

Author: markt Date: Thu Aug 11 11:30:03 2016 New Revision: 1755947 URL: http://svn.apache.org/viewvc?rev=1755947&view=rev Log: Correct import Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/FutureToSendHandler.java Propchange: tomc

svn commit: r1755945 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/FutureToSendHandler.java

Author: markt Date: Thu Aug 11 11:29:25 2016 New Revision: 1755945 URL: http://svn.apache.org/viewvc?rev=1755945&view=rev Log: Correct import Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/FutureToSendHandler.java Propchange: tomc

svn commit: r1755944 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/websocket/FutureToSendHandler.java

Author: markt Date: Thu Aug 11 11:29:01 2016 New Revision: 1755944 URL: http://svn.apache.org/viewvc?rev=1755944&view=rev Log: Correct import Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/FutureToSendHandler.java Propchange: tomc

svn commit: r1755942 - /tomcat/trunk/java/org/apache/tomcat/websocket/FutureToSendHandler.java

Author: markt Date: Thu Aug 11 11:28:23 2016 New Revision: 1755942 URL: http://svn.apache.org/viewvc?rev=1755942&view=rev Log: Correct import Modified: tomcat/trunk/java/org/apache/tomcat/websocket/FutureToSendHandler.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/FutureToSendH

[Bug 59904] memery leak--ServerCookie

https://bz.apache.org/bugzilla/show_bug.cgi?id=59904 --- Comment #8 from Mark Thomas --- I did some testing using: http://browsercookielimits.squawky.net/ Focusing on max cookies per domain, the results are: FireFox + Win = 150 FireFox + OSX = 150 Chrome + Win = 180 Chrome + OSX = 180 IE 11 +

svn commit: r1755926 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/SocketProperties.java webapps/docs/config/http.xml

Author: violetagg Date: Thu Aug 11 09:12:16 2016 New Revision: 1755926 URL: http://svn.apache.org/viewvc?rev=1755926&view=rev Log: Correct javadoc. Update Connectors configuration page. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/

buildbot success in on tomcat-8-trunk

The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/711 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1755923 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/net/SocketProperties.java webapps/docs/changelog.xml webapps/docs/config/http.xml

Author: violetagg Date: Thu Aug 11 08:54:54 2016 New Revision: 1755923 URL: http://svn.apache.org/viewvc?rev=1755923&view=rev Log: Correct javadoc. Update Connectors configuration page. Merge r1755918, r1755919 Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/or

svn commit: r1755920 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/net/SocketProperties.java webapps/docs/changelog.xml webapps/docs/config/http.xml

Author: violetagg Date: Thu Aug 11 08:48:58 2016 New Revision: 1755920 URL: http://svn.apache.org/viewvc?rev=1755920&view=rev Log: Correct javadoc. Update Connectors configuration page. Merge r1755918, r1755919 Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/or

svn commit: r1755919 - /tomcat/trunk/webapps/docs/changelog.xml

Author: violetagg Date: Thu Aug 11 08:45:47 2016 New Revision: 1755919 URL: http://svn.apache.org/viewvc?rev=1755919&view=rev Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tr

svn commit: r1755918 - in /tomcat/trunk: java/org/apache/tomcat/util/net/SocketProperties.java webapps/docs/config/http.xml

Author: violetagg Date: Thu Aug 11 08:35:18 2016 New Revision: 1755918 URL: http://svn.apache.org/viewvc?rev=1755918&view=rev Log: Correct javadoc. Update Connectors configuration page. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketProperties.java tomcat/trunk/webapps/docs/