Compiling JSPs with Jigsaw enabled Java 9

2016-05-17 Thread Mark Thomas
TL;DR. It doesn't work right now and that is probably OK. During my testing of the RMI leak detection changes and Java 9, I realised that JSP compilation was badly broken - none of the JRE provided classes were visible to the class loader. A little research turned up that Jigsaw effectively hides

svn commit: r1744324 - /tomcat/trunk/java/org/apache/jasper/servlet/JasperLoader.java

2016-05-17 Thread markt
Author: markt Date: Tue May 17 20:54:41 2016 New Revision: 1744324 URL: http://svn.apache.org/viewvc?rev=1744324&view=rev Log: Remove unnecessary field. Modified: tomcat/trunk/java/org/apache/jasper/servlet/JasperLoader.java Modified: tomcat/trunk/java/org/apache/jasper/servlet/JasperLoader.

svn commit: r1744323 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ webapps/docs/ webapps/docs/config/

2016-05-17 Thread markt
Author: markt Date: Tue May 17 20:36:54 2016 New Revision: 1744323 URL: http://svn.apache.org/viewvc?rev=1744323&view=rev Log: Make checking for RMI Target memory leaks optional and log a warning if running on Java 9 without the necessary command line options Modified: tomcat/trunk/java/org/

[Bug 59564] New: HttpServletRequest.getPart() always returns null with HTTP/2

2016-05-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59564 Bug ID: 59564 Summary: HttpServletRequest.getPart() always returns null with HTTP/2 Product: Tomcat 8 Version: 8.5.x-trunk Hardware: Macintosh Status: NEW

buildbot success in on tomcat-8-trunk

2016-05-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/631 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1744282 - in /tomcat/site/trunk/docs/tomcat-8.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2016-05-17 Thread markt
Author: markt Date: Tue May 17 14:25:36 2016 New Revision: 1744282 URL: http://svn.apache.org/viewvc?rev=1744282&view=rev Log: Update docs version for 8.0.x [This commit notification would consist of 68 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.] ---

svn commit: r1744275 - in /tomcat/tc7.0.x/trunk: ./ build.xml

2016-05-17 Thread markt
Author: markt Date: Tue May 17 14:12:28 2016 New Revision: 1744275 URL: http://svn.apache.org/viewvc?rev=1744275&view=rev Log: Increase maximum memory for Javadoc process after an OOME during the 8.0.35 release process. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/tru

svn commit: r1744272 - in /tomcat/tc8.0.x/trunk: ./ build.xml

2016-05-17 Thread markt
Author: markt Date: Tue May 17 14:11:01 2016 New Revision: 1744272 URL: http://svn.apache.org/viewvc?rev=1744272&view=rev Log: Increase maximum memory for Javadoc process after an OOME during the 8.0.35 release process. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/tru

svn commit: r1744271 - in /tomcat/tc8.5.x/trunk: ./ build.xml

2016-05-17 Thread markt
Author: markt Date: Tue May 17 14:09:42 2016 New Revision: 1744271 URL: http://svn.apache.org/viewvc?rev=1744271&view=rev Log: Increase maximum memory for Javadoc process after an OOME during the 8.0.35 release process. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/tru

svn commit: r1744270 - /tomcat/trunk/build.xml

2016-05-17 Thread markt
Author: markt Date: Tue May 17 14:09:10 2016 New Revision: 1744270 URL: http://svn.apache.org/viewvc?rev=1744270&view=rev Log: Increase maximum memory for Javadoc process after an OOME during the 8.0.35 release process. Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

8.0.35 Javadoc problems

2016-05-17 Thread Mark Thomas
A different issue occurred with the 8.0.35 Javadocs. In this case it was an OOME during generation. Again, the lack of failonerror meant it was missed. I plan on taking the same approach for 8.0.35 as I did for 8.5.2. Mark - To

[Bug 59398] org.apache.catalina.connector.CoyoteWriter.close throws org.apache.tomcat.jni.Error

2016-05-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59398 --- Comment #6 from Remy Maucherat --- I can sympathize since a lot of the APR code is synced now, but this is really wrong behavior. -- You are receiving this mail because: You are the assignee for the bug. -

svn commit: r1744261 - in /tomcat/site/trunk: ./ docs/ xdocs/

2016-05-17 Thread markt
Author: markt Date: Tue May 17 13:29:35 2016 New Revision: 1744261 URL: http://svn.apache.org/viewvc?rev=1744261&view=rev Log: Update site (excluding docs) for 8.3.35 release Modified: tomcat/site/trunk/build.properties.default tomcat/site/trunk/docs/download-80.html tomcat/site/trunk

svn commit: r13663 - /release/tomcat/tomcat-8/v8.5.0/

2016-05-17 Thread markt
Author: markt Date: Tue May 17 13:10:42 2016 New Revision: 13663 Log: Drop previous 8.5.x release from mirrors. Removed: release/tomcat/tomcat-8/v8.5.0/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additi

svn commit: r1744259 - /tomcat/site/trunk/build.properties.default

2016-05-17 Thread markt
Author: markt Date: Tue May 17 13:09:29 2016 New Revision: 1744259 URL: http://svn.apache.org/viewvc?rev=1744259&view=rev Log: Update docs version for 8.5.x Modified: tomcat/site/trunk/build.properties.default Modified: tomcat/site/trunk/build.properties.default URL: http://svn.apache.org/v

[Bug 59398] org.apache.catalina.connector.CoyoteWriter.close throws org.apache.tomcat.jni.Error

2016-05-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59398 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|REOPENED

[Bug 59398] org.apache.catalina.connector.CoyoteWriter.close throws org.apache.tomcat.jni.Error

2016-05-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59398 james.s...@metaswitch.com changed: What|Removed |Added Resolution|INVALID |--- Status|RESO

Re: 8.5.2 async state?

2016-05-17 Thread Romain Manni-Bucau
I see, that's however a regression for tomcat users. could the async listener wrapper impl this if a tomcat flag is switched on? Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn

Re: 8.5.2 async state?

2016-05-17 Thread Violeta Georgieva
Hi, 2016-05-17 13:46 GMT+03:00 Romain Manni-Bucau : > > the real issue is adding a listener there trigger onStartAsync()*ONLY* (no > onCompleted(), onTimeout(), onError() etc... cause > org.apache.catalina.core.AsyncContextImpl#setStarted does listeners.clear(); > ) > That's behaviour is by spec:

Re: 8.5.2 async state?

2016-05-17 Thread Romain Manni-Bucau
the real issue is adding a listener there trigger onStartAsync()*ONLY* (no onCompleted(), onTimeout(), onError() etc... cause org.apache.catalina.core.AsyncContextImpl#setStarted does listeners.clear(); ) Romain Manni-Bucau @rmannibucau | Blog

Re: 8.5.2 async state?

2016-05-17 Thread Rémy Maucherat
2016-05-17 12:37 GMT+02:00 Romain Manni-Bucau : > Only found https://bz.apache.org/bugzilla/show_bug.cgi?id=59261 which > doesn't mean this code would be invalid > > Also if you add a listener eagerly you will have the start event and loose > all "end" (completed, timeout etc...) ones. This doesn'

Re: 8.5.2 async state?

2016-05-17 Thread Romain Manni-Bucau
Only found https://bz.apache.org/bugzilla/show_bug.cgi?id=59261 which doesn't mean this code would be invalid Also if you add a listener eagerly you will have the start event and loose all "end" (completed, timeout etc...) ones. This doesn't sound very reliable. Can you point me out the related i

Re: 8.5.2 Javadocs problem

2016-05-17 Thread Violeta Georgieva
2016-05-17 13:31 GMT+03:00 Violeta Georgieva : > > Mark, > > 2016-05-17 12:37 GMT+03:00 Mark Thomas : > > > > On 17/05/2016 10:06, Mark Thomas wrote: > > > All, > > > > > > Something went wrong in the 8.5.2 release process and the Javadocs > > > weren't generated correctly. I only discovered this w

[ANN] Apache Tomcat 8.5.2 BETA available

2016-05-17 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 8.5.2 BETA. Apache Tomcat 8.0 is an open source software implementation of the Java Servlet, JavaServer Pages, Java Unified Expression Language, Java WebSocket and Java Authentication Service Provider Interface for Contai

svn commit: r1744247 - in /tomcat/site/trunk/docs/tomcat-8.5-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2016-05-17 Thread markt
Author: markt Date: Tue May 17 10:32:18 2016 New Revision: 1744247 URL: http://svn.apache.org/viewvc?rev=1744247&view=rev Log: Update docs for 8.5.3 release. Note: Docs updated from local build using 8.5.2 tag + r1744219 [This commit notification would consist of 73 parts, which exceeds the lim

Re: 8.5.2 Javadocs problem

2016-05-17 Thread Violeta Georgieva
Mark, 2016-05-17 12:37 GMT+03:00 Mark Thomas : > > On 17/05/2016 10:06, Mark Thomas wrote: > > All, > > > > Something went wrong in the 8.5.2 release process and the Javadocs > > weren't generated correctly. I only discovered this when I went to > > update the docs on the website for 8.5.2 and the

svn commit: r13662 - /release/tomcat/tomcat-9/v9.0.0.M4/

2016-05-17 Thread markt
Author: markt Date: Tue May 17 10:28:31 2016 New Revision: 13662 Log: Drop previous release from mirrors. Removed: release/tomcat/tomcat-9/v9.0.0.M4/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additiona

Re: 8.5.2 async state?

2016-05-17 Thread Mark Thomas
On 17/05/2016 11:24, Romain Manni-Bucau wrote: > Hi guys, > > on 8.5.2 this code doesn't work anymore (in a valve): > > if (!request.isAsync()) { > > getNext().invoke(request, response); > > } else { > request.getAsyncContext().addListener(...); > getNext().invoke(request, response)

8.5.2 async state?

2016-05-17 Thread Romain Manni-Bucau
Hi guys, on 8.5.2 this code doesn't work anymore (in a valve): if (!request.isAsync()) { getNext().invoke(request, response); } else { request.getAsyncContext().addListener(...); getNext().invoke(request, response); } Issue is isAsync() = true but getAsyncContext() throws an except

svn commit: r1744242 - in /tomcat/tc6.0.x/trunk: ./ dist.xml

2016-05-17 Thread markt
Author: markt Date: Tue May 17 10:12:47 2016 New Revision: 1744242 URL: http://svn.apache.org/viewvc?rev=1744242&view=rev Log: Ensure Javadoc failures cause build failures. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/dist.xml Propchange: tomcat/tc6.0.x/trunk/ -

svn commit: r1744241 - in /tomcat/tc7.0.x/trunk: ./ build.xml

2016-05-17 Thread markt
Author: markt Date: Tue May 17 10:09:52 2016 New Revision: 1744241 URL: http://svn.apache.org/viewvc?rev=1744241&view=rev Log: Ensure Javadoc failures cause build failures. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/build.xml Propchange: tomcat/tc7.0.x/trunk/

buildbot failure in on tomcat-8-trunk

2016-05-17 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-8-trunk/builds/630 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler sch

svn commit: r1744237 - in /tomcat/tc8.0.x/trunk: ./ build.xml

2016-05-17 Thread markt
Author: markt Date: Tue May 17 10:02:22 2016 New Revision: 1744237 URL: http://svn.apache.org/viewvc?rev=1744237&view=rev Log: Ensure Javadoc failures cause build failures. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/build.xml Propchange: tomcat/tc8.0.x/trunk/

Re: svn commit: r1744229 - /tomcat/trunk/build.xml

2016-05-17 Thread Mark Thomas
On 17/05/2016 10:50, Rémy Maucherat wrote: > 2016-05-17 11:48 GMT+02:00 : > >> Author: markt >> Date: Tue May 17 09:48:39 2016 >> New Revision: 1744229 >> >> URL: http://svn.apache.org/viewvc?rev=1744229&view=rev >> Log: >> Ensure Javadoc failures cause build failures. >> > Just make sure you don'

svn commit: r1744232 - in /tomcat/tc8.5.x/trunk: ./ build.xml

2016-05-17 Thread markt
Author: markt Date: Tue May 17 09:53:15 2016 New Revision: 1744232 URL: http://svn.apache.org/viewvc?rev=1744232&view=rev Log: Ensure Javadoc failures cause build failures. Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/build.xml Propchange: tomcat/tc8.5.x/trunk/

Re: svn commit: r1744229 - /tomcat/trunk/build.xml

2016-05-17 Thread Rémy Maucherat
2016-05-17 11:48 GMT+02:00 : > Author: markt > Date: Tue May 17 09:48:39 2016 > New Revision: 1744229 > > URL: http://svn.apache.org/viewvc?rev=1744229&view=rev > Log: > Ensure Javadoc failures cause build failures. > > Just make sure you don't backport failonwarning="true" to 8.0 ... Rémy

svn commit: r1744229 - /tomcat/trunk/build.xml

2016-05-17 Thread markt
Author: markt Date: Tue May 17 09:48:39 2016 New Revision: 1744229 URL: http://svn.apache.org/viewvc?rev=1744229&view=rev Log: Ensure Javadoc failures cause build failures. Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build

[Bug 59560] Start-up of tomcat8 to stop in the middle.

2016-05-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59560 Remy Maucherat changed: What|Removed |Added OS||All Status|NEW

Re: 8.5.2 Javadocs problem

2016-05-17 Thread Mark Thomas
On 17/05/2016 10:06, Mark Thomas wrote: > All, > > Something went wrong in the 8.5.2 release process and the Javadocs > weren't generated correctly. I only discovered this when I went to > update the docs on the website for 8.5.2 and the diff looked strange. > > I am currently repeating the build

svn commit: r1744219 - /tomcat/tc8.5.x/trunk/java/org/apache/catalina/servlet4preview/package-info.java

2016-05-17 Thread remm
Author: remm Date: Tue May 17 09:11:50 2016 New Revision: 1744219 URL: http://svn.apache.org/viewvc?rev=1744219&view=rev Log: Fix javadoc HTML content. Modified: tomcat/tc8.5.x/trunk/java/org/apache/catalina/servlet4preview/package-info.java Modified: tomcat/tc8.5.x/trunk/java/org/apache/c

8.5.2 Javadocs problem

2016-05-17 Thread Mark Thomas
All, Something went wrong in the 8.5.2 release process and the Javadocs weren't generated correctly. I only discovered this when I went to update the docs on the website for 8.5.2 and the diff looked strange. I am currently repeating the build process to see if I can reproduce the issue to figure

[ANN] Apache Tomcat 9.0.0.M6 available

2016-05-17 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 9.0.0.M6. Apache Tomcat 9 is an open source software implementation of the Java Servlet, JavaServer Pages, Java Unified Expression Language, Java WebSocket and JASPIC technologies. Apache Tomcat 9.0.0.M6 is a milestone r

svn commit: r1744208 - in /tomcat/site/trunk: docs/download-80.html docs/index.html docs/migration-85.html docs/oldnews.html docs/whichversion.html xdocs/download-80.xml xdocs/index.xml xdocs/migratio

2016-05-17 Thread markt
Author: markt Date: Tue May 17 08:26:15 2016 New Revision: 1744208 URL: http://svn.apache.org/viewvc?rev=1744208&view=rev Log: Update site (excluding docs) for 8.5.2 release Modified: tomcat/site/trunk/docs/download-80.html tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/migr

svn commit: r1744207 - in /tomcat/site/trunk: ./ docs/tomcat-9.0-doc/ docs/tomcat-9.0-doc/api/ docs/tomcat-9.0-doc/api/org/apache/catalina/ docs/tomcat-9.0-doc/api/org/apache/catalina/ant/ docs/tomcat

2016-05-17 Thread markt
Author: markt Date: Tue May 17 08:24:55 2016 New Revision: 1744207 URL: http://svn.apache.org/viewvc?rev=1744207&view=rev Log: Update Tomcat 9 docs to 9.0.0.M6 [This commit notification would consist of 75 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.]

svn commit: r1744205 - in /tomcat/site/trunk: docs/download-90.html docs/index.html docs/migration-9.html docs/oldnews.html docs/whichversion.html xdocs/download-90.xml xdocs/index.xml xdocs/migration

2016-05-17 Thread markt
Author: markt Date: Tue May 17 08:14:12 2016 New Revision: 1744205 URL: http://svn.apache.org/viewvc?rev=1744205&view=rev Log: Update site (excluding docs) for 9.0.0.M6 release Modified: tomcat/site/trunk/docs/download-90.html tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/m

Re: NPE in StandardJarScanner

2016-05-17 Thread Violeta Georgieva
2016-05-17 10:25 GMT+03:00 Romain Manni-Bucau : > > Thanks Violeta for the fix! > The fix will be available in 9.0.0.M7, 8.5.3 and 8.0.36 Regards, Violeta > > Romain Manni-Bucau > @rmannibucau | Blog > | Github < https://githu

svn commit: r1744197 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

2016-05-17 Thread violetagg
Author: violetagg Date: Tue May 17 07:26:20 2016 New Revision: 1744197 URL: http://svn.apache.org/viewvc?rev=1744197&view=rev Log: Merged revision 1744194 from tomcat/trunk: Ensure NPE will not be thrown during deployment when scanning jar files without MANIFEST.MF file. Modified: tomcat/tc8

Re: NPE in StandardJarScanner

2016-05-17 Thread Romain Manni-Bucau
Thanks Violeta for the fix! Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber | JavaEE Factory

svn commit: r1744195 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

2016-05-17 Thread violetagg
Author: violetagg Date: Tue May 17 07:23:21 2016 New Revision: 1744195 URL: http://svn.apache.org/viewvc?rev=1744195&view=rev Log: Merged revision 1744194 from tomcat/trunk: Ensure NPE will not be thrown during deployment when scanning jar files without MANIFEST.MF file. Modified: tomcat/tc8

svn commit: r1744194 - in /tomcat/trunk: java/org/apache/tomcat/util/scan/StandardJarScanner.java webapps/docs/changelog.xml

2016-05-17 Thread violetagg
Author: violetagg Date: Tue May 17 07:18:38 2016 New Revision: 1744194 URL: http://svn.apache.org/viewvc?rev=1744194&view=rev Log: Ensure NPE will not be thrown during deployment when scanning jar files without MANIFEST.MF file. Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/Standar

[Bug 59560] New: Start-up of tomcat8 to stop in the middle.

2016-05-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59560 Bug ID: 59560 Summary: Start-up of tomcat8 to stop in the middle. Product: Tomcat 8 Version: 8.0.30 Hardware: PC Status: NEW Severity: normal Priority: P2