it/target/junit-4.13-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
-Dexamples.sources.skip=true
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20151218.jar
-Dtomcat-dbcp-src.jar=/srv/gump/public/wo
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #15 from Mark Thomas ---
Ignoring the reasoning isn't a red herring. It is part of deciding what the
best solution is. "Because someone wants it" is not, on its own, sufficient
justification.
The patch looks like a good start if we
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #14 from Phillip Webb ---
I've been mulling this issue over a little bit more and I think that the
arguments about whether removing the header offers any real world security or
bandwidth benefits are a bit of a red herring. There's
https://bz.apache.org/bugzilla/show_bug.cgi?id=58723
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Author: markt
Date: Fri Dec 18 15:43:02 2015
New Revision: 1720817
URL: http://svn.apache.org/viewvc?rev=1720817&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58723
Clarify documentation and error messages for the text interface of the manager
to make clear that version must be
Author: violetagg
Date: Fri Dec 18 15:17:45 2015
New Revision: 1720807
URL: http://svn.apache.org/viewvc?rev=1720807&view=rev
Log:
Merged revision 1720804 from tomcat/trunk:
Fixed findbugs issues - Comparison of String parameter using == or !=. Update
false positives filter.
Modified:
tomcat
Author: violetagg
Date: Fri Dec 18 15:13:10 2015
New Revision: 1720805
URL: http://svn.apache.org/viewvc?rev=1720805&view=rev
Log:
Merged revision 1720804 from tomcat/trunk:
Fixed findbugs issues - Comparison of String parameter using == or !=. Update
false positives filter.
Modified:
tomcat
Author: violetagg
Date: Fri Dec 18 15:02:38 2015
New Revision: 1720804
URL: http://svn.apache.org/viewvc?rev=1720804&view=rev
Log:
Fixed findbugs issues - Comparison of String parameter using == or !=. Update
false positives filter.
Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/JmxR
The Buildbot has detected a restored build on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/246
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
Author: markt
Date: Fri Dec 18 14:42:01 2015
New Revision: 1720800
URL: http://svn.apache.org/viewvc?rev=1720800&view=rev
Log:
Various low-level FindBugs warnings
- use of static
- mutable constants
Modified:
tomcat/trunk/java/org/apache/catalina/storeconfig/ConnectorStoreAppender.java
Author: markt
Date: Fri Dec 18 14:19:34 2015
New Revision: 1720795
URL: http://svn.apache.org/viewvc?rev=1720795&view=rev
Log:
Use of '{' and '}' inside {@code ... } confuses the validation parser
Modified:
tomcat/trunk/java/org/apache/catalina/filters/ExpiresFilter.java
Modified: tomcat/tru
Author: markt
Date: Fri Dec 18 14:19:49 2015
New Revision: 1720796
URL: http://svn.apache.org/viewvc?rev=1720796&view=rev
Log:
Use of '{' and '}' inside {@code ... } confuses the validation parser
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/filters/ExpiresFilter.java
Modified:
t
Author: markt
Date: Fri Dec 18 14:13:18 2015
New Revision: 1720789
URL: http://svn.apache.org/viewvc?rev=1720789&view=rev
Log:
Comet processing in 7.0.x is a little messier than in 8.0.x. Refactor the BZ
58702 patch to take account of that.
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/cata
Author: violetagg
Date: Fri Dec 18 14:10:56 2015
New Revision: 1720788
URL: http://svn.apache.org/viewvc?rev=1720788&view=rev
Log:
Merged revisions 1720769, 1720776 from tomcat/trunk:
Fixed findbugs issues:
- Concatenates strings using + in a loop
- Useless condition
Modified:
tomcat/tc7.0.x/
Github user ukari commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165782452
I put that example in email, so you can't see it in github.
https://drive.google.com/file/d/0BxfFe2h4UJX4OEdMZ2dZMTBvYzBvOEl5Ykx4WUxNVWJiRmpj/view?usp=sharing
---
If y
Author: remm
Date: Fri Dec 18 13:48:41 2015
New Revision: 1720785
URL: http://svn.apache.org/viewvc?rev=1720785&view=rev
Log:
Code cleanup.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java
URL:
Github user violetagg commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165781265
I meant an example application which we can use to reproduce the issue that
you are describing.
---
If your project is set up for it, you can reply to this email and h
Author: violetagg
Date: Fri Dec 18 13:35:56 2015
New Revision: 1720783
URL: http://svn.apache.org/viewvc?rev=1720783&view=rev
Log:
Merged revisions 1720769, 1720776 from tomcat/trunk:
Fixed findbugs issues:
- Concatenates strings using + in a loop
- Useless condition
Modified:
tomcat/tc8.0.x/
Author: violetagg
Date: Fri Dec 18 13:00:53 2015
New Revision: 1720776
URL: http://svn.apache.org/viewvc?rev=1720776&view=rev
Log:
More useless conditions
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/XByteBuffer.java
tomcat/trunk/java/org/apache/jasper/compiler/JspReader.java
On 18/12/2015 12:05, Violeta Georgieva wrote:
> Hi,
>
> 2015-12-18 13:46 GMT+02:00 Mark Thomas :
>>
>> On 18/12/2015 11:42, ma...@apache.org wrote:
>>> Author: markt
>>> Date: Fri Dec 18 11:42:18 2015
>>> New Revision: 1720759
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1720759&view=rev
>>> Log:
Author: violetagg
Date: Fri Dec 18 12:36:35 2015
New Revision: 1720769
URL: http://svn.apache.org/viewvc?rev=1720769&view=rev
Log:
Fixed findbugs issues:
- Concatenates strings using + in a loop
- Useless condition
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
t
The Buildbot has detected a new failure on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/245
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Github user ukari commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165767039
Here is the example
2015-12-18 20:12 GMT+08:00 Wenjie Zhang :
> Here is the document for this filter,
>
http://tomcat.apache.org/tomcat-7.0-doc/config/
Github user wenjiezhang2013 commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165765309
Here is the document for this filter,
http://tomcat.apache.org/tomcat-7.0-doc/config/filter.html#Add_Default_Character_Set_Filter,
base on the code, this shoul
Github user violetagg commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165765057
Can you provide a sample example that demonstrates the issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Hi,
2015-12-18 13:46 GMT+02:00 Mark Thomas :
>
> On 18/12/2015 11:42, ma...@apache.org wrote:
> > Author: markt
> > Date: Fri Dec 18 11:42:18 2015
> > New Revision: 1720759
> >
> > URL: http://svn.apache.org/viewvc?rev=1720759&view=rev
> > Log:
> > Formatting. No functional change.
>
> I'm looking
Github user ukari commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165763957
Oh, you are right, sorry I make the mistake.
But why response's encoding not changed after I set
AddDefaultCharsetFilter?(I mean a HttpServletResponse)
Is the warppe
Author: markt
Date: Fri Dec 18 11:59:29 2015
New Revision: 1720763
URL: http://svn.apache.org/viewvc?rev=1720763&view=rev
Log:
Remove attribute from MBean descriptions that no longer exist.
Modified:
tomcat/trunk/java/org/apache/catalina/realm/mbeans-descriptors.xml
tomcat/trunk/java/org/
On 18/12/2015 11:42, ma...@apache.org wrote:
> Author: markt
> Date: Fri Dec 18 11:42:18 2015
> New Revision: 1720759
>
> URL: http://svn.apache.org/viewvc?rev=1720759&view=rev
> Log:
> Formatting. No functional change.
I'm looking into some issues reported by Coverity in this class so I
wanted t
Author: markt
Date: Fri Dec 18 11:42:18 2015
New Revision: 1720759
URL: http://svn.apache.org/viewvc?rev=1720759&view=rev
Log:
Formatting. No functional change.
Modified:
tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/manage
https://bz.apache.org/bugzilla/show_bug.cgi?id=58702
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
OS|
Github user violetagg commented on the pull request:
https://github.com/apache/tomcat/pull/25#issuecomment-165754059
Hello,
The encoding specified by the user is provided to the ResponseWrapper.
The ResponseWrapper is provided with the method `doFilter` instead of the
orig
Author: markt
Date: Fri Dec 18 11:33:56 2015
New Revision: 1720757
URL: http://svn.apache.org/viewvc?rev=1720757&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58702
Ensure an access log entry is generated if the client aborts the connection.
Modified:
tomcat/tc7.0.x/trunk/
Author: markt
Date: Fri Dec 18 11:27:01 2015
New Revision: 1720756
URL: http://svn.apache.org/viewvc?rev=1720756&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58702
Ensure an access log entry is generated if the client aborts the connection.
Modified:
tomcat/tc8.0.x/trunk/
Author: markt
Date: Fri Dec 18 11:17:34 2015
New Revision: 1720752
URL: http://svn.apache.org/viewvc?rev=1720752&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58702
Ensure an access log entry is generated if the client aborts the connection.
Modified:
tomcat/trunk/java/org/
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #13 from Phillip Webb ---
Created attachment 33364
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33364&action=edit
Suggested patch
Something like this. (not including tests yet as not sure where to add them)
--
You are r
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #12 from Phillip Webb ---
For more information about what's driving this request see
https://github.com/spring-projects/spring-boot/issues/4730. We've specifically
looking for feature parity across all embedded servlet containers th
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #11 from Phillip Webb ---
Removing all server header processing code will break back compatibility.
Specifically, this recently added Spring Boot feature [1] will stop working
since it relies on the `server` attribute being picked u
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
Phillip Webb changed:
What|Removed |Added
CC||pw...@pivotal.io
--- Comment #10 from P
https://bz.apache.org/bugzilla/show_bug.cgi?id=58751
--- Comment #1 from Andy Wilkinson ---
Created attachment 33363
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33363&action=edit
Another variant of the testcase the resulting in a ClientAbortException
I've attached another testcase tha
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #9 from Mark Thomas ---
I remain unconvinced that there are any real world security benefits to be
gained by removing the security header.
The bandwidth argument carries slightly more weight but we are only talking 27
bytes per res
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #8 from Remy Maucherat ---
"2) if a Server header was set by a web application, we should remove it": I
see no reason to do that.
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #7 from Phillip Webb ---
Thanks! Sorry, I should have checked that.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #6 from Mark Thomas ---
Read BUILDING.txt for details on the minimum Ant version required.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58750
--- Comment #5 from Phillip Webb ---
I'm trying to create a patch for this but I don't seem to be able to build
8.0.x from trunk.
Running `ant test` gives me:
test-bio:
BUILD FAILED
/Users/pwebb/projects/tomcat/trunk/build.xml:1374: The foll
45 matches
Mail list logo
