[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2015-11-27 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-apr has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2015-11-27 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community integration

[Bug 58657] Spring DeferredResult errorResult response not returned in async servlet 3.1 mode

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58657 --- Comment #4 from Mark Thomas --- Your test case, while welcome, assumes the Tomcat developers are familiar with Spring Boot. A zip or tar.gz of the source tree, a pointer to a github project or similar to build the WAR would be better. Assu

[Bug 58647] After blocking write timeout occurs, WsRemoteEndpointImplBase remains in BINARY_PARTIAL_WRITING state.

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58647 --- Comment #4 from Alexander Malyshev --- Ok, may be you're right. In case it's unrecoverable, though, I don't see why the connection is not closed in this case and I is left in this weird state. It's not an issue for me to close it myself or

[Bug 58655] IllegalStateException: calling HttpServletResponse#sendRedirect() with RemoteIpFilter

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58655 --- Comment #2 from Mark Thomas --- Using relative redirects (see bug 56917) should make this fixable. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 56917] Create a configuration to write relative 302 responses instead of absolute

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917 --- Comment #4 from Mark Thomas --- Good news. RFC2616 has been obsoleted by RFC7231 and friends. RFC7231 allows redirects to be relative. This looks like it could turn into my favourite type of bug report - one I can fix by deleting code :) -

[Bug 58662] blacklist some classes in custom ObjectInputStreams

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58662 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|REOPENED

[Bug 58662] blacklist some classes in custom ObjectInputStreams

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58662 romain.manni-bucau changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED

[Bug 58662] blacklist some classes in custom ObjectInputStreams

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58662 --- Comment #2 from romain.manni-bucau --- You dont need to be able to add a jar to lib directory. The point was a user can do it in its installation and this can have side effects. Or do you mean that adding a jar to tomcat/lib makes tomcat no

[Bug 58647] After blocking write timeout occurs, WsRemoteEndpointImplBase remains in BINARY_PARTIAL_WRITING state.

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58647 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Bug 58658] 7.0.66 running with Java 6 fails unless unneeded "tomcat7-websocket.jar" is removed from lib/

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58658 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED OS|

svn commit: r1716914 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/websocket/WsWebSocketContainer.java webapps/docs/changelog.xml

2015-11-27 Thread markt
Author: markt Date: Fri Nov 27 20:29:40 2015 New Revision: 1716914 URL: http://svn.apache.org/viewvc?rev=1716914&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58658 Correct a regression in 7.0.66 that prevented Tomcat from starting on Java 6 unless the WebSocket JARs (that requ

[Bug 58662] blacklist some classes in custom ObjectInputStreams

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58662 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #15 from Mark Thomas --- I think there are valid use cases for the flag so I'd like to keep it but I'd be happy to change the default. I found a few issues with my first pass which I have now fixed. I'm currently thinking more test

svn commit: r1716894 - /tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java

2015-11-27 Thread markt
Author: markt Date: Fri Nov 27 16:11:23 2015 New Revision: 1716894 URL: http://svn.apache.org/viewvc?rev=1716894&view=rev Log: Additional fix for BZ 58660 When Mapper root redirect is enabled, ensure '/' is added to path for redirect Modified: tomcat/trunk/java/org/apache/catalina/mapper/Mapp

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #14 from Remy Maucherat --- Testing looks ok (but I probably tested the same things you did). I would have preferred not adding the root path redirect flag though. -- You are receiving this mail because: You are the assignee for t

svn commit: r1716886 - /tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java

2015-11-27 Thread markt
Author: markt Date: Fri Nov 27 15:25:13 2015 New Revision: 1716886 URL: http://svn.apache.org/viewvc?rev=1716886&view=rev Log: Additional fix for BZ 58660 Need to override new method Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Modified: tomcat/trunk/java/org/a

buildbot failure in ASF Buildbot on tomcat-trunk

2015-11-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/695 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #13 from Mark Thomas --- I've committed my first pass at a fix for this to 9.0.x. Please test and I'll work on a 8.0.x release as soon as we are happy with this. At this point I'm still neutral on what the default should be for map

svn commit: r1716882 - in /tomcat/trunk/java/org/apache/catalina: authenticator/FormAuthenticator.java mapper/Mapper.java servlets/DefaultServlet.java

2015-11-27 Thread markt
Author: markt Date: Fri Nov 27 14:52:27 2015 New Revision: 1716882 URL: http://svn.apache.org/viewvc?rev=1716882&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 With mapperContextRootRedirectEnabled ste to false, the redirect needs to be handled elsewhere. - Ensure the Mapp

svn commit: r1716881 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2015-11-27 Thread markt
Author: markt Date: Fri Nov 27 14:39:23 2015 New Revision: 1716881 URL: http://svn.apache.org/viewvc?rev=1716881&view=rev Log: ServletPath is never null but it might be zero length. Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Modified: tomcat/trunk/java/org/a

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #12 from Mark Thomas --- That is exactly the issue I have been working through. I think I have it solved for the Default Servlet. I'm currently working on issue with FORM login at the context root that Konstantin highlighted. -- Y

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #11 from Remy Maucherat --- The issue is probably that the mapper rewrites (for mapping purposes I think) a "no servlet path" as "/", and the default servlet has no way to know this happened. If I remove this rewrite code, it doesn'

Re: Early Access b93 is available for JDK 9 on java.net

2015-11-27 Thread Rémy Maucherat
2015-11-27 13:43 GMT+01:00 Rory O'Donnell : > JEP 254: Compact Strings (http://openjdk.java.net/jeps/254) > > This JEP adopts a more space-efficient internal representation for strings. > > We propose to change the internal representation of the String class from > a UTF-16 char array to a byte ar

Early Access b93 is available for JDK 9 on java.net

2015-11-27 Thread Rory O'Donnell
Hi Mark/Mladen, Since my last message about JDK 9 build b88, a number of new JEPs have been integrated into JDK 9 b93 available here . I'd like to point you to a few that are now available for testing in this JDK 9 Early Access build: JEP 254: Compact String

[Bug 58662] New: blacklist some classes in custom ObjectInputStreams

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58662 Bug ID: 58662 Summary: blacklist some classes in custom ObjectInputStreams Product: Tomcat 9 Version: unspecified Hardware: PC OS: Mac OS X 10.4 Status: NEW

svn commit: r1716860 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/MapperListener.java

2015-11-27 Thread markt
Author: markt Date: Fri Nov 27 12:18:47 2015 New Revision: 1716860 URL: http://svn.apache.org/viewvc?rev=1716860&view=rev Log: Fix the issue that meant the work-around for BZ 58660 would not work. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/MapperListener.java Modified:

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #10 from Mark Thomas --- You say that just as I think I have put together a fix. Happy to change the default but I'd like to keep the option of having the Default Servlet do the redirect -- You are receiving this mail because: You

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #9 from Remy Maucherat --- Well, since we think everything else works, then the easiest/safest is to unconditionally add back the root path redirect in the mapper. -- You are receiving this mail because: You are the assignee for t

svn commit: r1716858 - /tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java

2015-11-27 Thread markt
Author: markt Date: Fri Nov 27 12:05:27 2015 New Revision: 1716858 URL: http://svn.apache.org/viewvc?rev=1716858&view=rev Log: Port refactoring from super class Modified: tomcat/trunk/java/org/apache/catalina/servlets/WebdavServlet.java Modified: tomcat/trunk/java/org/apache/catalina/servlet

svn commit: r1716856 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2015-11-27 Thread markt
Author: markt Date: Fri Nov 27 12:03:06 2015 New Revision: 1716856 URL: http://svn.apache.org/viewvc?rev=1716856&view=rev Log: Refactor - reduce duplication - use a StringBuilder Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Modified: tomcat/trunk/java/org/apac

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #8 from Konstantin Kolinko --- One more place that fails - a FormAuthenticator if it is configured to a web application as a whole and if its authentication form uses a relative URL to j_security_check, like the examples app does.

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #7 from Remy Maucherat --- Well, I messed up as well, since I was certain this was fine (the code change in the default servlet should have redirected the root path as far as I am concerned), although my own patch never removed the

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #6 from Mark Thomas --- I'm neutral on the default behaviour for context root redirects but either way the current issue needs to be fixed. I'm currently working on this. -- You are receiving this mail because: You are the assigne

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #5 from Remy Maucherat --- Specifically for the context root, the default behavior could be to redirect in the mapper (mapperContextRootRedirectEnabled could be true). -- You are receiving this mail because: You are the assignee f

Re: [VOTE] Release Apache Tomcat 7.0.66

2015-11-27 Thread Konstantin Kolinko
2015-11-26 0:25 GMT+03:00 Violeta Georgieva : > The proposed Apache Tomcat 7.0.66 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.66/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/org

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #4 from Konstantin Kolinko --- Tomcat 8.0.29 - Workaround: In conf/context.xml set the following attribute: Tomcat 7.0.66 (release candidate) - The workaround does not work. The cause is that MapperListener calls wrong (deprecat

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 --- Comment #3 from Konstantin Kolinko --- This is reproducible in Tomcat 7.0.66 (release candidate) as well. -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

svn commit: r1716807 - /tomcat/trunk/java/org/apache/coyote/AbstractProcessorLight.java

2015-11-27 Thread markt
Author: markt Date: Fri Nov 27 09:07:40 2015 New Revision: 1716807 URL: http://svn.apache.org/viewvc?rev=1716807&view=rev Log: Simplify Modified: tomcat/trunk/java/org/apache/coyote/AbstractProcessorLight.java Modified: tomcat/trunk/java/org/apache/coyote/AbstractProcessorLight.java URL: ht

[Bug 58660] Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID Status|NEW

[Bug 58660] New: Different redirect behaviour when accessing path without a /

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660 Bug ID: 58660 Summary: Different redirect behaviour when accessing path without a / Product: Tomcat 8 Version: 8.0.29 Hardware: PC Status: NEW Sever

[Bug 58659] Http2Parser.readFrame() hanging on an unconditional blocking read (TestHttp2Section_5_3 test)

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58659 Konstantin Kolinko changed: What|Removed |Added OS||All Summary|Http2Parse

[Bug 58659] New: Http2Parser.readFrame() hanging on an unconditional blocking read is necessary (TestHttp2Section_5_3 test)

2015-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58659 Bug ID: 58659 Summary: Http2Parser.readFrame() hanging on an unconditional blocking read is necessary (TestHttp2Section_5_3 test) Product: Tomcat 9 Version: 9.0.0.M1 Hard

buildbot success in ASF Buildbot on tomcat-trunk

2015-11-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/691 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSche

svn commit: r1716804 - /tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java

2015-11-27 Thread kkolinko
Author: kkolinko Date: Fri Nov 27 08:21:02 2015 New Revision: 1716804 URL: http://svn.apache.org/viewvc?rev=1716804&view=rev Log: Correct a comment typo Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java U