buildbot success in ASF Buildbot on tomcat-trunk

2015-09-22 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/339 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSche

svn commit: r1704747 - /tomcat/trunk/java/org/apache/coyote/ProtocolHandler.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 22:23:09 2015 New Revision: 1704747 URL: http://svn.apache.org/viewvc?rev=1704747&view=rev Log: Trivial javadoc commit to trigger CI Modified: tomcat/trunk/java/org/apache/coyote/ProtocolHandler.java Modified: tomcat/trunk/java/org/apache/coyote/ProtocolHandler

svn commit: r1704744 - in /tomcat/trunk/test/org/apache/catalina/webresources: AbstractTestFileResourceSet.java TestFileResourceSet.java TestFileResourceSetReadOnly.java TestFileResourceSetVirtual.jav

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 22:14:01 2015 New Revision: 1704744 URL: http://svn.apache.org/viewvc?rev=1704744&view=rev Log: Switch all the FileResource based tests to use dedicated temporary directories for all read/write tests. Modified: tomcat/trunk/test/org/apache/catalina/webresource

svn commit: r1704742 - /tomcat/trunk/test/org/apache/catalina/webresources/TestDirResourceSetVirtual.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 22:08:04 2015 New Revision: 1704742 URL: http://svn.apache.org/viewvc?rev=1704742&view=rev Log: Simplify inheritance Modified: tomcat/trunk/test/org/apache/catalina/webresources/TestDirResourceSetVirtual.java Modified: tomcat/trunk/test/org/apache/catalina/we

svn commit: r1704741 - /tomcat/trunk/test/org/apache/catalina/webresources/TestDirResourceSetMount.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 22:05:12 2015 New Revision: 1704741 URL: http://svn.apache.org/viewvc?rev=1704741&view=rev Log: Switch all the mounted DirResource based tests to use a dedicated temporary directory Modified: tomcat/trunk/test/org/apache/catalina/webresources/TestDirResourceSe

svn commit: r1704739 - in /tomcat/trunk/test/org/apache/catalina/webresources: AbstractTestDirResourceSet.java TestDirResourceSet.java TestDirResourceSetInternal.java TestDirResourceSetReadOnly.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 22:00:26 2015 New Revision: 1704739 URL: http://svn.apache.org/viewvc?rev=1704739&view=rev Log: Switch all the DirResource based tests to use dedicated temporary directories for all read/write tests. Removed: tomcat/trunk/test/org/apache/catalina/webresources/

buildbot exception in ASF Buildbot on tomcat-trunk

2015-09-22 Thread buildbot
The Buildbot has detected a build exception on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/336 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSch

svn commit: r1704735 - /tomcat/trunk/test/org/apache/catalina/webresources/TestDirResourceSetInternal.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 21:45:07 2015 New Revision: 1704735 URL: http://svn.apache.org/viewvc?rev=1704735&view=rev Log: Test should only use a single root Modified: tomcat/trunk/test/org/apache/catalina/webresources/TestDirResourceSetInternal.java Modified: tomcat/trunk/test/org/apa

svn commit: r1704733 - /tomcat/trunk/test/org/apache/catalina/webresources/TestFileResourceSetReadOnly.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 21:38:44 2015 New Revision: 1704733 URL: http://svn.apache.org/viewvc?rev=1704733&view=rev Log: The read only test should use read only resources. Modified: tomcat/trunk/test/org/apache/catalina/webresources/TestFileResourceSetReadOnly.java Modified: tomcat/t

svn commit: r1704732 - in /tomcat/trunk/test/org/apache/catalina/webresources: TestFileResourceSet.java TestFileResourceSetVirtual.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 21:37:06 2015 New Revision: 1704732 URL: http://svn.apache.org/viewvc?rev=1704732&view=rev Log: Revert r1704711. This fix wasn't right. Clear the slate so I can start again. Modified: tomcat/trunk/test/org/apache/catalina/webresources/TestFileResourceSet.java

svn commit: r1704731 - /tomcat/trunk/test/org/apache/catalina/webresources/TestDirResourceSetVirtual.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 21:35:54 2015 New Revision: 1704731 URL: http://svn.apache.org/viewvc?rev=1704731&view=rev Log: Use a dedicated temporary directory for resources that will be read/write during tests. Need to expand this to other tests with read/write resources. Modified: tomc

svn commit: r1704730 - /tomcat/trunk/test/org/apache/catalina/webresources/AbstractTestResourceSet.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 21:35:03 2015 New Revision: 1704730 URL: http://svn.apache.org/viewvc?rev=1704730&view=rev Log: Remove the hack for running tests in parallel without failures. Modified: tomcat/trunk/test/org/apache/catalina/webresources/AbstractTestResourceSet.java Modified:

buildbot success in ASF Buildbot on tomcat-trunk

2015-09-22 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/333 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSche

svn commit: r1704711 - in /tomcat/trunk/test/org/apache/catalina/webresources: TestFileResourceSet.java TestFileResourceSetVirtual.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 19:57:09 2015 New Revision: 1704711 URL: http://svn.apache.org/viewvc?rev=1704711&view=rev Log: Have one read only and one read/write FileResourceSet tests rather than two read only. Modified: tomcat/trunk/test/org/apache/catalina/webresources/TestFileResourceS

svn commit: r1704706 - /tomcat/trunk/test/org/apache/catalina/webresources/

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 19:46:30 2015 New Revision: 1704706 URL: http://svn.apache.org/viewvc?rev=1704706&view=rev Log: Refactoring in preparation for fixing issue with running tests in parallel Modified: tomcat/trunk/test/org/apache/catalina/webresources/AbstractTestDirResourceSet.ja

svn commit: r1704702 - in /tomcat/trunk/test/org/apache/catalina/startup: TestHostConfigAutomaticDeployment.java TomcatBaseTest.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 19:27:10 2015 New Revision: 1704702 URL: http://svn.apache.org/viewvc?rev=1704702&view=rev Log: Refactor to expose useful utility method to other tests Modified: tomcat/trunk/test/org/apache/catalina/startup/TestHostConfigAutomaticDeployment.java tomcat/tru

[Bug 58445] Valid domain characters in Rfc6265CookieProcessor are incomplete

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58445 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1704691 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java webapps/docs/changelog.xml

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 18:59:47 2015 New Revision: 1704691 URL: http://svn.apache.org/viewvc?rev=1704691&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58445 Fix off-by one error in calculation of valid characters in a cookie domain. Patch provided by Thorsten Ehlers. Mo

svn commit: r1704689 - /tomcat/trunk/java/org/apache/tomcat/util/http/Rfc6265CookieProcessor.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 18:56:39 2015 New Revision: 1704689 URL: http://svn.apache.org/viewvc?rev=1704689&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58445 Fix off-by one error in calculation of valid characters in a cookie domain. Patch provided by Thorsten Ehlers. Mo

[Bug 58444] _jspInit() never called on JSP with custom super class

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58444 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1704688 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ test/org/apache/jasper/runtime/ test/webapp-3.0/bug5nnnn/ webapps/docs/

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 18:53:36 2015 New Revision: 1704688 URL: http://svn.apache.org/viewvc?rev=1704688&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58444 Can't use _jsp_init() for initialising the InstanceManager or ExpressionFactory because custom JSP base classes w

svn commit: r1704687 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/jasper/compiler/ test/org/apache/jasper/runtime/ test/webapp/bug5nnnn/ webapps/docs/

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 18:48:28 2015 New Revision: 1704687 URL: http://svn.apache.org/viewvc?rev=1704687&view=rev Log: Can't use _jsp_init() for initialising the InstanceManager or ExpressionFactory because custom JSP base classes will never call _jsp_init(). Refactor the init of these va

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2015-09-22 Thread Mark Thomas
On 22/09/2015 17:03, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. Full details are available at: > http://ci.apache.org/builders/tomcat-trunk/builds/331 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for t

buildbot failure in ASF Buildbot on tomcat-trunk

2015-09-22 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/331 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

svn commit: r1704658 - /tomcat/trunk/test/org/apache/jasper/runtime/TestCustomHttpJspPage.java

2015-09-22 Thread remm
Author: remm Date: Tue Sep 22 15:48:29 2015 New Revision: 1704658 URL: http://svn.apache.org/viewvc?rev=1704658&view=rev Log: Checkstyle (since I now run this lame thing ...) Modified: tomcat/trunk/test/org/apache/jasper/runtime/TestCustomHttpJspPage.java Modified: tomcat/trunk/test/org/apac

svn commit: r1704647 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java test/org/apache/jasper/runtime/TestCustomHttpJspPage.java test/org/apache/jasper/runtime/TesterHttpJspBase.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 14:59:34 2015 New Revision: 1704647 URL: http://svn.apache.org/viewvc?rev=1704647&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58444 Can't use _jsp_init() for initialising the InstanceManager or ExpressionFactory because custom JSP base classes w

[Bug 58444] _jspInit() never called on JSP with custom super class

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58444 --- Comment #1 from Mark Thomas --- 7.0.x, 8.0.x and trunk all suffer from the same problem. I have a fix for trunk that I'll commit shortly and then I'll work on back-porting the fix to 8.0.x and 7.0.x. -- You are receiving this mail becaus

svn commit: r1704623 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 13:37:17 2015 New Revision: 1704623 URL: http://svn.apache.org/viewvc?rev=1704623&view=rev Log: Fix indentation in generated Java code. Cosmetic issue only. No functional impact. Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Modified: to

buildbot success in ASF Buildbot on tomcat-8-trunk

2015-09-22 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/156 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranch

[Bug 58445] New: Valid domain characters in Rfc6265CookieProcessor are incomplete

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58445 Bug ID: 58445 Summary: Valid domain characters in Rfc6265CookieProcessor are incomplete Product: Tomcat 8 Version: trunk Hardware: PC OS: Linux

[Bug 57136] EL Parser escaping dollar sign not ${ or ${...}

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57136 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1704576 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/el/parser/ELParser.jjt java/org/apache/el/parser/ELParserTokenManager.java test/org/apache/el/TestELEvaluation.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 10:57:25 2015 New Revision: 1704576 URL: http://svn.apache.org/viewvc?rev=1704576&view=rev Log: Fix an edge case parser bug found while investigating BZ 57136 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/el/parser/EL

svn commit: r1704574 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/el/parser/ELParser.jjt java/org/apache/el/parser/ELParserTokenManager.java test/org/apache/el/TestELEvaluation.java

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 10:53:32 2015 New Revision: 1704574 URL: http://svn.apache.org/viewvc?rev=1704574&view=rev Log: Fix an edge case parser bug found while investigating BZ 57136 Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/el/parser/EL

svn commit: r1704572 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ test/org/apache/el/ test/org/apache/jasper/compiler/ test/webapp-3.0/ test/webapp-3.0/bug45nnn/ webapps/docs/

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 10:51:14 2015 New Revision: 1704572 URL: http://svn.apache.org/viewvc?rev=1704572&view=rev Log: Correct regression in previous fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57136 \$ should be an escape for $ in JSP. \${ should be an escape for ${ only in EL

buildbot failure in ASF Buildbot on tomcat-8-trunk

2015-09-22 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/155 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSch

[Bug 58444] New: _jspInit() never called on JSP with custom super class

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58444 Bug ID: 58444 Summary: _jspInit() never called on JSP with custom super class Product: Tomcat 7 Version: unspecified Hardware: All OS: All Status: NEW S

buildbot success in ASF Buildbot on tomcat-8-trunk

2015-09-22 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/154 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranch

[Bug 57136] EL Parser escaping dollar sign not ${ or ${...}

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57136 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #19 from Mark Thomas --

svn commit: r1704486 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/jasper/compiler/ test/org/apache/el/ test/org/apache/jasper/compiler/ test/webapp/ test/webapp/bug45nnn/ webapps/docs/

2015-09-22 Thread markt
Author: markt Date: Tue Sep 22 08:56:51 2015 New Revision: 1704486 URL: http://svn.apache.org/viewvc?rev=1704486&view=rev Log: Correct regression in previous fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57136 \$ should be an escape for $ in JSP. \${ should be an escape for ${ only in EL

[Bug 57265] Tomcat 8 hiden behind NGINX fails to send file when using NIO connector

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1704483 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/session/TestStandardSession.java

2015-09-22 Thread remm
Author: remm Date: Tue Sep 22 08:47:52 2015 New Revision: 1704483 URL: http://svn.apache.org/viewvc?rev=1704483&view=rev Log: Fix test compile. Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/session/TestStandardSession.java Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/s

svn commit: r1704482 - in /tomcat/tc7.0.x/trunk: java/org/apache/tomcat/util/net/NioChannel.java java/org/apache/tomcat/util/net/NioEndpoint.java java/org/apache/tomcat/util/net/SecureNioChannel.java

2015-09-22 Thread remm
Author: remm Date: Tue Sep 22 08:39:44 2015 New Revision: 1704482 URL: http://svn.apache.org/viewvc?rev=1704482&view=rev Log: Port additional improvement for 57799, to also remove the sendfile flag. It is used to ensure expand capability on the buffer, but expand can only happen in rare cases du

svn commit: r1704480 - in /tomcat/tc8.0.x/trunk: java/org/apache/tomcat/util/net/NioChannel.java java/org/apache/tomcat/util/net/NioEndpoint.java java/org/apache/tomcat/util/net/SecureNioChannel.java

2015-09-22 Thread remm
Author: remm Date: Tue Sep 22 08:37:24 2015 New Revision: 1704480 URL: http://svn.apache.org/viewvc?rev=1704480&view=rev Log: Port additional improvement for 57799, to also remove the sendfile flag. It is used to ensure expand capability on the buffer, but expand can only happen in rare cases du

svn commit: r1704477 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioChannel.java NioEndpoint.java SecureNioChannel.java

2015-09-22 Thread remm
Author: remm Date: Tue Sep 22 08:29:17 2015 New Revision: 1704477 URL: http://svn.apache.org/viewvc?rev=1704477&view=rev Log: As part of 57799, also remove the sendfile flag. It is used to ensure expand capability on the buffer, but expand can only happen in rare cases during handshake so the ch

[Bug 57265] Tomcat 8 hiden behind NGINX fails to send file when using NIO connector

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #17 from Mark Thomas --

[Bug 57265] Tomcat 8 hiden behind NGINX fails to send file when using NIO connector

2015-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265 --- Comment #16 from Remy Maucherat --- According to Jean-Frédéric testing, the exception disappeared for him (no ab errors, and performance is rather good with the poller count setting, so all ok apparently). However it would need a sync to be