Hi,
I uploaded new scan [1] (against Tomcat 8 trunk).
Regards,
Violeta
[1] https://scan.coverity.com/projects/apache-tomcat
https://bz.apache.org/bugzilla/show_bug.cgi?id=58414
--- Comment #1 from Mark Thomas ---
I've been able to reproduce this with some edits to the chat example that ships
with Tomcat. Working on a fix now.
--
You are receiving this mail because:
You are the assignee for the bug.
Author: markt
Date: Fri Sep 18 15:34:30 2015
New Revision: 1703890
URL: http://svn.apache.org/viewvc?rev=1703890&view=rev
Log:
Test case for bug 58414. This passes without any changes. Is there something
else going on?
Modified:
tomcat/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketCo
The Buildbot has detected a restored build on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/142
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
Yes, you are right. These are real. I didn't rerun the entire test suite
after fixing the obvious false positives.
Yilong
On Fri, Sep 18, 2015 at 7:58 AM, Mark Thomas wrote:
> On 18/09/2015 15:51, Yilong Li wrote:
> > Are you using the 1.7-SNAPSHOT downloaded recently? It's frequently
> > updat
On 18/09/2015 15:51, Yilong Li wrote:
> Are you using the 1.7-SNAPSHOT downloaded recently? It's frequently
> updated. If that's the case, then it's probably a real race and I have to
> take a closer look.
Downloaded at around 10.30 UTC today.
The races looked plausible. There was an obvious orde
Are you using the 1.7-SNAPSHOT downloaded recently? It's frequently
updated. If that's the case, then it's probably a real race and I have to
take a closer look.
Thanks,
Yilong
On Fri, Sep 18, 2015 at 7:43 AM, Mark Thomas wrote:
> On 18/09/2015 15:27, Yilong Li wrote:
> > Hi Mark,
> >
> > I thi
On 18/09/2015 15:27, Yilong Li wrote:
> Hi Mark,
>
> I think these are false positives because the completion handler is only
> called after the IO operation completes. There is an implicit
> happens-before order here. I have fixed these false positives recently.
> That's why I didn't report them
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/312
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedul
Hi Mark,
I think these are false positives because the completion handler is only
called after the IO operation completes. There is an implicit
happens-before order here. I have fixed these false positives recently.
That's why I didn't report them in BZ. Could you try the latest version of
RV-Pred
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/311
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSche
Author: markt
Date: Fri Sep 18 14:14:18 2015
New Revision: 1703866
URL: http://svn.apache.org/viewvc?rev=1703866&view=rev
Log:
Fix various data races reported by RV-Predict.
Mostly caused by completion handlers that execute in a new thread
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
Author: markt
Date: Fri Sep 18 14:12:41 2015
New Revision: 1703865
URL: http://svn.apache.org/viewvc?rev=1703865&view=rev
Log:
Fix various data races reported by RV-Predict.
Mostly caused by completion handlers that execute in a new thread
Modified:
tomcat/trunk/java/org/apache/tomcat/websock
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/310
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedul
Author: markt
Date: Fri Sep 18 14:06:40 2015
New Revision: 1703862
URL: http://svn.apache.org/viewvc?rev=1703862&view=rev
Log:
Fix another data race
Code clean-up
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.
Author: markt
Date: Fri Sep 18 14:04:34 2015
New Revision: 1703860
URL: http://svn.apache.org/viewvc?rev=1703860&view=rev
Log:
Fix another data race
Code clean-up
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
Modified:
tomcat/trunk/java/org/apache/catalin
Author: markt
Date: Fri Sep 18 13:52:41 2015
New Revision: 1703857
URL: http://svn.apache.org/viewvc?rev=1703857&view=rev
Log:
More thread-safety
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/transport/SenderState.java
Propchange:
Author: markt
Date: Fri Sep 18 13:52:01 2015
New Revision: 1703856
URL: http://svn.apache.org/viewvc?rev=1703856&view=rev
Log:
More thread-safety
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/transport/SenderState.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/transpor
Author: markt
Date: Fri Sep 18 13:49:05 2015
New Revision: 1703854
URL: http://svn.apache.org/viewvc?rev=1703854&view=rev
Log:
More thread-safety
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/io/ObjectReader.java
Propchange: tomcat
Author: markt
Date: Fri Sep 18 13:48:31 2015
New Revision: 1703853
URL: http://svn.apache.org/viewvc?rev=1703853&view=rev
Log:
More thread-safety
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/ObjectReader.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/ObjectReader
Author: markt
Date: Fri Sep 18 13:45:39 2015
New Revision: 1703852
URL: http://svn.apache.org/viewvc?rev=1703852&view=rev
Log:
More thread-safety
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
Propchange:
Author: markt
Date: Fri Sep 18 13:44:41 2015
New Revision: 1703851
URL: http://svn.apache.org/viewvc?rev=1703851&view=rev
Log:
More thread-safety
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membersh
Author: markt
Date: Fri Sep 18 13:42:21 2015
New Revision: 1703850
URL: http://svn.apache.org/viewvc?rev=1703850&view=rev
Log:
More thread-safety
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
Propchange:
Author: markt
Date: Fri Sep 18 13:41:34 2015
New Revision: 1703849
URL: http://svn.apache.org/viewvc?rev=1703849&view=rev
Log:
More thread-safety
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membersh
Author: markt
Date: Fri Sep 18 13:34:39 2015
New Revision: 1703844
URL: http://svn.apache.org/viewvc?rev=1703844&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58412
Ensure correct method and package names are logged.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tom
https://bz.apache.org/bugzilla/show_bug.cgi?id=58412
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
The Buildbot has detected a build exception on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/309
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: markt
Date: Fri Sep 18 13:27:36 2015
New Revision: 1703842
URL: http://svn.apache.org/viewvc?rev=1703842&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58412
Ensure correct method and package names are logged.
Modified:
tomcat/trunk/java/org/apache/juli/AsyncFileHand
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/308
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSche
The Buildbot has detected a build exception on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/139
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranc
Author: markt
Date: Fri Sep 18 12:47:26 2015
New Revision: 1703825
URL: http://svn.apache.org/viewvc?rev=1703825&view=rev
Log:
Fix test broken by fix for BZ 58373
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java
tomca
Author: markt
Date: Fri Sep 18 12:41:19 2015
New Revision: 1703821
URL: http://svn.apache.org/viewvc?rev=1703821&view=rev
Log:
Fix test broken by fix for BZ 58373
Modified:
tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
tomcat/trunk/test/org/apache/catalina/core/TestStandardCon
Author: markt
Date: Fri Sep 18 12:04:39 2015
New Revision: 1703815
URL: http://svn.apache.org/viewvc?rev=1703815&view=rev
Log:
Rename to avoid naming overlap in StandardContext
Modified:
tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java
Modified: tomcat/trunk/java/org/apache/cata
The Buildbot has detected a new failure on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/138
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
https://bz.apache.org/bugzilla/show_bug.cgi?id=58401
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=58395
--- Comment #2 from Mark Thomas ---
*** Bug 58401 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
-
Author: markt
Date: Fri Sep 18 09:04:59 2015
New Revision: 1703785
URL: http://svn.apache.org/viewvc?rev=1703785&view=rev
Log:
Fix checkstyle warning
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
Propcha
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/305
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedul
Author: markt
Date: Fri Sep 18 09:04:20 2015
New Revision: 1703784
URL: http://svn.apache.org/viewvc?rev=1703784&view=rev
Log:
Fix checkstyle warning
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/memb
https://bz.apache.org/bugzilla/show_bug.cgi?id=58400
Mark Thomas changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Status|NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=58396
--- Comment #2 from Mark Thomas ---
*** Bug 58400 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=58371
--- Comment #3 from Mark Thomas ---
*** Bug 58399 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=58399
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=58398
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Fri Sep 18 08:56:11 2015
New Revision: 1703778
URL: http://svn.apache.org/viewvc?rev=1703778&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58398
Simplify the code and fix a data race (listeners should have been volatile)
Modified:
tomcat/tc8.0.x/trunk/ja
/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.11-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20150918.ja
c/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.11-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20
Author: markt
Date: Fri Sep 18 08:51:59 2015
New Revision: 1703774
URL: http://svn.apache.org/viewvc?rev=1703774&view=rev
Log:
Clean-up. No functional change.
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/util/LifecycleSupport.java
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/ca
Author: markt
Date: Fri Sep 18 08:50:33 2015
New Revision: 1703772
URL: http://svn.apache.org/viewvc?rev=1703772&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58398
Simplify the code and fix a data race (listeners should have been volatile)
Modified:
tomcat/trunk/java/org/a
https://bz.apache.org/bugzilla/show_bug.cgi?id=58397
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Fri Sep 18 08:33:20 2015
New Revision: 1703765
URL: http://svn.apache.org/viewvc?rev=1703765&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58397
Remove unnecessary duplicated connected field and fix a rare data race on close.
Modified:
tomcat/tc8.0.x/tru
Author: markt
Date: Fri Sep 18 08:22:11 2015
New Revision: 1703763
URL: http://svn.apache.org/viewvc?rev=1703763&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58397
Remove unnecessary duplicated connected field and fix a rare data race on close.
Modified:
tomcat/trunk/java/
52 matches
Mail list logo
