Re: Usage of JreVendor class

2015-09-16 Thread Felix Schumacher
Am 16. September 2015 22:45:14 MESZ, schrieb "Rémy Maucherat" : >2015-09-16 22:34 GMT+02:00 Mark Thomas : > >> I'd expect tomcat-utils.jar >> >> No problem. In tomcat 7 that class resides in tomcat-coyote. Should I move it, too? Regards, Felix > >Rémy -

svn commit: r1703487 - in /tomcat/tc8.0.x/trunk: ./ build.xml

2015-09-16 Thread fschumacher
Author: fschumacher Date: Thu Sep 17 04:17:37 2015 New Revision: 1703487 URL: http://svn.apache.org/r1703487 Log: Move JreVendor class from tomcat-api.jar to tomcat-util.jar and exclude it from catalina-deployer.jar. This is a follow-up to r1702183. Merge r1702183 and r1703486 from /tomcat/trunk

svn commit: r1703486 - /tomcat/trunk/build.xml

2015-09-16 Thread fschumacher
Author: fschumacher Date: Thu Sep 17 04:13:04 2015 New Revision: 1703486 URL: http://svn.apache.org/r1703486 Log: Move JreVendor class from tomcat-api.jar to tomcat-util.jar and exclude it from catalina-deployer.jar. This is a follow-up to r1702183. Modified: tomcat/trunk/build.xml Modified

Re: Usage of JreVendor class

2015-09-16 Thread Rémy Maucherat
2015-09-16 22:34 GMT+02:00 Mark Thomas : > I'd expect tomcat-utils.jar > > No problem. Rémy

Re: Usage of JreVendor class

2015-09-16 Thread Mark Thomas
On 16/09/2015 21:27, Felix Schumacher wrote: > Am 15.09.2015 um 20:26 schrieb Felix Schumacher: >> Hi all, >> >> with change r1701668 JreVendor is used in catalina.Globals. But it >> seems to be missing in tomcat-utils.jar since .../util/compat/** is >> not on the included files list. >> >> I have

Re: Usage of JreVendor class

2015-09-16 Thread Felix Schumacher
Am 15.09.2015 um 20:26 schrieb Felix Schumacher: Hi all, with change r1701668 JreVendor is used in catalina.Globals. But it seems to be missing in tomcat-utils.jar since .../util/compat/** is not on the included files list. I have tried the patch diff --git a/build.xml b/build.xml index 346

svn commit: r1703458 - in /tomcat/trunk/java/org/apache/coyote/http2: Stream.java StreamProcessor.java

2015-09-16 Thread markt
Author: markt Date: Wed Sep 16 20:17:34 2015 New Revision: 1703458 URL: http://svn.apache.org/r1703458 Log: Refactor. It makes more sense to have all the init code in one place. Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java tomcat/trunk/java/org/apache/coyote/http2/Strea

Re: svn commit: r1703290 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java

2015-09-16 Thread Christopher Schultz
Mark, On 9/16/15 2:11 PM, Mark Thomas wrote: > On 16/09/2015 14:29, Christopher Schultz wrote: >> Mark, >> >> On 9/15/15 5:10 PM, ma...@apache.org wrote: >>> Author: markt >>> Date: Tue Sep 15 21:10:30 2015 >>> New Revision: 1703290 >>> >>> URL: http://svn.apache.org/r1703290 >>> Log: >>> Follow-u

svn commit: r1703443 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java

2015-09-16 Thread markt
Author: markt Date: Wed Sep 16 18:37:35 2015 New Revision: 1703443 URL: http://svn.apache.org/r1703443 Log: Simplify a little - use [].clone() Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/

Re: svn commit: r1703290 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java

2015-09-16 Thread Mark Thomas
On 16/09/2015 14:29, Christopher Schultz wrote: > Mark, > > On 9/15/15 5:10 PM, ma...@apache.org wrote: >> Author: markt >> Date: Tue Sep 15 21:10:30 2015 >> New Revision: 1703290 >> >> URL: http://svn.apache.org/r1703290 >> Log: >> Follow-up to r1703177. >> Ensure that members never contains an i

[Bug 57265] Tomcat 8 hiden behind NGINX fails to send file when using NIO connector

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265 --- Comment #13 from Remy Maucherat --- I think JF ran into this issue with his SSL testing, so he can test. IMO the most likely is a concurrent channel close (it would flip the sendFile flag), could a simple connection error cause that ? I do

Thomas MC GOWAN est absent

2015-09-16 Thread Thomas MC-GOWAN
Je serai absent(e) du 16/09/2015 au 24/09/2015. Je répondrai à votre message à mon retour de congés. En cas de besoin contacter le responsable du pôle serveurs d'applications Java : Eric Veignant ou la responsable du Groupe ESA : Laura Pascu

[Bug 57265] Tomcat 8 hiden behind NGINX fails to send file when using NIO connector

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265 --- Comment #12 from Steve Clark --- (In reply to Steve Clark from comment #11) > (In reply to Mark Thomas from comment #10) > > A few questions: > > - How easily can you reproduce this? > > - Do you have a test case you can share? > > - Are yo

[Bug 58411] CoyoteWriter throws StringIndexOutOfBoundsException when concurrently printing lines

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411 --- Comment #15 from Christopher Schultz --- (In reply to Remy Maucherat from comment #14) > "or using a local output stream for the response object within a thread." Re-reading that section several times, I think you're right that the servlet

[Bug 57265] Tomcat 8 hiden behind NGINX fails to send file when using NIO connector

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57265 --- Comment #11 from Steve Clark --- (In reply to Mark Thomas from comment #10) > A few questions: > - How easily can you reproduce this? > - Do you have a test case you can share? > - Are you are able to apply a patch to Tomcat to test a possi

buildbot success in ASF Buildbot on tomcat-8-trunk

2015-09-16 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/130 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranch

buildbot failure in ASF Buildbot on tomcat-8-trunk

2015-09-16 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/129 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSch

Re: RV-Predict bugs

2015-09-16 Thread David Jencks
I don’t understand your transformation. foo is certainly a class member. I thought bar was a local variable, thus inaccessible to anything outside the method and thread being executed. Your transformation makes them look like they are the same kind of thing? I’m also not quite sure where the

[Bug 58411] CoyoteWriter throws StringIndexOutOfBoundsException when concurrently printing lines

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411 --- Comment #14 from Remy Maucherat --- "or using a local output stream for the response object within a thread." -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 58411] CoyoteWriter throws StringIndexOutOfBoundsException when concurrently printing lines

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411 --- Comment #13 from Christopher Schultz --- (In reply to Remy Maucherat from comment #11) > The thread safety issue actually came up fairly often in the past. And this > doesn't make sense, why would it be partially synced ? > > The specifica

[Bug 58386] Data race on fields org.apache.catalina.tribes.io.ObjectReader.accessed & lastAccess

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58386 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1703409 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/tribes/io/ObjectReader.java webapps/docs/changelog.xml

2015-09-16 Thread markt
Author: markt Date: Wed Sep 16 13:41:03 2015 New Revision: 1703409 URL: http://svn.apache.org/r1703409 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58386 On the basis that access() and finish() are synchronized, extend synchronization to other methods that access same fields. Modified

[Bug 58411] CoyoteWriter throws StringIndexOutOfBoundsException when concurrently printing lines

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411 --- Comment #12 from Christopher Schultz --- (In reply to Steve Davids from comment #8) > PrintWriter doesn't say anything specifically about thread safety but the > Writer implies it with the constructor saying: > > http://docs.oracle.com/jav

svn commit: r1703408 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ObjectReader.java

2015-09-16 Thread markt
Author: markt Date: Wed Sep 16 13:37:35 2015 New Revision: 1703408 URL: http://svn.apache.org/r1703408 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58386 On the basis that access() and finish() are synchronized, extend synchronization to other methods that access same fields. Modified

Re: svn commit: r1703290 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java

2015-09-16 Thread Christopher Schultz
Mark, On 9/15/15 5:10 PM, ma...@apache.org wrote: > Author: markt > Date: Tue Sep 15 21:10:30 2015 > New Revision: 1703290 > > URL: http://svn.apache.org/r1703290 > Log: > Follow-up to r1703177. > Ensure that members never contains an intermediate result of the sorting > process. > > Modified:

svn commit: r1703400 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java

2015-09-16 Thread markt
Author: markt Date: Wed Sep 16 13:25:41 2015 New Revision: 1703400 URL: http://svn.apache.org/r1703400 Log: Remove duplicate code. A call to reader.access() calls setLastAccess() Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java Modified: tomcat/t

svn commit: r1703398 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsWebSocketContainer.java webapps/docs/changelog.xml

2015-09-16 Thread markt
Author: markt Date: Wed Sep 16 13:21:22 2015 New Revision: 1703398 URL: http://svn.apache.org/r1703398 Log: Revert fix for BZ 58384 since it is now believed to be a false positive Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsWe

Re: RV-Predict bugs

2015-09-16 Thread Mark Thomas
On 16/09/2015 14:01, Caldarale, Charles R wrote: >> From: Mark Thomas [mailto:ma...@apache.org] >> Subject: Re: RV-Predict bugs > >> To re-cap. The assertion is that >> === >> String foo; >> doSomething() { >> if (foo == null) { >> foo = calculateNewValue(); >> } >> return foo; >> } >>

RE: RV-Predict bugs

2015-09-16 Thread Caldarale, Charles R
> From: Mark Thomas [mailto:ma...@apache.org] > Subject: Re: RV-Predict bugs > To re-cap. The assertion is that > === > String foo; > doSomething() { > if (foo == null) { > foo = calculateNewValue(); > } > return foo; > } > === > can be transformed (by the complier?) to > === > String f

Re: svn commit: r1703290 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java

2015-09-16 Thread Felix Schumacher
Am 16. September 2015 10:22:31 MESZ, schrieb Mark Thomas : >On 16/09/2015 05:41, Felix Schumacher wrote: >> >> >> Am 15. September 2015 23:10:30 MESZ, schrieb ma...@apache.org: >>> Author: markt >>> Date: Tue Sep 15 21:10:30 2015 >>> New Revision: 1703290 >>> >>> URL: http://svn.apache.org/r170

buildbot success in ASF Buildbot on tomcat-8-trunk

2015-09-16 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/128 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranch

[Bug 58411] CoyoteWriter throws StringIndexOutOfBoundsException when concurrently printing lines

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411 --- Comment #11 from Remy Maucherat --- The thread safety issue actually came up fairly often in the past. And this doesn't make sense, why would it be partially synced ? The specification is perfectly explicit about it (2.3.3.4). "Other than

[Bug 58411] CoyoteWriter throws StringIndexOutOfBoundsException when concurrently printing lines

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411 --- Comment #10 from Mark Thomas --- The spec talks a lot about the request and response not being thread-safe. It implies objects obtained from them are also not thread-safe but it isn't explicit. You end up in a position where it is the impli

svn commit: r1703368 - /tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/Membership.java

2015-09-16 Thread markt
Author: markt Date: Wed Sep 16 08:58:53 2015 New Revision: 1703368 URL: http://svn.apache.org/r1703368 Log: Follow-up to r1703291 Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/membership/Membership.java Modified: tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/members

Re: RV-Predict bugs

2015-09-16 Thread Mark Thomas
On 16/09/2015 06:38, David Jencks wrote: > At this point I tend to agree with Ylong and Jeremy. I’m very far > from being an expert but I thought 14.2 meant that the result of > execution of a single thread had to be the same as if it executed the > given instructions in the order supplied. I did

buildbot failure in ASF Buildbot on tomcat-trunk

2015-09-16 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/288 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

svn commit: r1703358 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java

2015-09-16 Thread markt
Author: markt Date: Wed Sep 16 08:24:52 2015 New Revision: 1703358 URL: http://svn.apache.org/r1703358 Log: Follow-up to r1703177 Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.ja

Re: svn commit: r1703290 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java

2015-09-16 Thread Mark Thomas
On 16/09/2015 05:41, Felix Schumacher wrote: > > > Am 15. September 2015 23:10:30 MESZ, schrieb ma...@apache.org: >> Author: markt >> Date: Tue Sep 15 21:10:30 2015 >> New Revision: 1703290 >> >> URL: http://svn.apache.org/r1703290 >> Log: >> Follow-up to r1703177. >> Ensure that members never co

Re: svn commit: r1703194 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2015-09-16 Thread Mark Thomas
On 15/09/2015 21:42, Rémy Maucherat wrote: > 2015-09-15 22:28 GMT+02:00 Mark Thomas : > >>> Sounds like a false positive to me. There are numerous implicit >> synchronizations in the above sequence, so the volatile is not particularly >> useful (but it's not terribly expensive either). >> >> Than

svn commit: r1703348 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java

2015-09-16 Thread remm
Author: remm Date: Wed Sep 16 08:10:37 2015 New Revision: 1703348 URL: http://svn.apache.org/r1703348 Log: Checkstyle nonsense. Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/Membership.java

Re: RV-Predict bugs

2015-09-16 Thread Mark Thomas
On 16/09/2015 02:49, Caldarale, Charles R wrote: >> From: Mark Thomas [mailto:ma...@apache.org] >> Subject: Re: RV-Predict bugs > >> My expectation is that once T2 has seen the updated value (originated >> from another thread) all subsequent reads in T2 of the same field are >> going to see the s

[Bug 58411] CoyoteWriter throws StringIndexOutOfBoundsException when concurrently printing lines

2015-09-16 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=58411 --- Comment #9 from Remy Maucherat --- Servlet 3.1 still says that Servlet objects are not thread safe. NIO2 does not allow concurrency either, so there's no reason to sync this stream but not any other one. -- You are receiving this mail bec