Hi folks! Great to see this thread picking up steam.
On Jun 10, 2015, at 6:12 AM, Mark Thomas wrote:
> On 10/06/2015 13:34, Fjodor Vershinin wrote:
>
>> And what about code backward compatibility for Geronimo,
>> should code ported back, or new Geronimo release can use our
>> implementation?
>
https://bz.apache.org/bugzilla/show_bug.cgi?id=58010
Joshua C Rebelo changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|INVALID
Author: markt
Date: Wed Jun 10 21:56:27 2015
New Revision: 1684771
URL: http://svn.apache.org/r1684771
Log:
Add a test for maxConcurrentStreams
Also expands capabilities of Http2TestBase to include
- large requests
- setting maxConcurrentStreams
Modified:
tomcat/trunk/test/org/apache/coyote/h
Author: markt
Date: Wed Jun 10 21:54:24 2015
New Revision: 1684770
URL: http://svn.apache.org/r1684770
Log:
Sync and notify on the correct object (the Stream) for stream flow control.
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Stream.java
Modified: tomcat/trunk/java/org/apache/coyot
Author: markt
Date: Wed Jun 10 21:31:08 2015
New Revision: 1684769
URL: http://svn.apache.org/r1684769
Log:
Testing HTTP/2 5.1.2
Make maxConcurrentStream configurable so it can be tested
I have a test for maxConcurrentStreams that works but it appears to be
triggering some flow control bugs I nee
Author: markt
Date: Wed Jun 10 20:02:11 2015
New Revision: 1684757
URL: http://svn.apache.org/r1684757
Log:
Add a test for closure of idle streams and fix the bugs it identified.
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/trunk/test/org/apache/coyo
Author: markt
Date: Wed Jun 10 19:55:35 2015
New Revision: 1684754
URL: http://svn.apache.org/r1684754
Log:
Another util method
Modified:
tomcat/trunk/java/org/apache/coyote/http2/ByteUtil.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/ByteUtil.java
URL:
http://svn.apache.org/view
Author: markt
Date: Wed Jun 10 19:55:17 2015
New Revision: 1684753
URL: http://svn.apache.org/r1684753
Log:
Use the method provided for changing state.
Modified:
tomcat/trunk/java/org/apache/coyote/http2/StreamStateMachine.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/StreamStateM
Author: markt
Date: Wed Jun 10 19:43:10 2015
New Revision: 1684752
URL: http://svn.apache.org/r1684752
Log:
Add the plumbing required for HTTP/2 5.1.1 and 5.1.2
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/trunk/java/org/apache/coyote/http2/LocalStri
Author: markt
Date: Wed Jun 10 19:41:31 2015
New Revision: 1684751
URL: http://svn.apache.org/r1684751
Log:
Add new jaspic-api.jar to jarsToSkip
Modified:
tomcat/trunk/conf/catalina.properties
Modified: tomcat/trunk/conf/catalina.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/con
Hi,
On Wed, Jun 10, 2015 at 3:28 PM, markt [via Tomcat] <
ml-node+s10n5035887...@n6.nabble.com> wrote:
> I don't really understand what the requirement is here. Can you expand /
> point me to the part of the spec?
>
It's simply that from within a SAM you can forward/include to a Servlet
using a
Hi,
On Wed, Jun 10, 2015 at 3:09 PM, markt [via Tomcat] <
ml-node+s10n5035886...@n6.nabble.com> wrote:
> A Valve is certainly a likely candidate since the current Authenticator
> implementations are all Valves. It really depends on whether access is
> required to Tomcat's internals. If you need a
https://bz.apache.org/bugzilla/show_bug.cgi?id=58010
--- Comment #2 from Joshua C Rebelo ---
I have tried that flag, but the javap -l command output for jsp class files
doesn't have the LineNumberTable and LocalVariableTable attributes details.
My build.xml has this entry.
Author: markt
Date: Wed Jun 10 14:23:48 2015
New Revision: 1684682
URL: http://svn.apache.org/r1684682
Log:
HTTP/2 5.1.2 requires active streams to be counted. Add an active flag
(currently unused) to Stream.
Try a different format for State enum constructors. Uses more space but I think
it is c
On 10/06/2015 14:04, Arjan Tijms wrote:
>> We are implementing JASPIC 1.1, and there will be quite a
>> lot changes anyway.
>
>
> JASPIC 1.1 itself was not a huge change over JASPIC 1.0, but it did put
> some extra requirements in place like the ability to forward and include
> resources using t
On 10/06/2015 13:34, Fjodor Vershinin wrote:
> Hi, guys!
"guys" can be taken as referring to men only. Something like the gender
neutral "all" would be more inclusive.
> This week goal is to replace current valve based authentication with JASPIC
> based mechanism. It is what I am currently workin
Hi,
On Wed, Jun 10, 2015 at 2:31 PM, Fjodor Vershinin [via Tomcat] <
ml-node+s10n5035882...@n6.nabble.com> wrote:
> Hi, guys!
> This week goal is to replace current valve based authentication with
> JASPIC
> based mechanism. It is what I am currently working on.
>
Nice ;)
> From my research G
2015-06-10 14:45 GMT+02:00 :
> Author: remm
> Date: Wed Jun 10 12:45:26 2015
> New Revision: 1684663
>
> URL: http://svn.apache.org/r1684663
> Log:
> Direct buffers need explicit cleanup to ensure complete reliability
> without OOMs.
>
> Rationale:
- The NIO JVM code does it, so it's probably good
Author: remm
Date: Wed Jun 10 12:45:26 2015
New Revision: 1684663
URL: http://svn.apache.org/r1684663
Log:
Direct buffers need explicit cleanup to ensure complete reliability without
OOMs.
Modified:
tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java
tomcat/trunk/java/o
Hi, guys!
This week goal is to replace current valve based authentication with JASPIC
based mechanism. It is what I am currently working on.
>From my research Geronimo's implementation is also based on tomcat's
valves, and it's pretty straightforward how to integrate SecurityValve into
Tomcat's cod
Author: markt
Date: Wed Jun 10 10:21:52 2015
New Revision: 1684633
URL: http://svn.apache.org/r1684633
Log:
Add JASPIC API JAR to the build
Based on a patch by fjodorver
This closes #21
Added:
tomcat/trunk/res/META-INF/jaspic-api.jar.manifest (with props)
Modified:
tomcat/trunk/build.xm
Github user markt-asf closed the pull request at:
https://github.com/apache/tomcat/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Author: markt
Date: Wed Jun 10 09:37:23 2015
New Revision: 1684619
URL: http://svn.apache.org/r1684619
Log:
Line length
Modified:
tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java
Modified:
tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java
Author: markt
Date: Wed Jun 10 09:34:22 2015
New Revision: 1684617
URL: http://svn.apache.org/r1684617
Log:
Add missing constants in JASPIC API to align with reference implementation.
Patch provided by fjodorver
Modified:
tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.
Author: markt
Date: Wed Jun 10 09:29:59 2015
New Revision: 1684616
URL: http://svn.apache.org/r1684616
Log:
Remove runtime exception declarations from JASPIC API to align with reference
implementation.
Patch provided by fjodorver
Modified:
tomcat/trunk/java/javax/security/auth/message/Messag
Author: markt
Date: Wed Jun 10 09:25:25 2015
New Revision: 1684613
URL: http://svn.apache.org/r1684613
Log:
Re-order methods in JASPIC API classes to align with order used in reference
implementation make it easier to check for differences using javap
Patch provided by fjodorver
Modified:
to
On 09/06/2015 11:31, Rémy Maucherat wrote:
> 2015-06-09 11:53 GMT+02:00 Konstantin Kolinko :
>
>> 2015-06-08 15:37 GMT+03:00 Mark Thomas :
>>> All,
>>>
>>> I'm not particularly happy with the current error handling (based around
>>> Http2Exception) and as I work my way through the spec in detail I
Author: markt
Date: Wed Jun 10 08:13:30 2015
New Revision: 1684599
URL: http://svn.apache.org/r1684599
Log:
Rename to make clear these are exceptions not errors
Added:
tomcat/trunk/java/org/apache/coyote/http2/ConnectionException.java
- copied, changed from r1684595,
tomcat/trunk/java/
Author: kfujino
Date: Wed Jun 10 08:13:00 2015
New Revision: 1684598
URL: http://svn.apache.org/r1684598
Log:
Fix indent. - no functional change.
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catal
Author: kfujino
Date: Wed Jun 10 08:12:29 2015
New Revision: 1684597
URL: http://svn.apache.org/r1684597
Log:
Fix indent. - no functional change.
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/catal
Author: kfujino
Date: Wed Jun 10 08:11:43 2015
New Revision: 1684596
URL: http://svn.apache.org/r1684596
Log:
Fix indent. - no functional change.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/tipis/
Author: markt
Date: Wed Jun 10 08:11:13 2015
New Revision: 1684595
URL: http://svn.apache.org/r1684595
Log:
Rename to avoid clash with java.lang.Error
Added:
tomcat/trunk/java/org/apache/coyote/http2/Http2Error.java
- copied, changed from r1684594,
tomcat/trunk/java/org/apache/coyote/h
Author: kfujino
Date: Wed Jun 10 08:06:09 2015
New Revision: 1684593
URL: http://svn.apache.org/r1684593
Log:
Do not set the nodes that failed to replication to the backup nodes.
Ensure that the nodes that the data has been successfully replicated are set to
the backup node.
Modified:
tomca
Author: kfujino
Date: Wed Jun 10 08:04:42 2015
New Revision: 1684591
URL: http://svn.apache.org/r1684591
Log:
Do not set the nodes that failed to replication to the backup nodes.
Ensure that the nodes that the data has been successfully replicated are set to
the backup node.
Modified:
tomca
https://bz.apache.org/bugzilla/show_bug.cgi?id=58015
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Wed Jun 10 08:00:18 2015
New Revision: 1684589
URL: http://svn.apache.org/r1684589
Log:
Delegate and filter() should be used consistently everywhere delegation is
possible to ensure consistent behaviour of the class loader.
Modified:
tomcat/tc8.0.x/trunk/ (props changed
Author: markt
Date: Wed Jun 10 07:54:37 2015
New Revision: 1684587
URL: http://svn.apache.org/r1684587
Log:
Add javax.websocket.* to the classes for which the web application class loader
will always delegate first (so the classes provided by Tomcat cannot be
overridden).
Modified:
tomcat/t
Author: kfujino
Date: Wed Jun 10 07:52:30 2015
New Revision: 1684586
URL: http://svn.apache.org/r1684586
Log:
Skip a sending data to the proxy nodes if failed to a sending data to the
backup nodes.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java
Modified:
Author: markt
Date: Wed Jun 10 07:51:52 2015
New Revision: 1684585
URL: http://svn.apache.org/r1684585
Log:
Fix a bug that prevented filter() from working correctly (it only returned true
for classes in sub-packages of the listed packaged, but not classes located in
the packages themselves)
Mod
Author: kfujino
Date: Wed Jun 10 07:49:29 2015
New Revision: 1684584
URL: http://svn.apache.org/r1684584
Log:
Do not set the nodes that failed to replication to the backup nodes.
Ensure that the nodes that the data has been successfully replicated are set to
the backup node.
Modified:
tomcat
Author: markt
Date: Wed Jun 10 07:47:38 2015
New Revision: 1684583
URL: http://svn.apache.org/r1684583
Log:
The validate() method is unnecessary.
Test 0.2 in loadClass(String, boolean) already ensures that Java SE classes can
not be overridden and does so in a way that doesn't require a list of p
Github user fjodorver commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-110630412
2,4,5) I use ant validate for checkstyle validation. Is it enough?
3) It looks like we need to rewrite AuthConfigFactory anyway (for example,
possible memory leaks,
42 matches
Mail list logo
