https://bz.apache.org/bugzilla/show_bug.cgi?id=57863
Bug ID: 57863
Summary: Can't get the matched pattern in RewriteValve
Product: Tomcat 8
Version: trunk
Hardware: All
OS: All
Status: NEW
Severity: normal
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc8.0.x-test-apr has an issue affecting its community
integration.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57830
--- Comment #7 from Bill Barker ---
(In reply to Christopher Schultz from comment #6)
> (In reply to Bill Barker from comment #5)
> > Ok, so I miss read the spec. After reading the spec again, I have lost all
> > interest in this issue.
>
> I
The Buildbot has detected a build exception on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/224
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranc
The Buildbot has detected a restored build on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/223
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
The Buildbot has detected a restored build on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/636
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
Author: markt
Date: Mon Apr 27 23:03:37 2015
New Revision: 1676395
URL: http://svn.apache.org/r1676395
Log:
Add some comments to clarify behaviour.
Review by schultz re object allocation
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/el/parser/AstVa
Author: markt
Date: Mon Apr 27 23:01:47 2015
New Revision: 1676394
URL: http://svn.apache.org/r1676394
Log:
Add some comments to clarify behaviour.
Review by schultz re object allocation
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/el/parser/AstVa
Author: markt
Date: Mon Apr 27 23:01:16 2015
New Revision: 1676393
URL: http://svn.apache.org/r1676393
Log:
Add some comments to clarify behaviour.
Review by schultz re object allocation
Modified:
tomcat/trunk/java/org/apache/el/parser/AstValue.java
tomcat/trunk/test/org/apache/el/TestMet
On 27/04/2015 23:10, Christopher Schultz wrote:
> Konstantin,
>
> On 4/27/15 6:06 PM, Konstantin Kolinko wrote:
>> 2015-04-28 0:43 GMT+03:00 :
>>> Author: markt
>>> Date: Mon Apr 27 21:43:22 2015
>>> New Revision: 1676381
>>>
>>> URL: http://svn.apache.org/r1676381
>>> Log:
>>> Further fix for ht
The Buildbot has detected a build exception on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/635
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranc
Konstantin,
On 4/27/15 6:06 PM, Konstantin Kolinko wrote:
> 2015-04-28 0:43 GMT+03:00 :
>> Author: markt
>> Date: Mon Apr 27 21:43:22 2015
>> New Revision: 1676381
>>
>> URL: http://svn.apache.org/r1676381
>> Log:
>> Further fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
>> Follow-u
2015-04-28 0:43 GMT+03:00 :
> Author: markt
> Date: Mon Apr 27 21:43:22 2015
> New Revision: 1676381
>
> URL: http://svn.apache.org/r1676381
> Log:
> Further fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
> Follow-up to r1676231
> Handle case where null is passed to a method with a s
Author: markt
Date: Mon Apr 27 21:59:42 2015
New Revision: 1676386
URL: http://svn.apache.org/r1676386
Log:
Fix IDE warning
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/filters/TestExpiresFilter.java
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/filters/TestExpiresFilte
Author: markt
Date: Mon Apr 27 21:51:54 2015
New Revision: 1676385
URL: http://svn.apache.org/r1676385
Log:
Follow-up to r1676372
Slightly different set-up needed to unit test in 7.0.x
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java
Modified:
tomcat/
https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
Mark Thomas changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
Author: markt
Date: Mon Apr 27 21:45:08 2015
New Revision: 1676383
URL: http://svn.apache.org/r1676383
Log:
Further fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
Follow-up to r1676234
Handle case where null is passed to a method with a single varargs parameter
Modified:
tomcat/
Author: markt
Date: Mon Apr 27 21:44:23 2015
New Revision: 1676382
URL: http://svn.apache.org/r1676382
Log:
Further fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
Follow-up to r1676232
Handle case where null is passed to a method with a single varargs parameter
Modified:
tomcat/
Author: markt
Date: Mon Apr 27 21:43:22 2015
New Revision: 1676381
URL: http://svn.apache.org/r1676381
Log:
Further fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
Follow-up to r1676231
Handle case where null is passed to a method with a single varargs parameter
Modified:
tomcat/
The Buildbot has detected a new failure on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/633
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
--- Comment #8 from Mark Thomas ---
The spec is unclear exactly what the required behaviour here is so (ignoring
Konstantin's issue one above) I'm happy that this is an improvement. IAE with a
decent error message is much better than AIOOB or N
https://bz.apache.org/bugzilla/show_bug.cgi?id=57856
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
The Buildbot has detected a build exception on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/222
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranc
Author: markt
Date: Mon Apr 27 20:31:54 2015
New Revision: 1676372
URL: http://svn.apache.org/r1676372
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57856
Ensure that any scheme/port changes implemented by the RemoteIpFilter also
affect HttpServletResponse.sendRedirect()
Modified:
Author: markt
Date: Mon Apr 27 20:29:58 2015
New Revision: 1676371
URL: http://svn.apache.org/r1676371
Log:
Implement a few more methods (will be required by some new tests for the
RemoteIpFilter)
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/cata
Author: markt
Date: Mon Apr 27 20:29:07 2015
New Revision: 1676370
URL: http://svn.apache.org/r1676370
Log:
Use getter to access coyoteResponse to make it easier to sub-class.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Respons
Author: markt
Date: Mon Apr 27 20:26:55 2015
New Revision: 1676369
URL: http://svn.apache.org/r1676369
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57856
Ensure that any scheme/port changes implemented by the RemoteIpFilter also
affect HttpServletResponse.sendRedirect()
Modified:
Author: markt
Date: Mon Apr 27 20:24:08 2015
New Revision: 1676368
URL: http://svn.apache.org/r1676368
Log:
Implement a few more methods (will be required by some new tests for the
RemoteIpFilter)
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/test/org/apache/cata
Author: markt
Date: Mon Apr 27 20:23:37 2015
New Revision: 1676367
URL: http://svn.apache.org/r1676367
Log:
Use getter to access coyoteResponse to make it easier to sub-class.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/Respons
The Buildbot has detected a build exception on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1154
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSc
Author: markt
Date: Mon Apr 27 20:13:05 2015
New Revision: 1676364
URL: http://svn.apache.org/r1676364
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57856
Ensure that any scheme/port changes implemented by the RemoteIpFilter also
affect HttpServletResponse.sendRedirect()
Modified:
https://bz.apache.org/bugzilla/show_bug.cgi?id=57823
--- Comment #3 from Christopher Schultz ---
(In reply to gregh from comment #2)
> This was the entry in the /etc/rc.d/init.d script that I have used for many
> years, 5,6,7. This only happens in 8.
>
> CLASSPATH="$CLASSPATH":"$CATALINA_HOME"/
https://bz.apache.org/bugzilla/show_bug.cgi?id=57830
--- Comment #6 from Christopher Schultz ---
(In reply to Bill Barker from comment #5)
> Ok, so I miss read the spec. After reading the spec again, I have lost all
> interest in this issue.
I'm curious: does this simply not interest you, or do
https://bz.apache.org/bugzilla/show_bug.cgi?id=57556
--- Comment #7 from Chuck Caldarale ---
(In reply to Christopher Schultz from comment #6)
> But my position is that this method should unconditionally return null.
+1 on that. Anyone using this method for anything other than debugging is
fool
https://bz.apache.org/bugzilla/show_bug.cgi?id=57556
--- Comment #6 from Christopher Schultz ---
(In reply to Matt from comment #5)
> Tomcat 6 only returned a path with an ending slash when asking for "/", any
> other directory path does not end in a slash. So this is actually breaking
> backward
https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
--- Comment #7 from Christian Strebel ---
(In reply to Konstantin Kolinko from comment #5)
> I think MethodExpression.invoke() shall wrap IllegalArgumentException into
> an ELException.
>
>
> It is documented that java.lang.reflect.Method.inv
https://bz.apache.org/bugzilla/show_bug.cgi?id=57856
Mark Thomas changed:
What|Removed |Added
OS||All
--- Comment #1 from Mark Thomas ---
https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
--- Comment #6 from Konstantin Kolinko ---
(In reply to Mark Thomas from comment #4)
> (In reply to Konstantin Kolinko from comment #3)
> > Reviewing r1676234
> >
> > 2) It looks that the message in AstValue.java prints "The method [{0}] was
>
Author: markt
Date: Mon Apr 27 13:11:41 2015
New Revision: 1676251
URL: http://svn.apache.org/r1676251
Log:
Implement a few more methods (will be required by some new tests for the
RemoteIpFilter)
Modified:
tomcat/trunk/test/org/apache/catalina/connector/TesterResponse.java
Modified: tomcat
Author: markt
Date: Mon Apr 27 13:10:36 2015
New Revision: 1676250
URL: http://svn.apache.org/r1676250
Log:
Use getter to access coyoteResponse to make it easier to sub-class.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Response.java
Modified: tomcat/trunk/java/org/apache/catal
https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
--- Comment #5 from Konstantin Kolinko ---
I think MethodExpression.invoke() shall wrap IllegalArgumentException into an
ELException.
It is documented that java.lang.reflect.Method.invoke() throws
IllegalArgumentException when "if the number
https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
--- Comment #4 from Mark Thomas ---
(In reply to Konstantin Kolinko from comment #3)
> Reviewing r1676234
>
> Apparently "null" src is equivalent to "no argument" or a zero-length array.
> [1]
>
> 1) When null is passed it should support both
The Buildbot has detected a restored build on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/632
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
Konstantin Kolinko changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://bz.apache.org/bugzilla/show_bug.cgi?id=57859
Mark Thomas changed:
What|Removed |Added
Resolution|--- |INVALID
OS|
https://bz.apache.org/bugzilla/show_bug.cgi?id=57860
Mark Thomas changed:
What|Removed |Added
Resolution|--- |INVALID
Status|NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=57860
Bug ID: 57860
Summary: use mina with apr/tomcat native and it crashs
Product: Tomcat Native
Version: 1.1.33
Hardware: PC
OS: Linux
Status: NEW
Severity:
https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Author: markt
Date: Mon Apr 27 09:51:04 2015
New Revision: 1676234
URL: http://svn.apache.org/r1676234
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
Explicitly handle the case where a MethodExpression is invoked with null or the
wrong number of parameters. Rather than failing with
Author: markt
Date: Mon Apr 27 09:49:23 2015
New Revision: 1676232
URL: http://svn.apache.org/r1676232
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
Explicitly handle the case where a MethodExpression is invoked with null or the
wrong number of parameters. Rather than failing with
Author: markt
Date: Mon Apr 27 09:45:12 2015
New Revision: 1676231
URL: http://svn.apache.org/r1676231
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
Explicitly handle the case where a MethodExpression is invoked with null or the
wrong number of parameters. Rather than failing with
https://bz.apache.org/bugzilla/show_bug.cgi?id=57855
--- Comment #1 from Mark Thomas ---
I've looked through the EL specification and I don't see the expected behaviour
defined for any of these cases.
I don't think MethodNotFoundException is the right exception in this case since
the method has
52 matches
Mail list logo
