[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. Th

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community integration

Re: Performance change

2015-01-09 22:44 GMT+01:00 Mark Thomas : > > I made a mistake, which also made me think that the NIO connector didn't > > suffer from the NPE. In the end, there's no significant improvement > there. > > That matches my results. NIO is about the same in 8.0.x and 9.0.x for me. > > >> The other thin

Re: Performance change

On 09/01/2015 19:13, Rémy Maucherat wrote: > 2015-01-09 18:45 GMT+01:00 Mark Thomas : > >> One reason (once all the refactoring is complete) might be WebSocket >> since the use of CompletionHandlers in WebSocket and NIO2 may allow for >> some efficiencies that just aren't possible with NIO or APR.

svn commit: r1650665 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Author: markt Date: Fri Jan 9 21:01:27 2015 New Revision: 1650665 URL: http://svn.apache.org/r1650665 Log: Trivial optimisation for blocking writes. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.j

svn commit: r1650662 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Author: markt Date: Fri Jan 9 20:56:09 2015 New Revision: 1650662 URL: http://svn.apache.org/r1650662 Log: Trivial optimisation for non-blocking writes. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoi

svn commit: r1650660 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Author: markt Date: Fri Jan 9 20:53:21 2015 New Revision: 1650660 URL: http://svn.apache.org/r1650660 Log: When doing a blocking write, write directly rather than via flush() since it is more efficient. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomc

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

it/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150109-native-src.tar.gz -Dexampl

svn commit: r1650639 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Author: markt Date: Fri Jan 9 20:08:10 2015 New Revision: 1650639 URL: http://svn.apache.org/r1650639 Log: Code review looking for possible causes of performance drop in NIO2. The completion handler will clear the socketWriteBuffer so no need to do it again in flush. This restores a few % of per

Re: Performance change

2015-01-09 18:45 GMT+01:00 Mark Thomas : > One reason (once all the refactoring is complete) might be WebSocket > since the use of CompletionHandlers in WebSocket and NIO2 may allow for > some efficiencies that just aren't possible with NIO or APR. > We'll see. > > I'll add looking at this to my

Re: ReplicatedContext and tomcat junit tests

On 09/01/2015 12:58, Felix Schumacher wrote: > Hi all, > > while trying to setup a unit test for bug 57425 I stumbled about two > things. > > First the Tomcat class always uses a StandardContext even if I set > another name for a context class on StandardHost. > > If I change addWebapp to use th

svn commit: r1650627 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java

Author: markt Date: Fri Jan 9 18:42:52 2015 New Revision: 1650627 URL: http://svn.apache.org/r1650627 Log: Add a warning based on what appears to have been the fix for an APR crash after the recent refactoring. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java M

svn commit: r1650623 - in /tomcat/trunk/java/org/apache/coyote: ajp/AjpProcessor.java http11/upgrade/UpgradeServletOutputStream.java

Author: markt Date: Fri Jan 9 18:33:08 2015 New Revision: 1650623 URL: http://svn.apache.org/r1650623 Log: Further review of socketWrapper.isReadyForWrite() Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeServ

[VOTE] Release Apache Tomcat 8.0.17

The proposed Apache Tomcat 8.0.17 release is now available for voting. The changes since 8.0.16 are: - Fix a RequestListener regression - Fix a bug in NIO2 with sending 100-Continue responses The main changes since 8.0.15 are: - Correct a regression in annotation scanning introduced in 8.0.15 - T

Re: Performance change

On 09/01/2015 17:25, Rémy Maucherat wrote: > Hi, > > Following the refactoring, performance is significantly down for NIO2, but > improved for NIO1. > > With my ab test on tomcat.gif, logging disabled, this does (Tomcat 8 vs > trunk): > NIO1: 50k -> 60k up 20% wow > NIO2: 65k -> 57k down 15% :

svn commit: r1650606 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

Author: remm Date: Fri Jan 9 17:31:41 2015 New Revision: 1650606 URL: http://svn.apache.org/r1650606 Log: Port fix from NIO2. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java URL: http://svn.apac

Performance change

Hi, Following the refactoring, performance is significantly down for NIO2, but improved for NIO1. With my ab test on tomcat.gif, logging disabled, this does (Tomcat 8 vs trunk): NIO1: 50k -> 60k NIO2: 65k -> 57k IMO the difference is significant, so this is a real regression. I didn't really see

svn commit: r1650587 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

Author: markt Date: Fri Jan 9 16:18:55 2015 New Revision: 1650587 URL: http://svn.apache.org/r1650587 Log: Prep for the next release Modified: tomcat/tc8.0.x/trunk/build.properties.default tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default tomcat/tc8.0.x/trunk/webapps/docs/changel

svn commit: r1650582 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_17: ./ build.properties.default

Author: markt Date: Fri Jan 9 15:56:27 2015 New Revision: 1650582 URL: http://svn.apache.org/r1650582 Log: Tag 8.0.17 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_17/ (props changed) - copied from r1650581, tomcat/tc8.0.x/trunk/ Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_17/build.properti

svn commit: r1650571 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java Nio2Endpoint.java SocketWrapperBase.java

Author: markt Date: Fri Jan 9 15:43:07 2015 New Revision: 1650571 URL: http://svn.apache.org/r1650571 Log: Fix failures on Windows Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java tomcat/trunk/java/

Re: svn commit: r1650535 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

On 09/01/2015 14:04, r...@apache.org wrote: > Author: remm > Date: Fri Jan 9 14:04:43 2015 > New Revision: 1650535 > > URL: http://svn.apache.org/r1650535 > Log: > Fix NPE that was swallowed. Thanks. That would certainly explain running out of connections. Mark > > Modified: > tomcat/tru

Re: svn commit: r1650535 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

On 09/01/2015 14:04, r...@apache.org wrote: > Author: remm > Date: Fri Jan 9 14:04:43 2015 > New Revision: 1650535 > > URL: http://svn.apache.org/r1650535 > Log: > Fix NPE that was swallowed. Thanks. That would certainly explain running out of connections. Mark > > Modified: > tomcat/tru

svn commit: r1650537 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Author: markt Date: Fri Jan 9 14:15:00 2015 New Revision: 1650537 URL: http://svn.apache.org/r1650537 Log: Add comment to explain null check Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL:

svn commit: r1650535 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

Author: remm Date: Fri Jan 9 14:04:43 2015 New Revision: 1650535 URL: http://svn.apache.org/r1650535 Log: Fix NPE that was swallowed. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java URL: http:

Re: svn commit: r1650527 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/SocketWrapperBase.java test/org/apache/tomcat/websocket/TestWebSocketFram

On 09/01/2015 13:46, Rémy Maucherat wrote: > 2015-01-09 14:39 GMT+01:00 : > >> Author: markt >> Date: Fri Jan 9 13:39:51 2015 >> New Revision: 1650527 >> >> URL: http://svn.apache.org/r1650527 >> Log: >> Simplify. Entries are removed from bufferedWrites as soon as they are >> fully written so the

Re: svn commit: r1650527 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/SocketWrapperBase.java test/org/apache/tomcat/websocket/TestWebSocketFram

2015-01-09 14:39 GMT+01:00 : > Author: markt > Date: Fri Jan 9 13:39:51 2015 > New Revision: 1650527 > > URL: http://svn.apache.org/r1650527 > Log: > Simplify. Entries are removed from bufferedWrites as soon as they are > fully written so the code only needs to check for size() > 0. > > I am test

svn commit: r1650527 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java java/org/apache/tomcat/util/net/SocketWrapperBase.java test/org/apache/tomcat/websocket/TestWebSocketFrameCli

Author: markt Date: Fri Jan 9 13:39:51 2015 New Revision: 1650527 URL: http://svn.apache.org/r1650527 Log: Simplify. Entries are removed from bufferedWrites as soon as they are fully written so the code only needs to check for size() > 0. Modified: tomcat/trunk/java/org/apache/tomcat/util/n

svn commit: r1650521 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java

Author: markt Date: Fri Jan 9 13:24:36 2015 New Revision: 1650521 URL: http://svn.apache.org/r1650521 Log: bufferedWrites is never null (it is final) Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapperBase.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWr

ReplicatedContext and tomcat junit tests

Hi all, while trying to setup a unit test for bug 57425 I stumbled about two things. First the Tomcat class always uses a StandardContext even if I set another name for a context class on StandardHost. If I change addWebapp to use the contextClass from the StandardHost the ReplicatedContext

svn commit: r1650512 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/coyote/http11/upgrade/ webapps/docs/config/

Author: markt Date: Fri Jan 9 12:22:54 2015 New Revision: 1650512 URL: http://svn.apache.org/r1650512 Log: Remove unused configuration setting since the recent refactoring removed a layer of buffering Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java tomca

svn commit: r1650510 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

Author: markt Date: Fri Jan 9 12:18:51 2015 New Revision: 1650510 URL: http://svn.apache.org/r1650510 Log: Better TODO Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apache.org/

svn commit: r1650509 - /tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java

Author: markt Date: Fri Jan 9 12:05:08 2015 New Revision: 1650509 URL: http://svn.apache.org/r1650509 Log: Clean-up - Fix Java 8 Javadoc warnings - Reduce field and method visibility Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Modified: tomcat/trunk/java/org/apache

svn commit: r1650504 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardHostValve.java test/org/apache/catalina/core/TestStandardHostValve.java webapps/docs/changelog.xml

Author: markt Date: Fri Jan 9 11:33:27 2015 New Revision: 1650504 URL: http://svn.apache.org/r1650504 Log: Fix issue reported during 8.0.16 release testing that requestDestroyed was not called for a non-async page when the ErrorReportingValve would be handling the error reporting. Modified:

svn commit: r1650488 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Author: markt Date: Fri Jan 9 10:22:41 2015 New Revision: 1650488 URL: http://svn.apache.org/r1650488 Log: Fix broken XML Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/tru

svn commit: r1650477 - in /tomcat/trunk/java/org/apache: catalina/security/SecurityClassLoad.java coyote/http11/Http11OutputBuffer.java

Author: markt Date: Fri Jan 9 10:05:24 2015 New Revision: 1650477 URL: http://svn.apache.org/r1650477 Log: Remove unnecessary code since o.a.coyote.http11.Constants is now pre-loaded. Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java tomcat/trunk/java/org/ap

svn commit: r1650471 - /tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java

Author: markt Date: Fri Jan 9 09:53:11 2015 New Revision: 1650471 URL: http://svn.apache.org/r1650471 Log: Remove a TODO that - on reflection - is not necessary. Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java Modified: tomcat/trunk/java/org/apache/coyote/http11

svn commit: r1650467 - in /tomcat/trunk: java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http11/filters/ java/org/apache/coyote/spdy/ test/org

Author: markt Date: Fri Jan 9 09:43:27 2015 New Revision: 1650467 URL: http://svn.apache.org/r1650467 Log: Remove parameter that was being passed around but never used because in the few places it was used, it was already available as a field. Modified: tomcat/trunk/java/org/apache/coyote/O

svn commit: r1650465 - in /tomcat/trunk/java/org/apache/coyote: OutputBuffer.java http11/Http11OutputBuffer.java

Author: markt Date: Fri Jan 9 09:34:41 2015 New Revision: 1650465 URL: http://svn.apache.org/r1650465 Log: Clean-up - Fix Java 8 Javadoc warnings - Correct copy/paste errors in Javadoc - Consistent formatting - Reduce method visibility where possible - In-line single use methods Modified:

Re: [CANCELLED][VOTE] Release Apache Tomcat 8.0.16

Hi, 2015-01-08 21:16 GMT+02:00 Mark Thomas : > > On 07/01/2015 15:19, Violeta Georgieva wrote: > > Hi, > > > > 2015-01-07 15:02 GMT+02:00 Mark Thomas : > >> > >> On 07/01/2015 07:42, Violeta Georgieva wrote: > >>> Hi, > >>> > >>> 2015-01-05 15:13 GMT+02:00 Mark Thomas >>>

Re: [CANCELLED][VOTE] Release Apache Tomcat 8.0.16

Hi Konstantin, 2015-01-08 23:53 GMT+02:00 Konstantin Kolinko : > > 2015-01-08 22:16 GMT+03:00 Mark Thomas : > > > > I've fixed this issue in trunk. I need to commit, back-port it and run > > through the unit tests. I should be able to do that this evening and I > > plan to tag 8.0.17 tomorrow morn