[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2014-12-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community integration

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-bio (in module tomcat-8.0.x) failed

2014-12-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-bio has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2014-12-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-validate has an issue affecting its community integration.

[Bug 56895] catalina.bat does not properly compose JAVA_OPTS

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56895 Chuck Caldarale changed: What|Removed |Added Version|7.0.57 |7.0.54 -- You are receiving thi

[Bug 56895] catalina.bat does not properly compose JAVA_OPTS

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56895 Marco changed: What|Removed |Added Version|7.0.54 |7.0.57 -- You are receiving this mail bec

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

2014-12-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2014-12-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-apr has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2014-12-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community integration

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-bio (in module tomcat-8.0.x) failed

2014-12-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-bio has an issue affecting its community integration.

buildbot success in ASF Buildbot on tomcat-trunk

2014-12-05 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/731 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: The AnyBranchSchedul

[GUMP@vmgump]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2014-12-05 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-validate has an issue affecting its community integration.

Re: svn commit: r1643371 - /tomcat/trunk/java/org/apache/catalina/core/

2014-12-05 Thread Mark Thomas
On 05/12/2014 22:56, Mark Thomas wrote: > On 05/12/2014 22:42, Rémy Maucherat wrote: >> 2014-12-05 23:22 GMT+01:00 Mark Thomas : >> My Tomcat trunk is quite broken right now (and the ci run isn't looking very good). It could be related to this. >>> >>> Hmm. I guess I must have missed some

[Bug 57284] When in async mode and calling it from another thread, chain.doFilter() throws NPE

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1643475 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ test/org/apache/catalina/core/ webapps/docs/

2014-12-05 Thread markt
Author: markt Date: Sat Dec 6 00:04:14 2014 New Revision: 1643475 URL: http://svn.apache.org/r1643475 Log: Revert r1643383 pending clarification from the Servlet EG re section 6.2.3 and threading requirements. Disable associated test. Modified: tomcat/tc8.0.x/trunk/ (props changed) t

svn commit: r1643474 - in /tomcat/trunk: java/org/apache/catalina/core/ test/org/apache/catalina/core/

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 23:58:13 2014 New Revision: 1643474 URL: http://svn.apache.org/r1643474 Log: Revert r1643371 pending clarification from the Servlet EG re section 6.2.3 and threading requirements. Disable associated test. Modified: tomcat/trunk/java/org/apache/catalina/core/App

Re: svn commit: r1643371 - /tomcat/trunk/java/org/apache/catalina/core/

2014-12-05 Thread Mark Thomas
On 05/12/2014 22:42, Rémy Maucherat wrote: > 2014-12-05 23:22 GMT+01:00 Mark Thomas : > >>> My Tomcat trunk is quite broken right now (and the ci run isn't looking >>> very good). It could be related to this. >> >> Hmm. I guess I must have missed something. Sorry about that. When I >> looked throu

svn commit: r1643465 - /tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Set.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 22:43:48 2014 New Revision: 1643465 URL: http://svn.apache.org/r1643465 Log: Follow up to r1643365/r1643366. BZ57309. Fix unit test failure. Modified: tomcat/trunk/java/org/apache/jasper/tagplugins/jstl/core/Set.java Modified: tomcat/trunk/java/org/apache/jaspe

Re: svn commit: r1643371 - /tomcat/trunk/java/org/apache/catalina/core/

2014-12-05 Thread Rémy Maucherat
2014-12-05 23:22 GMT+01:00 Mark Thomas : > > My Tomcat trunk is quite broken right now (and the ci run isn't looking > > very good). It could be related to this. > > Hmm. I guess I must have missed something. Sorry about that. When I > looked through the code it looked surprisingly harmless. > > T

[Bug 57284] When in async mode and calling it from another thread, chain.doFilter() throws NPE

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284 Konstantin Kolinko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|F

svn commit: r1643460 - in /tomcat/trunk: java/org/apache/el/lang/ELSupport.java test/org/apache/catalina/core/TestApplicationFilterChain.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 22:31:47 2014 New Revision: 1643460 URL: http://svn.apache.org/r1643460 Log: Fix Checkstyle warnings Modified: tomcat/trunk/java/org/apache/el/lang/ELSupport.java tomcat/trunk/test/org/apache/catalina/core/TestApplicationFilterChain.java Modified: tomcat/tr

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #16 from Konstantin Kolinko --- If you are using ThreadLocals implementing a Filter is the usual and better approach. 1) A Filter fulfills the same task of being executed when request enters application and when it leaves it. 2

Re: svn commit: r1643371 - /tomcat/trunk/java/org/apache/catalina/core/

2014-12-05 Thread Mark Thomas
On 05/12/2014 21:20, Rémy Maucherat wrote: > 2014-12-05 18:43 GMT+01:00 : > >> Author: markt >> Date: Fri Dec 5 17:43:56 2014 >> New Revision: 1643371 >> >> URL: http://svn.apache.org/r1643371 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57284 >> Enable startAsync() to be cal

Re: svn commit: r1643371 - /tomcat/trunk/java/org/apache/catalina/core/

2014-12-05 Thread Rémy Maucherat
2014-12-05 18:43 GMT+01:00 : > Author: markt > Date: Fri Dec 5 17:43:56 2014 > New Revision: 1643371 > > URL: http://svn.apache.org/r1643371 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57284 > Enable startAsync() to be called from a Filter and still be able to call > the remai

[Bug 57318] The value of int b in WsFrame class changes value of int rsv

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57318 jasonric...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution

[Bug 57318] The value of int b in WsFrame class changes value of int rsv

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57318 --- Comment #1 from jasonric...@gmail.com --- The sendbinary method is what causes this error to be thrown not send text or send object. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 57318] New: The value of int b in WsFrame class changes value of int rsv

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57318 Bug ID: 57318 Summary: The value of int b in WsFrame class changes value of int rsv Product: Tomcat 7 Version: 7.0.53 Hardware: All OS: Linux

svn commit: r1643410 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java WsWebSocketContainer.java

2014-12-05 Thread remm
Author: remm Date: Fri Dec 5 19:37:38 2014 New Revision: 1643410 URL: http://svn.apache.org/r1643410 Log: Only keep the origin header value system property, set to null by default (no origin header). Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java tomcat/trunk/jav

Re: svn commit: r1643194 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java Util.java WsWebSocketContainer.java

2014-12-05 Thread Rémy Maucherat
2014-12-05 19:52 GMT+01:00 Mark Thomas : > On 05/12/2014 08:42, r...@apache.org wrote: > > Author: remm > > Date: Fri Dec 5 08:42:50 2014 > > New Revision: 1643194 > > Short version: > +1 on some. > Against anything that is added with the sole purpose of passing a broken > TCK test. > A few quest

[Bug 57316] New: JspC fails if directory name contains URL encoded characters

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57316 Bug ID: 57316 Summary: JspC fails if directory name contains URL encoded characters Product: Tomcat 7 Version: 7.0.55 Hardware: Macintosh Status: NEW

Re: svn commit: r1643194 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java Util.java WsWebSocketContainer.java

2014-12-05 Thread Mark Thomas
On 05/12/2014 08:42, r...@apache.org wrote: > Author: remm > Date: Fri Dec 5 08:42:50 2014 > New Revision: 1643194 Short version: +1 on some. Against anything that is added with the sole purpose of passing a broken TCK test. A few questions with the general aim of reducing the number of system pr

Re: svn commit: r1643008 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java pojo/PojoMethodMapping.java

2014-12-05 Thread Mark Thomas
On 04/12/2014 14:21, Rémy Maucherat wrote: > 2014-12-04 15:01 GMT+01:00 Mark Thomas : > >>> Ah actually, it is a mix then of the two, it should implement what is >>> marked as WSC-4.8.1 in the spec instead. >> >> I thought that was what was implemented (prior to r1643008). What did I >> get wrong?

buildbot failure in ASF Buildbot on tomcat-trunk

2014-12-05 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/726 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: The AnyBranchScheduler

[Bug 57284] When in async mode and calling it from another thread, chain.doFilter() throws NPE

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1643383 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ test/org/apache/catalina/core/ webapps/docs/

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 18:35:21 2014 New Revision: 1643383 URL: http://svn.apache.org/r1643383 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57284 Enable startAsync() to be called from a Filter and still be able to call the remainder of the FilterChain Added: tomcat/tc

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #15 from Shailendra Singh --- Thank you for posting this bug. This will help me to avoid lots of troubles. I am also disappointed by this resolution. I am in the same boat as you as feel that Tomcat should have implemented in

svn commit: r1643371 - /tomcat/trunk/java/org/apache/catalina/core/

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 17:43:56 2014 New Revision: 1643371 URL: http://svn.apache.org/r1643371 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57284 Enable startAsync() to be called from a Filter and still be able to call the remainder of the FilterChain Modified: tomcat/t

svn commit: r1643370 - /tomcat/trunk/test/org/apache/catalina/core/TestApplicationFilterChain.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 17:43:16 2014 New Revision: 1643370 URL: http://svn.apache.org/r1643370 Log: Add a test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=57284 Added: tomcat/trunk/test/org/apache/catalina/core/TestApplicationFilterChain.java Added: tomcat/trunk/test

Re: svn commit: r1643194 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java Util.java WsWebSocketContainer.java

2014-12-05 Thread Mark Thomas
On 05/12/2014 08:44, Rémy Maucherat wrote: > 2014-12-05 9:42 GMT+01:00 : > >> Author: remm >> Date: Fri Dec 5 08:42:50 2014 >> New Revision: 1643194 >> >> URL: http://svn.apache.org/viewvc?rev=1643194&view=rev >> Log: >> Add configuration options for extensions, the origin header, periodic >> che

[Bug 57309] Custom type conversion sometimes bypassed

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57309 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1643367 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/el/ java/org/apache/el/lang/ java/org/apache/el/parser/ java/org/apache/el/stream/ java/org/apache/el/util/ test/org/apache/el/ test

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 17:39:06 2014 New Revision: 1643367 URL: http://svn.apache.org/r1643367 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57309 Ensure that the current EL Resolver is given an opportunity to perform type coercion before applying the default EL coercion rul

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #14 from Jozef Hartinger --- > I'd prefer to see this discussed by the Servlet EG before taking any action. Fair enough, I'll try to bring this up. -- You are receiving this mail because: You are the assignee for the bug. --

svn commit: r1643366 - in /tomcat/trunk: java/org/apache/el/lang/ java/org/apache/el/parser/ java/org/apache/el/stream/ test/org/apache/el/ test/org/apache/el/lang/ test/org/apache/el/stream/

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 17:33:58 2014 New Revision: 1643366 URL: http://svn.apache.org/r1643366 Log: Part 2 of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=57309 Run all the type specific conversions through the ELResolver Modified: tomcat/trunk/java/org/apache/el/lang/EL

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #13 from Jozef Hartinger --- > Well, it's not what I call EE integration then, which would be at the > container > level, not at the application level limited to Servlets. This is too limited, > for example, it has no possibil

svn commit: r1643365 - in /tomcat/trunk: java/org/apache/el/ java/org/apache/el/lang/ java/org/apache/el/parser/ java/org/apache/el/util/ test/org/apache/el/lang/ test/org/apache/el/util/

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 17:32:34 2014 New Revision: 1643365 URL: http://svn.apache.org/r1643365 Log: Part 1 of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=57309 Addressed the direct calls to ELSupport.coerceToType() Still need to address the type specific versions of that met

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #12 from Mark Thomas --- (In reply to Jozef Hartinger from comment #5) > Secondly, ServletRequestListener seems to be the portable hook for > integrating various frameworks that use ThreadLocals and it actually is > portable ac

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #11 from Remy Maucherat --- Well, it's not what I call EE integration then, which would be at the container level, not at the application level limited to Servlets. This is too limited, for example, it has no possibility to work

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #10 from Jozef Hartinger --- Not sure if I fully understand your question. We do not need our stuff to be active during Servlet init/destroy. We need it active during request processing. -- You are receiving this mail because:

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #9 from Remy Maucherat --- Ah, so you need a request object ? How do you manage during servlet init / destroy then ? -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #8 from Jozef Hartinger --- Actually since ThreadBindingListener does not have access to the ServletRequest object (as ServletRequestListener does) it is not really usable for our purpose. Thus, would it be possible to have th

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #7 from Remy Maucherat --- "is miserable": thanks for the feedback :) "when it is called with respect to ServletRequestListener": "Callback for establishing naming association when entering the application scope. This correspon

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #6 from Jozef Hartinger --- BTW, the documentation for http://tomcat.apache.org/tomcat-8.0-doc/api/org/apache/catalina/ThreadBindingListener.html is miserable. Is there an example somewhere of how this should be registered and w

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #5 from Jozef Hartinger --- I am really disappointed by this resolution. First of all: "Interface for receiving notification events about requests coming into and going out of scope of a web application." When a request goes

RE: JSR 236 with tomcat 8

2014-12-05 Thread shailendra singh
Chris, I simply responded to a comment from JLouis where he suggested me to go for TomEE for my requirement. I was not expecting response from any other person. So yes I asked for an information about TomEE on Tomcat mailing list but that question was for JLouis and not for any other person

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #4 from Remy Maucherat --- I fully agree with the resolution, especially since a facility designed specifically for this use has been added in Tomcat 8. But maybe the ThreadBinding listener should be backported to Tomcat 7 to c

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Blocks|57315

[Bug 57315] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57315 Mark Thomas changed: What|Removed |Added Depends on|57314 | -- You are receiving this mail bec

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #2 from Remy Maucherat --- As with JBoss Web, you're not supposed to be using the request listener but the ThreadBindingListener that I added if you want container integration (although it is not used yet for upgrade mode, I'll

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #1 from Mark Thomas --- *** Bug 57315 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 57315] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57315 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 Jozef Hartinger changed: What|Removed |Added Blocks||57315 -- You are receiving this

[Bug 57315] New: ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57315 Bug ID: 57315 Summary: ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads Product: Tomcat 8

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 mkouba changed: What|Removed |Added CC||mko...@redhat.com -- You are receiving t

[Bug 57308] Replace System.getProperty("file.separator") with File.separator throughout

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57308 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1643334 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/AntCompiler.java java/org/apache/jasper/compiler/JspRuntimeContext.java java/org/apache/tomcat/jni/Library.java test

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 15:34:02 2014 New Revision: 1643334 URL: http://svn.apache.org/r1643334 Log: Follow up to r164 Replace calls to System.getProperty("path.separator" with File.pathSeperator Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/ap

svn commit: r1643333 - in /tomcat/tc7.0.x/trunk: ./ java/javax/el/ExpressionFactory.java test/org/apache/juli/TestClassLoaderLogManager.java webapps/docs/changelog.xml

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 15:31:05 2014 New Revision: 164 URL: http://svn.apache.org/r164 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57308 Avoid unnecessary use of System.getProperty("file.separator") Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/t

svn commit: r1643332 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/security/ java/org/apache/el/parser/ java/org/apache/jasper/ java/org/apache/jasper/com

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 15:30:18 2014 New Revision: 1643332 URL: http://svn.apache.org/r1643332 Log: Follow up to r1643329 Replace System.getProperty("line.separator") with System.lineSeparator() Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache

[Bug 57314] New: ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 Bug ID: 57314 Summary: ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads Product: Tomcat 7

svn commit: r1643330 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/jasper/compiler/AntCompiler.java java/org/apache/jasper/compiler/JspRuntimeContext.java java/org/apache/tomcat/jni/Library.java test

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 15:26:47 2014 New Revision: 1643330 URL: http://svn.apache.org/r1643330 Log: Foolow up to r1643329 Replace calls to System.getProperty("path.separator" with File.pathSeperator Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/ap

svn commit: r1643329 - in /tomcat/tc8.0.x/trunk: ./ java/javax/el/ExpressionFactory.java test/org/apache/juli/TestClassLoaderLogManager.java webapps/docs/changelog.xml

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 15:26:05 2014 New Revision: 1643329 URL: http://svn.apache.org/r1643329 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57308 Avoid unnecessary use of System.getProperty("file.separator") Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/t

svn commit: r1643323 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/catalina/security/ java/org/apache/el/parser/ java/org/apache/jasper/ java/org/apache/jasper/compiler/ java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 15:18:46 2014 New Revision: 1643323 URL: http://svn.apache.org/r1643323 Log: Replace System.getProperty("line.separator") with System.lineSeparator() Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteWriter.java tomcat/trunk/java/org/apache/cat

svn commit: r1643310 - in /tomcat/trunk: java/org/apache/jasper/compiler/AntCompiler.java java/org/apache/jasper/compiler/JspRuntimeContext.java java/org/apache/tomcat/jni/Library.java test/org/apache

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 14:56:28 2014 New Revision: 1643310 URL: http://svn.apache.org/r1643310 Log: Replace calls to System.getProperty("path.separator" with File.pathSeperator Modified: tomcat/trunk/java/org/apache/jasper/compiler/AntCompiler.java tomcat/trunk/java/org/apache/jas

svn commit: r1643309 - in /tomcat/trunk: java/javax/el/ExpressionFactory.java test/org/apache/juli/TestClassLoaderLogManager.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 14:55:38 2014 New Revision: 1643309 URL: http://svn.apache.org/r1643309 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57308 Avoid unnecessary use of System.getProperty("file.separator") Modified: tomcat/trunk/java/javax/el/ExpressionFactory.java

[Bug 57281] Tomcat fails to call method of non-public filter class configured via Servlet 3.0 API when running with SecurityManager

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57281 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1643288 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/security/SecurityUtil.java webapps/docs/changelog.xml

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 14:06:32 2014 New Revision: 1643288 URL: http://svn.apache.org/r1643288 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57281 Enable non-public Filter and Servlet classes to be configured programmatically via the Servlet 3.0 API and then used without err

svn commit: r1643285 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/security/SecurityUtil.java webapps/docs/changelog.xml

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 14:04:29 2014 New Revision: 1643285 URL: http://svn.apache.org/r1643285 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57281 Enable non-public Filter and Servlet classes to be configured programmatically via the Servlet 3.0 API and then used without err

svn commit: r1643283 - /tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 13:58:58 2014 New Revision: 1643283 URL: http://svn.apache.org/r1643283 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57281 Use interfaces rather than implementations to call Filter and Servlet methods when running under a security manager. Modified:

[Bug 57265] Tomcat 8 hiden behind NGINX fails to send file when using NIO connector

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57265 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1643274 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 13:35:52 2014 New Revision: 1643274 URL: http://svn.apache.org/r1643274 Log: Possible fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=57265 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/NioE

svn commit: r1643273 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 13:34:32 2014 New Revision: 1643273 URL: http://svn.apache.org/r1643273 Log: Possible fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=57265 Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/NioE

svn commit: r1643270 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 13:30:27 2014 New Revision: 1643270 URL: http://svn.apache.org/viewvc?rev=1643270&view=rev Log: Possible fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=57265 Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified: tomcat/tr

svn commit: r1643250 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/webresources/JarResource.java

2014-12-05 Thread violetagg
Author: violetagg Date: Fri Dec 5 12:06:23 2014 New Revision: 1643250 URL: http://svn.apache.org/viewvc?rev=1643250&view=rev Log: Merged revision 1643249 from tomcat/trunk: Use the correct constant for the debug message. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/tr

svn commit: r1643249 - /tomcat/trunk/java/org/apache/catalina/webresources/JarResource.java

2014-12-05 Thread violetagg
Author: violetagg Date: Fri Dec 5 12:04:42 2014 New Revision: 1643249 URL: http://svn.apache.org/viewvc?rev=1643249&view=rev Log: Use the correct constant for the debug message. Modified: tomcat/trunk/java/org/apache/catalina/webresources/JarResource.java Modified: tomcat/trunk/java/org/apa

[Bug 57265] Tomcat 8 hiden behind NGINX fails to send file when using NIO connector

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57265 --- Comment #3 from Mark Thomas --- Looking at this again. Making the sendFile flag volatile isn't going to help since it is always correctly set to the true in the same thread where it is read and found to be false (which triggers the sta

[Bug 57252] Custom error page is not used for an error that occurs asynchronously

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57252 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1643242 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardHostValve.java java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/core/TestAsyncCo

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 11:39:00 2014 New Revision: 1643242 URL: http://svn.apache.org/viewvc?rev=1643242&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57252 Provide application configured error pages with a chance to handle an async error before the built-in error re

svn commit: r1643232 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/StandardHostValve.java java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/core/TestAsyncCo

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 10:54:21 2014 New Revision: 1643232 URL: http://svn.apache.org/viewvc?rev=1643232&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57252 Provide application configured error pages with a chance to handle an async error before the built-in error re

svn commit: r1643231 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 10:48:12 2014 New Revision: 1643231 URL: http://svn.apache.org/viewvc?rev=1643231&view=rev Log: Add whitespace to align flags to make it easier to see which states set which flags. Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java Mod

svn commit: r1643230 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/AsyncStateMachine.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 10:47:11 2014 New Revision: 1643230 URL: http://svn.apache.org/viewvc?rev=1643230&view=rev Log: Add whitespace to align flags to make it easier to see which states set which flags. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/o

svn commit: r1643229 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 10:46:04 2014 New Revision: 1643229 URL: http://svn.apache.org/viewvc?rev=1643229&view=rev Log: Fix concurrency issue identified while investigating BZ 57252. Ensure that non-container threads can't change the async state until the container thread has completed po

svn commit: r1643228 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/ java/org/apache/catalina/valves/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 10:42:26 2014 New Revision: 1643228 URL: http://svn.apache.org/viewvc?rev=1643228&view=rev Log: With the changes to the behaviour AsyncContext.isStarted() this method can no longer be used to determine if complete needs to be called to add a new method that can pro

svn commit: r1643226 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 10:33:59 2014 New Revision: 1643226 URL: http://svn.apache.org/viewvc?rev=1643226&view=rev Log: Fix three edgy async context bugs. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

svn commit: r1643225 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 10:32:13 2014 New Revision: 1643225 URL: http://svn.apache.org/viewvc?rev=1643225&view=rev Log: Back-port typo fix Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Propchange: tomcat/

svn commit: r1643224 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/catalina/core/LocalStrings.properties test/org/apache/catalina/core/TestAsyncCon

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 10:30:41 2014 New Revision: 1643224 URL: http://svn.apache.org/viewvc?rev=1643224&view=rev Log: Backport clarification from Servlet 3.1 that requires an ISE if getRequest() or getResponse() are called after complete() or dispatch() Modified: tomcat/tc7.0.x/trun

[Bug 57287] Sort files listed by DefaultServlet

2014-12-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57287 --- Comment #9 from Oleg Trokhov --- Created attachment 32260 --> https://issues.apache.org/bugzilla/attachment.cgi?id=32260&action=edit Bug 57287v3 Now with patch v3: 1. "s=NA" name=asc 2. "s=ND" name=dsc 3. "s=SA" size=asc 4. "s=SD" si

svn propchange: r1643215 - svn:log

2014-12-05 Thread markt
Author: markt Revision: 1643215 Modified property: svn:log Modified: svn:log at Fri Dec 5 09:53:22 2014 -- --- svn:log (original) +++ svn:log Fri Dec 5 09:53:22 2014 @@ -0,0 +1 @@ +Fix concurrency issue identified while

svn commit: r1643217 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/AsyncStateMachine.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 09:51:46 2014 New Revision: 1643217 URL: http://svn.apache.org/viewvc?rev=1643217&view=rev Log: Follow up to r1643215. If something goes wrong, ensure non-container threads are unblocked. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trun

svn commit: r1643216 - /tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 09:50:40 2014 New Revision: 1643216 URL: http://svn.apache.org/viewvc?rev=1643216&view=rev Log: Follow up to r1643002. If something goes wrong, ensure non-container threads are unblocked. Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java Mod

svn commit: r1643215 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 09:48:24 2014 New Revision: 1643215 URL: http://svn.apache.org/viewvc?rev=1643215&view=rev Log: (empty) Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/coyote/AsyncStateMachine.java tomcat/tc8.0.x/trunk/webapps/docs

svn commit: r1643212 - in /tomcat/tc7.0.x/trunk: ./ build.properties.default webapps/docs/changelog.xml

2014-12-05 Thread kkolinko
Author: kkolinko Date: Fri Dec 5 09:36:38 2014 New Revision: 1643212 URL: http://svn.apache.org/viewvc?rev=1643212&view=rev Log: Update to Checkstyle 6.1.1 Fixed trailing whitespace in changelog file. Merged r1643205 from tomcat/tc8.0.x/trunk. Modified: tomcat/tc7.0.x/trunk/ (props change

svn commit: r1643210 - in /tomcat/trunk/java/org/apache/catalina: core/StandardHostValve.java valves/ErrorReportValve.java

2014-12-05 Thread markt
Author: markt Date: Fri Dec 5 09:36:12 2014 New Revision: 1643210 URL: http://svn.apache.org/viewvc?rev=1643210&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57252 Provide application configured error pages with a chance to handle an async error before the built-in error re

  1   2   >