[GUMP@vmgump]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2014-12-04 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-validate has an issue affecting its community integration.

[Bug 50511] WARNING about Internal Dummy Connection of Apache

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50511 --- Comment #8 from Rainer Jung --- The change is in http://svn.apache.org/viewvc?view=revision&revision=1598864 This has not been released yet but will be part of version 1.2.41. Until that version will be released (I plan to start the r

[Bug 50511] WARNING about Internal Dummy Connection of Apache

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50511 --- Comment #7 from Ross Richardson --- This message is still occurring in 1.2.40. What was the resolution on this? This message is filling the jk log too much. -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 57285] No UAC prompt if Tomcat 8.0.15 uninstaller is launched via Start menu

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57285 --- Comment #4 from Konstantin Kolinko --- (In reply to Mark Thomas from comment #3) > I ma leaning towards reverting r1630897 and adding a note to BUILDING.txt > that UAC needs to be disabled for an unattended build. or code signing has t

[Bug 57285] No UAC prompt if Tomcat 8.0.15 uninstaller is launched via Start menu

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57285 --- Comment #3 from Mark Thomas --- I ma leaning towards reverting r1630897 and adding a note to BUILDING.txt that UAC needs to be disabled for an unattended build. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1643128 - /tomcat/trunk/test/org/apache/catalina/valves/TestRequestFilterValve.java

2014-12-04 Thread markt
Author: markt Date: Thu Dec 4 20:55:04 2014 New Revision: 1643128 URL: http://svn.apache.org/viewvc?rev=1643128&view=rev Log: Refactor test to stop IDE complaining about possible NPEs. Also requires slightly less code. Modified: tomcat/trunk/test/org/apache/catalina/valves/TestRequestFilterV

[jira] [Resolved] (MTOMCAT-289) Overriding the tomcat plugin dependencies to 7.0.53 does not get picked up by dependency:resolve-plugins

2014-12-04 Thread John Harvey (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Harvey resolved MTOMCAT-289. - Resolution: Invalid Bug in other plugin: https://jira.codehaus.org/browse/MDEP-474 > Overriding

[jira] [Commented] (MTOMCAT-289) Overriding the tomcat plugin dependencies to 7.0.53 does not get picked up by dependency:resolve-plugins

2014-12-04 Thread John Harvey (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234591#comment-14234591 ] John Harvey commented on MTOMCAT-289: - I found a way to turn on verbose logging, and

[jira] [Updated] (MTOMCAT-289) Overriding the tomcat plugin dependencies to 7.0.53 does not get picked up by dependency:resolve-plugins

2014-12-04 Thread John Harvey (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Harvey updated MTOMCAT-289: Attachment: pom.xml > Overriding the tomcat plugin dependencies to 7.0.53 does not get picked up by

[jira] [Created] (MTOMCAT-289) Overriding the tomcat plugin dependencies to 7.0.53 does not get picked up by dependency:resolve-plugins

2014-12-04 Thread John Harvey (JIRA)
John Harvey created MTOMCAT-289: --- Summary: Overriding the tomcat plugin dependencies to 7.0.53 does not get picked up by dependency:resolve-plugins Key: MTOMCAT-289 URL: https://issues.apache.org/jira/browse/MTOMCAT

[Bug 57284] When in async mode and calling it from another thread, chain.doFilter() throws NPE

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57284 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas

[Bug 57309] Custom type conversion sometimes bypassed

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57309 --- Comment #1 from Mark Thomas --- Proposed fix: https://github.com/markt-asf/tomcat/commit/53e9f7b44e1cd450ab27025a0202dbf4d383851d https://github.com/markt-asf/tomcat/commit/d075c49460df3bcfbda3e6ed9f3e357003bad5df I plan to commit this

Re: Tomcat8 coercing behavior

2014-12-04 Thread Mauro Molinari
Il 04/12/2014 15:15, Mark Thomas ha scritto: That we can fix. Indeed, reading section 1.23 of the EL spec we should fix it. My reading of the spec is that we should always give the ELResolver a chance to convert this before applying the defaults. I've raised https://issues.apache.org/bugzilla/s

[Bug 57309] Custom type conversion sometimes bypassed

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57309 Mauro Molinari changed: What|Removed |Added CC||mauro...@tiscali.it -- You are r

Re: svn commit: r1643008 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java pojo/PojoMethodMapping.java

2014-12-04 Thread Rémy Maucherat
2014-12-04 15:01 GMT+01:00 Mark Thomas : > > Ah actually, it is a mix then of the two, it should implement what is > > marked as WSC-4.8.1 in the spec instead. > > I thought that was what was implemented (prior to r1643008). What did I > get wrong? > > The test is fairly explicit that the annotate

Re: Tomcat8 coercing behavior

2014-12-04 Thread Mark Thomas
On 04/12/2014 09:21, mauromol wrote: > Violeta Georgieva-2 wrote >> Hi, >> >> This is incompatible change in EL 3.0. >> Check EL 3.0 Spec 1.23.1 and 1.23.2 the Rule for null String is to coerce >> to "". >> >> and >> >> A.4 Incompatibilities between EL 3.0 and EL 2.2 >> >> Regards >> Violeta > > T

[Bug 57308] Replace System.getProperty("file.separator") with File.separator throughout

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57308 --- Comment #3 from Sebb --- It looks like the same applies to "path.separator" and File.pathSeparator. i.e. changing the property causes issues for startup, and only the first char is used by Java. If so, here are the instances I found i

[Bug 57309] New: Custom type conversion sometimes bypassed

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57309 Bug ID: 57309 Summary: Custom type conversion sometimes bypassed Product: Tomcat 8 Version: trunk Hardware: All OS: All Status: NEW Severity: normal

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-04 Thread Rémy Maucherat
2014-12-04 14:58 GMT+01:00 Mark Thomas : > Shouldn't there still be a single empty message in that case? Otherwise, > how is the client meant to differentiate between no write and a write of > zero length? > > The problem I am trying to fix is extra empty messages when the writer is not actually u

Re: svn commit: r1643008 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java pojo/PojoMethodMapping.java

2014-12-04 Thread Mark Thomas
On 02/12/2014 22:59, Rémy Maucherat wrote: > 2014-12-02 23:12 GMT+01:00 Mark Thomas : > >> On 02/12/2014 21:16, r...@apache.org wrote: >>> Author: remm >>> Date: Tue Dec 2 21:16:51 2014 >>> New Revision: 1643008 >>> >>> URL: http://svn.apache.org/r1643008 >>> Log: >>> Websockets annotations can b

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-04 Thread Mark Thomas
On 04/12/2014 13:17, Rémy Maucherat wrote: > 2014-12-04 14:11 GMT+01:00 Mark Thomas : > >> The used flag is only ever set to true. It needs to be reset to false >> after a write to avoid multiple flush() calls one after the other >> triggering empty writes. >> >> Looking at the code, what would be

[Bug 57308] Replace System.getProperty("file.separator") with File.separator throughout

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57308 --- Comment #2 from Sebb --- (In reply to Mark Thomas from comment #1) > I have a patch for trunk [1] that I'll commit once svn writes are available > again. Then I'll look at back-ports. > > [1] > https://github.com/markt-asf/tomcat/commi

[Bug 57252] Custom error page is not used for an error that occurs asynchronously

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57252 --- Comment #2 from Mark Thomas --- Proposed fix: https://github.com/markt-asf/tomcat/commit/5e195b2f06dba1be3f90b0a9d1f67604af905e47 I'll commit this once the svn server returns to read/write -- You are receiving this mail because: You

[Bug 57265] Tomcat 8 hiden behind NGINX fails to send file when using NIO connector

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57265 --- Comment #2 from Mark Thomas --- Hard to see how this could happen. A possible fix is: https://github.com/markt-asf/tomcat/commit/9b18a9f97b88572b34f88c456b04d519b8480827 -- You are receiving this mail because: You are the assignee for

[Bug 57281] Tomcat fails to call method of non-public filter class configured via Servlet 3.0 API when running with SecurityManager

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57281 --- Comment #3 from Mark Thomas --- Proposed fix: https://github.com/markt-asf/tomcat/commit/fd145607a4782359e3b12711f3817fe195b0601f -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 57308] Replace System.getProperty("file.separator") with File.separator throughout

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57308 --- Comment #1 from Mark Thomas --- I have a patch for trunk [1] that I'll commit once svn writes are available again. Then I'll look at back-ports. [1] https://github.com/markt-asf/tomcat/commit/0744a45a939311cc0ac0981a6922e4afd1e2e7d4 -

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-04 Thread Rémy Maucherat
2014-12-04 14:11 GMT+01:00 Mark Thomas : > The used flag is only ever set to true. It needs to be reset to false > after a write to avoid multiple flush() calls one after the other > triggering empty writes. > > Looking at the code, what would be better is if something along the > lines of using b

Re: svn commit: r1642773 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsRemoteEndpointImplBase.java

2014-12-04 Thread Mark Thomas
On 01/12/2014 22:35, r...@apache.org wrote: > Author: remm > Date: Mon Dec 1 22:35:30 2014 > New Revision: 1642773 > > URL: http://svn.apache.org/r1642773 > Log: > Move the offending code to the server. Avoid sending a message when nothing > has actually been written. The used flag is only ever

[Bug 57308] New: Replace System.getProperty("file.separator") with File.separator throughout

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57308 Bug ID: 57308 Summary: Replace System.getProperty("file.separator") with File.separator throughout Product: Tomcat 7 Version: trunk Hardware: All OS:

[Bug 57282] request process UML diagram seems outdated

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282 --- Comment #5 from Mark Thomas --- You are part of community too. No-one else has stepped up to do this so if you want to fix these diagrams go for it. -- You are receiving this mail because: You are the assignee for the bug. --

Re: svn commit: r1642360 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java WsWebSocketContainer.java server/UpgradeUtil.java server

2014-12-04 Thread Rémy Maucherat
2014-12-04 11:55 GMT+01:00 Mark Thomas : > It is more like "least worst" rather than "best". > > Most things have sensible defaults and the user is able to change them > via properties set on ClientEndpointConfig.getUserProperties() or similar. > > For changing defaults I don't think there is much

[Bug 57287] Sort files listed by DefaultServlet

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57287 --- Comment #8 from Konstantin Kolinko --- It can be more simple, with a single parameter such as s=NA s=ND (sort Name ascending, Name descending) A shorter parameter name makes it less obvious that the name is English one, better for i18n

Re: svn commit: r1642721 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-12-04 Thread Mark Thomas
On 02/12/2014 15:07, Rémy Maucherat wrote: > 2014-12-02 15:47 GMT+01:00 Mark Thomas : > >> I think there might a solution that works for everybody (thanks >> Konstantin). What about setting an origin header value of "null" in the >> client if none is set by the user? That is consistent with all th

Re: svn commit: r1642360 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java WsWebSocketContainer.java server/UpgradeUtil.java server

2014-12-04 Thread Mark Thomas
On 02/12/2014 09:26, Rémy Maucherat wrote: > 2014-12-02 10:04 GMT+01:00 Mark Thomas : > >> Possible options: >> a) Require servers to support a NO-OP extension. Kind of pointless since >>it would just be there to pass the tests. >> b) Drop the test. Not ideal. If the API is there it should be

Re: Tomcat8 coercing behavior

2014-12-04 Thread mauromol
Violeta Georgieva-2 wrote > Hi, > > This is incompatible change in EL 3.0. > Check EL 3.0 Spec 1.23.1 and 1.23.2 the Rule for null String is to coerce > to "". > > and > > A.4 Incompatibilities between EL 3.0 and EL 2.2 > > Regards > Violeta This is causing big problems with JSF, indeed. There

[Bug 57287] Sort files listed by DefaultServlet

2014-12-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57287 --- Comment #7 from Violeta Georgieva --- (In reply to Oleg Trokhov from comment #6) > Created attachment 32249 [details] > sorting list > > I refactor import, so checkstyle task passed. So we leave my parameter > naming or rename as as Ap