[Bug 57282] request process UML diagram seems outdated

2014-11-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282 --- Comment #2 from Stephen Chen --- Created attachment 32237 --> https://issues.apache.org/bugzilla/attachment.cgi?id=32237&action=edit Page 1 step -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57282] request process UML diagram seems outdated

2014-11-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282 --- Comment #1 from Stephen Chen --- Created attachment 32236 --> https://issues.apache.org/bugzilla/attachment.cgi?id=32236&action=edit Page 2 step -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57282] New: request process UML diagram seems outdated

2014-11-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57282 Bug ID: 57282 Summary: request process UML diagram seems outdated Product: Tomcat 7 Version: 7.0.56 Hardware: PC Status: NEW Severity: normal Priority: P2

[jira] [Closed] (MTOMCAT-90) useNaming not very useful; perhaps use StandardServer to make it more useful

2014-11-28 Thread Benson Margulies (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benson Margulies closed MTOMCAT-90. --- Resolution: Invalid No longer relevant. > useNaming not very useful; perhaps use StandardServ

[Bug 57281] New: Tomcat fails to call method of non-public filter class configured via Servlet 3.0 API when running with SecurityManager

2014-11-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57281 Bug ID: 57281 Summary: Tomcat fails to call method of non-public filter class configured via Servlet 3.0 API when running with SecurityManager Product: Tomcat 7

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2014-11-28 Thread Bill Barker
-commons/daemon/dist/bin/commons-daemon-20141128-native-src.tar.gz -Dtest.reports=output/logs-BIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141128-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace

svn commit: r1642361 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-11-28 Thread remm
Author: remm Date: Fri Nov 28 20:51:58 2014 New Revision: 1642361 URL: http://svn.apache.org/r1642361 Log: Remove client debug. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java

Re: svn commit: r1642360 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java WsWebSocketContainer.java server/UpgradeUtil.java server

2014-11-28 Thread Konstantin Kolinko
2014-11-28 23:33 GMT+03:00 : > Author: remm > Date: Fri Nov 28 20:33:20 2014 > New Revision: 1642360 > > URL: http://svn.apache.org/r1642360 > Log: > - Use the extensions specified by the configuration (and ignore if there are > no associated transformations). > - Add an origin header on the clie

svn commit: r1642360 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java LocalStrings.properties TransformationFactory.java WsWebSocketContainer.java server/UpgradeUtil.java server/WsH

2014-11-28 Thread remm
Author: remm Date: Fri Nov 28 20:33:20 2014 New Revision: 1642360 URL: http://svn.apache.org/r1642360 Log: - Use the extensions specified by the configuration (and ignore if there are no associated transformations). - Add an origin header on the client. - Add path params as params too. - Use the

svn commit: r1642354 - /tomcat/trunk/java/org/apache/tomcat/websocket/Util.java

2014-11-28 Thread markt
Author: markt Date: Fri Nov 28 19:49:50 2014 New Revision: 1642354 URL: http://svn.apache.org/r1642354 Log: Follow up to r1642282 Clean-up. No functional changes. - Update comments to reflect code changes - Remove unnecessary nesting of if/else - Reduce code duplication in decoder matching Modifi

Re: svn commit: r1642282 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java WsRemoteEndpointImplBase.java

2014-11-28 Thread Mark Thomas
On 28/11/2014 10:33, r...@apache.org wrote: > Author: remm > Date: Fri Nov 28 10:33:35 2014 > New Revision: 1642282 > > URL: http://svn.apache.org/r1642282 > Log: > Fix apparent edge cases with handlers (partial ones for byte[]), decoders > (should be passed on to handlers) and encoders (byte[] d

svn commit: r1642352 - /tomcat/trunk/java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java

2014-11-28 Thread markt
Author: markt Date: Fri Nov 28 19:19:04 2014 New Revision: 1642352 URL: http://svn.apache.org/r1642352 Log: More kkolinko review Modified: tomcat/trunk/java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.j

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Mark Thomas
On 28/11/2014 19:07, Konstantin Kolinko wrote: > 2014-11-28 21:29 GMT+03:00 Mark Thomas : >> On 28/11/2014 17:47, Konstantin Kolinko wrote: >> >> Thanks for the review. I think I've addressed everything. >> > > public int hashCode() { > final int prime = 31; > in

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Konstantin Kolinko
2014-11-28 21:29 GMT+03:00 Mark Thomas : > On 28/11/2014 17:47, Konstantin Kolinko wrote: > > Thanks for the review. I think I've addressed everything. > public int hashCode() { final int prime = 31; int result = 1; result = prime * result + lcKey.ha

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Mark Thomas
On 28/11/2014 18:39, Christopher Schultz wrote: > Mark, > > On 11/28/14 12:06 PM, Mark Thomas wrote: >> On 28/11/2014 15:44, Rémy Maucherat wrote: >>> 2014-11-28 16:20 GMT+01:00 Martin Grigorov :I'm not >>> sure I follow you. >>> Assuming 'headers' is an instance of CaseInsensitiveKeyMap then

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Christopher Schultz
Mark, On 11/28/14 12:06 PM, Mark Thomas wrote: > On 28/11/2014 15:44, Rémy Maucherat wrote: >> 2014-11-28 16:20 GMT+01:00 Martin Grigorov :I'm not >> sure I follow you. >> >>> Assuming 'headers' is an instance of CaseInsensitiveKeyMap then: >>> - headers.get("BLAH") will delegate to innerMap.get(k

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Mark Thomas
On 28/11/2014 17:47, Konstantin Kolinko wrote: Thanks for the review. I think I've addressed everything. > 2014-11-28 17:53 GMT+03:00 : >> Author: markt >> Date: Fri Nov 28 14:53:15 2014 >> New Revision: 1642307 Cheers, Mark ---

svn commit: r1642341 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java java/org/apache/tomcat/websocket/LocalStrings.properties test/org/apache/tomcat/websocket/TestCaseI

2014-11-28 Thread markt
Author: markt Date: Fri Nov 28 18:27:38 2014 New Revision: 1642341 URL: http://svn.apache.org/r1642341 Log: kkolinko review Fix a typo. Simplify where values are known to be non-null Specify and test behaviour with null and non-String key values. Modified: tomcat/trunk/java/org/apache/tomcat/

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Konstantin Kolinko
2014-11-28 17:53 GMT+03:00 : > Author: markt > Date: Fri Nov 28 14:53:15 2014 > New Revision: 1642307 > > URL: http://svn.apache.org/r1642307 > Log: > Add a map that supports case insensitive keys. E.g. for use with HTTP headers. > > Added: > tomcat/trunk/java/org/apache/tomcat/websocket/CaseI

svn commit: r1642327 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Constants.java WsHandshakeResponse.java WsWebSocketContainer.java

2014-11-28 Thread markt
Author: markt Date: Fri Nov 28 17:30:55 2014 New Revision: 1642327 URL: http://svn.apache.org/r1642327 Log: Make use of the new case-insensitive map implementation. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Constants.java tomcat/trunk/java/org/apache/tomcat/websocket/WsHands

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Mark Thomas
On 28/11/2014 15:44, Rémy Maucherat wrote: > 2014-11-28 16:20 GMT+01:00 Martin Grigorov :I'm not > sure I follow you. > >> Assuming 'headers' is an instance of CaseInsensitiveKeyMap then: >> - headers.get("BLAH") will delegate to innerMap.get(key{"blah"}) // >> Perl-ish syntax to express what I

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Rémy Maucherat
2014-11-28 16:20 GMT+01:00 Martin Grigorov :I'm not sure I follow you. > Assuming 'headers' is an instance of CaseInsensitiveKeyMap then: > - headers.get("BLAH") will delegate to innerMap.get(key{"blah"}) // > Perl-ish syntax to express what I mean > - headers.get("bLAh") will also delegate to i

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Martin Grigorov
Hi Remy, On Fri, Nov 28, 2014 at 4:13 PM, Rémy Maucherat wrote: > 2014-11-28 16:05 GMT+01:00 Martin Grigorov : > > > Hi, > > > > Performance wise isn't it better to transform the String key to lowerCase > > at Key construction time and later use it in equals/hashCode ? > > Now the lower-ificatio

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Rémy Maucherat
2014-11-28 16:05 GMT+01:00 Martin Grigorov : > Hi, > > Performance wise isn't it better to transform the String key to lowerCase > at Key construction time and later use it in equals/hashCode ? > Now the lower-ification would happen for most Map operation. > The current is not spec compliant sinc

Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Martin Grigorov
Hi, Performance wise isn't it better to transform the String key to lowerCase at Key construction time and later use it in equals/hashCode ? Now the lower-ification would happen for most Map operation. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, Nov 28,

svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread markt
Author: markt Date: Fri Nov 28 14:53:15 2014 New Revision: 1642307 URL: http://svn.apache.org/r1642307 Log: Add a map that supports case insensitive keys. E.g. for use with HTTP headers. Added: tomcat/trunk/java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java (with props) tomca

Re: Test Classes Not Found

2014-11-28 Thread Christopher Schultz
Ahmed, On 11/28/14 5:20 AM, Ahmed Hosni wrote: > I have build tomcat from source on trunk branch ,build is successful but > when I run Junit Test it throws a ClassNotFound exception, I checked Ant > file it should make folder contains test classes , > but I did't find this folder or any .class

[Bug 57142] JSP 2.3 & EL 3.0 - %page import directive & EL ImportHandler

2014-11-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57142 --- Comment #9 from Konstantin Kolinko --- Reviewing r1642233 and r1642280. In general: a) I wonder whether we can do some work once when JSP page servlet class initializes, instead of doing everything a-new on each request. b) I wonder w

Re: JSR 236 with tomcat 8

2014-11-28 Thread Christopher Schultz
Shailendra, On 11/26/14 5:16 AM, shailendra singh wrote: > Its like I am asking you for a candy and you are advising me to buy a > football because someone is giving candy free with a football. > > Do you have a version of TomEE which is based on Java EE 7? I will be > happy to use it for testing

buildbot success in ASF Buildbot on tomcat-trunk

2014-11-28 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/695 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: The AnyBranchSchedul

svn commit: r1642282 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java WsRemoteEndpointImplBase.java

2014-11-28 Thread remm
Author: remm Date: Fri Nov 28 10:33:35 2014 New Revision: 1642282 URL: http://svn.apache.org/r1642282 Log: Fix apparent edge cases with handlers (partial ones for byte[]), decoders (should be passed on to handlers) and encoders (byte[] does not need a mandatory encoder). Modified: tomcat/tr

buildbot failure in ASF Buildbot on tomcat-8-trunk

2014-11-28 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-8-trunk/builds/36 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: The AnyBranchSchedul

Test Classes Not Found

2014-11-28 Thread Ahmed Hosni
I have build tomcat from source on trunk branch ,build is successful but when I run Junit Test it throws a ClassNotFound exception, I checked Ant file it should make folder contains test classes , but I did't find this folder or any .class files for test classes. I appreciate your help with thi

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2014-11-28 Thread Bill Barker
it/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141128-native-src.tar.gz -Dexamples.sources.

[Bug 57263] NoClassDefFoundError: sun/management/ExtendedPlatformComponent with JDK 1.8.0_40-ea-b15

2014-11-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57263 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1642280 - /tomcat/trunk/java/javax/el/ImportHandler.java

2014-11-28 Thread markt
Author: markt Date: Fri Nov 28 09:59:29 2014 New Revision: 1642280 URL: http://svn.apache.org/r1642280 Log: Follow-up to r1642233 Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57142 Page imports need to be visible to EL JSPs can import classes that EL is not permitted to resolve. Ensure t

[Bug 57263] NoClassDefFoundError: sun/management/ExtendedPlatformComponent with JDK 1.8.0_40-ea-b15

2014-11-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57263 Koen S. changed: What|Removed |Added Hardware|Macintosh |All -- You are receiving this mail beca

[Bug 57263] NoClassDefFoundError: sun/management/ExtendedPlatformComponent with JDK 1.8.0_40-ea-b15

2014-11-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57263 Koen S. changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALID

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2014-11-28 Thread Bill Barker
it-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141128-native-src.tar.gz -Dexamples.sources.skip=true

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2014-11-28 Thread Bill Barker
it-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141128-native-src.tar.gz -Dexamples.sources.skip=true