To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk-test-apr has an issue affecting its community integration.
Th
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk-test-nio has an issue affecting its community integration.
Th
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
T
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk-test-bio has an issue affecting its community integration.
Th
2014-10-29 17:42 GMT+03:00 :
> Author: markt
> Date: Wed Oct 29 14:42:01 2014
> New Revision: 1635154
>
> URL: http://svn.apache.org/r1635154
> Log:
> URLs may be added directly to the web application's class path. ensure that
> they are scanned if a StandardJarScanner is configured to scan the c
Author: markt
Date: Wed Oct 29 23:20:24 2014
New Revision: 1635335
URL: http://svn.apache.org/r1635335
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57147
JDBC Store corrections
- add missing properties
- note defaults
- remove required status from attributes that have defaults
- not
https://issues.apache.org/bugzilla/show_bug.cgi?id=57147
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=57148
Mark Thomas changed:
What|Removed |Added
Component|EL |Jasper
Version|8.0.14
Author: markt
Date: Wed Oct 29 23:02:44 2014
New Revision: 1635328
URL: http://svn.apache.org/r1635328
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57148
When coercing an object to a given type and a PropertyEditor has been
registered for the type correctly coerce the empty string
2014-10-29 22:28 GMT+01:00 Mark Thomas :
>
> Thanks. I've just removed it :)
>
> Adding the isCompleting() code and using it in the ErrorReportValve
> appears to have fixed all the issues with the unit tests apart from the
> ISE issues with get[Request|Response]() which are just issues with the
>
https://issues.apache.org/bugzilla/show_bug.cgi?id=57155
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=57154
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
it-4.12-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-APR
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20141029-native-src.tar.gz
-Dexamples.sources.skip=true
Author: markt
Date: Wed Oct 29 21:59:25 2014
New Revision: 1635313
URL: http://svn.apache.org/r1635313
Log:
Remove pointless Javadoc block
Modified:
tomcat/trunk/java/org/apache/catalina/Globals.java
Modified: tomcat/trunk/java/org/apache/catalina/Globals.java
URL:
http://svn.apache.org/vie
Author: markt
Date: Wed Oct 29 21:59:06 2014
New Revision: 1635312
URL: http://svn.apache.org/r1635312
Log:
Remove the temporary STRICT_SERVLET_COMPLIANCE tests
Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
Modified: tomcat/trunk/java/org/apache/catalina/core/Asy
Author: markt
Date: Wed Oct 29 21:44:13 2014
New Revision: 1635310
URL: http://svn.apache.org/r1635310
Log:
Fix and re-enable remaining tests broken by changes to
AsyncContextImpl.isStarted()
Modified:
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
Modified: tomcat/tru
On 29/10/2014 20:03, Rémy Maucherat wrote:
> 2014-10-29 20:27 GMT+01:00 Mark Thomas :
>
>> OK. Lets leave it in place until the issues with the tests are fixed.
>>
>> The started flag being true for the MUST_COMPLETE state is causing
>> problems too. It breaks code like this:
>>
>> if (request.isA
Author: markt
Date: Wed Oct 29 21:25:33 2014
New Revision: 1635308
URL: http://svn.apache.org/r1635308
Log:
Follow-up to 1635301
Use isCompleting to align with isDispatching
Fix the implementation for HTTP and AJP
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
tomc
Author: markt
Date: Wed Oct 29 21:01:06 2014
New Revision: 1635301
URL: http://svn.apache.org/r1635301
Log:
With the changes to the behaviour AsyncContext.isStarted() this method can no
longer be used to determine if complete needs to be called to add a new method
that can provide this informati
Author: markt
Date: Wed Oct 29 20:42:09 2014
New Revision: 1635297
URL: http://svn.apache.org/r1635297
Log:
Whitespace
Modified:
tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
URL:
http://svn.apache.org/viewvc/
Author: markt
Date: Wed Oct 29 20:16:52 2014
New Revision: 1635292
URL: http://svn.apache.org/r1635292
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/tomcat/util/net/TesterSupport.java
tomcat/trunk/test/org/apache/tomcat/websocket/TestW
Author: markt
Date: Wed Oct 29 20:10:49 2014
New Revision: 1635291
URL: http://svn.apache.org/r1635291
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java
tomcat/trunk/test/org/apache/tomcat/we
Author: remm
Date: Wed Oct 29 20:06:03 2014
New Revision: 1635289
URL: http://svn.apache.org/r1635289
Log:
Use the strict compliance flag to wrap around the change deferring real
completion of AsyncContext.complete until after onComplete. (part 2)
Modified:
tomcat/trunk/java/org/apache/coyot
Author: markt
Date: Wed Oct 29 20:05:34 2014
New Revision: 1635288
URL: http://svn.apache.org/r1635288
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/CookiesBaseTest.java
tomcat/trunk/test/org/apache/tomcat/util/http/Te
Author: markt
Date: Wed Oct 29 20:02:47 2014
New Revision: 1635286
URL: http://svn.apache.org/r1635286
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/naming/resources/TestNamingContext.java
Modified: tomcat/trunk/test/org/apache/naming/res
2014-10-29 20:27 GMT+01:00 Mark Thomas :
> OK. Lets leave it in place until the issues with the tests are fixed.
>
> The started flag being true for the MUST_COMPLETE state is causing
> problems too. It breaks code like this:
>
> if (request.isAsyncStarted()) {
> request.getAsyncContext().comp
Author: markt
Date: Wed Oct 29 20:00:04 2014
New Revision: 1635285
URL: http://svn.apache.org/r1635285
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java
tomcat/trunk/test/org/apache/coyote/http11/Te
Author: markt
Date: Wed Oct 29 19:57:50 2014
New Revision: 1635283
URL: http://svn.apache.org/r1635283
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java
tomcat/trunk/test/org/apache/catalina/startup/TestTom
Author: markt
Date: Wed Oct 29 19:58:19 2014
New Revision: 1635284
URL: http://svn.apache.org/r1635284
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/valves/TestErrorReportValve.java
Modified: tomcat/trunk/test/org/apache/catalina
Author: markt
Date: Wed Oct 29 19:55:08 2014
New Revision: 1635282
URL: http://svn.apache.org/r1635282
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/session/TestPersistentManager.java
tomcat/trunk/test/org/apache/catalina/sess
Author: markt
Date: Wed Oct 29 19:54:55 2014
New Revision: 1635280
URL: http://svn.apache.org/r1635280
Log:
Update for Tomcat 8
Modified:
tomcat/trunk/test/org/apache/catalina/session/Threading.java
Modified: tomcat/trunk/test/org/apache/catalina/session/Threading.java
URL:
http://svn.apach
Author: markt
Date: Wed Oct 29 19:45:02 2014
New Revision: 1635279
URL: http://svn.apache.org/r1635279
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
Modified:
tomcat/trunk/test/org/apache/cata
Author: markt
Date: Wed Oct 29 19:40:41 2014
New Revision: 1635278
URL: http://svn.apache.org/r1635278
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/mapper/TestMapperWebapps.java
Modified: tomcat/trunk/test/org/apache/catalina/ma
Author: markt
Date: Wed Oct 29 19:40:24 2014
New Revision: 1635276
URL: http://svn.apache.org/r1635276
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/loader/TestVirtualWebappLoader.java
tomcat/trunk/test/org/apache/catalina/loa
Author: markt
Date: Wed Oct 29 19:37:27 2014
New Revision: 1635274
URL: http://svn.apache.org/r1635274
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/filters/TestAddCharSetFilter.java
Modified:
tomcat/trunk/test/org/apache/catali
Author: markt
Date: Wed Oct 29 19:37:10 2014
New Revision: 1635273
URL: http://svn.apache.org/r1635273
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/core/TestApplicationFilterConfig.java
tomcat/trunk/test/org/apache/catalina/c
Author: markt
Date: Wed Oct 29 19:32:29 2014
New Revision: 1635269
URL: http://svn.apache.org/r1635269
Log:
Comment out some failing tests until they are fixed.
Modified:
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
Modified: tomcat/trunk/test/org/apache/catalina/core
Author: markt
Date: Wed Oct 29 19:31:50 2014
New Revision: 1635268
URL: http://svn.apache.org/r1635268
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
Modified: tomcat/trunk/test/org/apache/catalina/c
On 29/10/2014 19:27, Mark Thomas wrote:
> On 29/10/2014 19:05, Rémy Maucherat wrote:
>> 2014-10-29 20:00 GMT+01:00 Mark Thomas :
>>
>>> OK. That makes sense.
>>>
>>> My initial reading of the spec was that the ISE was required as soon as
>>> complete() was called. After all, that is what the Javado
On 29/10/2014 19:05, Rémy Maucherat wrote:
> 2014-10-29 20:00 GMT+01:00 Mark Thomas :
>
>> OK. That makes sense.
>>
>> My initial reading of the spec was that the ISE was required as soon as
>> complete() was called. After all, that is what the Javadoc says.
>>
>> However... the Javadoc for compl
2014-10-29 20:00 GMT+01:00 Mark Thomas :
> OK. That makes sense.
>
> My initial reading of the spec was that the ISE was required as soon as
> complete() was called. After all, that is what the Javadoc says.
>
> However... the Javadoc for complete() says:
>
> If this method is called before the
On 29/10/2014 18:28, Rémy Maucherat wrote:
> 2014-10-29 19:22 GMT+01:00 Mark Thomas :
>
>> OK. Try again :)
>>
>> -1 veto.
>>
>> This breaks a requirement of the Servlet 3.1 spec that an ISE should be
>> thrown if get[Request|Response]() is called after complete() is called.
>>
>> This commit brea
Hi,
2014-10-29 20:28 GMT+02:00 Rémy Maucherat :
>
> 2014-10-29 19:22 GMT+01:00 Mark Thomas :
>
> > OK. Try again :)
> >
> > -1 veto.
> >
> > This breaks a requirement of the Servlet 3.1 spec that an ISE should be
> > thrown if get[Request|Response]() is called after complete() is called.
> >
> > T
Author: remm
Date: Wed Oct 29 18:35:26 2014
New Revision: 1635250
URL: http://svn.apache.org/r1635250
Log:
Use the strict compliance flag to wrap around the vetoed change deferring real
completion of AsyncContext.complete until after onComplete.
Modified:
tomcat/trunk/java/org/apache/catalin
https://issues.apache.org/bugzilla/show_bug.cgi?id=57155
--- Comment #3 from Konstantin Kolinko ---
I envision a caveat with ContextConfig.fixDocBase().
The fixDocBase() method replaces null docBase with one calculated from path,
(new ContextName(path, context.getWebappVersion())).getBaseName().
2014-10-29 19:22 GMT+01:00 Mark Thomas :
> OK. Try again :)
>
> -1 veto.
>
> This breaks a requirement of the Servlet 3.1 spec that an ISE should be
> thrown if get[Request|Response]() is called after complete() is called.
>
> This commit breaks the unit tests that check this (the calls do not
> t
2014-10-29 19:14 GMT+01:00 Mark Thomas :
>
> Hmm. I withdraw that veto. This change has no impact on the failing
> test. I need to investigate further. (It is odd though how we are now
> seeing a ServletException where there should be an ISE).
>
> If there are tests which contradict these fixes, t
On 29/10/2014 17:29, r...@apache.org wrote:
> Author: remm
> Date: Wed Oct 29 17:29:19 2014
> New Revision: 1635215
>
> URL: http://svn.apache.org/r1635215
> Log:
> Fix three edgy async context bugs.
OK. Try again :)
-1 veto.
This breaks a requirement of the Servlet 3.1 spec that an ISE should
On 29/10/2014 18:11, Mark Thomas wrote:
> On 29/10/2014 17:29, r...@apache.org wrote:
>> Author: remm
>> Date: Wed Oct 29 17:29:19 2014
>> New Revision: 1635215
>>
>> URL: http://svn.apache.org/r1635215
>> Log:
>> Fix three edgy async context bugs.
>>
>> Modified:
>> tomcat/trunk/java/org/apach
On 29/10/2014 17:29, r...@apache.org wrote:
> Author: remm
> Date: Wed Oct 29 17:29:19 2014
> New Revision: 1635215
>
> URL: http://svn.apache.org/r1635215
> Log:
> Fix three edgy async context bugs.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
> tomcat
Author: markt
Date: Wed Oct 29 18:04:08 2014
New Revision: 1635235
URL: http://svn.apache.org/r1635235
Log:
Avoid using temp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/authenticator/TestDigestAuthenticator.java
Modified:
tomcat/trunk/test/org/apa
Author: markt
Date: Wed Oct 29 18:04:26 2014
New Revision: 1635237
URL: http://svn.apache.org/r1635237
Log:
Avoid using /tmp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java
tomcat/trunk/test/org/apache/catalina/connec
Author: markt
Date: Wed Oct 29 17:55:12 2014
New Revision: 1635228
URL: http://svn.apache.org/r1635228
Log:
Add a simple test of the normalization method
Modified:
tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java
Modified: tomcat/trunk/test/org/apache/catalina/connector
Author: markt
Date: Wed Oct 29 17:53:16 2014
New Revision: 1635227
URL: http://svn.apache.org/r1635227
Log:
Avoid using temp as a docBase where it is not necessary
Modified:
tomcat/trunk/test/javax/servlet/http/TestHttpServlet.java
Modified: tomcat/trunk/test/javax/servlet/http/TestHttpServl
Author: markt
Date: Wed Oct 29 17:44:11 2014
New Revision: 1635222
URL: http://svn.apache.org/r1635222
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57155
Allow a web application to be configured that does not have a docBase on the
file system. This is primarily intended for use whe
Author: remm
Date: Wed Oct 29 17:29:19 2014
New Revision: 1635215
URL: http://svn.apache.org/r1635215
Log:
Fix three edgy async context bugs.
Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
tomcat/tr
Author: remm
Date: Wed Oct 29 16:00:32 2014
New Revision: 1635185
URL: http://svn.apache.org/r1635185
Log:
r1003589 introduces a change of behavior where a missing JSP in jsp-file now
throws an exception on init. This is apparently not the right behavior
(although it is perfectly legitimate too)
https://issues.apache.org/bugzilla/show_bug.cgi?id=57155
--- Comment #2 from Mark Thomas ---
I'm leaning towards treating a docBase value of "" as invalid and using null to
signal that a docBase on the file system is not required. I need to do some
testing of this.
--
You are receiving this mai
https://issues.apache.org/bugzilla/show_bug.cgi?id=57154
--- Comment #3 from Mark Thomas ---
The root cause of this is indeed the redirect from the Mapper.
The redirect is a result of one of the requirements for welcome file
processing. The Servlet spec is clear Tomcat can implement these any wa
https://issues.apache.org/bugzilla/show_bug.cgi?id=57153
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Wed Oct 29 14:42:01 2014
New Revision: 1635154
URL: http://svn.apache.org/r1635154
Log:
URLs may be added directly to the web application's class path. ensure that
they are scanned if a StandardJarScanner is configured to scan the class path.
Added:
tomcat/trunk/test/org/
Author: markt
Date: Wed Oct 29 13:57:05 2014
New Revision: 1635134
URL: http://svn.apache.org/r1635134
Log:
Fix typo and Java 8 Javadoc issue
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.j
https://issues.apache.org/bugzilla/show_bug.cgi?id=57157
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Wed Oct 29 12:31:12 2014
New Revision: 1635113
URL: http://svn.apache.org/r1635113
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57157
Allow calls to AsyncContext.start(Runnable) during non-blocking IO reads and
writes.
Modified:
tomcat/trunk/java/org/apache
Author: markt
Date: Wed Oct 29 12:29:41 2014
New Revision: 1635112
URL: http://svn.apache.org/r1635112
Log:
Don't try and carry on if there is an ISE when trying to use non-blocking IO.
Treat it as the error it is.
Found this while debugging the test case in BZ 57157.
Modified:
tomcat/trunk/
Author: markt
Date: Wed Oct 29 12:25:34 2014
New Revision: 1635111
URL: http://svn.apache.org/r1635111
Log:
Formatting. No functional change.
Modified:
tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
Author: markt
Date: Wed Oct 29 12:24:42 2014
New Revision: 1635110
URL: http://svn.apache.org/r1635110
Log:
AsyncStateMachine doesn't need to know what type of socket the Processor
is associated with.
Modified:
tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java
tomcat/trunk/java/o
Author: remm
Date: Wed Oct 29 10:37:49 2014
New Revision: 1635093
URL: http://svn.apache.org/r1635093
Log:
Fix alias for cookie rewrite flag, should be CO rather than C.
Modified:
tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteValve.java
tomcat/trunk/webapps/docs/changelog.xm
Author: markt
Date: Wed Oct 29 10:20:09 2014
New Revision: 1635091
URL: http://svn.apache.org/r1635091
Log:
Fix the Java 8 Javadoc warnings in the tests by removing pointless Javadoc and
changing comments with problems to non-Javadoc format
Modified:
tomcat/trunk/test/org/apache/catalina/mbe
Author: markt
Date: Wed Oct 29 10:08:56 2014
New Revision: 1635086
URL: http://svn.apache.org/r1635086
Log:
Add version filtering. Patch by Pierre Viret.
Modified:
tomcat/sandbox/trunk-maven-layout/apache-tomcat/pom.xml
tomcat/sandbox/trunk-maven-layout/pom.xml
tomcat/sandbox/trunk-ma
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #45 from Mark Thomas ---
Patch applied. Many thanks.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-
On 28/10/2014 21:27, Mark Thomas wrote:
> On 26/10/2014 22:40, Konstantin Kolinko wrote:
>> Hi!
>>
>> This is a comment on the following commits:
>>
>> URL: http://svn.apache.org/r1633806
>> Log:
>> When coercing an object to a given type, only attempt coercion to an
>> array if both the object typ
Author: markt
Date: Wed Oct 29 09:49:02 2014
New Revision: 1635081
URL: http://svn.apache.org/r1635081
Log:
When coercing an object to an array type in Expression Langauage, handle the
case where the source object is an array of primitives.
Modified:
tomcat/trunk/java/org/apache/el/lang/ELSu
Author: kkolinko
Date: Wed Oct 29 09:25:04 2014
New Revision: 6899
Log:
Update "current version" in README file
Modified:
release/tomcat/tomcat-connectors/native/README.html
Modified: release/tomcat/tomcat-connectors/native/README.html
On 28/10/2014 21:28, Mark Thomas wrote:
> The Apache Tomcat team announces the immediate availability of Apache
> Tomcat Native 1.1.32 stable.
>
> The key features of this release are:
> - Add support for TLSv1.1 and TLSv1.2
> - Link Windows binaries with OpenSSL 1.0.1i and APR 1.5.1
Correction.
On 29/10/2014 02:59, Christopher Schultz wrote:
> Konstantin,
>
> On 10/28/14 7:33 PM, Konstantin Kolinko wrote:
>> 2014-10-29 2:17 GMT+03:00 Christopher Schultz :
>>> -BEGIN PGP SIGNED MESSAGE-
>>> Hash: SHA256
>>>
>>> All,
>>>
>>> A few notes:
>>>
>>> 1. Some mirrors have not yet updated
76 matches
Mail list logo
