Question of new SessionIdGenerator implementation.

2014-10-13 Thread Keiichi Fujino
I have a question of new SessionIdGenerator implementation. If reloading Manager( or Context), SessionIdGenerator is re-created based on sessionIdGeneratorClass that is cached to Manager. However, attributes of jvmRoute and sessionIdLength are default value. I think these attributes are need to tak

svn commit: r1631628 - in /tomcat/trunk: java/org/apache/catalina/ha/ClusterRuleSet.java java/org/apache/catalina/ha/session/ClusterManagerBase.java webapps/docs/changelog.xml webapps/docs/config/clus

2014-10-13 Thread kfujino
Author: kfujino Date: Tue Oct 14 06:08:49 2014 New Revision: 1631628 URL: http://svn.apache.org/r1631628 Log: Add support for the SessionIdGenerator to cluster manager template. Modified: tomcat/trunk/java/org/apache/catalina/ha/ClusterRuleSet.java tomcat/trunk/java/org/apache/catalina/ha

svn commit: r1631593 - in /tomcat/trunk/java/javax/servlet: Filter.java FilterChain.java FilterConfig.java FilterRegistration.java ServletContext.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 22:36:45 2014 New Revision: 1631593 URL: http://svn.apache.org/r1631593 Log: Fix some Javadoc warnings when compiling with Java 8 Modified: tomcat/trunk/java/javax/servlet/Filter.java tomcat/trunk/java/javax/servlet/FilterChain.java tomcat/trunk/java/jav

buildbot success in ASF Buildbot on tomcat-trunk

2014-10-13 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/540 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1631568 - in /tomcat/trunk/java/javax: el/ servlet/ servlet/jsp/ servlet/jsp/tagext/

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 21:51:42 2014 New Revision: 1631568 URL: http://svn.apache.org/r1631568 Log: Fix some Javadoc warnings when compiling with Java 8 Modified: tomcat/trunk/java/javax/el/ELResolver.java tomcat/trunk/java/javax/servlet/ServletContextAttributeListener.java to

[Bug 56397] Establish parallel Maven-based build process

2014-10-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Pierre Viret changed: What|Removed |Added Attachment #32101|0 |1 is obsolete|

svn commit: r1631520 - in /tomcat/trunk: java/org/apache/tomcat/util/buf/LocalStrings.properties java/org/apache/tomcat/util/buf/MessageBytes.java webapps/docs/changelog.xml

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 19:27:37 2014 New Revision: 1631520 URL: http://svn.apache.org/r1631520 Log: Cache the Encoder instances used to convert Strings to byte arrays in the Connectors (e.g. when writing HTTP headers) to improve throughput. Modified: tomcat/trunk/java/org/apache/tomc

svn commit: r1631458 - in /tomcat/trunk/java/org/apache/tomcat/util: descriptor/tld/ digester/ http/ http/fileupload/ modeler/ net/ net/jsse/

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 16:27:15 2014 New Revision: 1631458 URL: http://svn.apache.org/r1631458 Log: More Java 8 Javadoc error fixes Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/tld/TaglibXml.java tomcat/trunk/java/org/apache/tomcat/util/descriptor/tld/TldResourceP

buildbot failure in ASF Buildbot on tomcat-trunk

2014-10-13 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/538 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Sta

svn commit: r1631454 - in /tomcat/trunk: java/org/apache/tomcat/dbcp/dbcp2/ java/org/apache/tomcat/dbcp/dbcp2/datasources/ webapps/docs/

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 16:06:18 2014 New Revision: 1631454 URL: http://svn.apache.org/r1631454 Log: Fix Java 8 Javadoc errors in org.apache.tomcat.dbcp Modified: tomcat/trunk/java/org/apache/tomcat/dbcp/dbcp2/ (props changed) tomcat/trunk/java/org/apache/tomcat/dbcp/dbcp2/BasicD

svn commit: r1631451 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 16:01:59 2014 New Revision: 1631451 URL: http://svn.apache.org/r1631451 Log: Fix HTML entity Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java Modified: tomcat/trunk/modules/jdbc-pool/src/main/java/org/a

svn commit: r1631434 - in /tomcat/trunk/java/org/apache/tomcat/jni: File.java Poll.java SSLContext.java Socket.java Stdlib.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 15:06:59 2014 New Revision: 1631434 URL: http://svn.apache.org/r1631434 Log: Fix Java 8 Javadoc errors in org.apache.tomcat.jni Modified: tomcat/trunk/java/org/apache/tomcat/jni/File.java tomcat/trunk/java/org/apache/tomcat/jni/Poll.java tomcat/trunk/jav

svn commit: r1631431 - in /tomcat/trunk/java/org/apache/naming: JndiPermission.java SelectorContext.java factory/BeanFactory.java factory/SendMailFactory.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:59:30 2014 New Revision: 1631431 URL: http://svn.apache.org/r1631431 Log: Fix Java 8 Javadoc errors in org.apache.naming Modified: tomcat/trunk/java/org/apache/naming/JndiPermission.java tomcat/trunk/java/org/apache/naming/SelectorContext.java tomcat/

svn commit: r1631423 - /tomcat/trunk/java/org/apache/catalina/Lifecycle.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:41:02 2014 New Revision: 1631423 URL: http://svn.apache.org/r1631423 Log: Trivial change to test diffs Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java URL: http://svn.apache.org/v

svn commit: r1631422 - in /tomcat/trunk/java/org/apache: catalina/Lifecycle.java coyote/AsyncStateMachine.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:39:36 2014 New Revision: 1631422 URL: http://svn.apache.org/r1631422 Log: Set encoding so diffs are reported correctly Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java (props changed) tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.j

svn commit: r1631419 - /tomcat/trunk/java/org/apache/juli/logging/LogFactory.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:36:49 2014 New Revision: 1631419 URL: http://svn.apache.org/r1631419 Log: Fix typos Modified: tomcat/trunk/java/org/apache/juli/logging/LogFactory.java Modified: tomcat/trunk/java/org/apache/juli/logging/LogFactory.java URL: http://svn.apache.org/viewvc/tom

svn commit: r1631417 - in /tomcat/trunk/java/org/apache/jasper: compiler/ compiler/tagplugin/ runtime/ tagplugins/jstl/ xmlparser/

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:32:49 2014 New Revision: 1631417 URL: http://svn.apache.org/r1631417 Log: Fix Java 8 Javadoc errors in org.apache.jasper Modified: tomcat/trunk/java/org/apache/jasper/compiler/AntCompiler.java tomcat/trunk/java/org/apache/jasper/compiler/JspRuntimeContext

svn commit: r1631418 - in /tomcat/trunk/java/org/apache/juli/logging: Log.java LogFactory.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:33:05 2014 New Revision: 1631418 URL: http://svn.apache.org/r1631418 Log: Fix Java 8 Javadoc errors in org.apache.juli Modified: tomcat/trunk/java/org/apache/juli/logging/Log.java tomcat/trunk/java/org/apache/juli/logging/LogFactory.java Modified: tomcat

svn commit: r1631415 - in /tomcat/trunk/java/org/apache/el: MethodExpressionImpl.java ValueExpressionImpl.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:32:28 2014 New Revision: 1631415 URL: http://svn.apache.org/r1631415 Log: Fix Java 8 Javadoc errors in org.apache.el Modified: tomcat/trunk/java/org/apache/el/MethodExpressionImpl.java tomcat/trunk/java/org/apache/el/ValueExpressionImpl.java Modified: to

svn commit: r1631414 - in /tomcat/trunk/java/org/apache/coyote: Request.java Response.java http11/AbstractInputBuffer.java http11/InternalInputBuffer.java spdy/SpdyAprNpnHandler.java spdy/SpdyProxyPro

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:32:10 2014 New Revision: 1631414 URL: http://svn.apache.org/r1631414 Log: Fix Java 8 Javadoc errors in org.apache.coyote Modified: tomcat/trunk/java/org/apache/coyote/Request.java tomcat/trunk/java/org/apache/coyote/Response.java tomcat/trunk/java/org

svn commit: r1631406 - in /tomcat/trunk/java/org/apache: catalina/Lifecycle.java coyote/AsyncStateMachine.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:17:33 2014 New Revision: 1631406 URL: http://svn.apache.org/r1631406 Log: Use UTF-8 to fix ASCII art in Javadoc. How ironic. Modified: tomcat/trunk/java/org/apache/catalina/Lifecycle.java tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java Modifie

svn commit: r1631404 - in /tomcat/trunk/java/org/apache/catalina: users/MemoryUser.java util/ExtensionValidator.java util/MIME2Java.java util/RequestUtil.java valves/JDBCAccessLogValve.java valves/Rem

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:15:11 2014 New Revision: 1631404 URL: http://svn.apache.org/r1631404 Log: Fix more of the Java 8 Javadoc errors in the org.apace.catalina package Modified: tomcat/trunk/java/org/apache/catalina/users/MemoryUser.java tomcat/trunk/java/org/apache/catalina/u

svn commit: r1631399 - in /tomcat/trunk/java/org/apache/catalina: manager/ manager/host/ realm/ security/ servlets/ session/ startup/ storeconfig/ tribes/ tribes/group/ tribes/group/interceptors/ trib

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 14:04:33 2014 New Revision: 1631399 URL: http://svn.apache.org/r1631399 Log: Fix some more of the Java 8 Javadoc errors in the org.apace.catalina package Modified: tomcat/trunk/java/org/apache/catalina/manager/JspHelper.java tomcat/trunk/java/org/apache/cata

svn commit: r1631390 - in /tomcat/trunk/java/org/apache/catalina: ./ connector/ core/ filters/ ha/deploy/ ha/tcp/

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 13:38:25 2014 New Revision: 1631390 URL: http://svn.apache.org/r1631390 Log: Fix some more of the Java 8 Javadoc errors in the org.apace.catalina package Modified: tomcat/trunk/java/org/apache/catalina/WebResourceRoot.java tomcat/trunk/java/org/apache/catali

svn commit: r1631384 - in /tomcat/trunk/java/org/apache/catalina: ant/ ant/jmx/ authenticator/

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 13:19:34 2014 New Revision: 1631384 URL: http://svn.apache.org/r1631384 Log: Fix Java 8 Javadoc errors in org.apace.catalina.[ant|authenticator] Modified: tomcat/trunk/java/org/apache/catalina/ant/BaseRedirectorHelperTask.java tomcat/trunk/java/org/apache/ca

svn commit: r1631381 - in /tomcat/trunk: modules/jdbc-pool/build.xml webapps/docs/changelog.xml

2014-10-13 Thread kkolinko
Author: kkolinko Date: Mon Oct 13 13:18:28 2014 New Revision: 1631381 URL: http://svn.apache.org/r1631381 Log: Apply timestamp fix (r1630088 r1630094) to jdbc-pool and mention it in changelog. The VERSION_BUILT filter string is actually not used in any of jdbc-pool source files, so this change

[Bug 57079] New: Use Tomcat version number in jdbc-pool manifest when building it as part of Tomcat

2014-10-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57079 Bug ID: 57079 Summary: Use Tomcat version number in jdbc-pool manifest when building it as part of Tomcat Product: Tomcat 8 Version: 8.0.14 Hardware: PC S

svn commit: r1631350 - in /tomcat/trunk/java/javax/servlet/jsp: JspApplicationContext.java JspContext.java el/ExpressionEvaluator.java tagext/BodyTag.java tagext/IterationTag.java tagext/Tag.java tage

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 11:33:23 2014 New Revision: 1631350 URL: http://svn.apache.org/r1631350 Log: Fix Java8 Javadoc errors in the javax.servlet.jsp package Modified: tomcat/trunk/java/javax/servlet/jsp/JspApplicationContext.java tomcat/trunk/java/javax/servlet/jsp/JspContext.jav

svn commit: r1631347 - in /tomcat/trunk/java/javax/websocket: ./ server/

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 11:24:24 2014 New Revision: 1631347 URL: http://svn.apache.org/r1631347 Log: Fix Java8 Javadoc warnings for javax.websocket package Modified: tomcat/trunk/java/javax/websocket/ContainerProvider.java tomcat/trunk/java/javax/websocket/Endpoint.java tomcat/

svn commit: r1631342 - /tomcat/trunk/java/javax/servlet/AsyncContext.java

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 10:39:09 2014 New Revision: 1631342 URL: http://svn.apache.org/r1631342 Log: Javadoc. Fix Java 8 warnings for this class. Modified: tomcat/trunk/java/javax/servlet/AsyncContext.java Modified: tomcat/trunk/java/javax/servlet/AsyncContext.java URL: http://svn.ap

Re: [GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed

2014-10-13 Thread Mark Thomas
On 12/10/2014 14:22, Caldarale, Charles R wrote: >> From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] >> Subject: Re: [GUMP@vmgump]: Project tomcat-trunk-test-bio (in module >> tomcat-trunk) failed > >>> Is it worth doing that compared to the cost of creating and gc'ing the >>> local vari

Re: [GUMP@vmgump]: Project tomcat-trunk-test-bio (in module tomcat-trunk) failed

2014-10-13 Thread Mark Thomas
On 12/10/2014 11:08, Konstantin Kolinko wrote: > One more: > It is odd that filtering of MessageBytes is skipped if mb.getType() is > already T_BYTES. I don't think that code path is ever used. > I think those methods, and new/moved method > TesterAjpMessage.appendString() shall filter CTLs. > >

[Bug 56397] Establish parallel Maven-based build process

2014-10-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #35 from Mark Thomas --- No need to think too much about git at the moment. There doesn't seem to be much interest in moving right now. Patche are all applied and the build completes. I don't see the startup scripts or the con

svn commit: r1631323 - /tomcat/sandbox/trunk-maven-layout/pom.xml

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 09:30:57 2014 New Revision: 1631323 URL: http://svn.apache.org/r1631323 Log: Remove duplication Modified: tomcat/sandbox/trunk-maven-layout/pom.xml Modified: tomcat/sandbox/trunk-maven-layout/pom.xml URL: http://svn.apache.org/viewvc/tomcat/sandbox/trunk-maven

svn commit: r1631322 - /tomcat/sandbox/trunk-maven-layout/tomcat-webapps/docs/pom.xml

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 09:18:55 2014 New Revision: 1631322 URL: http://svn.apache.org/r1631322 Log: Futher patch from Pierre Viret. Modified: tomcat/sandbox/trunk-maven-layout/tomcat-webapps/docs/pom.xml Modified: tomcat/sandbox/trunk-maven-layout/tomcat-webapps/docs/pom.xml URL: ht

svn commit: r1631321 - /tomcat/sandbox/trunk-maven-layout/pom.xml

2014-10-13 Thread markt
Author: markt Date: Mon Oct 13 09:18:17 2014 New Revision: 1631321 URL: http://svn.apache.org/r1631321 Log: Futher patch from Pierre Viret. Enable the jdbc-pool module since BZ 57005 is fixed. Modified: tomcat/sandbox/trunk-maven-layout/pom.xml Modified: tomcat/sandbox/trunk-maven-layout/po