[Bug 56991] New: Request attribute org.apache.catalina.jsp_file needs to be nulled out after single use

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56991 Bug ID: 56991 Summary: Request attribute org.apache.catalina.jsp_file needs to be nulled out after single use Product: Tomcat 8 Version: 8.0.12 Hardware: PC

[Bug 55524] Deadlock produced during Websocket write operation (org.apache.catalina.websocket.WsOutbound)

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55524 --- Comment #10 from Violeta Georgieva --- (In reply to Dmitry Treskunov from comment #9) > Looking at the changelog > http://tomcat.apache.org/tomcat-7.0-doc/changelog.html I see that > > "Avoid a possible deadlock when one thread is shu

Re: [Bug 56739] Error response body generated only occasionally

2014-09-17 Thread Violeta Georgieva
Hi, 2014-08-07 11:53 GMT+03:00 : > > https://issues.apache.org/bugzilla/show_bug.cgi?id=56739 > > Mark Thomas changed: > >What|Removed |Added > > Component|Catalina

svn commit: r1625878 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ webapps/docs/

2014-09-17 Thread violetagg
Author: violetagg Date: Thu Sep 18 02:14:10 2014 New Revision: 1625878 URL: http://svn.apache.org/r1625878 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56982 Merged revision(s) 1624984 from tomcat/trunk: Return the actual negotiated extensions rather than an empty list for Session.

buildbot success in ASF Buildbot on tomcat-trunk

2014-09-17 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/465 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 56953] A improvement for "DataInputStream"

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56953 --- Comment #18 from hzha...@ebay.com --- Thanks for your advice. These points are extremely wise. (In reply to Konstantin Kolinko from comment #15) > OK, this is better. > > 1. Formatting: the code shall not use tab characters > > 2. In

svn commit: r1625855 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/windows-auth-howto.xml

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 23:41:23 2014 New Revision: 1625855 URL: http://svn.apache.org/r1625855 Log: After double-checking SPN to domain user is a one to one mapping Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/windows-auth-howto.xml Propchan

svn commit: r1625854 - /tomcat/trunk/webapps/docs/windows-auth-howto.xml

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 23:40:48 2014 New Revision: 1625854 URL: http://svn.apache.org/r1625854 Log: After double-checking SPN to domain user is a one to one mapping Modified: tomcat/trunk/webapps/docs/windows-auth-howto.xml Modified: tomcat/trunk/webapps/docs/windows-auth-howto.xml U

svn commit: r1625842 - /tomcat/trunk/webapps/docs/windows-auth-howto.xml

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 22:45:58 2014 New Revision: 1625842 URL: http://svn.apache.org/r1625842 Log: Answer an outstanding question and add some additional info Modified: tomcat/trunk/webapps/docs/windows-auth-howto.xml Modified: tomcat/trunk/webapps/docs/windows-auth-howto.xml URL:

svn commit: r1625843 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/windows-auth-howto.xml

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 22:46:26 2014 New Revision: 1625843 URL: http://svn.apache.org/r1625843 Log: Answer an outstanding question and add some additional info Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/windows-auth-howto.xml Propchange: t

[Bug 56990] New: ant ide-eclipse target shall download easymock library

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56990 Bug ID: 56990 Summary: ant ide-eclipse target shall download easymock library Product: Tomcat 8 Version: 8.0.12 Hardware: PC Status: NEW Severity: normal

svn commit: r1625837 - /tomcat/tc6.0.x/trunk/BUILDING.txt

2014-09-17 Thread kkolinko
Author: kkolinko Date: Wed Sep 17 22:17:28 2014 New Revision: 1625837 URL: http://svn.apache.org/r1625837 Log: CTR: Documentation Add a note about creating release builds on non-Windows platforms. It is port of r1553126. Modified: tomcat/tc6.0.x/trunk/BUILDING.txt Modified: tomcat/tc6.0.x/tr

svn commit: r1625827 - /tomcat/sandbox/trunk-maven-layout/tomcat-util/pom.xml

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 21:12:33 2014 New Revision: 1625827 URL: http://svn.apache.org/r1625827 Log: Fix typo Modified: tomcat/sandbox/trunk-maven-layout/tomcat-util/pom.xml Modified: tomcat/sandbox/trunk-maven-layout/tomcat-util/pom.xml URL: http://svn.apache.org/viewvc/tomcat/sandb

Re: svn commit: r1625825 - /tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/apache/tomcat/

2014-09-17 Thread Mark Thomas
On 17/09/2014 21:57, ma...@apache.org wrote: > Author: markt > Date: Wed Sep 17 20:57:12 2014 > New Revision: 1625825 > > URL: http://svn.apache.org/r1625825 > Log: > Add an external for util All, Sorry for the noise. It looks like my working copy is corrupted. A fresh checkout is fine. Mark

svn commit: r1625825 - /tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/apache/tomcat/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:57:12 2014 New Revision: 1625825 URL: http://svn.apache.org/r1625825 Log: Add an external for util Modified: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/apache/tomcat/ (props changed) Propchange: tomcat/sandbox/trunk-maven-layout/tom

svn commit: r1625824 - in /tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/apache: ./ tomcat/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:56:12 2014 New Revision: 1625824 URL: http://svn.apache.org/r1625824 Log: Restore packages Added: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/apache/ tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/apache/tomcat/ ---

svn commit: r1625823 - /tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:54:53 2014 New Revision: 1625823 URL: http://svn.apache.org/r1625823 Log: Re-add org packag Added: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/ - To unsubscribe, e-mail:

svn commit: r1625818 - /tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:50:45 2014 New Revision: 1625818 URL: http://svn.apache.org/r1625818 Log: Still not sure what is going on. Try deleting more stuff to clean things up. Removed: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/

[Bug 56397] Establish parallel Maven-based build process

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #16 from Pierre Viret --- I've just figured out where you have performed the changes (tomcat/sandbox/trunk-maven-layout/) so I will be able to check this out on Friday. Regarding the tests: I have not tried to integrate the tes

svn commit: r1625811 - /tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/apache/tomcat/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:39:04 2014 New Revision: 1625811 URL: http://svn.apache.org/r1625811 Log: Add an external for util Modified: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/apache/tomcat/ (props changed) Propchange: tomcat/sandbox/trunk-maven-layout/tom

svn commit: r1625808 - in /tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org: ./ apache/ apache/tomcat/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:37:06 2014 New Revision: 1625808 URL: http://svn.apache.org/r1625808 Log: Restore packages Added: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org/ tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org/apache/ tomcat/sandbox/

svn commit: r1625810 - /tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org/apache/tomcat/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:37:37 2014 New Revision: 1625810 URL: http://svn.apache.org/r1625810 Log: Add an external for util Modified: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org/apache/tomcat/ (props changed) Propchange: tomcat/sandbox/trunk-maven-layout/tom

svn commit: r1625807 - /tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:36:17 2014 New Revision: 1625807 URL: http://svn.apache.org/r1625807 Log: Still not sure what is going on. Try deleting more stuff to clean things up. Removed: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org/

[Bug 56397] Establish parallel Maven-based build process

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #15 from Pierre Viret --- Here my answers to the first comment: Working with the source: 1. How do you propose to update the version number after a release? Updating every POM by hand is not viable. --> I use the maven-version

svn commit: r1625804 - in /tomcat/sandbox/trunk-maven-layout/tomcat-util/src: main/java/org/apache/tomcat/ test/java/org/apache/tomcat/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:28:07 2014 New Revision: 1625804 URL: http://svn.apache.org/r1625804 Log: Remove externals while I try and figure out strange svn errors Modified: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org/apache/tomcat/ (props changed) tomcat/s

svn commit: r1625797 - in /tomcat/sandbox/trunk-maven-layout/tomcat-util: pom.xml src/test/java/org/apache/tomcat/ src/test/java/org/apache/tomcat/util/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:10:59 2014 New Revision: 1625797 URL: http://svn.apache.org/r1625797 Log: Simplify externals Removed: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/test/java/org/apache/tomcat/util/ Modified: tomcat/sandbox/trunk-maven-layout/tomcat-util/pom.xml

Re: svn commit: r1625794 - in /tomcat/sandbox/trunk-maven-layout/tomcat-util: pom.xml src/main/java/org/apache/tomcat/

2014-09-17 Thread Konstantin Kolinko
2014-09-18 0:03 GMT+04:00 : > Author: markt > Date: Wed Sep 17 20:03:26 2014 > New Revision: 1625794 > > URL: http://svn.apache.org/r1625794 > Log: > Simplify externals > > Modified: > tomcat/sandbox/trunk-maven-layout/tomcat-util/pom.xml > > tomcat/sandbox/trunk-maven-layout/tomcat-util/

svn commit: r1625794 - in /tomcat/sandbox/trunk-maven-layout/tomcat-util: pom.xml src/main/java/org/apache/tomcat/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 20:03:26 2014 New Revision: 1625794 URL: http://svn.apache.org/r1625794 Log: Simplify externals Modified: tomcat/sandbox/trunk-maven-layout/tomcat-util/pom.xml tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org/apache/tomcat/ (props changed)

[Bug 56397] Establish parallel Maven-based build process

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #14 from Mark Thomas --- For the record a narrow as possible single external combined with include/exclude filters in the POM looks like a good solution. I'll update the existing modules that use multiple externals to use this a

svn commit: r1625785 - in /tomcat/sandbox/trunk-maven-layout/tomcat-api: pom.xml src/main/java/org/apache/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 19:48:22 2014 New Revision: 1625785 URL: http://svn.apache.org/r1625785 Log: CComplete tomcat-api module with a combination of a simple external and a filter in the POM Modified: tomcat/sandbox/trunk-maven-layout/tomcat-api/pom.xml tomcat/sandbox/trunk-mave

svn commit: r1625781 - in /tomcat/sandbox/trunk-maven-layout/tomcat-servlet-api: pom.xml src/test/java/ src/test/java/javax/ src/test/javax/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 19:47:19 2014 New Revision: 1625781 URL: http://svn.apache.org/r1625781 Log: Fix test path Tests have circular dependencies so skip the for this module Added: tomcat/sandbox/trunk-maven-layout/tomcat-servlet-api/src/test/java/ tomcat/sandbox/trunk-maven-layo

[Bug 56989] Classes being loaded from wrong web app.

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56989 --- Comment #4 from Konstantin Kolinko --- You may try running with a debugger http://wiki.apache.org/tomcat/FAQ/Developing#Debugging With a breakpoint in static method SecurityContextHolder.initialize(). It may be interesting to know what

svn commit: r1625775 - in /tomcat/sandbox/trunk-maven-layout/tomcat-servlet-api: pom.xml src/main/java/javax/ src/test/ src/test/javax/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 19:29:11 2014 New Revision: 1625775 URL: http://svn.apache.org/r1625775 Log: Complete tomcat-servlet-api module with a combination of a simple external and a filter in the POM Added: tomcat/sandbox/trunk-maven-layout/tomcat-servlet-api/src/test/ tomcat/sand

svn commit: r1625774 - in /tomcat/sandbox/trunk-maven-layout/tomcat-servlet-api/src: ./ main/ main/java/ main/java/javax/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 19:22:55 2014 New Revision: 1625774 URL: http://svn.apache.org/r1625774 Log: Start work on sevrlet-api Added: tomcat/sandbox/trunk-maven-layout/tomcat-servlet-api/src/ tomcat/sandbox/trunk-maven-layout/tomcat-servlet-api/src/main/ tomcat/sandbox/trunk-ma

svn commit: r1625773 - in /tomcat/sandbox/trunk-maven-layout/tomcat-api/src: ./ main/ main/java/ main/java/org/ main/java/org/apache/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 19:18:57 2014 New Revision: 1625773 URL: http://svn.apache.org/r1625773 Log: Start work on tomcat-api module Added: tomcat/sandbox/trunk-maven-layout/tomcat-api/src/ tomcat/sandbox/trunk-maven-layout/tomcat-api/src/main/ tomcat/sandbox/trunk-maven-layout

svn commit: r1625769 - /tomcat/trunk/build.xml

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 19:17:28 2014 New Revision: 1625769 URL: http://svn.apache.org/r1625769 Log: Avoid creating empty package in JAR Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1625769&r1=1625768&r

[Bug 56989] Classes being loaded from wrong web app.

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56989 --- Comment #3 from Mel Martinez --- Sigh. Some typos. I wish Bugzilla allowed us to edit comments. - should be The issue is that a) the SecurityContextHolder class has a static reference to a 'strategy' object. b) When a reques

[Bug 56989] Classes being loaded from wrong web app.

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56989 --- Comment #2 from Mel Martinez --- Hi Konstantin, Thanks for your quick response on this topic. I will try to find the time to throw together a pair of sample web apps that will reproduce the problem (I cannot provide our actual project

[Bug 56397] Establish parallel Maven-based build process

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #13 from Mark Thomas --- Mmm. Because of what needs to be filtered, the use of externals is going to get painful for some modules. I'm wondering if there is a better solution. The modules aspect of this is good. Is it possible

svn commit: r1625744 - in /tomcat/sandbox/trunk-maven-layout/tomcat-util: pom.xml src/main/java/org/apache/tomcat/ src/test/java/org/apache/tomcat/util/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 18:51:15 2014 New Revision: 1625744 URL: http://svn.apache.org/r1625744 Log: Complete tomcat-util including tests Modified: tomcat/sandbox/trunk-maven-layout/tomcat-util/pom.xml tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/java/org/apache/tomcat/

svn commit: r1625737 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/server/UpgradeUtil.java

2014-09-17 Thread violetagg
Author: violetagg Date: Wed Sep 17 18:46:38 2014 New Revision: 1625737 URL: http://svn.apache.org/r1625737 Log: Merged revision 1623695 from tomcat/trunk: Switch creation of the SHA-1 digest required to generate a WebSocket upgrade to use the ConcurrentMessageDigest rather than using a dedicated

svn commit: r1625735 - in /tomcat/trunk/java/org/apache/tomcat/util/threads: Constants.java TaskThreadFactory.java

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 18:43:21 2014 New Revision: 1625735 URL: http://svn.apache.org/r1625735 Log: Fix cyclic dependency Modified: tomcat/trunk/java/org/apache/tomcat/util/threads/Constants.java tomcat/trunk/java/org/apache/tomcat/util/threads/TaskThreadFactory.java Modified: to

svn commit: r1625734 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/security/ConcurrentMessageDigest.java

2014-09-17 Thread violetagg
Author: violetagg Date: Wed Sep 17 18:41:26 2014 New Revision: 1625734 URL: http://svn.apache.org/r1625734 Log: Merged revision 1623693 from tomcat/trunk: Add SHA-1 support Add support for input consisting of multiply byte arrays (both changes are prep for switching WebSocket to use this utility c

svn commit: r1625733 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/authenticator/ java/org/apache/catalina/realm/ java/org/apache/catalina/servlets/ java/org/apache/catalina/util/ java/org/a

2014-09-17 Thread violetagg
Author: violetagg Date: Wed Sep 17 18:38:05 2014 New Revision: 1625733 URL: http://svn.apache.org/r1625733 Log: Merged revision 1623685 from tomcat/trunk: Move MessageDigest utility classes from o.a.catalina.util to o.a.tomcat.util.security so they are more widely available. Added: tomcat/t

svn commit: r1625727 - in /tomcat/sandbox/trunk-maven-layout/tomcat-util/src: ./ main/ main/java/ main/java/org/ main/java/org/apache/ main/java/org/apache/tomcat/ main/java/org/apache/tomcat/util/ te

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 18:35:00 2014 New Revision: 1625727 URL: http://svn.apache.org/r1625727 Log: Start on tomcat-util module Added: tomcat/sandbox/trunk-maven-layout/tomcat-util/src/ tomcat/sandbox/trunk-maven-layout/tomcat-util/src/main/ tomcat/sandbox/trunk-maven-layout/t

svn commit: r1625719 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java

2014-09-17 Thread violetagg
Author: violetagg Date: Wed Sep 17 18:06:28 2014 New Revision: 1625719 URL: http://svn.apache.org/r1625719 Log: Merged revision 1618835 from tomcat/trunk: Add plumbing to write reserved bits as set in the MessagePart rather than hard-coding them to 0. Re-order method parameters for writing header

[Bug 56989] Classes being loaded from wrong web app.

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56989 Konstantin Kolinko changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from

[Bug 56989] Classes being loaded from wrong web app.

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56989 Mel Martinez changed: What|Removed |Added CC||m.marti...@ll.mit.edu -- You are r

[Bug 56989] New: Classes being loaded from wrong web app.

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56989 Bug ID: 56989 Summary: Classes being loaded from wrong web app. Product: Tomcat 7 Version: 7.0.55 Hardware: All OS: All Status: NEW Severity: critic

svn commit: r1625623 - in /tomcat/tc7.0.x/trunk: ./ BUILDING.txt

2014-09-17 Thread kkolinko
Author: kkolinko Date: Wed Sep 17 15:03:45 2014 New Revision: 1625623 URL: http://svn.apache.org/r1625623 Log: Add a note about creating release builds on non-Windows platforms. It is merge of r1553126 from tomcat/trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/tru

svn commit: r1625619 - in /tomcat/sandbox/trunk-maven-layout/tomcat-juli/src: main/java/org/apache/ test/java/org/apache/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 14:53:32 2014 New Revision: 1625619 URL: http://svn.apache.org/r1625619 Log: Switch to externals relative to repository root as suggested by kkolinko Modified: tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/main/java/org/apache/ (props changed) tomcat/

svn commit: r1625618 - /tomcat/sandbox/trunk-maven-layout/pom.xml

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 14:52:06 2014 New Revision: 1625618 URL: http://svn.apache.org/r1625618 Log: Add AL2 header Modified: tomcat/sandbox/trunk-maven-layout/pom.xml Modified: tomcat/sandbox/trunk-maven-layout/pom.xml URL: http://svn.apache.org/viewvc/tomcat/sandbox/trunk-maven-lay

Re: svn commit: r1625596 - in /tomcat/sandbox/trunk-maven-layout/tomcat-juli/src: ./ main/ main/java/ main/java/org/ main/java/org/apache/

2014-09-17 Thread Mark Thomas
On 17/09/2014 15:29, Konstantin Kolinko wrote: > 2014-09-17 18:06 GMT+04:00 : >> Author: markt >> Date: Wed Sep 17 14:06:12 2014 >> New Revision: 1625596 >> >> URL: http://svn.apache.org/r1625596 >> Log: >> Start populating JULI as it should have no dependencies >> >> Added: >> tomcat/sandbox/

svn commit: r1625616 - in /tomcat/sandbox/trunk-maven-layout: pom.xml tomcat-juli/pom.xml

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 14:45:59 2014 New Revision: 1625616 URL: http://svn.apache.org/r1625616 Log: Add junit dependency required to run unit tests Modified: tomcat/sandbox/trunk-maven-layout/pom.xml tomcat/sandbox/trunk-maven-layout/tomcat-juli/pom.xml Modified: tomcat/sandbox/t

svn commit: r1625612 - in /tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/test: ./ java/ java/org/ java/org/apache/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 14:33:08 2014 New Revision: 1625612 URL: http://svn.apache.org/r1625612 Log: Link in JULI test resources Added: tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/test/ tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/test/java/ tomcat/sandbox/trunk-mave

Re: svn commit: r1625596 - in /tomcat/sandbox/trunk-maven-layout/tomcat-juli/src: ./ main/ main/java/ main/java/org/ main/java/org/apache/

2014-09-17 Thread Konstantin Kolinko
2014-09-17 18:06 GMT+04:00 : > Author: markt > Date: Wed Sep 17 14:06:12 2014 > New Revision: 1625596 > > URL: http://svn.apache.org/r1625596 > Log: > Start populating JULI as it should have no dependencies > > Added: > tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/ > tomcat/sandbox/tr

svn commit: r1625609 - /tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/main/java/org/apache/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 14:27:03 2014 New Revision: 1625609 URL: http://svn.apache.org/r1625609 Log: Fix the external Modified: tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/main/java/org/apache/ (props changed) Propchange: tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/mai

[Bug 56397] Establish parallel Maven-based build process

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #12 from Mark Thomas --- I am making progress. The structure is in svn, the sources for JULI are hooked up via externals and the tomcat-juli-8.0.13-SNAPSHOT.jar that is created looks reasonable (I haven't tested it). If we want

[Bug 56988] Allow to use relative paths in base.path setting when building Tomcat, e.g. "base.path=../libraries"

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56988 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|-

svn commit: r1625606 - in /tomcat/tc7.0.x/trunk: ./ build.xml webapps/docs/changelog.xml

2014-09-17 Thread kkolinko
Author: kkolinko Date: Wed Sep 17 14:17:04 2014 New Revision: 1625606 URL: http://svn.apache.org/r1625606 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56988 Allow to use relative paths in base.path setting when building Tomcat, e.g. "base.path=../libraries" Use consistent naming fo

[Bug 56923] Symlinks under WEB-INF/lib trigger a NullPointerException in StandardJarScanner

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56923 --- Comment #4 from Emmanuel Bourg --- Adding to the context solved the issue, thank you for the help Mark. -- You are receiving this mail because: You are the assignee for the bug. --

svn commit: r1625599 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml

2014-09-17 Thread kkolinko
Author: kkolinko Date: Wed Sep 17 14:09:02 2014 New Revision: 1625599 URL: http://svn.apache.org/r1625599 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56988 Allow to use relative paths in base.path setting when building Tomcat, e.g. "base.path=../libraries" Use consistent naming fo

svn commit: r1625596 - in /tomcat/sandbox/trunk-maven-layout/tomcat-juli/src: ./ main/ main/java/ main/java/org/ main/java/org/apache/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 14:06:12 2014 New Revision: 1625596 URL: http://svn.apache.org/r1625596 Log: Start populating JULI as it should have no dependencies Added: tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/ tomcat/sandbox/trunk-maven-layout/tomcat-juli/src/main/ tomcat/

svn commit: r1625595 - in /tomcat/sandbox/trunk-maven-layout: ./ catalina/ tomcat-annotations-api/ tomcat-api/ tomcat-catalina-ant/ tomcat-catalina-ha/ tomcat-catalina-jmx-remote/ tomcat-catalina-ws/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 14:00:48 2014 New Revision: 1625595 URL: http://svn.apache.org/r1625595 Log: Start to look at https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 Use the provided directory structure and POMs. No svn externals to pull in source have been added at this point. Ad

svn commit: r1625580 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/pojo/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/

2014-09-17 Thread violetagg
Author: violetagg Date: Wed Sep 17 13:27:37 2014 New Revision: 1625580 URL: http://svn.apache.org/r1625580 Log: Merged revision 1623236 from tomcat/trunk: Fix some checkstyle GenericWhitespace issues. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/

[Bug 56923] Symlinks under WEB-INF/lib trigger a NullPointerException in StandardJarScanner

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56923 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1625578 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java java/org/apache/tomcat/websocket/server/WsServerContainer.java

2014-09-17 Thread violetagg
Author: violetagg Date: Wed Sep 17 13:22:42 2014 New Revision: 1625578 URL: http://svn.apache.org/r1625578 Log: Merged revisions 1621698, 1622259 from tomcat/trunk: - Correct typo in a comment - No need for volatile. Can be final. Reported by FindBugs. Modified: tomcat/tc7.0.x/trunk/ (props

[Bug 56923] Symlinks under WEB-INF/lib trigger a NullPointerException in StandardJarScanner

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56923 Emmanuel Bourg changed: What|Removed |Added Status|RESOLVED|REOPENED Version|8.0.9

[Bug 56953] A improvement for "DataInputStream"

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56953 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 56955] Skip some useless information in the class when parsing

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56955 Bug 56955 depends on bug 56953, which changed state. Bug 56953 Summary: A improvement for "DataInputStream" https://issues.apache.org/bugzilla/show_bug.cgi?id=56953 What|Removed |Added

svn commit: r1625564 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/FastDataInputStream.java

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 13:00:41 2014 New Revision: 1625564 URL: http://svn.apache.org/r1625564 Log: Review comments from kkolinko Port of 1625563 from trunk Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)

[Bug 56397] Establish parallel Maven-based build process

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #11 from Pierre Viret --- Sorry about the circular dependency I forgot to mention that tomcat-coyote needs tomcat-util to compile, so tomcat-util may not depend on the tomcat-coyote. -- You are receiving this mail because: You

svn commit: r1625563 - /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/FastDataInputStream.java

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:59:55 2014 New Revision: 1625563 URL: http://svn.apache.org/r1625563 Log: Review comments from kkolinko Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/FastDataInputStream.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/class

[Bug 56953] A improvement for "DataInputStream"

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56953 --- Comment #16 from Mark Thomas --- Patch has been applied to 7.0.x for 7.0.56 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To u

svn commit: r1625562 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java

2014-09-17 Thread violetagg
Author: violetagg Date: Wed Sep 17 12:44:09 2014 New Revision: 1625562 URL: http://svn.apache.org/r1625562 Log: Merged revision 1619742 from tomcat/trunk: WebSocket permessage-deflate. Implement no_context_takeover parameters. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0

svn commit: r1625559 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/ClassParser.java java/org/apache/tomcat/util/bcel/classfile/FastDataInp

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:43:09 2014 New Revision: 1625559 URL: http://svn.apache.org/r1625559 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56953 Further performance improvements to BCEL parser. Based on a patch by hzhang9 POrt of r1625504 from trunk Added: tomcat/tc7.

svn commit: r1625558 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:42:29 2014 New Revision: 1625558 URL: http://svn.apache.org/r1625558 Log: Use the DataInput interface rather than an implementation. Port of r1625501 from trunk Also Align 7.0.x with trunk after comparing the two Modified: tomcat/tc7.0.x/trunk/ (props chan

svn commit: r1625557 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/AccessFlags.java java/org/apache/tomcat/util/bcel/classfile/JavaClass.j

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:35:00 2014 New Revision: 1625557 URL: http://svn.apache.org/r1625557 Log: Merge AccessFlags and JavaClass as the other sub-classes of AccessFlags have been removed. Port of r1624959 from trunk Removed: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/cl

svn commit: r1625556 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/ClassParser.java

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:34:03 2014 New Revision: 1625556 URL: http://svn.apache.org/r1625556 Log: Remove branch that is not used by Tomcat. Thanks to Cobertura coverage report. Port of r1624648 from trunk Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/jav

svn commit: r1625555 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/ClassParser.java te

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:30:32 2014 New Revision: 162 URL: http://svn.apache.org/r162 Log: Remove class_name argument from constructor, as Tomcat does not provide the name. Port of r1624647 from trunk Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk

svn commit: r1625554 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/ConstantPool.java java/org/apache/tomcat/util/bcel/classfile/Utility.ja

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:27:52 2014 New Revision: 1625554 URL: http://svn.apache.org/r1625554 Log: Inline ConstantPool.getConstantString() method. Port of r1624645 from trunk Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/

[Bug 56988] New: Allow to use relative paths in base.path setting when building Tomcat, e.g. "base.path=../libraries"

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56988 Bug ID: 56988 Summary: Allow to use relative paths in base.path setting when building Tomcat, e.g. "base.path=../libraries" Product: Tomcat 7 Version: 7.0.55 Hardware

svn commit: r1625553 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:26:53 2014 New Revision: 1625553 URL: http://svn.apache.org/r1625553 Log: Move int -> String mapping for class and interface names from JavaClass to ClassParser. This avoids an intermediary int[] array. Move commons classname lookup and compact code into a helper

svn commit: r1625552 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/ClassParser.java java/org/apache/tomcat/util/bcel/classfile/JavaClass.j

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:25:43 2014 New Revision: 1625552 URL: http://svn.apache.org/r1625552 Log: Do not create an empty arrays when Class has no interfaces. Skip creation of int[] indexes array and share the same empty String[] names array. Port of r1624636 from trunk Modified: to

svn commit: r1625551 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:24:28 2014 New Revision: 1625551 URL: http://svn.apache.org/r1625551 Log: Get rid of ArrayList arithmetics in JavaClass.getAnnotationEntries() Note that this changes return value of getAnnotationEntries() to be null instead of zero-length array by default. This

svn commit: r1625547 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:21:05 2014 New Revision: 1625547 URL: http://svn.apache.org/r1625547 Log: Flatten class hierarchy. The only subtype of Annotations class is RuntimeVisibleAnnotations. Port of r1624605 from trunk Removed: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bce

svn commit: r1625546 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:19:45 2014 New Revision: 1625546 URL: http://svn.apache.org/r1625546 Log: Remove RuntimeVisibleParameterAnnotations and its supporting classes. The fields in these classes have no getters (especially ParameterAnnotationEntry.annotation_table). As such, informatio

[Bug 56397] Establish parallel Maven-based build process

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #10 from Pierre Viret --- Thank you very much for your feedback. 1) About the circular dependency: the pattern for the tomcat-coyote component selects the file "org/apache/tomcat/util/net/Constants.java". This class is referenc

svn commit: r1625536 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 12:03:10 2014 New Revision: 1625536 URL: http://svn.apache.org/r1625536 Log: Add 'final' modifiers to fields. Remove several num_xxx fields that accompanied an xxx array. Port of r1624592 from trunk Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc

Re: buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-09-17 Thread Konstantin Kolinko
2014-09-17 14:42 GMT+04:00 : > The Buildbot has detected a new failure on builder tomcat-7-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-7-trunk/builds/296 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for this Build: silvan

svn commit: r1625516 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/classfile/ConstantPool.java

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 11:15:23 2014 New Revision: 1625516 URL: http://svn.apache.org/r1625516 Log: Remove constant_pool_count field. The field is never read, and its value is known from the length of constant_pool array created in constructor. Backport of r1624588 from trunk Modified:

svn commit: r1625515 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/bcel/ java/org/apache/tomcat/util/bcel/Constants.java java/org/apache/tomcat/util/bcel/classfile/Attribute.java

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 11:14:39 2014 New Revision: 1625515 URL: http://svn.apache.org/r1625515 Log: Simplify. There is no real need to convert every attribute name into numeric tag via lookup table, when there are only two attribute names that we recognize. In the old code there was an a

[Bug 56953] A improvement for "DataInputStream"

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56953 --- Comment #15 from Konstantin Kolinko --- OK, this is better. 1. Formatting: the code shall not use tab characters 2. In "skipBytes(int n)": there is no reason to call "fillNew()" after calling "in.skip(n - sum)" on the underlying stre

[Bug 56397] Establish parallel Maven-based build process

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #9 from Mark Thomas --- Thanks for this. I still want to try and create the svn externals as that means the Maven build would be based directly on svn and folks would be able to commit / propose patches / merge updates much more

buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-09-17 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/296 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: scheduler Build Sou

svn commit: r1625506 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/MessagePart.java java/org/apache/tomcat/websocket/PerMessageDeflate.java java/org/apache/tomcat/websocket/WsRemoteE

2014-09-17 Thread violetagg
Author: violetagg Date: Wed Sep 17 10:37:10 2014 New Revision: 1625506 URL: http://svn.apache.org/r1625506 Log: Merged revision 1619738 from tomcat/trunk: Extend support for the WebSocket permessage-deflate extension to compression of outgoing messages on the server side. Modified: tomcat/tc

[Bug 56953] A improvement for "DataInputStream"

2014-09-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56953 --- Comment #14 from Mark Thomas --- Thanks for the updated patches. I see a 20-25% improvement with the patch so it has been applied to 8.0.x for 8.0.13 onwards. I'll look into porting it to 7.0.x. -- You are receiving this mail because

svn commit: r1625504 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: ClassParser.java FastDataInputStream.java

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 10:34:51 2014 New Revision: 1625504 URL: http://svn.apache.org/r1625504 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56953 Further performance improvements to BCEL parser. Based on a patch by hzhang9 Added: tomcat/trunk/java/org/apache/tomcat/uti

svn commit: r1625501 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: AnnotationEntry.java Annotations.java ClassParser.java Constant.java ConstantPool.java ConstantUtf8.java ElementValu

2014-09-17 Thread markt
Author: markt Date: Wed Sep 17 10:28:19 2014 New Revision: 1625501 URL: http://svn.apache.org/r1625501 Log: Use the DataInput interface rather than an implementation Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationEntry.java tomcat/trunk/java/org/apache/tomcat/

Re: JMX loose ends

2014-09-17 Thread Mark Thomas
On 17/09/2014 02:05, Alarcón Vladimir wrote: > Hi, this is my first email here. > > I was looking at the JMX MBeans through j-console and I found some > loose ends here and there. It's not much, but I think I can help > fixing them. > > First, things first: Are you interested on help with the bug

  1   2   >