svn commit: r1625472 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java

2014-09-16 Thread violetagg
Author: violetagg Date: Wed Sep 17 06:43:50 2014 New Revision: 1625472 URL: http://svn.apache.org/r1625472 Log: Merged revisions 1618688, 1618704, 1618830 from tomcat/trunk: - Whitespace - Add a little plumbing for outgoing messages (no actual compression yet) - Make a couple of fields volatile th

svn commit: r1625471 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsWebSocketContainer.java

2014-09-16 Thread violetagg
Author: violetagg Date: Wed Sep 17 06:36:35 2014 New Revision: 1625471 URL: http://svn.apache.org/r1625471 Log: Merged revision 1606653 from tomcat/trunk: Fix root cause of NPE when using WebSocket clients. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/ap

svn commit: r1625470 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/

2014-09-16 Thread violetagg
Author: violetagg Date: Wed Sep 17 06:31:22 2014 New Revision: 1625470 URL: http://svn.apache.org/r1625470 Log: Merged revisions 1606103 from tomcat/trunk: Plumbing to enable transformation / extension processing for outgoing server messages. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1625469 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java

2014-09-16 Thread violetagg
Author: violetagg Date: Wed Sep 17 06:20:08 2014 New Revision: 1625469 URL: http://svn.apache.org/r1625469 Log: Merged revisions 1560817, 1561623, 1606072 from tomcat/trunk: - Fix some arcane introspection errors. - Add a TODO to remind me to come back and look at this - Correct comment Modified:

svn commit: r1625466 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/LocalStrings.properties java/org/apache/tomcat/websocket/TransformationFactory.java

2014-09-16 Thread violetagg
Author: violetagg Date: Wed Sep 17 05:40:06 2014 New Revision: 1625466 URL: http://svn.apache.org/r1625466 Log: Merged revisions 1605890,1605891 from tomcat/trunk: - Fix an i18n TODO - This time with the unsupported extension name Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/

svn commit: r1625464 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/MessagePart.java java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java

2014-09-16 Thread violetagg
Author: violetagg Date: Wed Sep 17 05:37:12 2014 New Revision: 1625464 URL: http://svn.apache.org/r1625464 Log: Merged revisions 1605821, 1605823 from tomcat/trunk: Refactoring with a view to adding transformation (i.e. extension) support to outgoing messages. Extract MessagePart into standalone

JMX loose ends

2014-09-16 Thread Alarcón Vladimir
Hi, this is my first email here. I was looking at the JMX MBeans through j-console and I found some loose ends here and there. It's not much, but I think I can help fixing them. First, things first: Are you interested on help with the bug fixes? Second: if you are interested, how should I proce

[Bug 54703] Nullpointer exception in HttpParser.parseMediaType

2014-09-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54703 --- Comment #8 from Greg Wilkins --- Note that such folded headers have been deprecated by RFC7230: http://tools.ietf.org/html/rfc7230#section-3.2.4 -- You are receiving this mail because: You are the assignee for the bug. --

JMX loose ends

2014-09-16 Thread Alarcón Vladimir
Hi, this is my first email here. I was looking at the JMX MBeans through j-console and I found some loose ends here and there. It's not much, but I think I can help fixing them. First, things first: Are you interested on help with the bug fixes? Second: if you are interested, how should I proc

Re: Discussion of pluggable password-derivation in Realms [Bug 56403]

2014-09-16 Thread Christopher Schultz
Mark, On 9/16/14 3:39 PM, Mark Thomas wrote: > Updated patch: > http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v2.patch Looks good, but its missing a configuration for the digester to actually read the configuration and set-up the CredentialHandler objects at runtime. Existing Me

Re: Discussion of pluggable password-derivation in Realms [Bug 56403]

2014-09-16 Thread Christopher Schultz
Mark, On 9/16/14 3:39 PM, Mark Thomas wrote: > On 16/09/2014 16:20, Christopher Schultz wrote: >> 1. In terms of limiting converting to String values, we could base >> everything on byte[] instead of String. > > Having looked at the current code and the Servlet API I don't believe > that this is

Re: Discussion of pluggable password-derivation in Realms [Bug 56403]

2014-09-16 Thread Christopher Schultz
Mark, On 9/16/14 12:46 PM, Mark Thomas wrote: > On 16/09/2014 17:17, Mark Thomas wrote: >> On 16/09/2014 16:20, Christopher Schultz wrote: > >>> 2. I don't like CredentialHandler.mutate(String input, byte[] salt, int >>> iterations). I think it ties the method signature to the implementation >>>

svn commit: r1625385 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ webapps/docs/

2014-09-16 Thread violetagg
Author: violetagg Date: Tue Sep 16 20:41:29 2014 New Revision: 1625385 URL: http://svn.apache.org/r1625385 Log: Merged revision 1605454 from tomcat/trunk: Handle preference selection for multiple extension headers with the same name Tighten up parameter validation for permessage-deflate Modified:

svn commit: r1625382 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/PerMessageDeflate.java java/org/apache/tomcat/websocket/Transformation.java java/org/apache/tomcat/websocket/WsFram

2014-09-16 Thread violetagg
Author: violetagg Date: Tue Sep 16 20:27:49 2014 New Revision: 1625382 URL: http://svn.apache.org/r1625382 Log: Merged revisions 1605066,1605417 from tomcat/trunk: - Handle decompression for messages split across multiple frames. - Fix copy/paste error in r1605054 Control messages should be read i

svn commit: r1625379 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/Util.java java/org/apache/tomcat/websocket/WsFrameBase.java

2014-09-16 Thread violetagg
Author: violetagg Date: Tue Sep 16 20:21:02 2014 New Revision: 1625379 URL: http://svn.apache.org/r1625379 Log: Merged revision 1605061 from tomcat/trunk: Add a new utility method and make use of it (will also be used in permessage-deflate) Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1625372 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/

2014-09-16 Thread violetagg
Author: violetagg Date: Tue Sep 16 20:15:51 2014 New Revision: 1625372 URL: http://svn.apache.org/r1625372 Log: Merged revision 1605054 from tomcat/trunk: Refactor transformations to enable the handing of overflow (the previous code ignored this possibility). Added: tomcat/tc7.0.x/trunk/jav

svn commit: r1625368 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/

2014-09-16 Thread violetagg
Author: violetagg Date: Tue Sep 16 20:07:55 2014 New Revision: 1625368 URL: http://svn.apache.org/r1625368 Log: Merged revisions 1604822,1604833 from tomcat/trunk: - Add plumbing to enable permessage-deflate implementation - This is still a work-in-progress - Trivial format change Modified: t

Re: Discussion of pluggable password-derivation in Realms [Bug 56403]

2014-09-16 Thread Mark Thomas
On 16/09/2014 16:20, Christopher Schultz wrote: > 1. In terms of limiting converting to String values, we could base > everything on byte[] instead of String. Having looked at the current code and the Servlet API I don't believe that this is practical. > 2. I don't like CredentialHandler.mutate(

svn commit: r1625362 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/

2014-09-16 Thread violetagg
Author: violetagg Date: Tue Sep 16 19:37:54 2014 New Revision: 1625362 URL: http://svn.apache.org/r1625362 Log: Merged revision 1604810 from tomcat/trunk: Add the initial implementation for the permessage-deflate implementation This is a work-in-progress - There are still multiple Autobahn failure

Re: Discussion of pluggable password-derivation in Realms [Bug 56403]

2014-09-16 Thread Mark Thomas
On 16/09/2014 16:20, Christopher Schultz wrote: > StringBuilder credential = new StringBuilder(saltLength << 1 + > serverCredential.length() + 10 + 2); > credential.append(HexUtils.toString(salt)) > .append('$') > .append(iterations) > .append('$') >

Re: Discussion of pluggable password-derivation in Realms [Bug 56403]

2014-09-16 Thread Mark Thomas
On 16/09/2014 17:17, Mark Thomas wrote: > On 16/09/2014 16:20, Christopher Schultz wrote: >> 2. I don't like CredentialHandler.mutate(String input, byte[] salt, int >> iterations). I think it ties the method signature to the implementation >> of the mutation algorithm. PBKDF2 for instance has both

Re: Discussion of pluggable password-derivation in Realms [Bug 56403]

2014-09-16 Thread Mark Thomas
On 16/09/2014 16:20, Christopher Schultz wrote: > All, > > In reference to bug 56403 > (https://issues.apache.org/bugzilla/show_bug.cgi?id=56403) and > specifically markt's proposed patch > (http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v1.patch), > I have the following comments.

Discussion of pluggable password-derivation in Realms [Bug 56403]

2014-09-16 Thread Christopher Schultz
All, In reference to bug 56403 (https://issues.apache.org/bugzilla/show_bug.cgi?id=56403) and specifically markt's proposed patch (http://people.apache.org/~markt/patches/2014-09-16-bug56403-tc8-v1.patch), I have the following comments. I'm interested in what others have to say. 1. In terms of l

[Bug 56403] Support pluggable password-derivation in Realms

2014-09-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56403 S changed: What|Removed |Added CC||bl...@gmx.net -- You are receiving this mail

[Bug 55524] Deadlock produced during Websocket write operation (org.apache.catalina.websocket.WsOutbound)

2014-09-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55524 --- Comment #9 from Dmitry Treskunov --- Looking at the changelog http://tomcat.apache.org/tomcat-7.0-doc/changelog.html I see that "Avoid a possible deadlock when one thread is shutting down a connection while another thread is trying to

[Bug 56403] Support pluggable password-derivation in Realms

2014-09-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56403 --- Comment #12 from Mark Thomas --- OK. Here is my first pass at incorporating these ideas in Tomcat 8. I spent a fair amount of time looking at how to keep existing configurations working while not making the API a complete mess. I also

svn commit: r1625290 - /tomcat/trunk/java/org/apache/catalina/Realm.java

2014-09-16 Thread markt
Author: markt Date: Tue Sep 16 13:55:15 2014 New Revision: 1625290 URL: http://svn.apache.org/r1625290 Log: Fix formatting Modified: tomcat/trunk/java/org/apache/catalina/Realm.java Modified: tomcat/trunk/java/org/apache/catalina/Realm.java URL: http://svn.apache.org/viewvc/tomcat/trunk/jav

svn commit: r1625289 - in /tomcat/trunk: java/org/apache/tomcat/util/buf/HexUtils.java test/org/apache/tomcat/util/buf/TestHexUtils.java

2014-09-16 Thread markt
Author: markt Date: Tue Sep 16 13:55:09 2014 New Revision: 1625289 URL: http://svn.apache.org/r1625289 Log: Add hex decoding support Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/HexUtils.java tomcat/trunk/test/org/apache/tomcat/util/buf/TestHexUtils.java Modified: tomcat/trunk/

svn commit: r1625288 - /tomcat/trunk/java/org/apache/tomcat/util/buf/HexUtils.java

2014-09-16 Thread markt
Author: markt Date: Tue Sep 16 13:54:57 2014 New Revision: 1625288 URL: http://svn.apache.org/r1625288 Log: Fix formatting Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/HexUtils.java Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/HexUtils.java URL: http://svn.apache.org/vie

Re: adding an internal filter

2014-09-16 Thread Romain Manni-Bucau
2014-09-16 15:16 GMT+02:00 Konstantin Kolinko : > 2014-09-15 23:01 GMT+04:00 Romain Manni-Bucau : >> Hi guys, >> >> in TomEE I'd like to add a filter but after context filter are started >> (means filterStart() from StandardContext is called). >> > > Why? What is the use case? > we add a filter wi

Re: adding an internal filter

2014-09-16 Thread Konstantin Kolinko
2014-09-15 23:01 GMT+04:00 Romain Manni-Bucau : > Hi guys, > > in TomEE I'd like to add a filter but after context filter are started > (means filterStart() from StandardContext is called). > Why? What is the use case? You code adds filter definitions. A filter definitions just associates filter

svn commit: r1625234 - in /tomcat/trunk: java/org/apache/coyote/ajp/ webapps/docs/

2014-09-16 Thread kfujino
Author: kfujino Date: Tue Sep 16 10:10:37 2014 New Revision: 1625234 URL: http://svn.apache.org/r1625234 Log: Reduce duplicated code. All AJP connectors use common method to configuration of processor. Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProtocol.java tomcat/trunk

svn commit: r1625232 - in /tomcat/tc7.0.x/trunk: java/org/apache/coyote/ajp/AjpAprProtocol.java java/org/apache/coyote/ajp/AjpNioProtocol.java webapps/docs/changelog.xml

2014-09-16 Thread kfujino
Author: kfujino Date: Tue Sep 16 09:46:55 2014 New Revision: 1625232 URL: http://svn.apache.org/r1625232 Log: Ensure that AjpNioProtocol and AjpAprProtocol enable the KeepAliveTimeout. Modified: tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java tomcat/tc7.0.x/trunk/java/

svn commit: r1625228 - in /tomcat/trunk: java/org/apache/coyote/ajp/AjpAprProtocol.java java/org/apache/coyote/ajp/AjpNio2Protocol.java webapps/docs/changelog.xml

2014-09-16 Thread kfujino
Author: kfujino Date: Tue Sep 16 09:29:23 2014 New Revision: 1625228 URL: http://svn.apache.org/r1625228 Log: follow up r1625227. Ensure that AJP connectors enable the KeepAliveTimeout. Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java tomcat/trunk/java/org/apache/coyo

svn commit: r1625227 - in /tomcat/trunk: java/org/apache/coyote/ajp/AjpNioProtocol.java webapps/docs/changelog.xml

2014-09-16 Thread kfujino
Author: kfujino Date: Tue Sep 16 09:23:59 2014 New Revision: 1625227 URL: http://svn.apache.org/r1625227 Log: Ensure that AjpNioProtocol enable the KeepAliveTimeout. Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpNioProtocol.java tomcat/trunk/webapps/docs/changelog.xml Modified: to

Re: Compiling Tomcat 7.0.55 with Java 6

2014-09-16 Thread Mark Thomas
On 16/09/2014 05:46, Santosh Math wrote: > Hi All, > > I tried to import tomcat 7.0.55 source into eclipse with Java 6, i got few > errors related to Classes which are not present in Java 6. When i upgraded > to Java 7, it got resolved. As expected. > Does Java 7 is required for building/compili