buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/156 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1600988 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestSetCookieSupportSeparatorsAllowed.java

Author: markt Date: Fri Jun 6 19:33:36 2014 New Revision: 1600988 URL: http://svn.apache.org/r1600988 Log: Correct bug reference. These are all V1 cookies. bug 55975 is a V0 cookie issue Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestSetCookieSupportSeparatorsAllowed.java Modi

[Bug 55975] Inconsistent escaping applied to V0 cookie values

https://issues.apache.org/bugzilla/show_bug.cgi?id=55975 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1600984 - in /tomcat/trunk/java/org/apache/coyote/http11/filters: ChunkedInputFilter.java LocalStrings.properties

Author: markt Date: Fri Jun 6 19:14:07 2014 New Revision: 1600984 URL: http://svn.apache.org/r1600984 Log: i18n for ChunkedInputFilter error message Add error flag to allow subsequent attempts at reading after an error to fail fast Added: tomcat/trunk/java/org/apache/coyote/http11/filters/L

svn commit: r1600978 - /tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java

Author: markt Date: Fri Jun 6 18:38:09 2014 New Revision: 1600978 URL: http://svn.apache.org/r1600978 Log: Clean-up. No functional change. Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedInputFilter.java Modified: tomcat/trunk/java/org/apache/coyote/http11/filters/Chunk

buildbot success in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/101 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sou

Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2014-06-06 18:39 GMT+02:00 Konstantin Kolinko : > 1. Doesn't it feel too early? > Maybe, but tests pass and no reports. > > 2. You only removed a startup warning. I think the documentation still > labels it as beta. > This could be a good middle ground. Rémy

svn commit: r1600965 - in /tomcat/trunk/java/org/apache/catalina: core/StandardHostValve.java valves/ErrorReportValve.java

Author: markt Date: Fri Jun 6 17:14:19 2014 New Revision: 1600965 URL: http://svn.apache.org/r1600965 Log: kkolinko review Use finishResponse() rather than flushBuffer to avoid chunking if not necessary. Add finishResponse() to ErrorReportValve.report() Don;t try and reset the response if it has

Re: Error handling

On 06/06/2014 18:01, Mark Thomas wrote: > On 06/06/2014 12:29, Konstantin Kolinko wrote: > > > >> Reviewing r1600449 and followups. >> >> // ErrorReportValve.java >> [[[ >> if (response.isCommitted()) { >> if (response.isErrorAfterCommit()) { >> // Flush any d

Re: Error handling

On 06/06/2014 12:29, Konstantin Kolinko wrote: > Reviewing r1600449 and followups. > > // ErrorReportValve.java > [[[ > if (response.isCommitted()) { > if (response.isErrorAfterCommit()) { > // Flush any data that is still to be written to the client >

svn commit: r1600963 - /tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

Author: markt Date: Fri Jun 6 16:58:02 2014 New Revision: 1600963 URL: http://svn.apache.org/r1600963 Log: Handle exceptions when trying to flush the response. Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Modified: tomcat/trunk/java/org/apache/catalina/valves

[Bug 56573] [Spec?] Session.getRequestURI() doesn't return the protocol, port etc.

https://issues.apache.org/bugzilla/show_bug.cgi?id=56573 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1600961 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/server/ webapps/docs/

Author: markt Date: Fri Jun 6 16:50:24 2014 New Revision: 1600961 URL: http://svn.apache.org/r1600961 Log: Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56573 The fix triggered a TCK failure Removed: tomcat/trunk/test/org/apache/tomcat/websocket/server/TestWsHandshakeReq

svn commit: r1600960 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/server/ webapps/docs/

Author: markt Date: Fri Jun 6 16:49:21 2014 New Revision: 1600960 URL: http://svn.apache.org/r1600960 Log: Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56573 The fix triggered a TCK failure Removed: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/server/TestWsHand

[Bug 56573] [Spec?] Session.getRequestURI() doesn't return the protocol, port etc.

https://issues.apache.org/bugzilla/show_bug.cgi?id=56573 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2014-06-06 20:17 GMT+04:00 Rémy Maucherat : > 2014-06-06 18:14 GMT+02:00 : > >> Author: remm >> Date: Fri Jun 6 16:14:44 2014 >> New Revision: 1600950 >> >> URL: http://svn.apache.org/r1600950 >> Log: >> Try removing the beta tag from the NIO2 connector to get more feedback, >> after the latest ro

[Bug 56600] Missing "return" statements in WebdavServlet.doPropfind()

https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|-

svn commit: r1600958 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: kkolinko Date: Fri Jun 6 16:34:49 2014 New Revision: 1600958 URL: http://svn.apache.org/r1600958 Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1600958&r1=160095

svn commit: r1600957 - /tomcat/trunk/webapps/docs/changelog.xml

Author: kkolinko Date: Fri Jun 6 16:31:53 2014 New Revision: 1600957 URL: http://svn.apache.org/r1600957 Log: Correct a typo. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/chan

svn commit: r1600956 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: kkolinko Date: Fri Jun 6 16:30:50 2014 New Revision: 1600956 URL: http://svn.apache.org/r1600956 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 Fix missing "return;" statements after sendError(): do not waste time generating response for PROPFIND requests that contain b

svn commit: r1600955 - in /tomcat/trunk: java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

Author: kkolinko Date: Fri Jun 6 16:24:32 2014 New Revision: 1600955 URL: http://svn.apache.org/r1600955 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 Fix missing "return;" statements after sendError(): do not waste time generating response for PROPFIND requests that contain b

Re: svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

2014-06-06 18:14 GMT+02:00 : > Author: remm > Date: Fri Jun 6 16:14:44 2014 > New Revision: 1600950 > > URL: http://svn.apache.org/r1600950 > Log: > Try removing the beta tag from the NIO2 connector to get more feedback, > after the latest round of fixes. In practice since it is not used by > def

svn commit: r1600950 - in /tomcat/trunk: java/org/apache/tomcat/util/net/Nio2Endpoint.java webapps/docs/changelog.xml

Author: remm Date: Fri Jun 6 16:14:44 2014 New Revision: 1600950 URL: http://svn.apache.org/r1600950 Log: Try removing the beta tag from the NIO2 connector to get more feedback, after the latest round of fixes. In practice since it is not used by default, it doesn't change much. Modified:

[Bug 56600] New: Missing "return" statements in WebdavServlet.doPropfind()

https://issues.apache.org/bugzilla/show_bug.cgi?id=56600 Bug ID: 56600 Summary: Missing "return" statements in WebdavServlet.doPropfind() Product: Tomcat 8 Version: 8.0.8 Hardware: PC Status: NEW Sever

svn commit: r1600948 - /tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.java

Author: kkolinko Date: Fri Jun 6 16:09:16 2014 New Revision: 1600948 URL: http://svn.apache.org/r1600948 Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=56568 Fix missing "return" statement for JSP method name check. Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspServlet.ja

[Bug 55975] Inconsistent escaping applied to V0 cookie values

https://issues.apache.org/bugzilla/show_bug.cgi?id=55975 Konstantin Kolinko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|F

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 --- Comment #12 from Konstantin Kolinko --- (In reply to Steve Sether from comment #8) > > Furthermore though, headers like this should be insanely easy to just add to > all the headers of a domain hosted on a machine. Apache solves this

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 --- Comment #11 from Konstantin Kolinko --- (In reply to Christopher Schultz from comment #9) > > The Filter can be added to conf/web.xml and will apply to all web > applications hosted by the container. I'm not sure in what order it will

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 --- Comment #10 from Christopher Schultz --- I think there is a bug in the Filter implementation provided by Jens: The filter calls chain.doFilter() and then adds the header afterward. This isn't going to work for any request that generate

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 --- Comment #9 from Christopher Schultz --- (In reply to Steve Sether from comment #8) > I think this is an important feature for Tomcat to support out of the box. Then vote for it: there are currently 5 votes from a single person for thi

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

https://issues.apache.org/bugzilla/show_bug.cgi?id=54618 Christopher Schultz changed: What|Removed |Added Attachment #3|application/octet-stream|text/plain mime typ

[Bug 56581] When an error occurs on a long JSP page, do not loose last chunk of printed text

https://issues.apache.org/bugzilla/show_bug.cgi?id=56581 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|-

svn commit: r1600899 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

Author: kkolinko Date: Fri Jun 6 14:36:36 2014 New Revision: 1600899 URL: http://svn.apache.org/r1600899 Log: Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=56581 If an error on a JSP page occurs when response have already been committed, do not clear the buffer of JspWriter, but flush it.

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/153 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Sta

[Bug 56581] When an error occurs on a long JSP page, do not loose last chunk of printed text

https://issues.apache.org/bugzilla/show_bug.cgi?id=56581 --- Comment #3 from Konstantin Kolinko --- Looking into generated test_jsp.java, I see that _jspService method ends with the following: [[[ } catch (java.lang.Throwable t) { if (!(t instanceof javax.servlet.jsp.SkipPageException

Time for 8.0.9

As I have said before, I'd like to get back to my original plane for monthly releases of 8.0.x. With that in mind - and unless some new bugs appear in the next few hours - I plan to tag 8.0.9 later today. Mark - To unsubscribe, e

[Bug 56580] el-api.jar memory leak

https://issues.apache.org/bugzilla/show_bug.cgi?id=56580 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1600862 - /tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Processor.java

Author: kkolinko Date: Fri Jun 6 12:10:18 2014 New Revision: 1600862 URL: http://svn.apache.org/r1600862 Log: Verify that response is flushed when servlet fails with an unexpected exception. Modified: tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Processor.java Modified: tom

svn commit: r1600858 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

Author: markt Date: Fri Jun 6 12:02:38 2014 New Revision: 1600858 URL: http://svn.apache.org/r1600858 Log: Don't assume that tests use the StandardManger Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Modified: tomcat/tc7.0.x/trunk/test/org/apache/catal

Re: buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-06-06 15:37 GMT+04:00 : > The Buildbot has detected a new failure on builder tomcat-7-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-7-trunk/builds/97 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for this Build: bb-vm_u

svn commit: r1600846 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Author: kkolinko Date: Fri Jun 6 11:38:57 2014 New Revision: 1600846 URL: http://svn.apache.org/r1600846 Log: Fix ordering of changelog entries according to bug number. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL:

buildbot failure in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/97 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: Error handling

2014-05-29 16:31 GMT+04:00 Mark Thomas : > You've probably noticed I've been poking around the ErrorReportValve, > the Response objects and other related code. I've been looking into an > issue that one of the groups at $work has raised around Tomcat's error > handling and I've been cleaning things

The Early Access build for JDK 8u20 b16 is available on java.net

Hi Mark, The backport fix for JDK-8041481 is in JDK 8u20 b17 as JDK-8039751 , available for download . Can you test and report results ? Rgds,Rory -- Rg

[Bug 56578] session.invalidate does not work on cluster enabled webapps

https://issues.apache.org/bugzilla/show_bug.cgi?id=56578 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1600840 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaSession.java test/org/apache/catalina/session/TestStandardSession.java webapps/docs/changelog.xml

Author: markt Date: Fri Jun 6 10:33:15 2014 New Revision: 1600840 URL: http://svn.apache.org/r1600840 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56578 Correct regression in the fix for 56339 that prevented sessions from expiring when using clustering. The effect of removing expi

svn commit: r1600839 - in /tomcat/trunk: java/org/apache/catalina/ha/session/DeltaSession.java test/org/apache/catalina/session/TestStandardSession.java webapps/docs/changelog.xml

Author: markt Date: Fri Jun 6 10:25:49 2014 New Revision: 1600839 URL: http://svn.apache.org/r1600839 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56578 Correct regression in the fix for 56339 that prevented sessions from expiring when using clustering. The effect of removing expi

buildbot retry in ASF Buildbot on tomcat-trunk

on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/151 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1600833 Blamel

svn commit: r1600833 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

Author: markt Date: Fri Jun 6 09:19:17 2014 New Revision: 1600833 URL: http://svn.apache.org/r1600833 Log: Don't assume that tests use the StandardManger Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Modified: tomcat/trunk/test/org/apache/catalina/startup/Tomca