[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2014-03-10 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This i

buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-03-10 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1795 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

[Bug 56027] Unable to use TCN on RHEL6 boxes if box is booted in fips mode

2014-03-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56027 --- Comment #9 from Ben Mason --- (In reply to Christopher Schultz from comment #8) > Created attachment 31226 [details] > Proposed patch against Tomcat-trunk > > Feel free to adapt this patch for Tomcat 6. Chris- I am having the same is

svn commit: r1576107 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/session/package.html webapps/docs/funcspecs/fs-admin-objects.xml webapps/docs/security-howto.xml

2014-03-10 Thread rjung
Author: rjung Date: Mon Mar 10 22:11:19 2014 New Revision: 1576107 URL: http://svn.apache.org/r1576107 Log: Entropy attribute for Manager gone since TC 7. Backport of r1576104 from trunk. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/sess

svn commit: r1576104 - in /tomcat/trunk: java/org/apache/catalina/session/package.html java/org/apache/catalina/storeconfig/server-registry.xml webapps/docs/funcspecs/fs-admin-objects.xml webapps/docs

2014-03-10 Thread rjung
Author: rjung Date: Mon Mar 10 22:02:09 2014 New Revision: 1576104 URL: http://svn.apache.org/r1576104 Log: Entropy attribute for Manager gone since TC 7. Modified: tomcat/trunk/java/org/apache/catalina/session/package.html tomcat/trunk/java/org/apache/catalina/storeconfig/server-registry

svn commit: r1576097 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

2014-03-10 Thread remm
Author: remm Date: Mon Mar 10 21:42:40 2014 New Revision: 1576097 URL: http://svn.apache.org/r1576097 Log: - Closing is not an async operation, but needs to be performed, so ignore errors if some pending things are going on with SSL. - Also fix some warnings. Modified: tomcat/trunk/java/org/

buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-10 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5571 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

[Bug 56242] Deploying a Velocity-based web application can thwart Attach API connections for monitoring

2014-03-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56242 Christopher Schultz changed: What|Removed |Added OS|Mac OS X 10.4 |Mac OS X 10.9 --- Comment #2

svn commit: r1576082 - /tomcat/trunk/java/org/apache/coyote/ajp/AjpNio2Protocol.java

2014-03-10 Thread kkolinko
Author: kkolinko Date: Mon Mar 10 20:58:45 2014 New Revision: 1576082 URL: http://svn.apache.org/r1576082 Log: CheckStyle: fix order of imports Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpNio2Protocol.java Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpNio2Protocol.java URL:

svn commit: r1576079 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/mbeans-descriptors.xml

2014-03-10 Thread kkolinko
Author: kkolinko Date: Mon Mar 10 20:51:51 2014 New Revision: 1576079 URL: http://svn.apache.org/r1576079 Log: Revert r1576000 It obviously was meant to be applied for trunk, not for Tomcat 6. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/mbeans-descriptors.xml Modified: to

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2014-03-10 Thread Bill Barker
/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20140310.jar:/srv/g

svn commit: r4615 - in /release/tomcat/tomcat-connectors/jk: ./ binaries/windows/ binaries/windows/symbols/

2014-03-10 Thread mturk
Author: mturk Date: Mon Mar 10 19:09:26 2014 New Revision: 4615 Log: Upload 1.2.39 artefacts Added: release/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.39-windows-i386-symbols.zip (with props) release/tomcat/tomcat-connectors/jk/binaries/windows/symbols

[Bug 56242] Deploying a Velocity-based web application can thwart Attach API connections for monitoring

2014-03-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56242 --- Comment #1 from Christopher Schultz --- Created attachment 31379 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31379&action=edit Minimal web application WAR that reproduces the problem. I had to remove the following files

[Bug 56242] New: Deploying a Velocity-based web application can thwart Attach API connections for monitoring

2014-03-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56242 Bug ID: 56242 Summary: Deploying a Velocity-based web application can thwart Attach API connections for monitoring Product: Tomcat 8 Version: trunk Hardware: PC

svn commit: r1576014 - /tomcat/trunk/build.properties.default

2014-03-10 Thread remm
Author: remm Date: Mon Mar 10 17:38:48 2014 New Revision: 1576014 URL: http://svn.apache.org/r1576014 Log: Try to see the testsuite state ... Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.

svn commit: r1576013 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java

2014-03-10 Thread remm
Author: remm Date: Mon Mar 10 17:38:27 2014 New Revision: 1576013 URL: http://svn.apache.org/r1576013 Log: Stop using writeTimeout for now (I don't see the point at the moment). Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java Modified: tomcat/trunk

Re: svn commit: r1576000 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/mbeans-descriptors.xml

2014-03-10 Thread Mark Thomas
On 10/03/2014 16:48, schu...@apache.org wrote: > Author: schultz > Date: Mon Mar 10 16:48:57 2014 > New Revision: 1576000 > > URL: http://svn.apache.org/r1576000 > Log: > Removed "jarPath" attribute, which has been removed from WebappClassLoader. > > Modified: > > tomcat/tc6.0.x/trunk/java/o

svn commit: r1576000 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/mbeans-descriptors.xml

2014-03-10 Thread schultz
Author: schultz Date: Mon Mar 10 16:48:57 2014 New Revision: 1576000 URL: http://svn.apache.org/r1576000 Log: Removed "jarPath" attribute, which has been removed from WebappClassLoader. Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/mbeans-descriptors.xml Modified: tomcat/tc

svn commit: r1575994 - in /tomcat/trunk/java/org/apache: coyote/ajp/AjpNio2Protocol.java coyote/http11/Http11Nio2Protocol.java tomcat/util/net/Nio2Channel.java tomcat/util/net/Nio2Endpoint.java tomcat

2014-03-10 Thread remm
Author: remm Date: Mon Mar 10 16:22:07 2014 New Revision: 1575994 URL: http://svn.apache.org/r1575994 Log: Add code to do a clean close of all current connections. Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpNio2Protocol.java tomcat/trunk/java/org/apache/coyote/http11/Http11Nio2P

Re: Special requirements on session id generator

2014-03-10 Thread Mark Thomas
On 10/03/2014 15:47, Rainer Jung wrote: > On 10.03.2014 16:08, Mark Thomas wrote: >> On 10/03/2014 15:00, Rainer Jung wrote: >>> Here's a patch: >>> >>> http://people.apache.org/~rjung/patches/TC8-SessionIdGenerator-extensible.patch >>> >>> Any concerns about applying to TC 8? Please note "Known pr

Re: Special requirements on session id generator

2014-03-10 Thread Rainer Jung
On 10.03.2014 16:08, Mark Thomas wrote: > On 10/03/2014 15:00, Rainer Jung wrote: >> Here's a patch: >> >> http://people.apache.org/~rjung/patches/TC8-SessionIdGenerator-extensible.patch >> >> Any concerns about applying to TC 8? Please note "Known problems". >> >> Some notes: >> >> About the patch

Re: Special requirements on session id generator

2014-03-10 Thread Mark Thomas
On 10/03/2014 15:00, Rainer Jung wrote: > Here's a patch: > > http://people.apache.org/~rjung/patches/TC8-SessionIdGenerator-extensible.patch > > Any concerns about applying to TC 8? Please note "Known problems". > > Some notes: > > About the patch: > > 1) New interface org.apache.catalina.Ses

svn commit: r1575960 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

2014-03-10 Thread markt
Author: markt Date: Mon Mar 10 15:00:14 2014 New Revision: 1575960 URL: http://svn.apache.org/r1575960 Log: Fix a couple of Javadoc nags Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNio2Channel.java

Re: Special requirements on session id generator

2014-03-10 Thread Rainer Jung
Here's a patch: http://people.apache.org/~rjung/patches/TC8-SessionIdGenerator-extensible.patch Any concerns about applying to TC 8? Please note "Known problems". Some notes: About the patch: 1) New interface org.apache.catalina.SessionIdGenerator - setter and getter for jvmRoute - sette

svn commit: r1575946 - in /tomcat/trunk/java/org/apache: coyote/ajp/ coyote/http11/ coyote/http11/upgrade/ tomcat/util/net/

2014-03-10 Thread remm
Author: remm Date: Mon Mar 10 14:08:43 2014 New Revision: 1575946 URL: http://svn.apache.org/r1575946 Log: Fix reported boxing warnings. Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpNio2Processor.java tomcat/trunk/java/org/apache/coyote/http11/InternalNio2InputBuffer.java tomc

Re: NIO 2 connector

2014-03-10 Thread Rémy Maucherat
2014-03-10 14:03 GMT+01:00 Konstantin Kolinko : > There are 52 warning shown by Eclipse IDE. > Most of them are boxing/unboxing ones. > > To remind, the setting are documented here: > res\ide-support\eclipse\java-compiler-errors-warnings.txt > Ahah, ok, NIO2 does a lof of boxing/unboxing indeed.

svn commit: r1575937 - /tomcat/trunk/test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java

2014-03-10 Thread remm
Author: remm Date: Mon Mar 10 13:18:57 2014 New Revision: 1575937 URL: http://svn.apache.org/r1575937 Log: Fix AJP NIO2 protocol selection. Modified: tomcat/trunk/test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java Modified: tomcat/trunk/test/org/apache/coyote/ajp/TestAbstractAjpProcess

Re: NIO 2 connector

2014-03-10 Thread Konstantin Kolinko
2014-03-08 4:41 GMT+04:00 Rémy Maucherat : > 2014-03-07 23:16 GMT+01:00 Konstantin Kolinko : > >> 1. It is a month since release 8.0.3 and thus I think 8.0.4 is >> expected in a week or so.. >> >> I am -1 to destabilize 8.0.x now. >> > > As a new component, it is not supposed to destabilize the oth

svn commit: r1575929 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2014-03-10 Thread remm
Author: remm Date: Mon Mar 10 12:58:42 2014 New Revision: 1575929 URL: http://svn.apache.org/r1575929 Log: Fix NIO2 mbean names tested by the registration test, it would otherwise use the NIO1 names. Modified: tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java Modified: tomc

svn commit: r1575928 - /tomcat/trunk/build.xml

2014-03-10 Thread kkolinko
Author: kkolinko Date: Mon Mar 10 12:58:07 2014 New Revision: 1575928 URL: http://svn.apache.org/r1575928 Log: Checkstyle: tab character Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1575928&r1=1575927&r2=15759

svn commit: r1575925 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Endpoint.java SecureNio2Channel.java

2014-03-10 Thread kkolinko
Author: kkolinko Date: Mon Mar 10 12:54:16 2014 New Revision: 1575925 URL: http://svn.apache.org/r1575925 Log: Checkstyle: 1. Trailing whitespace 2. Unused import Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/SecureNi

svn commit: r1575919 - in /tomcat/trunk/java/org/apache: coyote/ajp/ coyote/http11/ coyote/http11/upgrade/ tomcat/util/net/

2014-03-10 Thread kkolinko
Author: kkolinko Date: Mon Mar 10 12:12:27 2014 New Revision: 1575919 URL: http://svn.apache.org/r1575919 Log: Followup to r1575905: svn:eol-style=native for new files Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpNio2Processor.java (props changed) tomcat/trunk/java/org/apache/c

svn commit: r1575910 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java

2014-03-10 Thread kkolinko
Author: kkolinko Date: Mon Mar 10 11:43:03 2014 New Revision: 1575910 URL: http://svn.apache.org/r1575910 Log: Followup to r1575885 Do not hold writeLock when calling onError(). Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java Modified: tomcat/t

svn commit: r1575905 [4/4] - in /tomcat/trunk: ./ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http11/upgrade/ java/org/apache/tomcat/util/net/ webapps/docs/ webap

2014-03-10 Thread remm
Modified: tomcat/trunk/webapps/docs/config/ajp.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/ajp.xml?rev=1575905&r1=1575904&r2=1575905&view=diff == --- tomcat/trunk/webapps/docs/config/ajp.xml (ori

svn commit: r1575905 [2/4] - in /tomcat/trunk: ./ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/coyote/http11/upgrade/ java/org/apache/tomcat/util/net/ webapps/docs/ webap

2014-03-10 Thread remm
Added: tomcat/trunk/java/org/apache/coyote/http11/InternalNio2OutputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/InternalNio2OutputBuffer.java?rev=1575905&view=auto == --- tomcat

[RESULT] Was: [VOTE] Release Apache Tomcat Connectors 1.2.39

2014-03-10 Thread Mladen Turk
With required number of three +1 votes (Rainer, Keiichi, Mladen) and no other votes, I declare this vote as passed. I'll upload the artefacts, and create ANN message and update web site after mirror sync. On 02/28/2014 10:35 AM, Mladen Turk wrote: Hi, Apache Tomcat Connectors 1.2.39 release c

[Bug 56239] NullPointerException when finishing response under the Linux traffic control

2014-03-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56239 --- Comment #1 from Mark Thomas --- No information on the configuration of traffic control. No information on the load test being performed. No information in the application being tested. In short, no way anyone investigating this bug c

svn commit: r1575885 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java

2014-03-10 Thread markt
Author: markt Date: Mon Mar 10 10:15:54 2014 New Revision: 1575885 URL: http://svn.apache.org/r1575885 Log: Add more comments to explain the locks. Reduce scope of the writeLock in onWritePossible Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AbstractServletOutputStream.java

Re: Backporting security fixes to Debian

2014-03-10 Thread Emmanuel Bourg
I eventually figured why the tests were failing. I forgot to remove an assertion in TestAsyncContextImpl as part of r1475792, and TestGroupChannelMemberArrival was failing until I applied r1453622. Emmanuel Bourg Le 28/02/2014 15:15, Emmanuel Bourg a écrit : > Hi, > > I'm preparing a security u

Re: Tomcat 8: Firing listeners from within a synchronized(writeLock) in onWritePossible()

2014-03-10 Thread Rémy Maucherat
2014-03-10 10:36 GMT+01:00 Mark Thomas : > > I'm not convinced these write locks are needed, there should be no write > > concurrency in the first place. > > The explanation for why the lock is required is in the comments in the > writeInternal() method. The lock is definitely required. The issue

Re: Tomcat 8: Firing listeners from within a synchronized(writeLock) in onWritePossible()

2014-03-10 Thread Mark Thomas
On 08/03/2014 20:50, Rémy Maucherat wrote: > 2014-03-08 21:16 GMT+01:00 Konstantin Kolinko : > >> My question is that these events are fired while holding a >> "synchronized (writeLock) {" lock. >> Is holding the writeLock lock is needed here. >> >> The "on write possible" event is processed by we

[Bug 54315] Redeploying webapp causes NullPointerException in managerBase

2014-03-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54315 --- Comment #18 from Mark Thomas --- (In reply to Konstantin Kolinko from comment #17) > (In reply to Mark Thomas from comment #13) > > re 2, I don't see how this could lead to the constant NPE issue the OP > > reported unless deployment fa

[Bug 56239] New: NullPointerException when finishing response under the Linux traffic control

2014-03-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56239 Bug ID: 56239 Summary: NullPointerException when finishing response under the Linux traffic control Product: Tomcat 7 Version: 7.0.39 Hardware: PC OS: