Re: NIO 2 connector

2014-03-04 Thread jean-frederic clere
On 03/04/2014 07:26 PM, Mark Thomas wrote: Can you wait until we split 8.0.x from trunk or did you want to get this into 8.0.x? I would like to see it in 8.0.x so we can have it in the talk Chris and I present at the ApacheCon. Cheers Jean-Frederic

[Bug 56217] New: Regarding Tomcat Manager Application Status Page

2014-03-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56217 Bug ID: 56217 Summary: Regarding Tomcat Manager Application Status Page Product: Tomcat 7 Version: unspecified Hardware: All OS: All Status: NEW Sev

svn commit: r1574229 - /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/DefaultTestCase.java

2014-03-04 Thread markt
Author: markt Date: Tue Mar 4 22:31:46 2014 New Revision: 1574229 URL: http://svn.apache.org/r1574229 Log: Handle the maxActive -> maxTotal rename Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/DefaultTestCase.java Modified: tomcat/trunk/modules/jdbc-po

Re: NIO 2 connector

2014-03-04 Thread Rémy Maucherat
2014-03-04 21:51 GMT+01:00 Mark Thomas : > >> Can you wait until we split 8.0.x from trunk or did you want to get this > >> into 8.0.x? > >> > > > > Depends, if you want to branch soon or not. It would have to be > > experimental for a while anyway, but it will likely bring something > useful. > >

ApacheCon North America, Denver, April 7-11

2014-03-04 Thread Rich Bowen
Hello Tomcat enthusiasts, as you are no doubt aware, ApacheCon North America will be held in Denver, Colorado starting on April 7th. Tomcat will be represented there by a full day of content in the following talks: http://apacheconnorthamerica2014.sched.org/overview/type/tomcat We would love

Re: NIO 2 connector

2014-03-04 Thread Mark Thomas
On 04/03/2014 19:23, Rémy Maucherat wrote: > 2014-03-04 19:26 GMT+01:00 Mark Thomas : > >> On 04/03/2014 16:16, Rémy Maucherat wrote: >>> Hi, >>> >>> I've been working on porting a NIO2 connector that was originally >> developed >>> for JBoss AS by Nabil Benothman (an intern at Red Hat). Due to th

Re: NIO 2 connector

2014-03-04 Thread Rémy Maucherat
2014-03-04 19:26 GMT+01:00 Mark Thomas : > On 04/03/2014 16:16, Rémy Maucherat wrote: > > Hi, > > > > I've been working on porting a NIO2 connector that was originally > developed > > for JBoss AS by Nabil Benothman (an intern at Red Hat). Due to the very > > different connector structure in Tomca

Re: NIO 2 connector

2014-03-04 Thread Mark Thomas
On 04/03/2014 16:16, Rémy Maucherat wrote: > Hi, > > I've been working on porting a NIO2 connector that was originally developed > for JBoss AS by Nabil Benothman (an intern at Red Hat). Due to the very > different connector structure in Tomcat and my preference for basing it on > the existing NIO

svn commit: r1574167 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2014-03-04 Thread remm
Author: remm Date: Tue Mar 4 18:10:56 2014 New Revision: 1574167 URL: http://svn.apache.org/r1574167 Log: Avoid possible NPE. Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java URL: http:

svn commit: r1574162 - /tomcat/trunk/java/org/apache/tomcat/util/threads/TaskQueue.java

2014-03-04 Thread remm
Author: remm Date: Tue Mar 4 18:03:41 2014 New Revision: 1574162 URL: http://svn.apache.org/r1574162 Log: Avoid possible NPE (it really needs to throw a rejected execution instead anyway). Modified: tomcat/trunk/java/org/apache/tomcat/util/threads/TaskQueue.java Modified: tomcat/trunk/java

svn commit: r1574163 - in /tomcat/trunk/java/org/apache/catalina/connector: CoyoteInputStream.java InputBuffer.java

2014-03-04 Thread remm
Author: remm Date: Tue Mar 4 18:04:25 2014 New Revision: 1574163 URL: http://svn.apache.org/r1574163 Log: Fix wrong booleans (which shouldn't change anything in practice, but the code is wrong). Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteInputStream.java tomcat/trun

Re: NIO 2 connector

2014-03-04 Thread jean-frederic clere
On 03/04/2014 05:16 PM, Rémy Maucherat wrote: Pros: - Significantly faster, although the API looks slower by design Actually I didn't bench it yet but I benched "something similar" on JBossWeb: it performed faster than APR, the implementation is a bit different in that area so I will retest i

NIO 2 connector

2014-03-04 Thread Rémy Maucherat
Hi, I've been working on porting a NIO2 connector that was originally developed for JBoss AS by Nabil Benothman (an intern at Red Hat). Due to the very different connector structure in Tomcat and my preference for basing it on the existing NIO1 connector, it is mostly new code, though. So I would

svn commit: r1574052 - /tomcat/trunk/webapps/docs/changelog.xml

2014-03-04 Thread markt
Author: markt Date: Tue Mar 4 12:02:10 2014 New Revision: 1574052 URL: http://svn.apache.org/r1574052 Log: Note DBCP update to a release version. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tru

Re: svn commit: r1573484 - in /tomcat/trunk: build.properties.default build.xml

2014-03-04 Thread Mark Thomas
On 04/03/2014 11:44, Konstantin Kolinko wrote: > 2014-03-03 13:10 GMT+04:00 : >> Author: markt >> Date: Mon Mar 3 09:10:13 2014 >> New Revision: 1573484 >> >> URL: http://svn.apache.org/r1573484 >> Log: >> DBCP 2.0 has been released. >> > > Congratulations, Mark! > > Change log update for this

Re: svn commit: r1573484 - in /tomcat/trunk: build.properties.default build.xml

2014-03-04 Thread Konstantin Kolinko
2014-03-03 13:10 GMT+04:00 : > Author: markt > Date: Mon Mar 3 09:10:13 2014 > New Revision: 1573484 > > URL: http://svn.apache.org/r1573484 > Log: > DBCP 2.0 has been released. > Congratulations, Mark! Change log update for this =? > Modified: > tomcat/trunk/build.properties.default >

[Bug 56215] New: sendError doesn't send error page with AsyncContext

2014-03-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56215 Bug ID: 56215 Summary: sendError doesn't send error page with AsyncContext Product: Tomcat 7 Version: 7.0.50 Hardware: PC OS: Linux Status: NEW Seve

[Bug 56010] JspFactory.getPageContext with JspWriter.DEFAULT_BUFFER throws IllegalArgumentException

2014-03-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56010 --- Comment #3 from Konstantin Kolinko --- As far as I am reading, such value can only be used when calling the JspFactory.getPageContext() API directly. The buffer size that can be used in JSP configurations (in a page directive or in jsp-

svn commit: r1574015 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-03-04 Thread kkolinko
Author: kkolinko Date: Tue Mar 4 10:14:28 2014 New Revision: 1574015 URL: http://svn.apache.org/r1574015 Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1574015&r1=157401

svn commit: r1574010 - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/jsp/JspFactory.java

2014-03-04 Thread kkolinko
Author: kkolinko Date: Tue Mar 4 10:09:49 2014 New Revision: 1574010 URL: http://svn.apache.org/r1574010 Log: Merged r1574004 from tomcat/trunk: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56010 Documentation part of the fix The constants mentioned in JspFactory.getPageContext(..) bel

svn commit: r1574004 - /tomcat/trunk/java/javax/servlet/jsp/JspFactory.java

2014-03-04 Thread kkolinko
Author: kkolinko Date: Tue Mar 4 10:08:12 2014 New Revision: 1574004 URL: http://svn.apache.org/r1574004 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56010 Documentation part of the fix The constants mentioned in JspFactory.getPageContext(..) belong to JspWriter. There are no suc