[Bug 56043] Adding Admin control for default page

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56043 Tinu changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail beca

[Bug 56043] Adding Admin control for default page

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56043 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 56043] New: Adding Admin control for default page

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56043 Bug ID: 56043 Summary: Adding Admin control for default page Product: Tomcat 7 Version: 7.0.50 Hardware: PC OS: Windows NT Status: NEW Severity: maj

Notes from review of BZ 56029 and ELParser patches

2014-01-20 Thread Konstantin Kolinko
Hi! Reviewing the patches for https://issues.apache.org/bugzilla/show_bug.cgi?id=56029 (r1559555, r1559708, r1559820) Important: 1. The test "org.apache.jasper.compiler.TestELParser" tests success of a roundtrip: - parsing a String into EL expression - recreating original String with ELP

[Bug 56042] New: java.lang.IllegalStateException: Calling [asyncComplete()] is not valid for a request with Async state [MUST_DISPATCH]

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56042 Bug ID: 56042 Summary: java.lang.IllegalStateException: Calling [asyncComplete()] is not valid for a request with Async state [MUST_DISPATCH] Product: Tomcat 7

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate-eoln (in module tomcat-7.0.x) failed

2014-01-20 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate-eoln has an issue affecting its community integra

[GUMP@vmgump]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed

2014-01-20 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate-eoln has an issue affecting its community integrati

buildbot failure in ASF Buildbot on tomcat-trunk

2014-01-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5421 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

Re: Using HttpParser for Cookie header?

2014-01-20 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/01/2014 21:38, Jeremy Boynes wrote: > I started to look at using HttpParser for the Cookie header but > there are some differences in the way it works compared to the > existing parser in Cookies that I wanted to check direction before > getting

[Bug 56032] WebSocket Endpoint onClose method not called when channel closed by thread interruption

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56032 --- Comment #2 from Mark Thomas --- I've been looking at the WebSocket code and (by tweaking a unit tests an using a few break points) I can create a situation where the server times out trying to write a WebSocket message to the client. Th

Using HttpParser for Cookie header?

2014-01-20 Thread Jeremy Boynes
I started to look at using HttpParser for the Cookie header but there are some differences in the way it works compared to the existing parser in Cookies that I wanted to check direction before getting too far in. The area I’m concerned about is the need to copy the bytes in order to parse the

buildbot success in ASF Buildbot on tomcat-7-trunk

2014-01-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1699 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build So

[Bug 56032] WebSocket Endpoint onClose method not called when channel closed by thread interruption

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56032 --- Comment #1 from Mark Thomas --- Do you have some unit tests or some sample code to demonstrate the problem? -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 56039] New: JmxRemoteLifecycleListener does not work with SSL

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56039 Bug ID: 56039 Summary: JmxRemoteLifecycleListener does not work with SSL Product: Tomcat 7 Version: 7.0.50 Hardware: PC OS: Linux Status: NEW Severi

svn commit: r1559820 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ELParser.java

2014-01-20 Thread jboynes
Author: jboynes Date: Mon Jan 20 20:07:23 2014 New Revision: 1559820 URL: http://svn.apache.org/r1559820 Log: merge fix for potential NPE Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/ELParser.java Propchange: tomcat/tc7.0.x/trunk/

buildbot success in ASF Buildbot on tomcat-trunk

2014-01-20 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5420 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: svn commit: r1559707 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/resources/LocalStrings.properties test/org/apache/el/TestELInJsp.java test/webapp/bug5

2014-01-20 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/01/2014 18:25, Jeremy Boynes wrote: > On Jan 20, 2014, at 6:22 AM, ma...@apache.org wrote: > >> Author: markt Date: Mon Jan 20 14:22:49 2014 New Revision: >> 1559707 >> >> URL: http://svn.apache.org/r1559707 Log: Additional fix for bug >> 56029

svn commit: r1559801 - /tomcat/trunk/java/javax/servlet/http/Cookie.java

2014-01-20 Thread jboynes
Author: jboynes Date: Mon Jan 20 18:30:13 2014 New Revision: 1559801 URL: http://svn.apache.org/r1559801 Log: Refactor cookie name validation into a helper class to prepare for enabling RFC6265. This should have no functional change. Modified: tomcat/trunk/java/javax/servlet/http/Cookie.java

Re: svn commit: r1559707 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/resources/LocalStrings.properties test/org/apache/el/TestELInJsp.java test/webapp/bug5

2014-01-20 Thread Jeremy Boynes
On Jan 20, 2014, at 6:22 AM, ma...@apache.org wrote: > Author: markt > Date: Mon Jan 20 14:22:49 2014 > New Revision: 1559707 > > URL: http://svn.apache.org/r1559707 > Log: > Additional fix for bug 56029. Now whitespace is not skipped, make sure it is > trimmed before the function name is used.

svn commit: r1559798 - /tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java

2014-01-20 Thread jboynes
Author: jboynes Date: Mon Jan 20 18:22:16 2014 New Revision: 1559798 URL: http://svn.apache.org/r1559798 Log: Fix for NPE introduced by r1559707 that caused ELParser test to fail. Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java Modified: tomcat/trunk/java/org/apache/jasp

[jira] [Commented] (MTOMCAT-257) Classpathes separation between plugin and application is broken (can't use slf4j-jcl in app)

2014-01-20 Thread Brendan Le Ny (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876600#comment-13876600 ] Brendan Le Ny commented on MTOMCAT-257: --- true doesn't solve the issue. It seems t

[jira] [Created] (MTOMCAT-257) Classpathes separation between plugin and application is broken (can't use slf4j-jcl in app)

2014-01-20 Thread Brendan Le Ny (JIRA)
Brendan Le Ny created MTOMCAT-257: - Summary: Classpathes separation between plugin and application is broken (can't use slf4j-jcl in app) Key: MTOMCAT-257 URL: https://issues.apache.org/jira/browse/MTOMCAT-257

buildbot failure in ASF Buildbot on tomcat-7-trunk

2014-01-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1698 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

[Bug 56029] Ternary operator doesn't work as expected inside attributes in jspx pages

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56029 --- Comment #9 from Mark Thomas --- If fixed the white space issue in 8.0.x and 7.0.x and added it to the proposal for 6.0.x -- You are receiving this mail because: You are the assignee for the bug. --

svn commit: r1559710 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-01-20 Thread markt
Author: markt Date: Mon Jan 20 14:32:00 2014 New Revision: 1559710 URL: http://svn.apache.org/r1559710 Log: Update proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1559710&r1=15

svn commit: r1559708 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/resources/LocalStrings.properties test/org/apache/el/TestELInJsp.java test/weba

2014-01-20 Thread markt
Author: markt Date: Mon Jan 20 14:30:48 2014 New Revision: 1559708 URL: http://svn.apache.org/r1559708 Log: Additional fix for bug 56029. Now whitespace is not skipped, make sure it is trimmed before the function name is used. Includes a test case based on a jspx file by kkolinko. Added: tom

svn commit: r1559707 - in /tomcat/trunk: java/org/apache/jasper/compiler/ELParser.java java/org/apache/jasper/resources/LocalStrings.properties test/org/apache/el/TestELInJsp.java test/webapp/bug5nnnn

2014-01-20 Thread markt
Author: markt Date: Mon Jan 20 14:22:49 2014 New Revision: 1559707 URL: http://svn.apache.org/r1559707 Log: Additional fix for bug 56029. Now whitespace is not skipped, make sure it is trimmed before the function name is used. Includes a test case based on a jspx file by kkolinko. Added: tom

[Bug 55956] Regarding Tomcat Manager Application Status

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55956 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1559699 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/filters/ java/org/apache/catalina/manager/ java/org/apache/catalina/valves/ java/org/apache/coyot

2014-01-20 Thread markt
Author: markt Date: Mon Jan 20 14:06:01 2014 New Revision: 1559699 URL: http://svn.apache.org/r1559699 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55956 Make the forwarded remote IP available on the Manager status page Modified: tomcat/tc7.0.x/trunk/ (props changed) tomc

svn commit: r1559697 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/filters/ java/org/apache/catalina/manager/ java/org/apache/catalina/valves/ java/org/apache/coyote/ webapps/

2014-01-20 Thread markt
Author: markt Date: Mon Jan 20 14:02:45 2014 New Revision: 1559697 URL: http://svn.apache.org/r1559697 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55956 Make the forwarded remote IP available on the Manager status page Modified: tomcat/trunk/java/org/apache/catalina/Globals.ja

[Bug 56029] Ternary operator doesn't work as expected inside attributes in jspx pages

2014-01-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56029 --- Comment #8 from Konstantin Kolinko --- Created attachment 31231 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31231&action=edit test.jspx - Failure to trim leading space from fn prefix Re: r1559555 Not yet. Testing curre

buildbot failure in ASF Buildbot on tomcat-trunk

2014-01-20 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5417 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1559663 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Request.java

2014-01-20 Thread markt
Author: markt Date: Mon Jan 20 10:03:00 2014 New Revision: 1559663 URL: http://svn.apache.org/r1559663 Log: Remove unused code Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/connector/Request.java Propchange: tomcat/tc7.0.x/trunk/

svn commit: r1559662 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

2014-01-20 Thread markt
Author: markt Date: Mon Jan 20 10:00:31 2014 New Revision: 1559662 URL: http://svn.apache.org/r1559662 Log: Remove unused code Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java URL: http://svn.apache