svn commit: r1534919 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-10-22 Thread kfujino
Author: kfujino Date: Wed Oct 23 06:14:49 2013 New Revision: 1534919 URL: http://svn.apache.org/r1534919 Log: Add subsection name. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7

svn commit: r1534918 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-10-22 Thread kfujino
Author: kfujino Date: Wed Oct 23 06:12:05 2013 New Revision: 1534918 URL: http://svn.apache.org/r1534918 Log: Add a description of the side effects of r1534575. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://sv

Re: svn commit: r1534575 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java webapps/docs/changelo

2013-10-22 Thread Keiichi Fujino
> > /** > > * The default initial capacity - MUST be a power of two. > > @@ -1396,8 +1396,7 @@ public abstract class AbstractReplicated > > try { > > return key(null); > > } catch ( Exception x ) { > > -log.error("Deserialization

RE: Tomcat closes Websocket connection when using a SSL HTTP APR connector (was: RE: Tagging 7.0.46)

2013-10-22 Thread Konstantin Preißer
Hi Mark, > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Tuesday, October 22, 2013 2:57 PM > To: Tomcat Developers List > Subject: Re: Tomcat closes Websocket connection when using a SSL HTTP > APR connector (was: RE: Tagging 7.0.46) > > On 21/10/2013 15:26, Mar

svn commit: r1534869 - /tomcat/tc7.0.x/trunk/

2013-10-22 Thread kpreisser
Author: kpreisser Date: Wed Oct 23 00:15:46 2013 New Revision: 1534869 URL: http://svn.apache.org/r1534869 Log: Add mergeinfo. Modified: tomcat/tc7.0.x/trunk/ (props changed) Propchange: tomcat/tc7.0.x/trunk/ --

[Bug 55686] make request.getParameterNames() and request.getParameterMap ordered

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55686 --- Comment #5 from quaff --- @Christopher Schultz, it should be [a, b, c],and request.getParameterValues("a") will be [1,4] -- You are receiving this mail because: You are the assignee for the bug. --

svn commit: r1534848 - in /tomcat/tc7.0.x/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard: Client.java DrawboardEndpoint.java Room.java

2013-10-22 Thread kpreisser
Author: kpreisser Date: Tue Oct 22 23:32:26 2013 New Revision: 1534848 URL: http://svn.apache.org/r1534848 Log: Merged revision(s) 1534846 from tomcat/trunk: - Prevent recursive invocation of Runnables by Room.invokeAndWait() to prevent errors like ConcurrentModificationException when Room.broadc

svn commit: r1534846 - in /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/drawboard: Client.java DrawboardEndpoint.java Room.java

2013-10-22 Thread kpreisser
Author: kpreisser Date: Tue Oct 22 23:29:14 2013 New Revision: 1534846 URL: http://svn.apache.org/r1534846 Log: - Prevent recursive invocation of Runnables by Room.invokeAndWait() to prevent errors like ConcurrentModificationException when Room.broadcastRoomMessage() iterates over an ArrayList a

[Bug 55691] New: javax.el.ArrayELResolver.setValue not supporting arrays of primitives

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55691 Bug ID: 55691 Summary: javax.el.ArrayELResolver.setValue not supporting arrays of primitives Product: Tomcat 6 Version: 6.0.37 Hardware: All OS: Linux

Re: [VOTE] Release Apache Tomcat 7.0.47

2013-10-22 Thread Olivier Lamy
On 18 October 2013 22:14, Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.47 release is now available for voting. > This release candidate contains JSR-356 Java WebSocket 1.0 implementation. > Note that use of this functionality requires Java 7. > > It can be obtained from: > https://dis

RE: websocket connection (at startup) between 2 webapps in same Tomcat 7.0.47 instance hangs indefinitely

2013-10-22 Thread Bob DeRemer
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Tuesday, October 22, 2013 4:00 PM > To: Tomcat Developers List > Subject: Re: websocket connection (at startup) between 2 webapps in same > Tomcat 7.0.47 instance hangs indefinitely > > On 22/10/2013 20:41, Bob De

Re: websocket connection (at startup) between 2 webapps in same Tomcat 7.0.47 instance hangs indefinitely

2013-10-22 Thread Mark Thomas
On 22/10/2013 20:41, Bob DeRemer wrote: > > >> -Original Message- >> From: Mark Thomas [mailto:ma...@apache.org] >> Sent: Tuesday, October 22, 2013 3:34 PM >> To: Tomcat Developers List >> Subject: Re: websocket connection (at startup) between 2 webapps in same >> Tomcat 7.0.47 instance h

RE: websocket connection (at startup) between 2 webapps in same Tomcat 7.0.47 instance hangs indefinitely

2013-10-22 Thread Bob DeRemer
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Tuesday, October 22, 2013 3:34 PM > To: Tomcat Developers List > Subject: Re: websocket connection (at startup) between 2 webapps in same > Tomcat 7.0.47 instance hangs indefinitely > > On 22/10/2013 16:17, Mark T

svn commit: r1534752 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsWebSocketContainer.java webapps/docs/web-socket-howto.xml

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 19:38:33 2013 New Revision: 1534752 URL: http://svn.apache.org/r1534752 Log: Add some timouts rather for IO operations while establishing a WebSocket client connection. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/

svn commit: r1534751 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/web-socket-howto.xml

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 19:36:46 2013 New Revision: 1534751 URL: http://svn.apache.org/r1534751 Log: Document client side SSL config Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml tomcat/tc7.0.x/trunk/webapps/docs/web-socket-ho

Re: websocket connection (at startup) between 2 webapps in same Tomcat 7.0.47 instance hangs indefinitely

2013-10-22 Thread Mark Thomas
On 22/10/2013 16:17, Mark Thomas wrote: > On 18/10/2013 22:09, Bob DeRemer wrote: >> Hi Guys, >> >> >> >> In our implementation, we have a gateway app that uses jsr websockets to >> communication with our main application server. In a small system, we >> want to run them both on a single Tomcat

svn commit: r1534744 - in /tomcat/trunk: java/org/apache/tomcat/websocket/WsWebSocketContainer.java webapps/docs/web-socket-howto.xml

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 19:31:11 2013 New Revision: 1534744 URL: http://svn.apache.org/r1534744 Log: Add some timouts rather for IO operations while establishing a WebSocket client connection. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java tomcat

svn commit: r1534727 - /tomcat/trunk/webapps/docs/web-socket-howto.xml

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 18:45:46 2013 New Revision: 1534727 URL: http://svn.apache.org/r1534727 Log: Document client side SSL config Modified: tomcat/trunk/webapps/docs/web-socket-howto.xml Modified: tomcat/trunk/webapps/docs/web-socket-howto.xml URL: http://svn.apache.org/viewvc/tom

Re: websocket connection (at startup) between 2 webapps in same Tomcat 7.0.47 instance hangs indefinitely

2013-10-22 Thread Mark Thomas
On 18/10/2013 22:09, Bob DeRemer wrote: > Hi Guys, > > > > In our implementation, we have a gateway app that uses jsr websockets to > communication with our main application server. In a small system, we > want to run them both on a single Tomcat instance using the same Tomcat > NIO connector,

Re: Proposal for a more flexible tomcat embedding api

2013-10-22 Thread Pid
Hi, I've already got reasonably far with a similar idea. https://github.com/pidster-dot-org/embed-apache-tomcat There's a core utility for embedding Tomcat[1] and a JUnit Rule[2] for testing that uses it, e.g. 1. https://github.com/pidster-dot-org/embed-apache-tomcat/blob/master/embed-apache-t

Re: Tomcat closes Websocket connection when using a SSL HTTP APR connector (was: RE: Tagging 7.0.46)

2013-10-22 Thread Mark Thomas
On 21/10/2013 15:26, Mark Thomas wrote: > On 19/10/2013 23:31, Mark Thomas wrote: >> On 18/10/2013 19:37, Mark Thomas wrote: >>> On 18/10/2013 13:54, Mark Thomas wrote: On 18/10/2013 12:48, Mark Thomas wrote: > When it goes wrong, the sequence is: > Read result [1] > Read result [4

svn commit: r1534619 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: AprServletInputStream.java LocalStrings.properties

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 12:54:33 2013 New Revision: 1534619 URL: http://svn.apache.org/r1534619 Log: Latest attempt to address issues with APR/native, SSL and the drawboard example Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServletInputStream.java tomcat/trunk

[Bug 55686] make request.getParameterNames() and request.getParameterMap ordered

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55686 --- Comment #4 from Christopher Schultz --- The fix for bug #55576 might not entirely "fix" this enhancement as written. For example, in this case: /path/to/servlet?a=1&b=2&c=3&a=4 One might expect the return value of getParameterNames t

o.a.c.c.Request.getParameterMap duplicates a pre-existing parameters Map

2013-10-22 Thread Christopher Schultz
All, I was reading-through the request-parameters processing code and I noticed that while the Parameters class is used to build a Map of parameter names -> value arrays, that same Map is not used when Request.getParameterNames is called. Instead, Request.getParameterNames builds a copy of that s

svn commit: r1534616 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 12:43:24 2013 New Revision: 1534616 URL: http://svn.apache.org/r1534616 Log: kkolinko review Fix typo Use less code Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.ja

Re: svn commit: r1534612 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java

2013-10-22 Thread Konstantin Kolinko
2013/10/22 : > Author: markt > Date: Tue Oct 22 12:24:06 2013 > New Revision: 1534612 > > URL: http://svn.apache.org/r1534612 > Log: > Improve debug logging of SocketWrapper that just uses toString() > > Modified: > tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java > > Modified:

svn commit: r1534612 - /tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 12:24:06 2013 New Revision: 1534612 URL: http://svn.apache.org/r1534612 Log: Improve debug logging of SocketWrapper that just uses toString() Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java Modified: tomcat/trunk/java/org/apache/tomcat

Re: svn commit: r1534575 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java webapps/docs/changelo

2013-10-22 Thread Konstantin Kolinko
2013/10/22 : > Author: kfujino > Date: Tue Oct 22 09:45:25 2013 > New Revision: 1534575 > > URL: http://svn.apache.org/r1534575 > Log: > The logger of AbstractReplicatedMap should be non-static in order to enable > logging of each application. > > Modified: > > tomcat/tc7.0.x/trunk/java/org/

svn commit: r1534575 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java webapps/docs/changelog.xm

2013-10-22 Thread kfujino
Author: kfujino Date: Tue Oct 22 09:45:25 2013 New Revision: 1534575 URL: http://svn.apache.org/r1534575 Log: The logger of AbstractReplicatedMap should be non-static in order to enable logging of each application. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/Abstrac

svn commit: r1534572 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java

2013-10-22 Thread kfujino
Author: kfujino Date: Tue Oct 22 09:42:08 2013 New Revision: 1534572 URL: http://svn.apache.org/r1534572 Log: follow-up r1534566. Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/LazyReplicatedMap.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/LazyReplicatedMa

svn commit: r1534566 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

2013-10-22 Thread kfujino
Author: kfujino Date: Tue Oct 22 09:39:30 2013 New Revision: 1534566 URL: http://svn.apache.org/r1534566 Log: The logger of AbstractReplicatedMap should be non-static in order to enable logging of each application. Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplica

[Bug 55688] SendRedirect does not work with AsyncContext

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55688 Vikram changed: What|Removed |Added OS|All |Windows 7 -- You are receiving this mail

[Bug 55688] SendRedirect does not work with AsyncContext

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55688 --- Comment #1 from Vikram --- Some more details, my sample servlet "get" code looks like this, @Override protected void doGet(HttpServletRequest req, HttpServletResponse response) throws ServletException, IOException {

[Bug 55688] SendRedirect does not work with AsyncContext

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55688 Vikram changed: What|Removed |Added CC||vicky...@gmail.com OS|

[Bug 55688] New: SendRedirect does not work with AsyncContext

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55688 Bug ID: 55688 Summary: SendRedirect does not work with AsyncContext Product: Tomcat 7 Version: 7.0.42 Hardware: PC Status: NEW Severity: major Priority: P

svn commit: r1534544 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: AprServletInputStream.java AprServletOutputStream.java LocalStrings.properties

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 09:00:56 2013 New Revision: 1534544 URL: http://svn.apache.org/r1534544 Log: Add wrapper information to error message Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServletInputStream.java tomcat/trunk/java/org/apache/coyote/http11/upgrade

svn commit: r1534543 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 08:55:07 2013 New Revision: 1534543 URL: http://svn.apache.org/r1534543 Log: Remove socket from list of connections as soon as we know it is going to be closed. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java

svn commit: r1534540 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: AprServletInputStream.java AprServletOutputStream.java

2013-10-22 Thread markt
Author: markt Date: Tue Oct 22 08:34:32 2013 New Revision: 1534540 URL: http://svn.apache.org/r1534540 Log: Check for closed sockets earlier and reduce code duplication. Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServletInputStream.java tomcat/trunk/java/org/apache/

Generating javadoc in Tomcat 7 with jdk 7 when java.7.home is set

2013-10-22 Thread Violeta Georgieva
Hi, I'm looking at the issue with javadoc reported by Rainer [1] I know that we've decided to use the quick-fix tool for javadoc instead of jdk 7 [2]. But that was before websocket downport that require jdk 7 for building. What do you think if we start generating javadoc with jdk 7 when java.7.ho

APR/native with SSL usage questions

2013-10-22 Thread Mark Thomas
I've been doing some further research on the current issues with WebSockets over HTTPS with the APR/native connector and I have a few questions. 1. Is concurrent reading and writing from/to the socket supported with SSL? 2. Is non-blocking IO supported with SSL? Background The error observed w

[Bug 55576] Order of ServletRequest parameters is not preserved

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55576 Violeta Georgieva changed: What|Removed |Added CC||zhouyanm...@gmail.com --- Comm

[Bug 55686] make request.getParameterNames() and request.getParameterMap ordered

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55686 Violeta Georgieva changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--

[Bug 55686] make request.getParameterNames() and request.getParameterMap ordered

2013-10-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55686 --- Comment #2 from quaff --- wonderful,thanks very much,I have tested with 8.0.0-RC5,can you fix this in 7.0.x? -- You are receiving this mail because: You are the assignee for the bug. --