Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Rainer Jung
On 04.10.2013 00:37, Christopher Schultz wrote: > Rainer, > > On 10/3/13 5:40 PM, Rainer Jung wrote: >> On 03.10.2013 21:52, Mark Thomas wrote: >>> On 03/10/2013 17:34, Christopher Schultz wrote: On 10/3/13 11:42 AM, Mark Thomas wrote: >> >>> I was thinking maybe an APR function that gave a t

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Christopher Schultz
Rainer, On 10/3/13 5:40 PM, Rainer Jung wrote: > On 03.10.2013 21:52, Mark Thomas wrote: >> On 03/10/2013 17:34, Christopher Schultz wrote: >>> On 10/3/13 11:42 AM, Mark Thomas wrote: > >> I was thinking maybe an APR function that gave a textual error message >> for a given error code. Currently,

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Christopher Schultz
Mark, On 10/3/13 6:29 PM, Christopher Schultz wrote: > Okay, that's something I can do: a JNI wrapper around apr_strerror > should be trivial. Already exists: public static native String org.apache.tomcat.jni.Error.strerror(int statcode); -chris signature.asc Description: OpenPGP digital

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Christopher Schultz
Mark, On 10/3/13 3:52 PM, Mark Thomas wrote: > On 03/10/2013 17:34, Christopher Schultz wrote: >> On 10/3/13 11:42 AM, Mark Thomas wrote: > >>> On the other hand, a JVM crash is a very strong motivation to fix >>> an issue. > >> For *you*, or for the user? > > For me. I haven't looked at the hi

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Rainer Jung
On 03.10.2013 21:52, Mark Thomas wrote: > On 03/10/2013 17:34, Christopher Schultz wrote: >> On 10/3/13 11:42 AM, Mark Thomas wrote: > I was thinking maybe an APR function that gave a textual error message > for a given error code. Currently, the APR Java code reports just the > error number. It w

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Mark Thomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/10/2013 17:34, Christopher Schultz wrote: > On 10/3/13 11:42 AM, Mark Thomas wrote: >> On the other hand, a JVM crash is a very strong motivation to fix >> an issue. > > For *you*, or for the user? For me. I haven't looked at the historical bu

Re: 8.0.x / 7.0.x progress

2013-10-03 Thread Mark Thomas
On 02/10/2013 18:28, Mark Thomas wrote: > On 01/10/2013 19:39, Mark Thomas wrote: All the other issues I am aware of have been resolved. >> The fairly frequent (5%-10%) failure rate of TestCoyoteOutputStream >> still needs to be addressed. > > This appears to impact all connectors so at this poi

svn commit: r1528922 - /tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java

2013-10-03 Thread markt
Author: markt Date: Thu Oct 3 16:35:12 2013 New Revision: 1528922 URL: http://svn.apache.org/r1528922 Log: Fix line wrapping Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java URL: http://svn

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Christopher Schultz
Mark, On 10/3/13 11:42 AM, Mark Thomas wrote: > On 03/10/2013 16:12, Christopher Schultz wrote: >> On 10/3/13 9:18 AM, Mark Thomas wrote: > >>> Having been responsible for introducing and fixing a number of >>> these issues I disagree. It is usually fairly easy to tell what >>> the problem is fro

svn commit: r1528920 - in /tomcat/trunk/java/org/apache/catalina/storeconfig: ConnectorStoreAppender.java GlobalNamingResourcesSF.java StoreAppender.java server-registry.xml

2013-10-03 Thread remm
Author: remm Date: Thu Oct 3 16:23:59 2013 New Revision: 1528920 URL: http://svn.apache.org/r1528920 Log: - Fix some classnames for resources following refactorings - Add support for InetAddress for the connector address - Do not ignore the thread local listener and add the special engine listene

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Mark Thomas
On 03/10/2013 16:12, Christopher Schultz wrote: > On 10/3/13 9:18 AM, Mark Thomas wrote: >> Having been responsible for introducing and fixing a number of >> these issues I disagree. It is usually fairly easy to tell what >> the problem is from the crash report (double close on a socket, >> invali

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Christopher Schultz
Mark, On 10/3/13 9:18 AM, Mark Thomas wrote: > On 03/10/2013 13:51, Christopher Schultz wrote: >> Sebb, >> >> On 10/3/13 8:06 AM, sebb wrote: >>> The problem is that bugs that reveal themselves as JVM crashes >>> are much harder to debug. >> >> +1 >> >> This is exactly the point I was arguing. Whe

buildbot success in ASF Buildbot on tomcat-7-trunk

2013-10-03 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1444 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build So

[Bug 55602] JRE crashes during websocket communication

2013-10-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55602 --- Comment #7 from st.mailingli...@gmail.com --- (In reply to Chuck Caldarale from comment #6) > (In reply to st.mailinglists from comment #5) > > Do you mean 7.0.46, or rather 7.0.43? Current stable release is 7.0.42, and > > 7.0.42 is als

[Bug 55602] JRE crashes during websocket communication

2013-10-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55602 --- Comment #6 from Chuck Caldarale --- (In reply to st.mailinglists from comment #5) > Do you mean 7.0.46, or rather 7.0.43? Current stable release is 7.0.42, and > 7.0.42 is also the release where I observed this bug. 7.0.46, since the a

[Bug 55602] JRE crashes during websocket communication

2013-10-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55602 --- Comment #5 from st.mailingli...@gmail.com --- (In reply to Mark Thomas from comment #4) > This has been fixed in 8.0.x and 7.0.x and will be included in 8.0.0-RC4 > onwards and 7.0.46 onwards. Do you mean 7.0.46, or rather 7.0.43? Curren

svn commit: r1528858 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameClient.java webapps/docs/changelog.xml

2013-10-03 Thread markt
Author: markt Date: Thu Oct 3 13:39:14 2013 New Revision: 1528858 URL: http://svn.apache.org/r1528858 Log: Only send a close message on an IOException if the client has not yet received a close control message from the server as the IOException may be in response to the client continuing to sen

svn commit: r1528855 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameClient.java

2013-10-03 Thread markt
Author: markt Date: Thu Oct 3 13:32:52 2013 New Revision: 1528855 URL: http://svn.apache.org/r1528855 Log: Only send a close message on an IOException if the client has not yet received a close control message from the server as the IOException may be in response to the client continuing to sen

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Mark Thomas
On 03/10/2013 13:51, Christopher Schultz wrote: > Sebb, > > On 10/3/13 8:06 AM, sebb wrote: >> The problem is that bugs that reveal themselves as JVM crashes >> are much harder to debug. > > +1 > > This is exactly the point I was arguing. When we get a JVM crash > report, the stack dump could be

RE: svn commit: r1528631 - /tomcat/trunk/webapps/docs/tomcat-docs.xsl

2013-10-03 Thread Konstantin Preißer
Hi Konstantin, > -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Thursday, October 3, 2013 1:36 PM > The file mentioned in external entity declaration is loaded (via > entity resolver) and its text is inserted as is in the specified > place, > > >

svn commit: r1528834 - /tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java

2013-10-03 Thread markt
Author: markt Date: Thu Oct 3 12:55:20 2013 New Revision: 1528834 URL: http://svn.apache.org/r1528834 Log: Remove method call that appears to be unnecessary and on rare occassions has triggered a unit test failure. Modified: tomcat/trunk/java/org/apache/juli/ClassLoaderLogManager.java Modi

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread Christopher Schultz
Sebb, On 10/3/13 8:06 AM, sebb wrote: > The problem is that bugs that reveal themselves as JVM crashes are > much harder to debug. +1 This is exactly the point I was arguing. When we get a JVM crash report, the stack dump could be completely different depending upon which architecture, kernel, c

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-03 Thread sebb
On 2 October 2013 06:18, Mladen Turk wrote: > On 10/01/2013 07:32 PM, sebb wrote: >> >> >> If a Java application succeeds in crashing the JVM, then IMO the JVM >> has a bug. I believe that all native code should strive to behave the >> same way. >> > > This is conceptual difference. Partly. > Mo

Re: svn commit: r1528631 - /tomcat/trunk/webapps/docs/tomcat-docs.xsl

2013-10-03 Thread Konstantin Kolinko
2013/10/3 Konstantin Preißer : > Hi, > >> -Original Message- >> From: kpreis...@apache.org [mailto:kpreis...@apache.org] >> Sent: Wednesday, October 2, 2013 11:25 PM > >> - >> + > > The previous version seemed to use the tree that is loaded from > project.xml by th

RE: 8.0.x / 7.0.x progress

2013-10-03 Thread Konstantin Preißer
Hi Mark, > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Thursday, October 3, 2013 10:56 AM > > Thanks. When I now open snake.xhtml with Chrome, press a key and close > Chrome, then the snake disappears. > > Then, I also get the following exception - probably be

svn commit: r1528758 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServletInputStream.java

2013-10-03 Thread markt
Author: markt Date: Thu Oct 3 09:01:49 2013 New Revision: 1528758 URL: http://svn.apache.org/r1528758 Log: Ensure the APR/native error for EOF is reported as an EOF. Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/AprServletInputStream.java Modified: tomcat/trunk/java/org/apa

Re: 8.0.x / 7.0.x progress

2013-10-03 Thread Mark Thomas
On 02/10/2013 20:36, Konstantin Preißer wrote: > Hi Mark, > >> -Original Message- >> From: Mark Thomas [mailto:ma...@apache.org] >> Sent: Wednesday, October 2, 2013 7:28 PM >> To: Tomcat Developers List >> Subject: Re: 8.0.x / 7.0.x progress >> >> On 01/10/2013 19:39, Mark Thomas wrote: >>