Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-01 Thread Mladen Turk
On 10/01/2013 07:32 PM, sebb wrote: If a Java application succeeds in crashing the JVM, then IMO the JVM has a bug. I believe that all native code should strive to behave the same way. This is conceptual difference. Most of those checks are done again inside Java. However inside JVM the Java

[Bug 55608] fmt:bundle tag unnecessarily buffers body content

2013-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55608 --- Comment #8 from Dan Armstrong --- Agreed that changing component behavior, even if the change is inline with the spec, can be problematic. Especially within a minor release in series like 1.1.2 -> 1.1.3. Consider Oracle changing Java

[Bug 55608] fmt:bundle tag unnecessarily buffers body content

2013-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55608 --- Comment #7 from Kris Schneider --- I don't think the page directive and its attributes really have any bearing on this, but since I generally agree with the changes, it's probably not worth going into. The JSTL 1.1 & 1.2 specs have this

[Bug 55608] fmt:bundle tag unnecessarily buffers body content

2013-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55608 --- Comment #6 from Christopher Schultz --- (In reply to Dan Armstrong from comment #4) > (In reply to Christopher Schultz from comment #3) > > One could argue that might actually be used to intentionally > > buffer content a bit, just in

[Bug 55608] fmt:bundle tag unnecessarily buffers body content

2013-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55608 --- Comment #5 from Dan Armstrong --- Created attachment 30899 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30899&action=edit Diff for changes to current trunk of BundleSupport.java I have attached a diff for the current trun

[Bug 55608] fmt:bundle tag unnecessarily buffers body content

2013-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55608 --- Comment #4 from Dan Armstrong --- (In reply to Christopher Schultz from comment #3) > One could argue that might actually be used to intentionally > buffer content a bit, just in case an error occurs. Once the response is > committed,

svn commit: r1528258 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 22:59:31 2013 New Revision: 1528258 URL: http://svn.apache.org/r1528258 Log: Async timeouts are checked roughly once a second. Check connection and keep-alive timeouts using the same period (rather than roughly every 5s) Modified: tomcat/trunk/java/org/apache/t

svn commit: r1528250 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 22:48:15 2013 New Revision: 1528250 URL: http://svn.apache.org/r1528250 Log: Ensure that the Poller actions socket close requests ASAP Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Pr

svn commit: r1528248 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 22:46:22 2013 New Revision: 1528248 URL: http://svn.apache.org/r1528248 Log: Ensure that the Poller actions socket close requests ASAP Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net

RE: 8.0.x / 7.0.x progress

2013-10-01 Thread Konstantin Preißer
Hi Mark, > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Tuesday, October 1, 2013 8:39 PM > To: Tomcat Developers List > Subject: 8.0.x / 7.0.x progress > > Pulling together information from multiple threads: > > 8.0.x trunk appears to be stable (i.e. no longer

svn commit: r1528212 - /tomcat/tc7.0.x/trunk/webapps/examples/jsp/jsptoserv/jts.html

2013-10-01 Thread kpreisser
Author: kpreisser Date: Tue Oct 1 20:36:09 2013 New Revision: 1528212 URL: http://svn.apache.org/r1528212 Log: Fix broken link to "ServletToJsp.java.html" - it is generated by Ant txt2html task. Modified: tomcat/tc7.0.x/trunk/webapps/examples/jsp/jsptoserv/jts.html Modified: tomcat/tc7.0.x

svn commit: r1528211 - /tomcat/trunk/java/org/apache/tomcat/buildutil/Txt2Html.java

2013-10-01 Thread kpreisser
Author: kpreisser Date: Tue Oct 1 20:26:55 2013 New Revision: 1528211 URL: http://svn.apache.org/r1528211 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55383 - Improve HTML markup of generated pages by Txt2HTML ant task. - Use declared encoding ("ISO-8859-1") instead of default enco

RE: Broken links

2013-10-01 Thread Konstantin Preißer
On 26.9.2013 15:00, Konstantin Preißer wrote: > When looking at 3) and browsing in SVN history, it seems there never was such > a HTML > page that contains the source for servletToJsp.java. However, as I'm working > on improving > the HTML markup, I'm looking if we can get rid of those static HTM

svn commit: r1528178 - /tomcat/trunk/webapps/examples/jsp/jsptoserv/jts.html

2013-10-01 Thread kpreisser
Author: kpreisser Date: Tue Oct 1 18:46:55 2013 New Revision: 1528178 URL: http://svn.apache.org/r1528178 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55383 Improve markup of HTML page. Fix broken link to "ServletToJsp.java.html" - it is generated by Ant txt2html task. Modified:

svn commit: r1528177 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/res/LocalStrings.properties

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 18:43:32 2013 New Revision: 1528177 URL: http://svn.apache.org/r1528177 Log: More debug logging for the APR/native connector. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/

svn commit: r1528176 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 18:43:04 2013 New Revision: 1528176 URL: http://svn.apache.org/r1528176 Log: Address issue reported with high CPU usage under low load load. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.ja

svn commit: r1528174 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 18:41:43 2013 New Revision: 1528174 URL: http://svn.apache.org/r1528174 Log: Ensure that connectionCount remains thread-safe Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Propchange:

svn commit: r1528175 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 18:42:37 2013 New Revision: 1528175 URL: http://svn.apache.org/r1528175 Log: If there are sockets to close, close them rather than waiting for the next Poller run. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat

8.0.x / 7.0.x progress

2013-10-01 Thread Mark Thomas
Pulling together information from multiple threads: 8.0.x trunk appears to be stable (i.e. no longer crashes) but the FormAuthenticator unit tests are very slow (24 minutes). This needs to be resolved. I will port the latest APR changes to 7.0.x shortly. A build of the latest 1.1.x tomcat-native

svn commit: r1528172 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java res/LocalStrings.properties

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 18:28:42 2013 New Revision: 1528172 URL: http://svn.apache.org/r1528172 Log: More debug logging for the APR/native connector. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalString

svn commit: r1528171 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 18:27:42 2013 New Revision: 1528171 URL: http://svn.apache.org/r1528171 Log: Address issue reported with high CPU usage under low load load. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/ut

svn commit: r1528169 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 18:19:21 2013 New Revision: 1528169 URL: http://svn.apache.org/r1528169 Log: If there are sockets to close, close them rather than waiting for the next Poller run. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/ja

svn commit: r1528166 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 18:13:30 2013 New Revision: 1528166 URL: http://svn.apache.org/r1528166 Log: Ensure that connectionCount remains thread-safe Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoi

svn commit: r1528158 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/res/LocalStrings.properties

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 17:49:49 2013 New Revision: 1528158 URL: http://svn.apache.org/r1528158 Log: Better log message for socket destruction and remove reference to deleted parameter Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/u

buildbot success in ASF Buildbot on tomcat-trunk

2013-10-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5029 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-01 Thread sebb
On 1 October 2013 15:47, Christopher Schultz wrote: > Mladen, > > On 10/1/13 10:39 AM, Mladen Turk wrote: >> On 10/01/2013 04:15 PM, Christopher Schultz wrote: >>> Mladen and Rainer, > > -1. You are just hiding the reason for crash. >>> >>> I disagree: the reason for the crash can still be

Re: Need to test build of tc native 1.1.x

2013-10-01 Thread Mladen Turk
On 10/01/2013 06:46 PM, Mark Thomas wrote: Here you go http://people.apache.org/~mturk/native/tomcat-native-win32-x86_64-r1528132.zip You forgot to make the file public readable so I used my infra karma to fix that :) Yeah, I always forget that sftp from samba drive sets weird privs. Glad i

Re: Need to test build of tc native 1.1.x

2013-10-01 Thread Mark Thomas
On 01/10/2013 17:46, Mark Thomas wrote: > On 01/10/2013 17:21, Mladen Turk wrote: >> On 10/01/2013 05:03 PM, Mark Thomas wrote: >>> I think one of the current issues has been fixed in 1.1.x. I'm trying to >>> build it locally but if anyone who has a build env to hand to build a >>> AMD 64-bit tc-na

Re: Need to test build of tc native 1.1.x

2013-10-01 Thread Mark Thomas
On 01/10/2013 17:21, Mladen Turk wrote: > On 10/01/2013 05:03 PM, Mark Thomas wrote: >> I think one of the current issues has been fixed in 1.1.x. I'm trying to >> build it locally but if anyone who has a build env to hand to build a >> AMD 64-bit tc-native dll for me that would be a big help. >> >

svn commit: r1528141 - /tomcat/trunk/webapps/docs/images/docs-stylesheet.css

2013-10-01 Thread kpreisser
Author: kpreisser Date: Tue Oct 1 16:37:43 2013 New Revision: 1528141 URL: http://svn.apache.org/r1528141 Log: Replace tab with spaces Modified: tomcat/trunk/webapps/docs/images/docs-stylesheet.css Modified: tomcat/trunk/webapps/docs/images/docs-stylesheet.css URL: http://svn.apache.org/vi

svn commit: r1528140 - /tomcat/trunk/webapps/docs/images/docs-stylesheet.css

2013-10-01 Thread kpreisser
Author: kpreisser Date: Tue Oct 1 16:35:39 2013 New Revision: 1528140 URL: http://svn.apache.org/r1528140 Log: Fix style for element in comments section. Modified: tomcat/trunk/webapps/docs/images/docs-stylesheet.css Modified: tomcat/trunk/webapps/docs/images/docs-stylesheet.css URL: http

Re: Need to test build of tc native 1.1.x

2013-10-01 Thread Mladen Turk
On 10/01/2013 05:03 PM, Mark Thomas wrote: I think one of the current issues has been fixed in 1.1.x. I'm trying to build it locally but if anyone who has a build env to hand to build a AMD 64-bit tc-native dll for me that would be a big help. Here you go http://people.apache.org/~mturk/native

Re: Need to test build of tc native 1.1.x

2013-10-01 Thread Mladen Turk
On 10/01/2013 05:03 PM, Mark Thomas wrote: I think one of the current issues has been fixed in 1.1.x. I'm trying to build it locally but if anyone who has a build env to hand to build a AMD 64-bit tc-native dll for me that would be a big help. Give one hour. I have the env. Cheers -- ^TM ---

[Bug 45067] UDecoder.java stack dumps on valid URL encoding

2013-10-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45067 ankaraju.devath...@gmail.com changed: What|Removed |Added Hardware|PC |All

Need to test build of tc native 1.1.x

2013-10-01 Thread Mark Thomas
I think one of the current issues has been fixed in 1.1.x. I'm trying to build it locally but if anyone who has a build env to hand to build a AMD 64-bit tc-native dll for me that would be a big help. Thanks, Mark - To unsubscri

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-01 Thread Christopher Schultz
Mladen, On 10/1/13 10:39 AM, Mladen Turk wrote: > On 10/01/2013 04:15 PM, Christopher Schultz wrote: >> Mladen and Rainer, -1. You are just hiding the reason for crash. >> >> I disagree: the reason for the crash can still be reported. It just >> won't be reported with a JVM crash: instea

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-01 Thread Mladen Turk
On 10/01/2013 04:15 PM, Christopher Schultz wrote: Mladen and Rainer, -1. You are just hiding the reason for crash. I disagree: the reason for the crash can still be reported. It just won't be reported with a JVM crash: instead, there will be an exception. I disagree on your disagreement :)

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-01 Thread Christopher Schultz
Mladen and Rainer, On 10/1/13 2:59 AM, Rainer Jung wrote: > On 01.10.2013 06:53, Mladen Turk wrote: >> On 09/30/2013 08:50 PM, Christopher Schultz wrote: >>> Mladen, >>> >>> Unless there is significant objection, >> >> Yes there is. >> The transition from Java to JNI costs 10 times then >> then a

[jira] [Commented] (MTOMCAT-240) Artifacts with same artifactID but different groupID are skipped

2013-10-01 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782909#comment-13782909 ] Hudson commented on MTOMCAT-240: SUCCESS: Integrated in TomcatMavenPlugin-mvn3.x #256 (Se

buildbot failure in ASF Buildbot on tomcat-trunk

2013-10-01 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5028 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

[jira] [Closed] (MTOMCAT-240) Artifacts with same artifactID but different groupID are skipped

2013-10-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-240. -- Resolution: Fixed patch applied. Thanks! > Artifacts with same artifactID but

svn commit: r1528074 - /tomcat/maven-plugin/trunk/pom.xml

2013-10-01 Thread olamy
Author: olamy Date: Tue Oct 1 12:57:55 2013 New Revision: 1528074 URL: http://svn.apache.org/r1528074 Log: add contributor Modified: tomcat/maven-plugin/trunk/pom.xml Modified: tomcat/maven-plugin/trunk/pom.xml URL: http://svn.apache.org/viewvc/tomcat/maven-plugin/trunk/pom.xml?rev=1528074

svn commit: r1528073 - /tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/run/DefaultClassLoaderEntriesCalculator.java

2013-10-01 Thread olamy
Author: olamy Date: Tue Oct 1 12:57:44 2013 New Revision: 1528073 URL: http://svn.apache.org/r1528073 Log: [MTOMCAT-240] Artifacts with same artifactID but different groupID are skipped Submitted by Petar Tahchiev Modified: tomcat/maven-plugin/trunk/common-tomcat-maven-plugin/src/main/java

[jira] [Commented] (MTOMCAT-240) Artifacts with same artifactID but different groupID are skipped

2013-10-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782870#comment-13782870 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-240: doh I didn't know war pl

[jira] [Commented] (MTOMCAT-240) Artifacts with same artifactID but different groupID are skipped

2013-10-01 Thread Petar Tahchiev (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782866#comment-13782866 ] Petar Tahchiev commented on MTOMCAT-240: It copies both, but changes their names

[jira] [Commented] (MTOMCAT-240) Artifacts with same artifactID but different groupID are skipped

2013-10-01 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782855#comment-13782855 ] Olivier Lamy (*$^¨%`£) commented on MTOMCAT-240: I wonder if more than on

svn commit: r1528060 - /tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties

2013-10-01 Thread markt
Author: markt Date: Tue Oct 1 12:05:40 2013 New Revision: 1528060 URL: http://svn.apache.org/r1528060 Log: Better log message for socket destruction and remove reference to deleted parameter Modified: tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties Modified: tomca

Re: [VOTE] Release Apache Tomcat 7.0.45

2013-10-01 Thread Mark Thomas
On 01/10/2013 10:18, Mark Thomas wrote: > On 01/10/2013 00:29, Konstantin Preißer wrote: > >> Hi Mark, >> >> I just tested trunk with r1527733, but unfortanetly I still see the same >> crashes in tcnative-1.dll. > > Hmm. I can't re-create these any more. Are you sure you are using the > latest 8

Re: [VOTE] Release Apache Tomcat 7.0.45

2013-10-01 Thread Ognjen Blagojevic
Mark, On 1.10.2013 11:18, Mark Thomas wrote: I just tested trunk with r1527733, but unfortanetly I still see the same crashes in tcnative-1.dll. Hmm. I can't re-create these any more. Are you sure you are using the latest 8.0.x code? I also still get the crash with r1527985. -Ognjen -

Re: [VOTE] Release Apache Tomcat 7.0.45

2013-10-01 Thread Mark Thomas
On 01/10/2013 00:29, Konstantin Preißer wrote: > Hi Mark, > > I just tested trunk with r1527733, but unfortanetly I still see the same > crashes in tcnative-1.dll. Hmm. I can't re-create these any more. Are you sure you are using the latest 8.0.x code? I do see a hang when running the unit tes

Re: Recent tcnative null-dereference with 8.0.0-RC3 and 7.0.45 [tcnative-1.dll+0x7e23]

2013-10-01 Thread Rainer Jung
On 01.10.2013 06:53, Mladen Turk wrote: > On 09/30/2013 08:50 PM, Christopher Schultz wrote: >> Mladen, >> >> Unless there is significant objection, > > Yes there is. > The transition from Java to JNI costs 10 times then > then a simple 'if (socket == OL)' in java > >> I'd like to add such NULL