Re: [ANN] New committer: Konstantin Preißer

2013-09-24 Thread Henri Gomez
Welcome Konstantin Nice to see than such a venerable project like Tomcat still attract new commiters :) 2013/9/25 Mark Thomas > On behalf of the Tomcat committers I am pleased to announce that > Konstantin Preißer has been voted in as a new Tomcat committer. > > In addition to a number of high

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2013-09-24 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration.

svn commit: r1526052 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 23:50:09 2013 New Revision: 1526052 URL: http://svn.apache.org/r1526052 Log: Removal of a socket from the poller needs to happen on the poller thread as removal, like addition, is not thread safe. Removal of a socket from the poller needs to remove the socket from t

Re: Issue in AprEndpoint detected by TestCoyoteAdapter

2013-09-24 Thread Mark Thomas
On 24/09/2013 16:19, Mark Thomas wrote: > On 24/09/2013 08:16, Mark Thomas wrote: >> On 23/09/2013 00:54, Rainer Jung wrote: >> >>> I agree that there's probably another problem further up the stack. >> >> I'm looking at this now. > > I've found a couple of issues. Not sure if either of these are

Re: svn commit: r1525975 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2013-09-24 Thread Olivier Lamy
Welcome! On 25 September 2013 05:10, wrote: > Author: kpreisser > Date: Tue Sep 24 19:10:44 2013 > New Revision: 1525975 > > URL: http://svn.apache.org/r1525975 > Log: > Add myself to the committers list. > > Modified: > tomcat/site/trunk/docs/whoweare.html > tomcat/site/trunk/xdocs/whow

Re: Issue in AprEndpoint detected by TestCoyoteAdapter

2013-09-24 Thread Mark Thomas
On 24/09/2013 08:16, Mark Thomas wrote: > On 23/09/2013 00:54, Rainer Jung wrote: > >> I agree that there's probably another problem further up the stack. > > I'm looking at this now. I've found a couple of issues. Not sure if either of these are the root cause of the remaining issues we see but

svn commit: r1526043 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 22:49:13 2013 New Revision: 1526043 URL: http://svn.apache.org/r1526043 Log: Narrow scope of localAddList Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http:

svn commit: r1526036 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 22:39:14 2013 New Revision: 1526036 URL: http://svn.apache.org/r1526036 Log: Reduce visibility Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apach

[ANN] New committer: Konstantin Preißer

2013-09-24 Thread Mark Thomas
On behalf of the Tomcat committers I am pleased to announce that Konstantin Preißer has been voted in as a new Tomcat committer. In addition to a number of high quality bug reports and patches, Konstantin is also responsible for the makeover the Tomcat web site and Tomcat 8 documentation has recei

RE: svn commit: r1525975 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2013-09-24 Thread Konstantin Preißer
Hi Mark, > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Tuesday, September 24, 2013 10:02 PM > I guess everything works then :) Yes, E-Mail and SVN seem to be working. :) > A very warm welcome. Thanks! Konstantin -

Re: svn commit: r1525977 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2013-09-24 Thread Christopher Schultz
Konstantin, On 9/24/13 3:22 PM, kpreis...@apache.org wrote: > Author: kpreisser Welcome! -chris signature.asc Description: OpenPGP digital signature

svn commit: r1526018 - in /tomcat/site/trunk: ./ docs/tomcat-8.0-doc/ docs/tomcat-8.0-doc/api/ docs/tomcat-8.0-doc/api/org/apache/catalina/ docs/tomcat-8.0-doc/api/org/apache/catalina/ant/ docs/tomcat

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 21:33:05 2013 New Revision: 1526018 URL: http://svn.apache.org/r1526018 Log: Update docs to 8.0.0-RC3 [This commit notification would consist of 125 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.] --

svn commit: r2975 - /release/tomcat/tomcat-8/v8.0.0-RC1/

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 20:44:43 2013 New Revision: 2975 Log: Remove old release Removed: release/tomcat/tomcat-8/v8.0.0-RC1/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mai

svn commit: r2975 - /release/tomcat/tomcat-8/v8.0.0-RC1/

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 20:44:43 2013 New Revision: 2975 Log: Remove old release Removed: release/tomcat/tomcat-8/v8.0.0-RC1/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mai

[ANN] Apache Tomcat 8.0.0-RC3 (alpha) available

2013-09-24 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 8.0.0-RC3 (alpha). Apache Tomcat 8 is an open source software implementation of the Java Servlet, JavaServer Pages, Java Unified Expression Language and Java WebSocket technologies. Apache Tomcat 8 is aligned with Java E

svn commit: r1526000 - in /tomcat/site/trunk: docs/doap_Tomcat.rdf docs/download-80.html docs/index.html docs/oldnews.html docs/whichversion.html xdocs/doap_Tomcat.rdf xdocs/download-80.xml xdocs/inde

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 20:30:42 2013 New Revision: 1526000 URL: http://svn.apache.org/r1526000 Log: Update main site for 8.0.0-RC3 Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/docs/download-80.html tomcat/site/trunk/docs/index.html tomcat/site/trunk/d

svn commit: r1525996 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-09-24 Thread violetagg
Author: violetagg Date: Tue Sep 24 20:15:18 2013 New Revision: 1525996 URL: http://svn.apache.org/r1525996 Log: Mark 7.0.44 as not released based on the vote results. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: htt

svn commit: r1525995 - in /tomcat/tc7.0.x/trunk/res/maven: mvn-pub.xml tomcat-websocket.pom tomcat7-websocket.pom

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 20:14:50 2013 New Revision: 1525995 URL: http://svn.apache.org/r1525995 Log: Add the Tomcat 7 WebSocket impl JAR to the maven upload script Added: tomcat/tc7.0.x/trunk/res/maven/tomcat7-websocket.pom - copied, changed from r1525898, tomcat/tc7.0.x/trunk/r

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Mark Thomas
On 24/09/2013 08:40, Mark Thomas wrote: > On 24/09/2013 08:07, Martin Grigorov wrote: >> On Tue, Sep 24, 2013 at 4:35 PM, Rossen Stoyanchev < >>> Also what's the equivalent of the Tomcat 8 tomcat-websocket >>> dependency? I see the 7.0.44 binary has tomcat7-websocket.jar but I >>> >> >> Here is wh

svn commit: r1525994 - /tomcat/tc7.0.x/trunk/build.xml

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 20:12:42 2013 New Revision: 1525994 URL: http://svn.apache.org/r1525994 Log: Correct reference to name of Tomcat 7 WebSocket implementation source JAR Modified: tomcat/tc7.0.x/trunk/build.xml Modified: tomcat/tc7.0.x/trunk/build.xml URL: http://svn.apache.org/

svn commit: r2974 - /dev/tomcat/tomcat-7/v7.0.44/

2013-09-24 Thread violetagg
Author: violetagg Date: Tue Sep 24 20:07:02 2013 New Revision: 2974 Log: 7.0.44 RC did not pass the vote - dropping. Removed: dev/tomcat/tomcat-7/v7.0.44/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For addi

svn commit: r2974 - /dev/tomcat/tomcat-7/v7.0.44/

2013-09-24 Thread violetagg
Author: violetagg Date: Tue Sep 24 20:07:02 2013 New Revision: 2974 Log: 7.0.44 RC did not pass the vote - dropping. Removed: dev/tomcat/tomcat-7/v7.0.44/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For addi

Re: svn commit: r1525975 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2013-09-24 Thread Mark Thomas
On 24/09/2013 12:10, kpreis...@apache.org wrote: > Author: kpreisser > Date: Tue Sep 24 19:10:44 2013 > New Revision: 1525975 > > URL: http://svn.apache.org/r1525975 > Log: > Add myself to the committers list. I guess everything works then :) A very warm welcome. Mark

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Violeta Georgieva
2013/9/24 Nick Williams > > > On Sep 24, 2013, at 11:00 AM, Rossen Stoyanchev wrote: > > > On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas wrote: > > > >> The necessary update to the script that uploads those JARs to the Maven > >> repo was missed. I think I have fixed it locally but need to test i

svn commit: r1525977 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2013-09-24 Thread kpreisser
Author: kpreisser Date: Tue Sep 24 19:22:58 2013 New Revision: 1525977 URL: http://svn.apache.org/r1525977 Log: Fix link to the Apache Committers list - it is now handled by the ASF Infrastructure. Modified: tomcat/site/trunk/docs/whoweare.html tomcat/site/trunk/xdocs/whoweare.xml Modif

svn commit: r1525975 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2013-09-24 Thread kpreisser
Author: kpreisser Date: Tue Sep 24 19:10:44 2013 New Revision: 1525975 URL: http://svn.apache.org/r1525975 Log: Add myself to the committers list. Modified: tomcat/site/trunk/docs/whoweare.html tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/docs/whoweare.html URL: http

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Nick Williams
On Sep 24, 2013, at 11:00 AM, Rossen Stoyanchev wrote: > On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas wrote: > >> The necessary update to the script that uploads those JARs to the Maven >> repo was missed. I think I have fixed it locally but need to test it >> from somewhere with connectivity.

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Rossen Stoyanchev
On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas wrote: > The necessary update to the script that uploads those JARs to the Maven > repo was missed. I think I have fixed it locally but need to test it > from somewhere with connectivity. Unless the JavaOne Wifi is > significantly better than yesterda

svn commit: r1525932 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 15:58:22 2013 New Revision: 1525932 URL: http://svn.apache.org/r1525932 Log: Fix issue with unwrapping. Cast needs to use the unwrapped request object. Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java Modified: tomcat/tc

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Mark Thomas
On 24/09/2013 08:52, Rossen Stoyanchev wrote: > On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas wrote: > >> Tomcat should already being the necessary unwrapping in lines 179-181. >> It isn't immediately clear to me why this isn't working as intended. Can >> you denug this and add some insight? > >

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Rossen Stoyanchev
On Tue, Sep 24, 2013 at 11:40 AM, Mark Thomas wrote: > Tomcat should already being the necessary unwrapping in lines 179-181. > It isn't immediately clear to me why this isn't working as intended. Can > you denug this and add some insight? Indeed, the code does unwrap the request correctly but t

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Mark Thomas
On 24/09/2013 08:07, Martin Grigorov wrote: > Hi Rossen, > > > On Tue, Sep 24, 2013 at 4:35 PM, Rossen Stoyanchev < > rstoyanc...@gopivotal.com> wrote: > >> I am getting a ClassCastException when using (non JSR-356) upgrade, >> i.e. WsServerContainer.doUpgrade: >> >> Caused by: java.lang.ClassCa

Re: Issue in AprEndpoint detected by TestCoyoteAdapter

2013-09-24 Thread Mark Thomas
On 23/09/2013 00:54, Rainer Jung wrote: > I agree that there's probably another problem further up the stack. I'm looking at this now. > Since the apr endpoint explicitely uses the return value of remove to > decide whether something was removed, APT_NOTFOUND seems better. But as > you said: why

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Martin Grigorov
Hi Rossen, On Tue, Sep 24, 2013 at 4:35 PM, Rossen Stoyanchev < rstoyanc...@gopivotal.com> wrote: > I am getting a ClassCastException when using (non JSR-356) upgrade, > i.e. WsServerContainer.doUpgrade: > > Caused by: java.lang.ClassCastException: > > org.springframework.security.web.servletapi

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Christopher Schultz
Violetta, On 9/24/13 10:01 AM, Christopher Schultz wrote: > Building tomcat-dbcp with Java 1.6 and resuming the build with Java 7 > shows everything is okay. > > But, when I run all the tests, I get lots and lots of failures: > Testsuite: javax.el.TestArrayELResolver > Tests run: 1, Failures: 0,

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Christopher Schultz
Rossen, On 9/24/13 10:35 AM, Rossen Stoyanchev wrote: > I am getting a ClassCastException when using (non JSR-356) upgrade, > i.e. WsServerContainer.doUpgrade: > > Caused by: java.lang.ClassCastException: > org.springframework.security.web.servletapi.HttpServlet3RequestFactory$Servlet3SecurityCon

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Rossen Stoyanchev
I am getting a ClassCastException when using (non JSR-356) upgrade, i.e. WsServerContainer.doUpgrade: Caused by: java.lang.ClassCastException: org.springframework.security.web.servletapi.HttpServlet3RequestFactory$Servlet3SecurityContextHolderAwareRequestWrapper cannot be cast to org.apache.catali

buildbot success in ASF Buildbot on tomcat-trunk

2013-09-24 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5001 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: [WS] To flush or not to flush

2013-09-24 Thread Remy Maucherat
On Tue, 2013-09-24 at 06:34 -0700, Mark Thomas wrote: > Non-blocking IO with non-upgraded streams still uses the standard > buffering mechanisms. > > I agree some clarification is required. When section 5.1 discusses > buffering, it does so in the context of the ServletResponse object so it > isn'

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Christopher Schultz
Violetta, On 9/23/13 4:58 PM, Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.44 release is now available for voting. > This release candidate contains JSR-356 Java WebSocket 1.0 implementation. > Note that use of this functionality requires Java 7. > > It can be obtained from: > https:

Re: Refactoring class loader access to resources

2013-09-24 Thread Romain Manni-Bucau
Hi about the expanding, tomee forces it so an option can work. I agree with you "theorically" components shouldn't do it but in practises they have to (there is no real solutions on this side. That's why all APIs about scanning ends with a SPI :(). About addURL I think you are right too and addUR

Re: [WS] To flush or not to flush

2013-09-24 Thread Mark Thomas
On 23/09/2013 09:43, Remy Maucherat wrote: > Hi Mark, > > Unless I missed something, Websockets 1.0 on Servlet 3.1 upgrade doesn't > do much flushing, so that the IS/OS used in upgrade must effectively > just write immediately the data (and ensure it is really sent over the > wire). Correct. Unle

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Jeanfrancois Arcand
On 2013-09-23 4:58 PM, Violeta Georgieva wrote: The proposed Apache Tomcat 7.0.44 release is now available for voting. This release candidate contains JSR-356 Java WebSocket 1.0 implementation. Note that use of this functionality requires Java 7. It can be obtained from: https://dist.apache.org

svn commit: r1525881 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/util/ParameterMap.java java/org/apache/tomcat/util/http/Parameters.java test/org/apache/tomcat/util/http/TestParameters.jav

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 13:22:49 2013 New Revision: 1525881 URL: http://svn.apache.org/r1525881 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55576 Preserve the order that request parameters were presented by the client. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1525880 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestParameters.java

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 13:17:32 2013 New Revision: 1525880 URL: http://svn.apache.org/r1525880 Log: Fix unit test now that parameters are returned in the order they are received. Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestParameters.java Modified: tomcat/trunk/test/o

svn commit: r1525879 - /tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java

2013-09-24 Thread markt
Author: markt Date: Tue Sep 24 13:14:11 2013 New Revision: 1525879 URL: http://svn.apache.org/r1525879 Log: Fix typo Modified: tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamHandlerFactory.java Modified: tomcat/trunk/java/org/apache/catalina/webresources/TomcatURLStreamH

Re: Refactoring class loader access to resources

2013-09-24 Thread Mark Thomas
On 24/09/2013 05:05, Romain Manni-Bucau wrote: > Hi > > about the handler: a lot of container (i particularly know tomee but not > only) use string representation of URL to find file to then work on the > file (either during scanning or sometimes for some more advanced "hack"). > If you introduce

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Martin Grigorov
On Mon, Sep 23, 2013 at 10:58 PM, Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.44 release is now available for voting. > This release candidate contains JSR-356 Java WebSocket 1.0 implementation. > Note that use of this functionality requires Java 7. > > It can be obtained from: > htt

Re: Refactoring class loader access to resources

2013-09-24 Thread Romain Manni-Bucau
Hi about the handler: a lot of container (i particularly know tomee but not only) use string representation of URL to find file to then work on the file (either during scanning or sometimes for some more advanced "hack"). If you introduce something not known by these framework it will just fail. T

Re: Refactoring class loader access to resources

2013-09-24 Thread Mark Thomas
On 23/09/2013 21:52, Romain Manni-Bucau wrote: > I already explained how t8 loader and WebResource breaks libs based on std > URLClassLoader I've looked back through the dev list archives and can't find any specific information that describes the problem in any detail. I'm fairly confident that wh

Re: Why does mod_jk require a C++ compiler instead of just C?

2013-09-24 Thread Rainer Jung
On 24.09.2013 11:58, Mladen Turk wrote: > On 09/23/2013 10:58 PM, Christopher Schultz wrote: >> All, >> >> Someone recently on the users list[1] had some trouble building mod_jk >> and it turned out that the problem was a missing c++ compiler. >> > > There is nothing in the code that would require

svn commit: r1525831 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/session/BackupManager.java java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xml

2013-09-24 Thread kfujino
Author: kfujino Date: Tue Sep 24 10:22:24 2013 New Revision: 1525831 URL: http://svn.apache.org/r1525831 Log: Logger instance of cluster session manager is changed to non-static in order to enable logging of each application. Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session

svn commit: r1525827 - in /tomcat/trunk/java/org/apache/catalina/ha/session: BackupManager.java DeltaManager.java

2013-09-24 Thread kfujino
Author: kfujino Date: Tue Sep 24 10:08:58 2013 New Revision: 1525827 URL: http://svn.apache.org/r1525827 Log: Logger instance of cluster session manager is changed to non-static in order to enable logging of each application. Modified: tomcat/trunk/java/org/apache/catalina/ha/session/BackupM

Re: Why does mod_jk require a C++ compiler instead of just C?

2013-09-24 Thread Mladen Turk
On 09/23/2013 10:58 PM, Christopher Schultz wrote: All, Someone recently on the users list[1] had some trouble building mod_jk and it turned out that the problem was a missing c++ compiler. There is nothing in the code that would require C++. It's probably an extra (or copy/paste) configure r

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-09-24 Thread Bill Barker
Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-20130924.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.1-SNAPSHOT.jar -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20130924-native-src.tar.gz -Dexampl