Re: Problem with o.a.c.webresources and packed WARs

2013-09-13 Thread Violeta Georgieva
Hi Mark, 2013/9/13 Mark Thomas > > a) Unpack JAR resources to the work dir and return a URL to the unpacked > location -1 > > In trying to decide between b) and c) I came to the conclusion that it > would be better to keep the war:// url scheme and generic tomcat:// url > schemes separated even

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Nick Williams changed: What|Removed |Added Attachment #30825|0 |1 is obsolete|

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Christopher Schultz
Mark, On 9/13/13 6:03 PM, Christopher Schultz wrote: > On 9/13/13 5:50 AM, Mark Thomas wrote: >> This release needs some more votes. It is currently blocking both the >> 7.0.43 and the 8.0.0-RC2 releases. > > What actually changed that needs to be in 7.0.43? The changelog for > tcnative 1.1.28 do

svn commit: r1523127 - /tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml

2013-09-13 Thread schultz
Author: schultz Date: Fri Sep 13 22:14:13 2013 New Revision: 1523127 URL: http://svn.apache.org/r1523127 Log: Added changelog item to match the patch in r1518225. Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneous/changelog.xml Modified: tomcat/native/branches/1.1.x/xdocs/miscellaneo

svn commit: r1523126 - /tomcat/native/branches/1.1.x/README.txt

2013-09-13 Thread schultz
Author: schultz Date: Fri Sep 13 22:10:58 2013 New Revision: 1523126 URL: http://svn.apache.org/r1523126 Log: Re-fixed paths in build instructions. svn != release. Modified: tomcat/native/branches/1.1.x/README.txt Modified: tomcat/native/branches/1.1.x/README.txt URL: http://svn.apache.org/

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Christopher Schultz
Mark, On 9/13/13 5:50 AM, Mark Thomas wrote: > This release needs some more votes. It is currently blocking both the > 7.0.43 and the 8.0.0-RC2 releases. What actually changed that needs to be in 7.0.43? The changelog for tcnative 1.1.28 does not have a whole lot in it... -chris signature.asc

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Christopher Schultz
Rainer, On 9/13/13 5:51 PM, Rainer Jung wrote: > Please add a short information what the purpose of tcnative actualky is > in the the announcement for 1.1.28. There is also http://svn.apache.org/r1507114 which adds a decent description to the web site. The online documentation just hasn't been re

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Rainer Jung
On 09.09.2013 13:31, Mladen Turk wrote: > Version 1.1.28 is bug fixing release. > The proposed release artefacts can be found at [1], > and the build was done using tag [2]. > > The VOTE will remain open for at least 48 hours. > > The Apache Tomcat Native 1.1.28 is > [X] Stable, go ahead and rel

svn commit: r1523120 - /tomcat/native/branches/1.1.x/TODO.txt

2013-09-13 Thread rjung
Author: rjung Date: Fri Sep 13 21:46:41 2013 New Revision: 1523120 URL: http://svn.apache.org/r1523120 Log: Remove obsolete item. Modified: tomcat/native/branches/1.1.x/TODO.txt Modified: tomcat/native/branches/1.1.x/TODO.txt URL: http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/TO

Re: Problem with o.a.c.webresources and packed WARs

2013-09-13 Thread Konstantin Kolinko
2013/9/13 Mark Thomas : > I started to look at Bug 52489 [1] which is requesting code signing > support for WARs. I decided to work with an unpacked version of the > examples application. During testing, I noticed that WEB-INF/classes and > WEB-INF/lib were always being unpacked to the work directo

Re: Problem with o.a.c.webresources and packed WARs

2013-09-13 Thread Mark Thomas
On 13/09/2013 17:23, Christopher Schultz wrote: > Mark, > > On 9/13/13 9:16 AM, Mark Thomas wrote: >> The Javadoc for ServletContext#getResource() [3] is clear. The >> container must provide a URL for every resource and that URL must >> be usable. > > Usable by whom? (Sounds like a dumb question,

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #20 from Mark Thomas --- (In reply to Nick Williams from comment #19) > (In reply to Jeremy Boynes from comment #18) > > 1) CopyOnWriteArrayList would simplify managing added transformers and is > > intended for this use-case. >

Re: Problem with o.a.c.webresources and packed WARs

2013-09-13 Thread Christopher Schultz
Mark, On 9/13/13 9:16 AM, Mark Thomas wrote: > The Javadoc for ServletContext#getResource() [3] is clear. The container > must provide a URL for every resource and that URL must be usable. Usable by whom? (Sounds like a dumb question, but please see below) > There > is an immediate issue with re

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Christopher Schultz
Mladen, On 9/9/13 7:31 AM, Mladen Turk wrote: > Version 1.1.28 is bug fixing release. > The proposed release artefacts can be found at [1], > and the build was done using tag [2]. > > The VOTE will remain open for at least 48 hours. > > The Apache Tomcat Native 1.1.28 is > [X] Stable, go ahead

[VOTE][RESULT] Over-zealous svn commit to Tomcat 6.0

2013-09-13 Thread Christopher Schultz
All, > Patch http://svn.apache.org/r1521514 is > > [ ] Okay, leave it committed and don't do it again > [ ] Broken, revert and propose an alternate patch > [ ] Committed in violation of the RTC policy, revert and propose Okay - binding:markt, kkolinko, rjung[1] non-binding:schultz No

Problem with o.a.c.webresources and packed WARs

2013-09-13 Thread Mark Thomas
I started to look at Bug 52489 [1] which is requesting code signing support for WARs. I decided to work with an unpacked version of the examples application. During testing, I noticed that WEB-INF/classes and WEB-INF/lib were always being unpacked to the work directory. As well as looking to be un

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Violeta Georgieva
2013/9/13 Mladen Turk > > On 09/09/2013 01:31 PM, Mladen Turk wrote: >> >> Version 1.1.28 is bug fixing release. >> The proposed release artefacts can be found at [1], >> and the build was done using tag [2]. >> >> The VOTE will remain open for at least 48 hours. >> >> The Apache Tomcat Native 1.1

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #19 from Nick Williams --- (In reply to Jeremy Boynes from comment #18) > 1) CopyOnWriteArrayList would simplify managing added transformers and is > intended for this use-case. How have I never heard of this class before? Cert

[Bug 53602] Support for HTTP status code 451

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53602 --- Comment #5 from Christopher Schultz --- (In reply to Mark Thomas from comment #4) > This (and any other new codes) can be added once they are approved. +1 Any webapp that wants to use code 451 (amusing code, eh?) with a response messa

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #18 from Jeremy Boynes --- 1) CopyOnWriteArrayList would simplify managing added transformers and is intended for this use-case. 2) I would not try to de-dupe the list at all. There's no contract around equals() for transformer

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Henri Gomez
[X] Stable, go ahead and release Works for me (openSUSE 12.3 64bits, Tomcat 7.0.42, Hotspot 1.6.0-45)

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Mark Thomas
Ping. This release needs some more votes. It is currently blocking both the 7.0.43 and the 8.0.0-RC2 releases. Cheers, Mark On 09/09/2013 12:31, Mladen Turk wrote: > Version 1.1.28 is bug fixing release. > The proposed release artefacts can be found at [1], > and the build was done using tag [

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Mladen Turk
On 09/09/2013 01:31 PM, Mladen Turk wrote: Version 1.1.28 is bug fixing release. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The VOTE will remain open for at least 48 hours. The Apache Tomcat Native 1.1.28 is [x] Stable, go ahead and release [ ]

svn commit: r1522806 - /tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java

2013-09-13 Thread markt
Author: markt Date: Fri Sep 13 08:08:19 2013 New Revision: 1522806 URL: http://svn.apache.org/r1522806 Log: Remove TODO. WebappClassLoader has all the Lifecycle implementation it needs. Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Modified: tomcat/trunk/java/

Re: [VOTE] Release Apache Tomcat Native 1.1.28

2013-09-13 Thread Mladen Turk
On 09/09/2013 01:31 PM, Mladen Turk wrote: Version 1.1.28 is bug fixing release. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The VOTE will remain open for at least 48 hours. The Apache Tomcat Native 1.1.28 is [ ] Stable, go ahead and release [x]

[Bug 55508] TldLocationsCache not recognising custom TLDs in WEB-INF/lib

2013-09-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55508 Jeremy Boynes changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVALI