Re: Jasper improvements - web resources and TLDs

2013-08-21 Thread Jeremy Boynes
On Aug 12, 2013, at 8:40 AM, Mark Thomas wrote: > On 12/08/2013 16:20, Jeremy Boynes wrote: > > I'm wondering about adding enableWebSockets() and enableJSPs() methods > to Tomcat which would automatically add the relevant SCI to any Context > created via one of the addContext(...) methods. Thoug

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-08-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This i

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Nick Williams changed: What|Removed |Added Attachment #30748|0 |1 is obsolete|

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-08-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Nick Williams changed: What|Removed |Added Attachment #30678|0 |1 is obsolete|

Re: Can't build from trunk anymore -- problems with DBCP2

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 5:32 PM, Nick Williams wrote: > I have latest-ish from trunk (< 2 days old) and compiled without issue. When > I tried to run it, however, console output indicates a serious issue creating > DataSource resources: > > 21-Aug-2013 17:18:30.800 WARNING [localhost-startStop-1]

Can't build from trunk anymore -- problems with DBCP2

2013-08-21 Thread Nick Williams
I have latest-ish from trunk (< 2 days old) and compiled without issue. When I tried to run it, however, console output indicates a serious issue creating DataSource resources: 21-Aug-2013 17:18:30.800 WARNING [localhost-startStop-1] org.apache.catalina.core.NamingContextListener.addResource Fa

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread sebb
On 21 August 2013 20:21, Christopher Schultz wrote: > Sebb, > > On 8/21/13 1:46 PM, sebb wrote: >> On 21 August 2013 14:48, Christopher Schultz >> wrote: >>> Nick, >>> >>> On 8/20/13 8:24 PM, Nick Williams wrote: I ran in to a roadblock with this idea. Part of the byte code of a class i

Re: Back-porting JSR-356 Progress update

2013-08-21 Thread Mark Thomas
Investigating some Gump and BuildBot failures has identified a large block of functionality that still remains to be back-ported to 7.0.x - namely the changes to Coyote that allowed upgraded connections to support concurrent read and write. It isn't as simple as copy and paste as there has been so

svn commit: r1516296 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java test/org/apache/tomcat/websocket/TesterFirehoseServer.java

2013-08-21 Thread markt
Author: markt Date: Wed Aug 21 20:24:58 2013 New Revision: 1516296 URL: http://svn.apache.org/r1516296 Log: Use a common wait time on the server and the client. This fixes an exception observed on some platforms with 7.0.x that distracted from the root cause of the test failure. Modified: to

svn commit: r1516295 - in /tomcat/trunk/test/org/apache/tomcat/websocket: TestWebSocketFrameClient.java TesterFirehoseServer.java

2013-08-21 Thread markt
Author: markt Date: Wed Aug 21 20:24:24 2013 New Revision: 1516295 URL: http://svn.apache.org/r1516295 Log: Use a common wait time on the server and the client. This fixes an exception observed on some platforms with 7.0.x that distracted from the root cause of the test failure. Modified: to

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 12:46 PM, sebb wrote: > On 21 August 2013 14:48, Christopher Schultz > wrote: >> Nick, >> >> On 8/20/13 8:24 PM, Nick Williams wrote: >>> I ran in to a roadblock with this idea. Part of the byte code of a >>> class includes the fully-qualified class name. If I create a class

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Christopher Schultz
Sebb, On 8/21/13 1:46 PM, sebb wrote: > On 21 August 2013 14:48, Christopher Schultz > wrote: >> Nick, >> >> On 8/20/13 8:24 PM, Nick Williams wrote: >>> I ran in to a roadblock with this idea. Part of the byte code of a >>> class includes the fully-qualified class name. If I create a class, >>>

Re: WebAppClassLoader#addrepository and #addURL

2013-08-21 Thread Romain Manni-Bucau
How does an app would scan its content? (dont say a sci it doesnt match a lot of cases) Le 21 août 2013 20:00, "Mark Thomas" a écrit : > On 21/08/2013 18:46, Romain Manni-Bucau wrote: > > Hi > > > > Browsing some code sources (groovy, xbean, tomee,...and i don'tepeak of > > github) I found getURL

Re: WebAppClassLoader#addrepository and #addURL

2013-08-21 Thread Mark Thomas
On 21/08/2013 18:46, Romain Manni-Bucau wrote: > Hi > > Browsing some code sources (groovy, xbean, tomee,...and i don'tepeak of > github) I found getURLs and addURL quite common and think it should be > supported by tomcat by default. Adding getURLs in WebResources wouldnt hurt > and would make th

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread sebb
On 21 August 2013 14:48, Christopher Schultz wrote: > Nick, > > On 8/20/13 8:24 PM, Nick Williams wrote: >> I ran in to a roadblock with this idea. Part of the byte code of a >> class includes the fully-qualified class name. If I create a class, >> say UnweavedClass, and replace its byte code in m

Re: WebAppClassLoader#addrepository and #addURL

2013-08-21 Thread Romain Manni-Bucau
Hi Browsing some code sources (groovy, xbean, tomee,...and i don'tepeak of github) I found getURLs and addURL quite common and think it should be supported by tomcat by default. Adding getURLs in WebResources wouldnt hurt and would make the getURLs of the classloader trivial. The addURLs should ju

svn commit: r1516183 - /tomcat/trunk/test/org/apache/tomcat/websocket/TesterBlockWebSocketSCI.java

2013-08-21 Thread markt
Author: markt Date: Wed Aug 21 15:02:21 2013 New Revision: 1516183 URL: http://svn.apache.org/r1516183 Log: Fix Gump errors with WebSocket and trunk Added: tomcat/trunk/test/org/apache/tomcat/websocket/TesterBlockWebSocketSCI.java (with props) Added: tomcat/trunk/test/org/apache/tomcat/w

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-08-21 Thread Mark Thomas
On 21/08/2013 15:43, Mark Thomas wrote: > On 21/08/2013 14:20, Nick Williams wrote: >> >> On Aug 21, 2013, at 6:14 AM, Mark Thomas wrote: >> >>> I'm not exactly sure what the problem is. It looks like the WebSocket >>> SCI is being registered twice or is running twice but I can't reproduce >>> the

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-08-21 Thread Mark Thomas
On 21/08/2013 14:20, Nick Williams wrote: > > On Aug 21, 2013, at 6:14 AM, Mark Thomas wrote: > >> I'm not exactly sure what the problem is. It looks like the WebSocket >> SCI is being registered twice or is running twice but I can't reproduce >> the problem. Anyone got any ideas? >> >> Currently

svn commit: r1516168 - /tomcat/tc7.0.x/trunk/conf/catalina.properties

2013-08-21 Thread markt
Author: markt Date: Wed Aug 21 14:14:46 2013 New Revision: 1516168 URL: http://svn.apache.org/r1516168 Log: WebSocket API has neither SCIs nor TLDs WebSocket Impl has no TLDs Modified: tomcat/tc7.0.x/trunk/conf/catalina.properties Modified: tomcat/tc7.0.x/trunk/conf/catalina.properties URL:

svn commit: r1516163 - /tomcat/tc7.0.x/trunk/conf/catalina.properties

2013-08-21 Thread markt
Author: markt Date: Wed Aug 21 14:05:14 2013 New Revision: 1516163 URL: http://svn.apache.org/r1516163 Log: Silence some TLD warnings when running unit tests Modified: tomcat/tc7.0.x/trunk/conf/catalina.properties Modified: tomcat/tc7.0.x/trunk/conf/catalina.properties URL: http://svn.apach

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Christopher Schultz
Nick, On 8/20/13 8:24 PM, Nick Williams wrote: > I ran in to a roadblock with this idea. Part of the byte code of a > class includes the fully-qualified class name. If I create a class, > say UnweavedClass, and replace its byte code in my fake transformer > with that of another class, the FQCN cha

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 6:14 AM, Mark Thomas wrote: > I'm not exactly sure what the problem is. It looks like the WebSocket > SCI is being registered twice or is running twice but I can't reproduce > the problem. Anyone got any ideas? > > Currently, my plan is to add some logging to the SCI registra

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Nick Williams
On Aug 21, 2013, at 2:58 AM, Mark Thomas wrote: > On 21/08/2013 01:24, Nick Williams wrote: > >> My backup idea is slightly less clean but, IMO, still more clean than adding >> ASM as a test-time dependency and trying to figure all of that out. I >> locally compiled fake "weaved" versions of t

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-08-21 Thread Mark Thomas
I'm not exactly sure what the problem is. It looks like the WebSocket SCI is being registered twice or is running twice but I can't reproduce the problem. Anyone got any ideas? Currently, my plan is to add some logging to the SCI registration code to see what triggers each registration of each SCI

buildbot success in ASF Buildbot on tomcat-trunk

2013-08-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4860 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1516119 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/connector/TestCoyoteAdapter.java

2013-08-21 Thread markt
Author: markt Date: Wed Aug 21 09:18:16 2013 New Revision: 1516119 URL: http://svn.apache.org/r1516119 Log: (empty) Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java Propchange: tomcat/tc7.0.x/trunk/

svn commit: r1516113 - /tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java

2013-08-21 Thread markt
Author: markt Date: Wed Aug 21 08:47:25 2013 New Revision: 1516113 URL: http://svn.apache.org/r1516113 Log: Fix Gump failure as java.io.tmpdir directory isn't writable. Modified: tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java Modified: tomcat/trunk/test/org/apache/cat

Re: Need guidance for writing unit tests for 55317

2013-08-21 Thread Mark Thomas
On 21/08/2013 01:24, Nick Williams wrote: > My backup idea is slightly less clean but, IMO, still more clean than adding > ASM as a test-time dependency and trying to figure all of that out. I locally > compiled fake "weaved" versions of the UnweavedClass (with the modified > behavior) and then