Re: svn commit: r1513714 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/Context.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/startup/TldConfig.java webapps/do

2013-08-14 Thread Mark Thomas
Jeremy Boynes wrote: >On Aug 14, 2013, at 12:58 AM, Mark Thomas wrote: > >> On 14/08/2013 03:20, jboy...@apache.org wrote: >>> Author: jboynes >>> Date: Wed Aug 14 02:20:02 2013 >>> New Revision: 1513714 >>> >>> URL: http://svn.apache.org/r1513714 >>> Log: >>> Deprecate TldConfig and TLD-related

Re: Code style rules: Line length

2013-08-14 Thread Jeremy Boynes
On Aug 14, 2013, at 3:41 AM, Mark Thomas wrote: > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK w

Re: svn commit: r1513714 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/Context.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/startup/TldConfig.java webapps/do

2013-08-14 Thread Jeremy Boynes
On Aug 14, 2013, at 12:58 AM, Mark Thomas wrote: > On 14/08/2013 03:20, jboy...@apache.org wrote: >> Author: jboynes >> Date: Wed Aug 14 02:20:02 2013 >> New Revision: 1513714 >> >> URL: http://svn.apache.org/r1513714 >> Log: >> Deprecate TldConfig and TLD-related properties of Context as they h

svn commit: r1514139 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/Context.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/startup/TldConfig.java webapps/docs/c

2013-08-14 Thread jboynes
Author: jboynes Date: Thu Aug 15 02:37:36 2013 New Revision: 1514139 URL: http://svn.apache.org/r1514139 Log: revert r1513714 Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/Context.java tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java tomcat/tc7.0.x/tru

Re: Consider support for the Servlet profile of JSR 196 (JASPIC) in Tomcat 7.0.x

2013-08-14 Thread David Blevins
On Aug 14, 2013, at 2:25 AM, Arjan Tijms wrote: > markt wrote >> No-one said it would be difficult. TomEE has already done it. We'd just >> need to lift the code. Difficulty really doesn't come into it. If there >> is a demand for it, it will get implemented. If there isn't, it won't. > > Thank

buildbot success in ASF Buildbot on tomcat-trunk

2013-08-14 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4828 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1513919 - in /tomcat/trunk: java/org/apache/catalina/connector/CoyoteAdapter.java test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 15:02:59 2013 New Revision: 1513919 URL: http://svn.apache.org/r1513919 Log: Fix non-blocking test failures on OSX. Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlocking

svn commit: r1513897 - /tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 14:34:13 2013 New Revision: 1513897 URL: http://svn.apache.org/r1513897 Log: Work-around CI build failures Modified: tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java Modified: tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBl

svn commit: r1513887 - /tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 14:08:26 2013 New Revision: 1513887 URL: http://svn.apache.org/r1513887 Log: Add some timing information Modified: tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java Modified: tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBloc

svn commit: r1513855 - /tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 12:52:43 2013 New Revision: 1513855 URL: http://svn.apache.org/r1513855 Log: Use logger rather than System.out primarily to get datestamps for messages. Modified: tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java Modified: tomcat/trunk/

[Bug 55400] WsFilter not compatible with async sample applications

2013-08-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55400 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1513842 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 12:29:03 2013 New Revision: 1513842 URL: http://svn.apache.org/r1513842 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55400 WsFilter needs to be marked as supporting async else it prevents apps from using async requests. Modified: tomcat/trunk/jav

svn commit: r1513829 - /tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 12:16:32 2013 New Revision: 1513829 URL: http://svn.apache.org/r1513829 Log: Tomcat 8 requires Java 7 so simplify code. Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/GroupChannel.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/G

svn commit: r1513828 - in /tomcat/trunk/java/org/apache/catalina/tribes: group/ChannelCoordinator.java group/GroupChannel.java group/interceptors/MessageDispatchInterceptor.java transport/nio/Parallel

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 12:13:59 2013 New Revision: 1513828 URL: http://svn.apache.org/r1513828 Log: Reformat excessively long lines (> 200 chars). Also reformatted long lines > 100 chars. Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/ChannelCoordinator.java tomcat/t

svn commit: r1513823 - /tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 11:58:43 2013 New Revision: 1513823 URL: http://svn.apache.org/r1513823 Log: Reformat excessively long lines (> 200 chars). Also reformatted long lines > 100 chars. Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Modified: tomcat/tr

buildbot failure in ASF Buildbot on tomcat-trunk

2013-08-14 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4823 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1513806 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 10:47:00 2013 New Revision: 1513806 URL: http://svn.apache.org/r1513806 Log: Reformat excessively long lines (> 200 chars). Also reformatted long lines > 100 chars. Modified: tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java Modified: tomca

Re: Code style rules: Line length

2013-08-14 Thread Mark Thomas
Summarising the response to this thread so far: There is a preference for not strictly enforcing whatever limit is selected. Rules need exceptions and committers can exercise judgement. It does create a grey area but the majority is OK with that. There is a mix of views on line length but there a

buildbot success in ASF Buildbot on tomcat-trunk

2013-08-14 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4822 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1513798 - /tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 10:17:13 2013 New Revision: 1513798 URL: http://svn.apache.org/r1513798 Log: Add an access log check to the write error test case Modified: tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java Modified: tomcat/trunk/test/org/apache/catalin

svn commit: r1513788 - /tomcat/trunk/webapps/docs/config/context.xml

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 09:39:50 2013 New Revision: 1513788 URL: http://svn.apache.org/r1513788 Log: Remove reference to attributes that no longer exist. Modified: tomcat/trunk/webapps/docs/config/context.xml Modified: tomcat/trunk/webapps/docs/config/context.xml URL: http://svn.apac

svn commit: r1513787 - /tomcat/trunk/webapps/docs/config/systemprops.xml

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 09:39:24 2013 New Revision: 1513787 URL: http://svn.apache.org/r1513787 Log: Remove reference to attributes that no longer exist. Modified: tomcat/trunk/webapps/docs/config/systemprops.xml Modified: tomcat/trunk/webapps/docs/config/systemprops.xml URL: http://

svn commit: r1513784 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 09:37:42 2013 New Revision: 1513784 URL: http://svn.apache.org/r1513784 Log: Remove unused code. Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java URL: http://svn

svn commit: r1513783 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 09:36:34 2013 New Revision: 1513783 URL: http://svn.apache.org/r1513783 Log: Async read/write errors need to trigger error responses so the socket is closed. Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Modified: tomcat/trunk/jav

svn commit: r1513782 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2013-08-14 Thread markt
Author: markt Date: Wed Aug 14 09:35:40 2013 New Revision: 1513782 URL: http://svn.apache.org/r1513782 Log: Provide a request processing time for an error response if possible. Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Modified: tomcat/trunk/java/org/

Re: Consider support for the Servlet profile of JSR 196 (JASPIC) in Tomcat 7.0.x

2013-08-14 Thread Arjan Tijms
Hi, markt wrote > Had you not cut all the context, it would be clear that Ron's question > was: >> Does the Tomcat community support the inclusion of the Servlet profile >> of JSR 196 in the EE web Profile? > Hence my response. I don't think the Tomcat developers are in a position > to pass judge

Re: svn commit: r1513714 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/Context.java java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/startup/TldConfig.java webapps/do

2013-08-14 Thread Mark Thomas
On 14/08/2013 03:20, jboy...@apache.org wrote: > Author: jboynes > Date: Wed Aug 14 02:20:02 2013 > New Revision: 1513714 > > URL: http://svn.apache.org/r1513714 > Log: > Deprecate TldConfig and TLD-related properties of Context as they have been > removed in Tomcat 8.0.x where TLD processing is

Re: Consider support for the Servlet profile of JSR 196 (JASPIC) in Tomcat 7.0.x

2013-08-14 Thread Mark Thomas
On 13/08/2013 22:58, Arjan Tijms wrote: > markt wrote >>> we are contacting standalone and EE web profile Servlet containers >> [...] >> The has been very little demand from the Apache Tomcat user community to >> support the Java EE web profile. > > I guess Ron meant Tomcat with the "standalone