svn commit: r1512166 - /tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/fmt/ParamSupport.java

2013-08-08 Thread jboynes
Author: jboynes Date: Fri Aug 9 06:53:41 2013 New Revision: 1512166 URL: http://svn.apache.org/r1512166 Log: Remove "executable" property Modified: tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/fmt/ParamSupport.java (props changed) Propchange:

svn commit: r1512153 - /tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/common/xml/JSTLVariableStackTest.java

2013-08-08 Thread jboynes
Author: jboynes Date: Fri Aug 9 06:38:05 2013 New Revision: 1512153 URL: http://svn.apache.org/r1512153 Log: Update eol-style Modified: tomcat/taglibs/standard/trunk/impl/src/test/java/org/apache/taglibs/standard/tag/common/xml/JSTLVariableStackTest.java (props changed) Propchange: tom

svn commit: r1512151 - /tomcat/taglibs/standard/trunk/NOTICE

2013-08-08 Thread jboynes
Author: jboynes Date: Fri Aug 9 06:31:19 2013 New Revision: 1512151 URL: http://svn.apache.org/r1512151 Log: Update copyright year and text Modified: tomcat/taglibs/standard/trunk/NOTICE Modified: tomcat/taglibs/standard/trunk/NOTICE URL: http://svn.apache.org/viewvc/tomcat/taglibs/standar

svn commit: r1512150 - /tomcat/taglibs/taglibs-parent/trunk/NOTICE

2013-08-08 Thread jboynes
Author: jboynes Date: Fri Aug 9 06:25:34 2013 New Revision: 1512150 URL: http://svn.apache.org/r1512150 Log: Update copyright year and text Modified: tomcat/taglibs/taglibs-parent/trunk/NOTICE Modified: tomcat/taglibs/taglibs-parent/trunk/NOTICE URL: http://svn.apache.org/viewvc/tomcat/tag

svn commit: r1512148 - in /tomcat/trunk: java/org/apache/tomcat/util/descriptor/tld/ test/org/apache/tomcat/util/descriptor/tld/

2013-08-08 Thread jboynes
Author: jboynes Date: Fri Aug 9 06:21:56 2013 New Revision: 1512148 URL: http://svn.apache.org/r1512148 Log: Start adding model for loading complete TLDs using Digester. This will unify Jasper's model, which is mostly complete but uses a separate DOM model, and Catalina's, which is Digester bas

Re: Code style rules: Line length

2013-08-08 Thread Jeremy Boynes
On Aug 8, 2013, at 10:50 AM, Mark Thomas wrote: > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > > As a starting point what do folks think of the following options: > > Line

svn commit: r1512073 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11Processor.java

2013-08-08 Thread markt
Author: markt Date: Thu Aug 8 22:26:38 2013 New Revision: 1512073 URL: http://svn.apache.org/r1512073 Log: Fix refactoring in r1512034 that broke HTTP BIO and APR Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java tomcat/trunk/java/org/apache/coyote/http11/Http1

buildbot failure in ASF Buildbot on tomcat-trunk

2013-08-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4804 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

Re: Code style rules: Line length

2013-08-08 Thread Christopher Schultz
Mark, On 8/8/13 1:50 PM, Mark Thomas wrote: > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > > As a starting point what do folks think of the following options: > > Line leng

Re: Code style rules: Line length

2013-08-08 Thread Konstantin Kolinko
2013/8/8 Mark Thomas : > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > Changing @SuppressWarnings had its technical reasons. I do not see much reasons to reconsider code forma

svn commit: r1512034 - in /tomcat/trunk/java/org/apache/coyote: ./ ajp/ http11/

2013-08-08 Thread markt
Author: markt Date: Thu Aug 8 21:09:38 2013 New Revision: 1512034 URL: http://svn.apache.org/r1512034 Log: Pull up SocketWrapper Modified: tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java tomcat/trunk/java/org/apa

svn commit: r1512033 - /tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java

2013-08-08 Thread markt
Author: markt Date: Thu Aug 8 21:09:00 2013 New Revision: 1512033 URL: http://svn.apache.org/r1512033 Log: Switch the logic around in preparation for a fix for BZ 55381 Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util

svn commit: r1511988 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2013-08-08 Thread markt
Author: markt Date: Thu Aug 8 19:43:43 2013 New Revision: 1511988 URL: http://svn.apache.org/r1511988 Log: Fix comment typos Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java U

Re: Code style rules: Line length

2013-08-08 Thread Nick Williams
On Aug 8, 2013, at 12:50 PM, Mark Thomas wrote: > Currently, Tomcat has an 'guide' of a maximum of 80 characters for line > length. It has been a while since we reviewed this and as we are looking > at style rules... > > As a starting point what do folks think of the following options: > > Line

buildbot success in ASF Buildbot on tomcat-trunk

2013-08-08 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4802 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1511907 - in /tomcat/trunk: ./ java/javax/el/ java/javax/websocket/ java/javax/websocket/server/ java/org/apache/catalina/connector/ java/org/apache/catalina/core/ java/org/apache/catalin

2013-08-08 Thread markt
Author: markt Date: Thu Aug 8 18:07:43 2013 New Revision: 1511907 URL: http://svn.apache.org/r1511907 Log: Switch from ignoring unavoidable generics warnings in Eclipse to explicitly using @SuppressWarnings Modified: tomcat/trunk/build.xml tomcat/trunk/java/javax/el/StandardELContext.jav

svn commit: r1511905 - /tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/DefaultTestCase.java

2013-08-08 Thread markt
Author: markt Date: Thu Aug 8 18:04:59 2013 New Revision: 1511905 URL: http://svn.apache.org/r1511905 Log: Update unit tests to use DBCP2 Modified: tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/DefaultTestCase.java Modified: tomcat/trunk/modules/jdbc-pool/src/te

Code style rules: Line length

2013-08-08 Thread Mark Thomas
Currently, Tomcat has an 'guide' of a maximum of 80 characters for line length. It has been a while since we reviewed this and as we are looking at style rules... As a starting point what do folks think of the following options: Line length: 80 - the current 100 - 120 - Strictness Informal - th

buildbot failure in ASF Buildbot on tomcat-trunk

2013-08-08 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4801 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

Re: Use (or not) of @SuppressWarnings

2013-08-08 Thread Mark Thomas
On 07/08/2013 09:41, Mark Thomas wrote: > For trunk we have been running a policy of zero warnings in the code. > This has helped to highlight issues as code is edited as any warnings > are immediately clear. Obviously, this depends on what warnings are enabled. > > Currently, we use Eclipse's "Ig

svn commit: r1511866 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/UriTemplate.java res/findbugs/filter-false-positives.xml test/org/apache/tomcat/websocket/server/TestUriTemplate.java

2013-08-08 Thread markt
Author: markt Date: Thu Aug 8 16:46:55 2013 New Revision: 1511866 URL: http://svn.apache.org/r1511866 Log: Duplicate path parameters are invalid Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/UriTemplate.java tomcat/trunk/res/findbugs/filter-false-positives.xml tomcat

Re: Use (or not) of @SuppressWarnings

2013-08-08 Thread Brian Burch
On 07/08/13 19:49, Konstantin Kolinko wrote: 2013/8/7 Brian Burch : I use netbeans exclusively. I get warnings about import order from almost every tc source file. Periodically I scratch around looking for the rules template so I can change them to conform with the ant checkstyle rules, which a

Re: Use (or not) of @SuppressWarnings

2013-08-08 Thread Christopher Schultz
Jeremy, On 8/7/13 11:38 AM, Jeremy Boynes wrote: > On Aug 7, 2013, at 12:41 AM, Mark Thomas wrote: > >> For trunk we have been running a policy of zero warnings in the code. >> This has helped to highlight issues as code is edited as any warnings >> are immediately clear. Obviously, this depends

[Bug 55314] Provide option to allow programmatic deployment of server (WebSocket) endpoint at runtime

2013-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55314 --- Comment #8 from Mark Thomas --- Thinking about this some more, wouldn't it be easier from a developer point of view just to forward the request and let WsFilter do all the work? -- You are receiving this mail because: You are the assi

svn commit: r1511621 - /tomcat/trunk/webapps/docs/changelog.xml

2013-08-08 Thread kkolinko
Author: kkolinko Date: Thu Aug 8 08:51:51 2013 New Revision: 1511621 URL: http://svn.apache.org/r1511621 Log: Correct typos. (Followup to r1511469) Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/t

[Bug 55387] DefaultServlet calls response.setContentLengthLong which is a 3.1 method but doesn't check that you're using 3.1

2013-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55387 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55387] DefaultServlet calls response.setContentLengthLong which is a 3.1 method but doesn't check that you're using 3.1

2013-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55387 --- Comment #1 from Burt Beckwith --- Sorry, user error since the 3.1 jar will be provided by the container. Please close. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 55387] New: DefaultServlet calls response.setContentLengthLong which is a 3.1 method but doesn't check that you're using 3.1

2013-08-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55387 Bug ID: 55387 Summary: DefaultServlet calls response.setContentLengthLong which is a 3.1 method but doesn't check that you're using 3.1 Product: Tomcat 8 Ve