[Bug 55312] No SCI scan in embedded Tomcat

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55312 Bug 55312 depends on bug 55287, which changed state. Bug 55287 Summary: ServletContainerInitializer in parent classloader may not be found https://issues.apache.org/bugzilla/show_bug.cgi?id=55287 What|Removed

[Bug 55287] ServletContainerInitializer in parent classloader may not be found

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55287 Jeremy Boynes changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 55312] No SCI scan in embedded Tomcat

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55312 Jeremy Boynes changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Jerem

svn commit: r1507874 - /tomcat/trunk/test/org/apache/jasper/servlet/TestJasperInitializer.java

2013-07-28 Thread jboynes
Author: jboynes Date: Mon Jul 29 00:01:15 2013 New Revision: 1507874 URL: http://svn.apache.org/r1507874 Log: Test case should assert SCI is actually loaded Modified: tomcat/trunk/test/org/apache/jasper/servlet/TestJasperInitializer.java Modified: tomcat/trunk/test/org/apache/jasper/servlet/

svn commit: r1507873 - in /tomcat/trunk: build.xml test/META-INF/ test/META-INF/services/ test/META-INF/services/javax.servlet.ServletContainerInitializer test/org/apache/jasper/servlet/TestJasperInit

2013-07-28 Thread jboynes
Author: jboynes Date: Sun Jul 28 23:45:37 2013 New Revision: 1507873 URL: http://svn.apache.org/r1507873 Log: Ensure the JasperInitializer is used when running tests. This led to discovery of 55319 but otherwise has no impact at this time. However, when we handle TLD processing from the SCI then t

[Bug 55319] FragmentJarScannerCallback does not set isWebapp

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55319 Jeremy Boynes changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1507872 - /tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java

2013-07-28 Thread jboynes
Author: jboynes Date: Sun Jul 28 23:38:09 2013 New Revision: 1507872 URL: http://svn.apache.org/r1507872 Log: Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=55319 Set isWebapp and delegate for fragments scanned from File callbacks Modified: tomcat/trunk/java/org/apache/tomcat/ut

[Bug 55319] New: FragmentJarScannerCallback does not set isWebapp

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55319 Bug ID: 55319 Summary: FragmentJarScannerCallback does not set isWebapp Product: Tomcat 8 Version: trunk Hardware: All OS: All Status: NEW Severity:

svn commit: r1507870 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/WebappServiceLoader.java test/org/apache/catalina/startup/TestWebappServic

2013-07-28 Thread jboynes
Author: jboynes Date: Sun Jul 28 23:01:23 2013 New Revision: 1507870 URL: http://svn.apache.org/r1507870 Log: Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=55287 Decouple service loading for ServletContainerInitializers from ContextConfig and ensure services defined by the parent C

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #8 from Nick Williams --- To address Jeremy's concerns/questions: 1) I don't see a security issue. JBoss, GlassFish, WebLogic, and WebSphere, for example, all "automatically enable this for all applications." You say, "Currentl

[Bug 55317] Facilitate weaving by allowing ClassFileTransformer to be added to WebppClassLoader

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Jeremy Boynes changed: What|Removed |Added Summary|Make|Facilitate weaving by

[Bug 55312] No SCI scan in embedded Tomcat

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55312 Jeremy Boynes changed: What|Removed |Added Depends on||55287 --- Comment #2 from Jeremy B

[Bug 55287] ServletContainerInitializer in parent classloader may not be found

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55287 Jeremy Boynes changed: What|Removed |Added Blocks||55312 -- You are receiving this m

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #6 from Jeremy Boynes --- How does this interact with annotation scanning and ServletContainerInitializers? For example, a transformer could add or remove annotations or class dependencies (e.g. adding new interfaces) that rela

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #5 from Jeremy Boynes --- I have reservations around the security consequences of providing anything that has access to the webapp classloader the ability to modify any code defined by that classloader. Currently, that has to

[Bug 55312] No SCI scan in embedded Tomcat

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55312 --- Comment #1 from Dave Syer --- I played around with the Tomcat embedded server a bit more and found that it actually is relatively easy (if obscure) to switch on SCI: ContextConfig contextConfig = new ContextConfig(); co

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #4 from Nick Williams --- First, here's the companion Spring Framework enhancement request: https://jira.springsource.org/browse/SPR-10788 /I/ don't need to extend WebappClassLoader. I plan on simply adding to the existing Weba

[Bug 55101] BasicAuthenticator parser and associated unit tests

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55101 --- Comment #4 from Brian Burch --- Created attachment 30636 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30636&action=edit remove redundant test cases for unusual but valid credentials r1495169 introduced a new BasicAuthenti

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #3 from Rainer Jung --- Sorry, me again: if we want to support it in an agent free way, it seems it woul suffice to add a addTransformer() (or probably better registerTransformer() and unregisterTranformer()) call to the WebappC

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #2 from Rainer Jung --- Why would one need to extend the webapp class loader? A quick look to java.lang.instrument indicates that one should be able to do it with a normal instrumentation agent. Can you clarify? The registered

[Bug 55317] Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 --- Comment #1 from Mark Thomas --- I have no objections in principle but obviously I'd want to see the proposed patch first. I will say that someone from the Spring project will need to confirm that any proposed patch is a) correct and b)

[Bug 55317] New: Make o.a.c.l.WebappClassLoader Instrumentable

2013-07-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55317 Bug ID: 55317 Summary: Make o.a.c.l.WebappClassLoader Instrumentable Product: Tomcat 7 Version: trunk Hardware: All OS: All Status: NEW Severity: en

Bug report for Taglibs [2013/07/28]

2013-07-28 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 8 [2013/07/28]

2013-07-28 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2013/07/28]

2013-07-28 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2013/07/28]

2013-07-28 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2013/07/28]

2013-07-28 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Native [2013/07/28]

2013-07-28 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2013/07/28]

2013-07-28 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned