[Bug 55031] Update MANIFEST.MF for OSGi headers

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55031 --- Comment #1 from Violeta Georgieva --- Hi, In the patch you specify in the Export-Package header: org.apache.tomcat.jdbc.pool.interceptor;uses:="org.apache.tomcat.jdbc.pool,org.apache.juli.logging,javax.management.openmbean,org.apache.

Re: mod_jk, JSESSION_ID and load-balancing

2013-06-27 Thread Henri Gomez
>Thanks for testing Henri. From my point of view it should be good for >production and I guess 1.2.38 is not to far away. +1 I'll do some more tests using ab/gatling to see how it works under load. > >And now you can have your own personal HENRICOOKIE ;) > Rhooo :) Thanks Rainer, great works

Re: svn commit: r1497552 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 6:14 PM, Konstantin Kolinko wrote: > 2013/6/28 : >> Author: markt >> Date: Thu Jun 27 20:10:40 2013 >> New Revision: 1497552 >> >> URL: http://svn.apache.org/r1497552 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55151 >> Fix bugs in test >> >> Modified:

Re: svn commit: r1497552 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-06-27 Thread Konstantin Kolinko
2013/6/28 : > Author: markt > Date: Thu Jun 27 20:10:40 2013 > New Revision: 1497552 > > URL: http://svn.apache.org/r1497552 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55151 > Fix bugs in test > > Modified: > > tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodi

svn commit: r1497580 - in /tomcat/trunk/java/org/apache/tomcat/websocket/server: LocalStrings.properties WsServerContainer.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 22:04:44 2013 New Revision: 1497580 URL: http://svn.apache.org/r1497580 Log: WebSocket 1.0, Section 6.4 Once an Endpoint has been used, no more Endpoints can be registered Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/LocalStrings.properties

svn commit: r1497579 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 21:57:07 2013 New Revision: 1497579 URL: http://svn.apache.org/r1497579 Log: Refactor to remove duplicate code Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/

svn commit: r1497578 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 21:49:04 2013 New Revision: 1497578 URL: http://svn.apache.org/r1497578 Log: Copy duplicate path checks for annotation deloyments. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java Modified: tomcat/trunk/java/org/apache/tomc

svn commit: r1497576 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 21:46:32 2013 New Revision: 1497576 URL: http://svn.apache.org/r1497576 Log: Follow-up to r1497569. More thread-safety Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket

Re: svn commit: r1497569 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 4:32 PM, ma...@apache.org wrote: > Author: markt > Date: Thu Jun 27 21:32:39 2013 > New Revision: 1497569 > > URL: http://svn.apache.org/r1497569 > Log: > With an eye to the future, First phrase of your new novel? :-) ---

svn commit: r1497569 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 21:32:39 2013 New Revision: 1497569 URL: http://svn.apache.org/r1497569 Log: With an eye to the future, fix some thread-safety issues Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java Modified: tomcat/trunk/java/org/apache/t

Re: mod_jk, JSESSION_ID and load-balancing

2013-06-27 Thread Rainer Jung
On 27.06.2013 17:28, Henri Gomez wrote: > Rainer, I tried mod_jk 1.2.38-dev and it works as expected : > > An HTTPd in front, 2 Nexus behind, using HENRICOOKIE, requests are sent to > proper Tomcat whatever Nexus/Shiro did with JSESSIONID ie : > > Browser 1 : > > HENRICOOKIE > .swf-nexus > > JS

[Bug 55151] Fix in MsgByte encoder and decoder TestEncodingDecoding websocket test

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55151 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1497552 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 20:10:40 2013 New Revision: 1497552 URL: http://svn.apache.org/r1497552 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55151 Fix bugs in test Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java Modified: tomcat/t

[Bug 55144] NIO connection locked when trying to release it

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55144 --- Comment #3 from Mark Thomas --- Any way you can debug the instance to see that the timeout has been set to? I'll have another look at the code and see if I can spot any possible code paths that could lead to a much longer delay. Is it

[Bug 55150] Memory leak with tag-file

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55150 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 43878] Tag-file classes get loaded for each JSP -> perm gen space problem

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43878 Mark Thomas changed: What|Removed |Added CC||jiangguo...@gmail.com --- Comment #7

Re: Tomcat 7.0.41 JNDIRealm revision 1491394

2013-06-27 Thread Mark Thomas
On 27/06/2013 19:23, Brian Burch wrote: > So will you deal with it from now on, or would you like me to open > bugs on tc7 and tc8? Fixed. It would be good if you could confirm the fix is correct. Mark - To unsubscribe, e-

svn commit: r1497545 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 20:02:46 2013 New Revision: 1497545 URL: http://svn.apache.org/r1497545 Log: Fix regression in r1459346 Thanks to Brian Burch for spotting this and kkolinko for the fix. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/c

svn commit: r1497538 - /tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 19:57:28 2013 New Revision: 1497538 URL: http://svn.apache.org/r1497538 Log: Fix regression in r1459346 Thanks to Brian Burch for spotting this and kkolinko for the fix. Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Modified: tomcat/trunk

Re: Tomcat 7.0.41 JNDIRealm revision 1491394

2013-06-27 Thread Brian Burch
On 27/06/13 18:51, Konstantin Kolinko wrote: 2013/6/27 Brian Burch : I eventually got round to integration testing of 7.0.41 yesterday and was baffled to find I couldn't logon! To cut a long debugging story short, revision 1491394 has a bug that was introduced as part of the standardisation of

[Bug 55151] Fix in MsgByte encoder and decoder TestEncodingDecoding websocket test

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55151 Niki Dokovski changed: What|Removed |Added Attachment #30492|0 |1 is patch|

[Bug 55151] New: Fix in MsgByte encoder and decoder TestEncodingDecoding websocket test

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55151 Bug ID: 55151 Summary: Fix in MsgByte encoder and decoder TestEncodingDecoding websocket test Product: Tomcat 8 Version: trunk Hardware: PC OS: Window

Re: Tomcat 7.0.41 JNDIRealm revision 1491394

2013-06-27 Thread Konstantin Kolinko
2013/6/27 Brian Burch : > I eventually got round to integration testing of 7.0.41 yesterday and was > baffled to find I couldn't logon! > > To cut a long debugging story short, revision 1491394 has a bug that was > introduced as part of the standardisation of our Base64 handling. I wasn't > sure wh

svn commit: r1497474 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java test/org/apache/catalina/core/TestAsyncContextImpl.java

2013-06-27 Thread violetagg
Author: violetagg Date: Thu Jun 27 17:41:06 2013 New Revision: 1497474 URL: http://svn.apache.org/r1497474 Log: When calculating the path in AsyncContext.dispatch(), methods ServletRequest.getRequestURI and ServletRequest.getContextPath cannot be used. That's because the first one returns a stri

Tomcat 7.0.41 JNDIRealm revision 1491394

2013-06-27 Thread Brian Burch
I eventually got round to integration testing of 7.0.41 yesterday and was baffled to find I couldn't logon! To cut a long debugging story short, revision 1491394 has a bug that was introduced as part of the standardisation of our Base64 handling. I wasn't sure whether I ought to open a new bug

svn commit: r1497407 - in /tomcat/trunk/java/org/apache/tomcat/websocket/pojo: LocalStrings.properties PojoMethodMapping.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 15:55:47 2013 New Revision: 1497407 URL: http://svn.apache.org/r1497407 Log: Ensure methods with WebSocket annotations are public Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/LocalStrings.properties tomcat/trunk/java/org/apache/tomcat/websock

Re: mod_jk, JSESSION_ID and load-balancing

2013-06-27 Thread Henri Gomez
Rainer, I tried mod_jk 1.2.38-dev and it works as expected : An HTTPd in front, 2 Nexus behind, using HENRICOOKIE, requests are sent to proper Tomcat whatever Nexus/Shiro did with JSESSIONID ie : Browser 1 : HENRICOOKIE .swf-nexus JSESSIONID 799c3a8a-fd70-4a08-8a1a-6f301da6a9bc Browser 2 : HE

Re: svn commit: r1497299 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 9:42 AM, Mark Thomas wrote: > On 27/06/2013 15:29, Nick Williams wrote: >> >> On Jun 27, 2013, at 6:08 AM, ma...@apache.org wrote: >> >>> Author: markt >>> Date: Thu Jun 27 11:08:03 2013 >>> New Revision: 1497299 >>> >>> URL: http://svn.apache.org/r1497299 >>> Log: >>> WebS

[Bug 55143] Unable to add programmatic message handler to an endpoint with custom decoder

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55143 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1497386 - /tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 14:47:36 2013 New Revision: 1497386 URL: http://svn.apache.org/r1497386 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55143 Add a test case. Patch provided by Niki Dokovski Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestEncodingDe

Re: svn commit: r1497299 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread Mark Thomas
On 27/06/2013 15:29, Nick Williams wrote: > > On Jun 27, 2013, at 6:08 AM, ma...@apache.org wrote: > >> Author: markt >> Date: Thu Jun 27 11:08:03 2013 >> New Revision: 1497299 >> >> URL: http://svn.apache.org/r1497299 >> Log: >> WebSocket 1.0, Section 4.8 >> Don't look for annotations on inherit

Re: svn commit: r1497299 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread Nick Williams
On Jun 27, 2013, at 6:08 AM, ma...@apache.org wrote: > Author: markt > Date: Thu Jun 27 11:08:03 2013 > New Revision: 1497299 > > URL: http://svn.apache.org/r1497299 > Log: > WebSocket 1.0, Section 4.8 > Don't look for annotations on inherited methods. > > Modified: >tomcat/trunk/java/org/a

[Bug 55143] Unable to add programmatic message handler to an endpoint with custom decoder

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55143 --- Comment #11 from Niki Dokovski --- Created attachment 30491 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30491&action=edit TestEncodingDecoding patch -- You are receiving this mail because: You are the assignee for the b

[Bug 55143] Unable to add programmatic message handler to an endpoint with custom decoder

2013-06-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55143 --- Comment #10 from Niki Dokovski --- Here is an extension of my favourite TestEncodingDecoding which validates the original case. Mark if you want we can close this issue. However I will continue on this topic in two directions: 1. I spo

buildbot success in ASF Buildbot on tomcat-trunk

2013-06-27 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4538 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1497308 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 11:37:25 2013 New Revision: 1497308 URL: http://svn.apache.org/r1497308 Log: Fix logic error that triggered an NPE and associated test failures Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified: tomcat/trunk/java/org/

buildbot failure in ASF Buildbot on tomcat-trunk

2013-06-27 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4536 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1497305 - in /tomcat/trunk/java/org/apache/tomcat/websocket/pojo: LocalStrings.properties PojoEndpointBase.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 11:30:22 2013 New Revision: 1497305 URL: http://svn.apache.org/r1497305 Log: WebSocket 1.0, Section 5.2.2 Container must log error if no error handling is configured. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/LocalStrings.properties tomcat

svn commit: r1497299 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 11:08:03 2013 New Revision: 1497299 URL: http://svn.apache.org/r1497299 Log: WebSocket 1.0, Section 4.8 Don't look for annotations on inherited methods. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified: tomcat/trunk/

svn commit: r1497294 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 10:54:54 2013 New Revision: 1497294 URL: http://svn.apache.org/r1497294 Log: Simplify a little Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.ja

svn commit: r1497291 - in /tomcat/trunk/java/org/apache/tomcat/websocket: Util.java pojo/PojoMethodMapping.java

2013-06-27 Thread markt
Author: markt Date: Thu Jun 27 10:45:59 2013 New Revision: 1497291 URL: http://svn.apache.org/r1497291 Log: More changes for BZ 55143. @OnMessage may need multiple message handlers depending on the decoders present Modified: tomcat/trunk/java/org/apache/tomcat/websocket/Util.java tomcat/