svn commit: r1493231 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticator.java

Author: markt Date: Fri Jun 14 20:14:05 2013 New Revision: 1493231 URL: http://svn.apache.org/r1493231 Log: Fix typos Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticator.java Modified: tomcat/trunk/test/org/apache/catalina/authenticator/TestFormAuthenticator

svn commit: r1493197 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

Author: markt Date: Fri Jun 14 18:43:13 2013 New Revision: 1493197 URL: http://svn.apache.org/r1493197 Log: Special handling for isUserInRole("**") Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java UR

Re: Jar scanning, SCI scanning, fragment scanning

On 14/06/2013 18:53, Christopher Schultz wrote: BCEL reads class files as files. http://commons.apache.org/proper/commons-bcel/ No, I get that, but the scanner ultimately has to use a ClassLoader to load Class objects so they can be passed-off to the SCIs. Which ClassLoader does that? The w

svn commit: r1493194 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

Author: markt Date: Fri Jun 14 18:32:18 2013 New Revision: 1493194 URL: http://svn.apache.org/r1493194 Log: Special handling for isUserInRole("*") Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java URL

Re: Jar scanning, SCI scanning, fragment scanning

Geronimo's xbean-finder also supplies this functionality using asm. david jencks On Jun 14, 2013, at 9:55 AM, sebb wrote: > On 14 June 2013 17:35, Christopher Schultz > wrote: >> Mark, >> >> On 6/14/13 12:21 PM, Mark Thomas wrote: >>> On 14/06/2013 16:57, Christopher Schultz wrote: Mark

Re: svn commit: r1493066 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

On 14.06.2013 18:36, Christopher Schultz wrote: > Mark, > > On 6/14/13 12:22 PM, Mark Thomas wrote: >> On 14/06/2013 17:15, Christopher Schultz wrote: >>> I was actually hoping that certain JDBC drivers would start packaging a >>> listener that could do things like stop driver-launched threads, et

Re: Jar scanning, SCI scanning, fragment scanning

Sebb, On 6/14/13 12:55 PM, sebb wrote: > On 14 June 2013 17:35, Christopher Schultz > wrote: >> Mark, >> >> On 6/14/13 12:21 PM, Mark Thomas wrote: >>> On 14/06/2013 16:57, Christopher Schultz wrote: Mark, On 6/14/13 3:16 AM, Mark Thomas wrote: > On 14/06/2013 03:31, Christoph

Re: Jar scanning, SCI scanning, fragment scanning

FYI xbean has runtime constraints bcel skips (valid read and loaded info are consistent) Le 14 juin 2013 18:56, "sebb" a écrit : > On 14 June 2013 17:35, Christopher Schultz > wrote: > > Mark, > > > > On 6/14/13 12:21 PM, Mark Thomas wrote: > >> On 14/06/2013 16:57, Christopher Schultz wrote: >

Re: Jar scanning, SCI scanning, fragment scanning

On 14 June 2013 17:35, Christopher Schultz wrote: > Mark, > > On 6/14/13 12:21 PM, Mark Thomas wrote: >> On 14/06/2013 16:57, Christopher Schultz wrote: >>> Mark, >>> >>> On 6/14/13 3:16 AM, Mark Thomas wrote: On 14/06/2013 03:31, Christopher Schultz wrote: > It might be nice if this

Re: svn commit: r1493066 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

Mark, On 6/14/13 12:22 PM, Mark Thomas wrote: > On 14/06/2013 17:15, Christopher Schultz wrote: >> I was actually hoping that certain JDBC drivers would start packaging a >> listener that could do things like stop driver-launched threads, etc. >> that the user doesn't really know have been started

Re: Jar scanning, SCI scanning, fragment scanning

Mark, On 6/14/13 12:21 PM, Mark Thomas wrote: > On 14/06/2013 16:57, Christopher Schultz wrote: >> Mark, >> >> On 6/14/13 3:16 AM, Mark Thomas wrote: >>> On 14/06/2013 03:31, Christopher Schultz wrote: >>> It might be nice if this were not a one-of-many decision, but if a client could ch

Re: svn commit: r1493066 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

On 14/06/2013 17:15, Christopher Schultz wrote: I was actually hoping that certain JDBC drivers would start packaging a listener that could do things like stop driver-launched threads, etc. that the user doesn't really know have been started. Will this then always be a requirement of the webapp t

Re: Jar scanning, SCI scanning, fragment scanning

On 14/06/2013 16:57, Christopher Schultz wrote: Mark, On 6/14/13 3:16 AM, Mark Thomas wrote: On 14/06/2013 03:31, Christopher Schultz wrote: It might be nice if this were not a one-of-many decision, but if a client could choose more than one type. A bit-mask or a list of scan-types would be n

Re: Jar scanning, SCI scanning, fragment scanning

Romain, On 6/14/13 12:13 PM, Romain Manni-Bucau wrote: > Cdi handle interfaces too which are not Object. There are interfaces which are do not extend Object? There is essentially a base interface that declares every method in java.lang.Object. It's simply not possible to have an instance of an i

Re: svn commit: r1493066 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

Mark, On 6/14/13 11:54 AM, Mark Thomas wrote: > On 14/06/2013 16:38, Rainer Jung wrote: >> On 14.06.2013 15:43, ma...@apache.org wrote: >>> Author: markt >>> Date: Fri Jun 14 13:43:56 2013 >>> New Revision: 1493066 >>> >>> URL: http://svn.apache.org/r1493066 >>> Log: >>> Container provided JARs sh

Re: Jar scanning, SCI scanning, fragment scanning

Cdi handle interfaces too which are not Object. About throwing away classloader that's what we do in tomee. Le 14 juin 2013 18:09, "Christopher Schultz" a écrit : > Romain, > > On 6/14/13 5:38 AM, Romain Manni-Bucau wrote: > > can work this way, today that's not as easy as it could to replace to

Re: Jar scanning, SCI scanning, fragment scanning

Romain, On 6/14/13 5:38 AM, Romain Manni-Bucau wrote: > can work this way, today that's not as easy as it could to replace tomat > scanning(s) (tld, classes) by tomee one. > > About CDI: you basically need to pass all classes on jars with a beans.xml > to the CDI container so @HandlesType doesn't

Re: Jar scanning, SCI scanning, fragment scanning

Mark, On 6/14/13 3:16 AM, Mark Thomas wrote: > On 14/06/2013 03:31, Christopher Schultz wrote: > >> It might be nice if this were not a one-of-many decision, but if a >> client could choose more than one type. A bit-mask or a list of >> scan-types would be nice. I could see the same type of scann

Re: svn commit: r1493066 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

On 14/06/2013 16:38, Rainer Jung wrote: On 14.06.2013 15:43, ma...@apache.org wrote: Author: markt Date: Fri Jun 14 13:43:56 2013 New Revision: 1493066 URL: http://svn.apache.org/r1493066 Log: Container provided JARs should not be scanned for deployment annotations nor should they be checked f

Re: svn commit: r1493066 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

On 14.06.2013 15:43, ma...@apache.org wrote: > Author: markt > Date: Fri Jun 14 13:43:56 2013 > New Revision: 1493066 > > URL: http://svn.apache.org/r1493066 > Log: > Container provided JARs should not be scanned for deployment annotations nor > should they be checked for web-fragment.xml files.

svn commit: r1493115 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/LocalStrings.properties

Author: kkolinko Date: Fri Jun 14 15:25:05 2013 New Revision: 1493115 URL: http://svn.apache.org/r1493115 Log: Merged r1493113 from tomcat/trunk: Followup to r1493073: correct a typo. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/Loca

svn commit: r1493113 - /tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties

Author: kkolinko Date: Fri Jun 14 15:23:34 2013 New Revision: 1493113 URL: http://svn.apache.org/r1493113 Log: Followup to r1493073: correct a typo. Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.

svn commit: r1493080 - in /tomcat/trunk/java/org/apache/catalina: deploy/WebXml.java startup/ContextConfig.java

Author: markt Date: Fri Jun 14 14:14:00 2013 New Revision: 1493080 URL: http://svn.apache.org/r1493080 Log: Always process container JARs for SCIs Order of SCI processing for container JARs compared to web application JARs should be the same as class loading order. Modified: tomcat/trunk/jav

svn commit: r1493073 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/LocalStrings.properties java/org/apache/catalina/core/StandardContext.java

Author: markt Date: Fri Jun 14 13:51:13 2013 New Revision: 1493073 URL: http://svn.apache.org/r1493073 Log: Rename string and update text Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties tomcat/tc7.0.x/trunk/j

svn commit: r1493071 - in /tomcat/trunk/java/org/apache/catalina/core: LocalStrings.properties StandardContext.java

Author: markt Date: Fri Jun 14 13:50:21 2013 New Revision: 1493071 URL: http://svn.apache.org/r1493071 Log: Rename string and update text Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified:

svn commit: r1493069 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

Author: markt Date: Fri Jun 14 13:46:42 2013 New Revision: 1493069 URL: http://svn.apache.org/r1493069 Log: Container provided JARs should not be scanned for deployment annotations. Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apa

svn commit: r1493067 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

Author: markt Date: Fri Jun 14 13:44:43 2013 New Revision: 1493067 URL: http://svn.apache.org/r1493067 Log: Whoops. Better comment. Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java URL: http

svn commit: r1493066 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

Author: markt Date: Fri Jun 14 13:43:56 2013 New Revision: 1493066 URL: http://svn.apache.org/r1493066 Log: Container provided JARs should not be scanned for deployment annotations nor should they be checked for web-fragment.xml files. Modified: tomcat/trunk/java/org/apache/catalina/startup/

[Bug 54083] Provide jarsToSkip on a per-webapp basis

https://issues.apache.org/bugzilla/show_bug.cgi?id=54083 --- Comment #1 from Mark Thomas --- This has been implemented in trunk for Tomcat 8. The changes are non-trivial to back-port. I don't intend proposing a back-port of these changes. I'll leave this open a little while in case someone want

[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

https://issues.apache.org/bugzilla/show_bug.cgi?id=54770 --- Comment #3 from Mark Thomas --- This has been implemented in trunk for Tomcat 8. The changes are non-trivial to back-port. I don't intend proposing a back-port of these changes. The log4j issue can be resolved by a less broad exclusion

Re: svn commit: r1493015 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/StandardContext.java

2013/6/14 : > Author: markt > Date: Fri Jun 14 10:00:57 2013 > New Revision: 1493015 > > URL: http://svn.apache.org/r1493015 > Log: > As per review from voiletagg, restrictions from in Servlet 3.0, section 4.0 > apply to listeners added through the pluggability API as well as via TLDs. > > Modifi

svn commit: r1493015 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/StandardContext.java

Author: markt Date: Fri Jun 14 10:00:57 2013 New Revision: 1493015 URL: http://svn.apache.org/r1493015 Log: As per review from voiletagg, restrictions from in Servlet 3.0, section 4.0 apply to listeners added through the pluggability API as well as via TLDs. Modified: tomcat/tc7.0.x/trunk/

svn commit: r1493014 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

Author: markt Date: Fri Jun 14 09:53:49 2013 New Revision: 1493014 URL: http://svn.apache.org/r1493014 Log: Further restriction as per Servlet 3.1 section 4.4 Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/Standa

svn commit: r1493013 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

Author: markt Date: Fri Jun 14 09:52:53 2013 New Revision: 1493013 URL: http://svn.apache.org/r1493013 Log: More clarity Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java URL: http://svn.apache

Re: svn commit: r1493011 - in /tomcat/trunk/java/org/apache/catalina/core: ApplicationContext.java StandardContext.java

2013/6/14 : > Author: markt > Date: Fri Jun 14 09:43:27 2013 > New Revision: 1493011 > > URL: http://svn.apache.org/r1493011 > Log: > Improve comments. > Rename local variable for clarity. > > Modified: > tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java > tomcat/trunk/jav

svn commit: r1493011 - in /tomcat/trunk/java/org/apache/catalina/core: ApplicationContext.java StandardContext.java

Author: markt Date: Fri Jun 14 09:43:27 2013 New Revision: 1493011 URL: http://svn.apache.org/r1493011 Log: Improve comments. Rename local variable for clarity. Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java tomcat/trunk/java/org/apache/catalina/core/Standard

Re: Jar scanning, SCI scanning, fragment scanning

can work this way, today that's not as easy as it could to replace tomat scanning(s) (tld, classes) by tomee one. About CDI: you basically need to pass all classes on jars with a beans.xml to the CDI container so @HandlesType doesn't match this need really well. *Romain Manni-Bucau* *Twitter: @rm

Re: svn commit: r1492331 - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/ java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/deploy/ java/org/apache/catalina/startup/

On 14/06/2013 07:55, Violeta Georgieva wrote: 2013/6/12 Author: markt Date: Wed Jun 12 18:31:30 2013 New Revision: 1492331 URL: http://svn.apache.org/r1492331 Log: With clarification from the EG for Servlet 3.1 section 4.4 finally makes sense. Implement the necessary restriction and add a te

Re: Jar scanning, SCI scanning, fragment scanning

On 14/06/2013 09:28, Romain Manni-Bucau wrote: SCIs are too webapp linked to be usable by others, that's the point > so it needs to be proprietary ATM If the problem you are trying to solve is JAR scanning outside of the Servlet container then that - frankly - isn't a Tomcat problem. Tomcat

Re: Jar scanning, SCI scanning, fragment scanning

SCIs are too webapp linked to be usable by others, that's the point so it needs to be proprietary ATM + SCI doesn't scan eveything (thinking to cdi you cannot guess a bean is a cdi one before having analyzed it). *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blo

Re: Jar scanning, SCI scanning, fragment scanning

On 14/06/2013 09:14, Romain Manni-Bucau wrote: well i think it will be handled for next spec as it was for interceptors (but it is not that important for initializer in *applications*). I don't get what's the issue using a scanner registry with "get or create" semantic. Is it only tomcat doesn't

Re: Jar scanning, SCI scanning, fragment scanning

On 13/06/2013 17:23, Mark Thomas wrote: As I make my way through the Servlet 3.1 spec reviewing all the changes to make sure they have all been implemented, I have reached section 8.2. There are a number of related issues here. 1. Three known issues with the current SCI / fragment handling [1]

Re: Jar scanning, SCI scanning, fragment scanning

well i think it will be handled for next spec as it was for interceptors (but it is not that important for initializer in *applications*). I don't get what's the issue using a scanner registry with "get or create" semantic. Is it only tomcat doesn't need it by itself? If so my point is today tomca

svn commit: r1492990 - in /tomcat/trunk: java/org/apache/tomcat/util/scan/StandardJarScanFilter.java webapps/docs/config/jar-scan-filter.xml

Author: markt Date: Fri Jun 14 08:12:57 2013 New Revision: 1492990 URL: http://svn.apache.org/r1492990 Log: Fix line endings Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanFilter.java (props changed) tomcat/trunk/webapps/docs/config/jar-scan-filter.xml (props

Re: svn commit: r1492983 - in /tomcat/trunk/webapps/docs/config: jar-scan-filter.xml jar-scanner.xml project.xml

On 14/06/2013 09:08, Konstantin Kolinko wrote: 2013/6/14 : Author: markt Date: Fri Jun 14 07:44:22 2013 New Revision: 1492983 URL: http://svn.apache.org/r1492983 Log: Add some documentation Added: tomcat/trunk/webapps/docs/config/jar-scan-filter.xml and also in a earlier commit tomcat

Re: Jar scanning, SCI scanning, fragment scanning

On 14/06/2013 08:54, Romain Manni-Bucau wrote: that's what we do in TomEE but i don't get how a SCI (order is not deterministic IIRC) can solve the issue. You have yet to articulate exactly what the issue is. You are correct that SCI processing order is not fully deterministic. Container SCIs

Re: svn commit: r1492983 - in /tomcat/trunk/webapps/docs/config: jar-scan-filter.xml jar-scanner.xml project.xml

2013/6/14 : > Author: markt > Date: Fri Jun 14 07:44:22 2013 > New Revision: 1492983 > > URL: http://svn.apache.org/r1492983 > Log: > Add some documentation > > Added: > tomcat/trunk/webapps/docs/config/jar-scan-filter.xml and also in a earlier commit > tomcat/trunk/java/org/apache/tomcat/uti

Re: Jar scanning, SCI scanning, fragment scanning

that's what we do in TomEE but i don't get how a SCI (order is not deterministic IIRC) can solve the issue. *Romain Manni-Bucau* *Twitter: @rmannibucau * *Blog: **http://rmannibucau.wordpress.com/* *LinkedIn: **http://fr.linkedin.

Re: Jar scanning, SCI scanning, fragment scanning

On 14/06/2013 08:35, Romain Manni-Bucau wrote: wait SCIs stands for ServletContainerInitializer right? if so just think all apps are not only webapps (ear typically) I'd disagree. I'd say WARs are far more popular than EARs. For EARs if there is a case for application wide scanning (not sure

svn commit: r1492984 - in /tomcat/trunk/java/org/apache/catalina: deploy/WebXml.java startup/ContextConfig.java

Author: markt Date: Fri Jun 14 07:44:57 2013 New Revision: 1492984 URL: http://svn.apache.org/r1492984 Log: Make flag that indicates if JAR is from webapp or container visible to fragment processing code. Modified: tomcat/trunk/java/org/apache/catalina/deploy/WebXml.java tomcat/trunk/java

svn commit: r1492983 - in /tomcat/trunk/webapps/docs/config: jar-scan-filter.xml jar-scanner.xml project.xml

Author: markt Date: Fri Jun 14 07:44:22 2013 New Revision: 1492983 URL: http://svn.apache.org/r1492983 Log: Add some documentation Added: tomcat/trunk/webapps/docs/config/jar-scan-filter.xml Modified: tomcat/trunk/webapps/docs/config/jar-scanner.xml tomcat/trunk/webapps/docs/config/pr

svn commit: r1492981 - /tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanFilter.java

Author: markt Date: Fri Jun 14 07:43:55 2013 New Revision: 1492981 URL: http://svn.apache.org/r1492981 Log: Add some Javadoc Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanFilter.java Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanFilter.java

svn commit: r1492980 - in /tomcat/trunk/java/org/apache: catalina/startup/ContextRuleSet.java tomcat/JarScanner.java tomcat/util/scan/StandardJarScanner.java

Author: markt Date: Fri Jun 14 07:43:23 2013 New Revision: 1492980 URL: http://svn.apache.org/r1492980 Log: Add getter/setter for JarScanFilter to JarScanner Enable JarScanFilter to be configured via a context.xml file (and server.xml) Modified: tomcat/trunk/java/org/apache/catalina/startup/C

svn commit: r1492979 - in /tomcat/trunk: conf/ java/org/apache/catalina/startup/ java/org/apache/jasper/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/ java/org/apache/tomcat/util/scan/

Author: markt Date: Fri Jun 14 07:42:41 2013 New Revision: 1492979 URL: http://svn.apache.org/r1492979 Log: Get JarScanFilter working with default values Added: tomcat/trunk/java/org/apache/tomcat/JarScanFilter.java - copied, changed from r1492978, tomcat/trunk/java/org/apache/tomcat/J

svn commit: r1492978 - in /tomcat/trunk/java/org/apache: catalina/startup/ContextConfig.java catalina/startup/TldConfig.java jasper/compiler/TldLocationsCache.java tomcat/JarScanType.java tomcat/JarSc

Author: markt Date: Fri Jun 14 07:41:33 2013 New Revision: 1492978 URL: http://svn.apache.org/r1492978 Log: Add the type of scan to the JarScanner API This is preparation for changing how jarsToSkip are handled. Added: tomcat/trunk/java/org/apache/tomcat/JarScanType.java - copied, chang

svn commit: r1492977 - /tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

Author: markt Date: Fri Jun 14 07:40:40 2013 New Revision: 1492977 URL: http://svn.apache.org/r1492977 Log: Shared loader should be treated as a source of application JARs Commons and Server loaders should be treated as a source of container JARs Modified: tomcat/trunk/java/org/apache/tomcat/

svn commit: r1492976 - in /tomcat/trunk/java/org/apache: catalina/startup/TldConfig.java jasper/compiler/TldLocationsCache.java

Author: markt Date: Fri Jun 14 07:40:09 2013 New Revision: 1492976 URL: http://svn.apache.org/r1492976 Log: Add a comment on TLD JARs since no distinction is made between TLDs provided by an application and by the container. Modified: tomcat/trunk/java/org/apache/catalina/startup/TldConfig.ja

svn commit: r1492975 - in /tomcat/trunk/java/org/apache: catalina/startup/ContextConfig.java catalina/startup/TldConfig.java jasper/compiler/TldLocationsCache.java tomcat/JarScannerCallback.java tomca

Author: markt Date: Fri Jun 14 07:39:32 2013 New Revision: 1492975 URL: http://svn.apache.org/r1492975 Log: Enable client of JarScanner to determine if JAR is part of a web application or provided by the container. Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

svn commit: r1492974 - /tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

Author: markt Date: Fri Jun 14 07:38:41 2013 New Revision: 1492974 URL: http://svn.apache.org/r1492974 Log: Already skipped WEB-INF/lib so no need to skip those JARs again Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Modified: tomcat/trunk/java/org/apache/t

Re: svn commit: r1491940 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/catalina/core/LocalStrings.properties test/org/apache/catalina/core/TestAsyncContextImp

2013/6/14 Mark Thomas wrote: > > On 14/06/2013 07:00, Violeta Georgieva wrote: >> >> >> Is that mean that if I have AsyncListener that does some work in >> onComplete() then I will not be able to use the request and response >> objects? > > > Yes and no. You can't call getRequest() or getResponse()

svn commit: r1492973 - in /tomcat/trunk/java/org/apache: catalina/startup/ContextConfig.java catalina/startup/TldConfig.java jasper/compiler/TldLocationsCache.java tomcat/JarScanner.java tomcat/util/s

Author: markt Date: Fri Jun 14 07:38:09 2013 New Revision: 1492973 URL: http://svn.apache.org/r1492973 Log: Remove class loader from the scan method as class loader is accessible from ServletContext. Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java tomcat/trunk/j

Re: Jar scanning, SCI scanning, fragment scanning

wait SCIs stands for ServletContainerInitializer right? if so just think all apps are not only webapps (ear typically) + the issue is really tomcat scanning shouldn't occur if already done (or the opposite, myfaces should reuse tomcat scanned info is here, cxf, spring, cdi container...). *Romain M

Re: svn commit: r1491940 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java java/org/apache/catalina/core/LocalStrings.properties test/org/apache/catalina/core/TestAsyncContextImp

On 14/06/2013 07:00, Violeta Georgieva wrote: 2013/6/11 Author: markt Date: Tue Jun 11 20:18:10 2013 New Revision: 1491940 URL: http://svn.apache.org/r1491940 Log: Servlet 3.1 requires an ISE if getRequest() or getResponse() are called after complete() or dispatch() Modified: tomcat/t

Re: Jar scanning, SCI scanning, fragment scanning

On 14/06/2013 04:05, Nick Williams wrote: On Jun 13, 2013, at 11:23 AM, Mark Thomas wrote: As I make my way through the Servlet 3.1 spec reviewing all the changes to make sure they have all been implemented, I have reached section 8.2. There are a number of related issues here. 1. Three known

Re: Jar scanning, SCI scanning, fragment scanning

On 14/06/2013 08:18, Romain Manni-Bucau wrote: i think all containers actually hack this part since it doesn't match the need when you are just a little bit bigger than tomcat. What requirements can't be met with an SCI? Mark --

Re: Jar scanning, SCI scanning, fragment scanning

i think all containers actually hack this part since it doesn't match the need when you are just a little bit bigger than tomcat. today almost all apps scans (even spring ;) so would be great to get a nicer scanner. *Romain Manni-Bucau* *Twitter: @rmannibucau * *B

Re: Jar scanning, SCI scanning, fragment scanning

On 14/06/2013 03:31, Christopher Schultz wrote: It might be nice if this were not a one-of-many decision, but if a client could choose more than one type. A bit-mask or a list of scan-types would be nice. I could see the same type of scanner being used for multiple different purposes. That is