Re: and security constraints

2013-04-19 Thread David Jencks
Hi Mark, I hope my being tired doesn't come across as being unpleasant… if so I apologize in advance. I think a lot of the security discussion in the servlet spec is vague and misleading. I think the JACC spec provides a firmer basis for thinking about how security is supposed to work. IMO y

and security constraints

2013-04-19 Thread Mark Thomas
Currently, Tomcat only checks against elements if there is a call to isUserInRole(). Prior to Servlet 3.0 this made sense. The person deploying the web application has control over web.xml and hence the security roles (those used in security constraints) but no control over application roles (thos

svn commit: r1470028 - /tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 20:32:27 2013 New Revision: 1470028 URL: http://svn.apache.org/r1470028 Log: kkolinko review Query string starts at first ? Modified: tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java Modified: tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.ja

Re: svn commit: r1469891 - /tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java

2013-04-19 Thread Mark Thomas
On 19/04/2013 20:54, Konstantin Kolinko wrote: > 2013/4/19 : >> Author: markt >> Date: Fri Apr 19 15:20:53 2013 >> New Revision: 1469891 >> >> URL: http://svn.apache.org/r1469891 >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54822 >> Fix handling of query strings with SPDY. >>

svn commit: r1470025 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/pojo/ test/org/apache/tomcat/websocket/server/ weba

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 20:30:00 2013 New Revision: 1470025 URL: http://svn.apache.org/r1470025 Log: Use the ServletContext attribute in unit tests. Remove unnecessary double init() of ServerContainer Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/Constants.java tom

[Bug 54805] [jsr 356] javax.websocket.server.ServerContainer is null when Servlet.init(ServletContext)

2013-04-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54805 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1470020 - /tomcat/trunk/webapps/docs/config/cluster-deployer.xml

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 20:24:20 2013 New Revision: 1470020 URL: http://svn.apache.org/r1470020 Log: Whitespace police Modified: tomcat/trunk/webapps/docs/config/cluster-deployer.xml Modified: tomcat/trunk/webapps/docs/config/cluster-deployer.xml URL: http://svn.apache.org/viewvc/tom

svn commit: r1470016 - in /tomcat/trunk/java/org/apache/tomcat/websocket/server: WsListener.java WsSci.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 20:09:44 2013 New Revision: 1470016 URL: http://svn.apache.org/r1470016 Log: Set ServletContext attribute to expose the ServerContainer. Refactor the ServerContainer bootstrap. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsListener.java to

[Bug 48268] Patch to fix generics in tomcat-lite

2013-04-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48268 Merab changed: What|Removed |Added CC||merabgurabani...@hotmail.co

Re: svn commit: r1469891 - /tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java

2013-04-19 Thread Konstantin Kolinko
2013/4/19 : > Author: markt > Date: Fri Apr 19 15:20:53 2013 > New Revision: 1469891 > > URL: http://svn.apache.org/r1469891 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54822 > Fix handling of query strings with SPDY. > Based on a patch by Sheldon Shao. > > Modified: > tomc

[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2013-04-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=142&rev2=143 aprendedanzaoriental\.info ask\.com a

svn commit: r1470010 - in /tomcat/trunk/java: javax/websocket/server/ServerContainerProvider.java org/apache/tomcat/websocket/server/WsServerContainerProvider.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 19:51:14 2013 New Revision: 1470010 URL: http://svn.apache.org/r1470010 Log: Remove ServerContainerProvider. Should be the last of the API changes. Removed: tomcat/trunk/java/javax/websocket/server/ServerContainerProvider.java tomcat/trunk/java/org/apache/t

svn commit: r1470008 - in /tomcat/trunk: java/javax/websocket/ java/javax/websocket/server/ test/org/apache/tomcat/websocket/ test/org/apache/tomcat/websocket/pojo/

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 19:48:59 2013 New Revision: 1470008 URL: http://svn.apache.org/r1470008 Log: Align API with spec. Update tests for new API. Modified: tomcat/trunk/java/javax/websocket/ClientEndpointConfig.java tomcat/trunk/java/javax/websocket/Decoder.java tomcat/trunk/

[Tomcat Wiki] Trivial Update of "RandolphS" by RandolphS

2013-04-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "RandolphS" page has been changed by RandolphS: http://wiki.apache.org/tomcat/RandolphS New page: [[http://doesphen375works.webs.com|phen375 reviews]] Appetite suppressant similar

svn commit: r1469997 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/WsServerContainer.java test/org/apache/tomcat/websocket/server/TestWebSocketServerContainer.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 19:25:49 2013 New Revision: 1469997 URL: http://svn.apache.org/r1469997 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54807 Forgot to create TreeSet with correct Comparator. Add a test case that checks the context starts correctly. Also, TemplatePathM

[Bug 54807] [jsr356] java.lang.ClassCastException: org.apache.tomcat.websocket.server.WsServerContainer$TemplatePathMatch

2013-04-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54807 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1469987 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 18:56:38 2013 New Revision: 1469987 URL: http://svn.apache.org/r1469987 Log: Simplify Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java UR

buildbot failure in ASF Buildbot on tomcat-trunk

2013-04-19 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4219 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2013-04-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=141&rev2=142 shyxbc\.com\.cn signalsforex silicone

[Tomcat Wiki] Trivial Update of "Buying_Instantaneous_Strategies_Within_skin_lightening" by MuhammadS

2013-04-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "Buying_Instantaneous_Strategies_Within_skin_lightening" page has been changed by MuhammadS: http://wiki.apache.org/tomcat/Buying_Instantaneous_Strategies_Within_skin_lightening Ne

buildbot success in ASF Buildbot on tomcat-trunk

2013-04-19 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4218 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1469905 - in /tomcat/trunk: java/org/apache/tomcat/websocket/server/WsServerContainer.java test/org/apache/tomcat/websocket/server/TestServerContainerImpl.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 15:33:48 2013 New Revision: 1469905 URL: http://svn.apache.org/r1469905 Log: No longer using Servlet mappings Removed: tomcat/trunk/test/org/apache/tomcat/websocket/server/TestServerContainerImpl.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/

[Bug 54850] Automate startup and shutdown using keyboard shortcuts

2013-04-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54850 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 54822] URL with Query String can't work over SPDY

2013-04-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54822 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1469891 - /tomcat/trunk/java/org/apache/coyote/spdy/SpdyProcessor.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 15:20:53 2013 New Revision: 1469891 URL: http://svn.apache.org/r1469891 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54822 Fix handling of query strings with SPDY. Based on a patch by Sheldon Shao. Modified: tomcat/trunk/java/org/apache/coyote/spd

svn commit: r1469876 - /tomcat/trunk/java/org/apache/jasper/compiler/Mark.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 15:06:42 2013 New Revision: 1469876 URL: http://svn.apache.org/r1469876 Log: Bracket police Modified: tomcat/trunk/java/org/apache/jasper/compiler/Mark.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/Mark.java URL: http://svn.apache.org/viewvc/tomc

svn commit: r1469873 - /tomcat/trunk/java/org/apache/jasper/compiler/Mark.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 15:05:46 2013 New Revision: 1469873 URL: http://svn.apache.org/r1469873 Log: Remove Javadoc for non-existent parameter Modified: tomcat/trunk/java/org/apache/jasper/compiler/Mark.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/Mark.java URL: http:/

svn commit: r1469869 - /tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 15:04:59 2013 New Revision: 1469869 URL: http://svn.apache.org/r1469869 Log: Remove reference to (removed) unnecessary listener Modified: tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java Modified: tomcat/trunk/java/org/apache/catalina/

svn commit: r1469867 - /tomcat/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java

2013-04-19 Thread markt
Author: markt Date: Fri Apr 19 15:02:52 2013 New Revision: 1469867 URL: http://svn.apache.org/r1469867 Log: Trailing white-space police. Modified: tomcat/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java Modified: tomcat/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.ja

Re: [VOTE] Tighten up wiki security to reduce spam

2013-04-19 Thread Mark Thomas
On 19/04/2013 15:49, Mark Thomas wrote: > Should the changes described in [1] be applied to the Tomcat wiki? > [X] +1 Make it so > [ ] 0 No opinion > [ ] -1 I object to this proposed change because... My vote for the record. Mark > [1] > http://wiki.apache.org/general/OurWikiFarm#per_wiki_acces

[VOTE] Tighten up wiki security to reduce spam

2013-04-19 Thread Mark Thomas
Given the recent increase in Wiki Spam (it has increased generally across the ASF as well) I think it is time to apply the changes described in [1]. On the plus side, it should eliminate spam. On the down side, legitimate users that want to make changes need to ask for access first. I have said

[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2013-04-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=140&rev2=141 profi-fachuebersetzung\.de profi-fachue

[Tomcat Wiki] Trivial Update of "EmmettLov" by EmmettLov

2013-04-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "EmmettLov" page has been changed by EmmettLov: http://wiki.apache.org/tomcat/EmmettLov New page: Popyt na usługi detektywistyczne jest we współczesnym świecie [[http://detektyw.pr

[Bug 51294] Since 7.0.12 do not work option unpackWARs=true for WARs outside appBase

2013-04-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51294 --- Comment #18 from Andreas Horstmann --- But it does work. I used it at one of my customers and I also reproduced the behavior locally. -- You are receiving this mail because: You are the assignee for the bug. -