Bug report for Tomcat Native [2013/01/06]

2013-01-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Modules [2013/01/06]

2013-01-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2013/01/06]

2013-01-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2013/01/06]

2013-01-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2013/01/06]

2013-01-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 8 [2013/01/06]

2013-01-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2013/01/06]

2013-01-05 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Re: PreDestroy annotation handling

2013-01-05 Thread Christopher Schultz
Konstantin, On 1/5/13 6:31 PM, Konstantin Kolinko wrote: > 2013/1/6 Christopher Schultz : >> >> On 1/5/13 12:52 PM, Konstantin Kolinko wrote: >>> 2) Calling PreDestroy methods if init() method fails. >>> >>> The specs say that >>> - if @PostConstruct methods fail then nothing is called afterwards,

[Bug 54377] New: RemoteIpFilter does not correctly set request attributes for AccessLog

2013-01-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54377 Bug ID: 54377 Summary: RemoteIpFilter does not correctly set request attributes for AccessLog Product: Tomcat 7 Version: 7.0.32 Hardware: All OS: All

Re: PreDestroy annotation handling

2013-01-05 Thread Konstantin Kolinko
2013/1/6 Christopher Schultz : > > On 1/5/13 12:52 PM, Konstantin Kolinko wrote: >> 2) Calling PreDestroy methods if init() method fails. >> >> The specs say that >> - if @PostConstruct methods fail then nothing is called afterwards, and >> - if init() fails then destroy() is not called. >> >> I wo

Re: PreDestroy annotation handling

2013-01-05 Thread Mark Thomas
Konstantin Kolinko wrote: >1) Calling PreDestroy methods if destroy() method fails. > >I think that PreDestroy methods should be called even if destroy() >fails. >For Filters it was fixed by r1428645 . For Servlets this is yet to be >fixed. > >I think this has to be fixed, similar to r1428645.

Re: PreDestroy annotation handling

2013-01-05 Thread Christopher Schultz
Konstantin, On 1/5/13 12:52 PM, Konstantin Kolinko wrote: > 2) Calling PreDestroy methods if init() method fails. > > The specs say that > - if @PostConstruct methods fail then nothing is called afterwards, and > - if init() fails then destroy() is not called. > > I wonder whether failure of ini

svn commit: r1429369 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-01-05 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 20:00:32 2013 New Revision: 1429369 URL: http://svn.apache.org/viewvc?rev=1429369&view=rev Log: Add proposal and move an earlier one into the correct section Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn

svn commit: r1429360 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/security/SecurityUtil.java webapps/docs/changelog.xml

2013-01-05 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 19:01:34 2013 New Revision: 1429360 URL: http://svn.apache.org/viewvc?rev=1429360&view=rev Log: Merged revisions r1429179 r1429180 r1429356 from tomcat/trunk: Simplify the code. - The method names are case-sensitive. - We are returning "null" on failure, so there

svn commit: r1429356 - /tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java

2013-01-05 Thread kkolinko
Author: kkolinko Date: Sat Jan 5 18:50:46 2013 New Revision: 1429356 URL: http://svn.apache.org/viewvc?rev=1429356&view=rev Log: Comment Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityUtil.java URL:

svn commit: r1429348 - in /tomcat/jk/trunk: jkstatus/build.xml native/NOTICE native/common/jk_status.c native/iis/jk_isapi_plugin.c xdocs/style.xsl

2013-01-05 Thread rjung
Author: rjung Date: Sat Jan 5 18:09:04 2013 New Revision: 1429348 URL: http://svn.apache.org/viewvc?rev=1429348&view=rev Log: Again another year. Modified: tomcat/jk/trunk/jkstatus/build.xml tomcat/jk/trunk/native/NOTICE tomcat/jk/trunk/native/common/jk_status.c tomcat/jk/trunk/n

PreDestroy annotation handling

2013-01-05 Thread Konstantin Kolinko
Hi! I was reviewing the calls to InstanceManager.destroyInstance( ) in view of r1428645 and its followups. This method is essentially responsible for calling methods annotated as @PreDestroy. The documentation here are chapters 15.5.9/15.5.10 of Servlet 3.0 Rev a and chapters 2.5/2.6 of JSR250 Co

[Bug 54284] Util.objectNameValueNeedsQuote throws NPE for anonymous Filters

2013-01-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54284 Violeta Georgieva changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #6 from Violet

[Bug 54284] Util.objectNameValueNeedsQuote throws NPE for anonymous Filters

2013-01-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54284 --- Comment #5 from Violeta Georgieva --- Created attachment 29818 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29818&action=edit Test case -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 54284] Util.objectNameValueNeedsQuote throws NPE for anonymous Filters

2013-01-05 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54284 --- Comment #4 from Violeta Georgieva --- Created attachment 29817 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29817&action=edit Patch proposal -- You are receiving this mail because: You are the assignee for the bug.