svn commit: r1426662 - /tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java

2012-12-28 Thread markt
Author: markt Date: Fri Dec 28 23:33:32 2012 New Revision: 1426662 URL: http://svn.apache.org/viewvc?rev=1426662&view=rev Log: Make distinction between wrapper and socket clearer It is the socket that is the key for the connections map, not the processor Modified: tomcat/trunk/java/org/apache

Re: svn commit: r1425680 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.java

2012-12-28 Thread Mark Thomas
On 28/12/2012 00:04, Konstantin Kolinko wrote: > Looking at the current code, "new String()" call still remains in WsFrame.java > Starting with Line 270: > > if (controlBufferBinary.remaining() > 0) { > CoderResult cr = utf8DecoderControl.decode( >

svn commit: r1426458 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.java

2012-12-28 Thread markt
Author: markt Date: Fri Dec 28 11:22:44 2012 New Revision: 1426458 URL: http://svn.apache.org/viewvc?rev=1426458&view=rev Log: Remove a new String() that should have been removed when the decoder was added. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.java Modified: tomcat

Re: svn commit: r1425985 - /tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties

2012-12-28 Thread Mark Thomas
On 27/12/2012 23:47, Konstantin Kolinko wrote: > If I understand this correctly, you had to trim the text of > "wsFrame.textMessageTooBig" message? Correct. > Maybe add some comment there to warn future translators? Done. > Maybe automatically truncate the i18n'ed message if it is too long? I'

svn commit: r1426456 - /tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties

2012-12-28 Thread markt
Author: markt Date: Fri Dec 28 11:18:04 2012 New Revision: 1426456 URL: http://svn.apache.org/viewvc?rev=1426456&view=rev Log: Add warning about message length Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/tomcat/websoc

svn commit: r1426455 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.java

2012-12-28 Thread markt
Author: markt Date: Fri Dec 28 11:15:05 2012 New Revision: 1426455 URL: http://svn.apache.org/viewvc?rev=1426455&view=rev Log: Consistency - use WsIOException Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.

Re: svn commit: r1426009 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpoint.java

2012-12-28 Thread Mark Thomas
On 27/12/2012 23:36, Konstantin Kolinko wrote: > 2012/12/27 : >> Author: markt >> Date: Wed Dec 26 20:19:51 2012 >> New Revision: 1426009 >> >> URL: http://svn.apache.org/viewvc?rev=1426009&view=rev >> Log: >> Correctly set isText flag for text messages >> >> Modified: >> tomcat/trunk/java/org

svn commit: r1426452 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpoint.java

2012-12-28 Thread markt
Author: markt Date: Fri Dec 28 11:07:06 2012 New Revision: 1426452 URL: http://svn.apache.org/viewvc?rev=1426452&view=rev Log: Fix logic thanks to review by kkolinko Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/we

Re: svn commit: r1426336 - in /tomcat/trunk/java: javax/websocket/PongMessage.java org/apache/tomcat/websocket/PojoMethodMapping.java org/apache/tomcat/websocket/Utf8Decoder.java org/apache/tomcat/web

2012-12-28 Thread Mark Thomas
On 27/12/2012 23:04, Konstantin Kolinko wrote: > 2012/12/28 : >> Author: markt >> Date: Thu Dec 27 21:40:39 2012 >> New Revision: 1426336 >> >> URL: http://svn.apache.org/viewvc?rev=1426336&view=rev >> Log: >> Javadoc >> >> Modified: >> tomcat/trunk/java/javax/websocket/PongMessage.java >>

svn commit: r1426451 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.java

2012-12-28 Thread markt
Author: markt Date: Fri Dec 28 11:03:16 2012 New Revision: 1426451 URL: http://svn.apache.org/viewvc?rev=1426451&view=rev Log: Fix typos Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrame.java URL: http://svn.

[Bug 54355] Many a times httpSession.invalidate() gets executed in concurrent thread

2012-12-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54355 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 54355] Many a times httpSession.invalidate() gets executed in concurrent thread

2012-12-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54355 Yogesh changed: What|Removed |Added CC||ynmanw...@gmail.com OS|

[Bug 54355] New: Many a times httpSession.invalidate() gets executed in concurrent thread

2012-12-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54355 Bug ID: 54355 Summary: Many a times httpSession.invalidate() gets executed in concurrent thread Product: Tomcat 6 Version: 6.0.32 Hardware: PC Status: NEW