Re: atomicity problem in SecurityUtil.java

2012-07-21 Thread Chris R
Mark, Thank you for your "kind" response. > and it seems that there may be a problem there. More specifically, in the > > execute method, getAttribute of Globals.SUBJECT_ATTR is obtained on a > > session > > and then it is set in a non-atomic fashion. > > While that statement is true, you have no

Re: atomicity problem in SecurityUtil.java

2012-07-21 Thread Mark Thomas
On 21/07/2012 21:32, Chris R wrote: > Hi, > > I am looking at SecurityUtil.java ( > http://www.docjar.com/html/api/org/apache/catalina/security/SecurityUtil.java.html) It would be much better to reference the source from the canonical location (the ASF svn repo) rather than some unverified third-

svn commit: r1364165 - /tomcat/trunk/TOMCAT-NEXT.txt

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 20:31:11 2012 New Revision: 1364165 URL: http://svn.apache.org/viewvc?rev=1364165&view=rev Log: Update progress Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.txt?rev=136

svn commit: r1364163 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 20:26:49 2012 New Revision: 1364163 URL: http://svn.apache.org/viewvc?rev=1364163&view=rev Log: More false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.a

svn commit: r1364162 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 20:26:31 2012 New Revision: 1364162 URL: http://svn.apache.org/viewvc?rev=1364162&view=rev Log: Add explanatory comment Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.ja

svn commit: r1364155 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 19:11:44 2012 New Revision: 1364155 URL: http://svn.apache.org/viewvc?rev=1364155&view=rev Log: Suppress incorrect warning Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig

svn commit: r1364154 - /tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 19:10:39 2012 New Revision: 1364154 URL: http://svn.apache.org/viewvc?rev=1364154&view=rev Log: FindBugs - Possible NPE Use consistent approach to exception handling and the creation of the FailedContext instance context cannot be null Modified: tomcat/trunk/ja

svn commit: r1364151 - in /tomcat/trunk/java/org/apache/catalina/startup: CatalinaProperties.java ContextConfig.java DigesterFactory.java TldConfig.java

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 19:00:28 2012 New Revision: 1364151 URL: http://svn.apache.org/viewvc?rev=1364151&view=rev Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java tomcat/trunk/java/org/apache/catalina/startup/ContextConfig

svn commit: r1364150 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 18:57:54 2012 New Revision: 1364150 URL: http://svn.apache.org/viewvc?rev=1364150&view=rev Log: Deprecate unused / unnecessary code Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/CatalinaProperties.ja

svn commit: r1364149 - in /tomcat/trunk/java/org/apache/catalina/startup: CatalinaProperties.java ContextConfig.java DigesterFactory.java TldConfig.java

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 18:57:23 2012 New Revision: 1364149 URL: http://svn.apache.org/viewvc?rev=1364149&view=rev Log: Deprecate unused / unnecessary code Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java tomcat/trunk/java/org/apache/catalina/startup/

svn commit: r1364147 - /tomcat/trunk/java/org/apache/catalina/startup/

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 18:52:54 2012 New Revision: 1364147 URL: http://svn.apache.org/viewvc?rev=1364147&view=rev Log: Code clean-up for o.a.catalina.startup - Add final prompted by UCDetector - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/startup/ClassLoaderFact

svn commit: r1364143 - /tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 18:31:59 2012 New Revision: 1364143 URL: http://svn.apache.org/viewvc?rev=1364143&view=rev Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java UR

svn commit: r1364142 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Catalina.java

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 18:29:12 2012 New Revision: 1364142 URL: http://svn.apache.org/viewvc?rev=1364142&view=rev Log: Deprecate unused / unnecessary code Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Catalina.java Propcha

svn commit: r1364141 - /tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 18:28:19 2012 New Revision: 1364141 URL: http://svn.apache.org/viewvc?rev=1364141&view=rev Log: Deprecate unused / unnecessary code Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Cat

svn commit: r1364140 - in /tomcat/trunk/java/org/apache/catalina/startup: Bootstrap.java Catalina.java

2012-07-21 Thread markt
Author: markt Date: Sat Jul 21 18:24:12 2012 New Revision: 1364140 URL: http://svn.apache.org/viewvc?rev=1364140&view=rev Log: Code clean-up - Java 7 use of <> Modified: tomcat/trunk/java/org/apache/catalina/startup/Bootstrap.java tomcat/trunk/java/org/apache/catalina/startup/Catalina.ja

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2012-07-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. Th

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2012-07-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration.

[GUMP@vmgump]: Project tomcat-trunk-dbcp (in module tomcat-trunk) failed

2012-07-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-dbcp has an issue affecting its community integration. This i

[GUMP@vmgump]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed

2012-07-21 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate-eoln has an issue affecting its community integrati