Re: access to build environment

2012-07-11 Thread Filip Hanik
I'd guess those two, do we use anything else for tomcat ci? Sent from my iPhone On Jul 11, 2012, at 16:42, Mark Thomas wrote: > On 11/07/2012 23:40, Filip Hanik (mailing lists) wrote: >> How do I get access to the build environment? > > Which build environment? Gump, buildbot, something else?

Re: Unit tests and trunk

2012-07-11 Thread Filip Hanik
I can reproduce the bug in both our unit tests and the original bug report. further more I can turn non blocking into blocking by opening an closing a selector that is never used. definitely a bug, since a jvm/network flag resolves it. while your vm may support ipv6, there is still an additio

Missing classes in stock 5.5.35 JARs?

2012-07-11 Thread Christopher Schultz
All, http://stackoverflow.com/questions/11427522/ssl-configuration-getting-classpuretlsimplementation-jsse15factory-not-foun The SO poster is using 5.5.30 but the problem appears to still exist in 5.5.35 (latest). I downloaded the "core" Tomcat 5.5.35 tarball and none of the .jar files in there

svn commit: r1360470 - in /tomcat/trunk/java/org/apache/catalina: core/AsyncContextImpl.java startup/Tomcat.java

2012-07-11 Thread markt
Author: markt Date: Wed Jul 11 23:15:00 2012 New Revision: 1360470 URL: http://svn.apache.org/viewvc?rev=1360470&view=rev Log: Fix a few Eclipse warnings Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java M

svn commit: r1360468 - /tomcat/trunk/java/org/apache/catalina/connector/ClientAbortException.java

2012-07-11 Thread markt
Author: markt Date: Wed Jul 11 23:10:53 2012 New Revision: 1360468 URL: http://svn.apache.org/viewvc?rev=1360468&view=rev Log: Simplify (this class dates from pre-Java 1.4) Modified: tomcat/trunk/java/org/apache/catalina/connector/ClientAbortException.java Modified: tomcat/trunk/java/org/ap

svn commit: r1360462 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2012-07-11 Thread markt
Author: markt Date: Wed Jul 11 22:52:57 2012 New Revision: 1360462 URL: http://svn.apache.org/viewvc?rev=1360462&view=rev Log: Add missing word Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/view

[Bug 53524] Typo in cluster-howto.html

2012-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53524 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1360461 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/cluster-howto.xml

2012-07-11 Thread markt
Author: markt Date: Wed Jul 11 22:51:35 2012 New Revision: 1360461 URL: http://svn.apache.org/viewvc?rev=1360461&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53524 Fix typo and spelling Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/

svn commit: r1360460 - /tomcat/trunk/webapps/docs/cluster-howto.xml

2012-07-11 Thread markt
Author: markt Date: Wed Jul 11 22:49:14 2012 New Revision: 1360460 URL: http://svn.apache.org/viewvc?rev=1360460&view=rev Log: Fix spelling Modified: tomcat/trunk/webapps/docs/cluster-howto.xml Modified: tomcat/trunk/webapps/docs/cluster-howto.xml URL: http://svn.apache.org/viewvc/tomcat/tr

svn commit: r1360455 - /tomcat/trunk/webapps/docs/cluster-howto.xml

2012-07-11 Thread markt
Author: markt Date: Wed Jul 11 22:45:15 2012 New Revision: 1360455 URL: http://svn.apache.org/viewvc?rev=1360455&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53524 Fix typo Modified: tomcat/trunk/webapps/docs/cluster-howto.xml Modified: tomcat/trunk/webapps/docs/clust

Re: access to build environment

2012-07-11 Thread Mark Thomas
On 11/07/2012 23:40, Filip Hanik (mailing lists) wrote: > How do I get access to the build environment? Which build environment? Gump, buildbot, something else? Mark > > So we can change the build to default to Java 7 > > Filip > > > > >

Re: Unit tests and trunk

2012-07-11 Thread Mark Thomas
On 11/07/2012 23:30, Filip Hanik (mailing lists) wrote: > I wasn't able to reproduce on a Win 7 VM because the VM environment itself > doesn't support IPv6 Given who we work for, the opportunities for humorous comments is extensive :) I'll settle for saying that I've double checked the VM I have

access to build environment

2012-07-11 Thread Filip Hanik (mailing lists)
How do I get access to the build environment? So we can change the build to default to Java 7 Filip - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
I opened a new issue pointing back to the old issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7183450. It may take a day or two before your bug shows up in this external database. > -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Wednes

buildbot failure in ASF Buildbot on tomcat-trunk

2012-07-11 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3183 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, July 11, 2012 4:28 PM > To: Tomcat Developers List > Subject: Re: Unit tests and trunk > > On 11/07/2012 22:39, Filip Hanik (mailing lists) wrote: > > Ok, I have a resolution to this, it's a IPv6 proble

svn commit: r1360449 - /tomcat/trunk/webapps/docs/aio.xml

2012-07-11 Thread fhanik
Author: fhanik Date: Wed Jul 11 22:29:08 2012 New Revision: 1360449 URL: http://svn.apache.org/viewvc?rev=1360449&view=rev Log: fix sentence Modified: tomcat/trunk/webapps/docs/aio.xml Modified: tomcat/trunk/webapps/docs/aio.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/ai

Re: Unit tests and trunk

2012-07-11 Thread Mark Thomas
On 11/07/2012 22:39, Filip Hanik (mailing lists) wrote: > Ok, I have a resolution to this, it's a IPv6 problem. The reason it worked > on my virtual machine, is cause the virtual machine doesn't have IPv6 > > When I add > > > To the unit tests, it works fine on Windows. > > Here is what led me

RE: svn commit: r1360372 - /tomcat/trunk/webapps/docs/aio.xml

2012-07-11 Thread Filip Hanik (mailing lists)
Will fix > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, July 11, 2012 4:03 PM > To: Tomcat Developers List > Subject: Re: svn commit: r1360372 - /tomcat/trunk/webapps/docs/aio.xml > > On 11/07/2012 20:51, fha...@apache.org wrote: > > Author: fhanik

Re: svn commit: r1360372 - /tomcat/trunk/webapps/docs/aio.xml

2012-07-11 Thread Mark Thomas
On 11/07/2012 20:51, fha...@apache.org wrote: > Author: fhanik > Date: Wed Jul 11 19:51:57 2012 > New Revision: 1360372 > > URL: http://svn.apache.org/viewvc?rev=1360372&view=rev > Log: > Clarify documentation around send file > > Modified: > tomcat/trunk/webapps/docs/aio.xml > > Modified: t

svn commit: r1360433 - in /tomcat/trunk: build.properties.default build.xml

2012-07-11 Thread fhanik
Author: fhanik Date: Wed Jul 11 22:01:17 2012 New Revision: 1360433 URL: http://svn.apache.org/viewvc?rev=1360433&view=rev Log: Add IPv4Stack flag one can control from build.properties and build.properties.default default value is false but can be overridden even from command line default compile

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
Ok, I have a resolution to this, it's a IPv6 problem. The reason it worked on my virtual machine, is cause the virtual machine doesn't have IPv6 When I add To the unit tests, it works fine on Windows. Here is what led me to believe in this: http://blog.bielu.com/2011/11/hotspot-64bit-server-ha

[Bug 53535] Out of memory while performing ContextConfig.webConfig

2012-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53535 --- Comment #2 from Cedomir Igaly --- Created attachment 29051 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29051&action=edit diff -u Here it is! -- You are receiving this mail because: You are the assignee for the bug. --

svn commit: r1360408 - /tomcat/trunk/webapps/docs/aio.xml

2012-07-11 Thread fhanik
Author: fhanik Date: Wed Jul 11 21:24:18 2012 New Revision: 1360408 URL: http://svn.apache.org/viewvc?rev=1360408&view=rev Log: correct the sentence. chunked will not work, as the length is fixed and not encoding is added during send file Modified: tomcat/trunk/webapps/docs/aio.xml Modified

RE: svn commit: r1360372 - /tomcat/trunk/webapps/docs/aio.xml

2012-07-11 Thread Caldarale, Charles R
> From: fha...@apache.org [mailto:fha...@apache.org] > Subject: svn commit: r1360372 - /tomcat/trunk/webapps/docs/aio.xml > Author: fhanik > Date: Wed Jul 11 19:51:57 2012 > New Revision: 1360372 > URL: http://svn.apache.org/viewvc?rev=1360372&view=rev > +In addition to setting these parame

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
The idea of creating a VM that is like mine was a good one. I did a clean install of Windows 7 64 bit, and it works like a charm. My network stack must have something installed at the network stack Filip > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday

svn commit: r1360393 - /tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java

2012-07-11 Thread fhanik
Author: fhanik Date: Wed Jul 11 20:51:13 2012 New Revision: 1360393 URL: http://svn.apache.org/viewvc?rev=1360393&view=rev Log: Cleanup and better file naming Modified: tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java Modified: tomcat/trunk/test/org/apache/catalina/connector

svn commit: r1360372 - /tomcat/trunk/webapps/docs/aio.xml

2012-07-11 Thread fhanik
Author: fhanik Date: Wed Jul 11 19:51:57 2012 New Revision: 1360372 URL: http://svn.apache.org/viewvc?rev=1360372&view=rev Log: Clarify documentation around send file Modified: tomcat/trunk/webapps/docs/aio.xml Modified: tomcat/trunk/webapps/docs/aio.xml URL: http://svn.apache.org/viewvc/to

[Bug 53531] ExpandWar.expand does not check the return value of File.mkdir and File.mkdirs

2012-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 Christopher Schultz changed: What|Removed |Added Summary|ExpandWar.expand does not |ExpandWar.expand does not

[Bug 53531] ExpandWar.expand does not check the return value of File.mkdirs

2012-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 Christopher Schultz changed: What|Removed |Added Attachment #29045|0 |1 is obsolete|

svn commit: r1360369 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-07-11 Thread schultz
Author: schultz Date: Wed Jul 11 19:41:14 2012 New Revision: 1360369 URL: http://svn.apache.org/viewvc?rev=1360369&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev

[Bug 53531] ExpandWar.expand does not check the return value of File.mkdirs

2012-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 --- Comment #3 from Christopher Schultz --- Created attachment 29050 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29050&action=edit Patch for 6.0.x against r1359053 -- You are receiving this mail because: You are the assigne

Re: Unit tests and trunk

2012-07-11 Thread Mark Thomas
On 11/07/2012 20:13, Filip Hanik (mailing lists) wrote: > > >> -Original Message- >> From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] >> Sent: Wednesday, July 11, 2012 10:13 AM >> To: 'Tomcat Developers List' >> Subject: RE: Unit tests and trunk >> >> >> >>> -Original Mes

[Bug 53531] ExpandWar.expand does not check the return value of File.mkdirs

2012-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 Christopher Schultz changed: What|Removed |Added Attachment #29045|Patch against current trunk |Patch against current 5.5.x

svn commit: r1360359 - /tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java

2012-07-11 Thread fhanik
Author: fhanik Date: Wed Jul 11 19:16:31 2012 New Revision: 1360359 URL: http://svn.apache.org/viewvc?rev=1360359&view=rev Log: remove unused imports Modified: tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java Modified: tomcat/trunk/test/org/apache/catalina/connector/TestSend

svn commit: r1360358 - /tomcat/trunk/test/org/apache/catalina/connector/TestSendFile.java

2012-07-11 Thread fhanik
Author: fhanik Date: Wed Jul 11 19:16:10 2012 New Revision: 1360358 URL: http://svn.apache.org/viewvc?rev=1360358&view=rev Log: Add a test file unit test case. This test case fails with both NIO and BIO on Windows 7 with JDK 1.7 Added: tomcat/trunk/test/org/apache/catalina/connector/TestSen

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Filip Hanik (mailing lists) [mailto:devli...@hanik.com] > Sent: Wednesday, July 11, 2012 10:13 AM > To: 'Tomcat Developers List' > Subject: RE: Unit tests and trunk > > > > > -Original Message- > > From: Mark Thomas [mailto:ma...@apache.org] > > Sen

[Bug 53513] Race condition / out of order operation in session replication at node startup

2012-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53513 Mark Thomas changed: What|Removed |Added Component|Cluster |Cluster Version|7.0.26

[Bug 53535] Out of memory while performing ContextConfig.webConfig

2012-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53535 --- Comment #1 from Mark Thomas --- Looks like a sensible improvement to me. Can you provide the patch in diff -u format to save me unpicking it please. -- You are receiving this mail because: You are the assignee for the bug. --

RE: Unit tests and trunk

2012-07-11 Thread Filip Hanik (mailing lists)
> -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, July 11, 2012 2:45 AM > To: Tomcat Developers List > Subject: Re: Unit tests and trunk > > On 11/07/2012 02:27, Filip Hanik (mailing lists) wrote: > > Here's what I've found out so far > > > > The patch

[Bug 53535] New: Out of memory while performing ContextConfig.webConfig

2012-07-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53535 Priority: P2 Bug ID: 53535 Assignee: dev@tomcat.apache.org Summary: Out of memory while performing ContextConfig.webConfig Severity: normal Classification: Unclassified

Re: Unit tests and trunk

2012-07-11 Thread Mark Thomas
On 11/07/2012 02:27, Filip Hanik (mailing lists) wrote: > Here's what I've found out so far > > The patch below does solve the problem. In a rather remarkable way. > The line > int cnt = socket.write(buf); //write the data > > never returns 0, meaning the writes are always blocking. Even though

svn commit: r1360060 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Response.java test/org/apache/catalina/connector/TestResponse.java webapps/docs/changelog.xml

2012-07-11 Thread markt
Author: markt Date: Wed Jul 11 08:27:31 2012 New Revision: 1360060 URL: http://svn.apache.org/viewvc?rev=1360060&view=rev Log: Handle fragments as well as query strings in normalisation of redirects Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/cat

svn commit: r1360059 - in /tomcat/trunk: java/org/apache/catalina/connector/Response.java test/org/apache/catalina/connector/TestResponse.java

2012-07-11 Thread markt
Author: markt Date: Wed Jul 11 08:26:26 2012 New Revision: 1360059 URL: http://svn.apache.org/viewvc?rev=1360059&view=rev Log: Handle fragments as well as query strings in normalisation of redirects Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java tomcat/trunk/test/

Re: svn commit: r1359751 - in /tomcat/tc5.5.x/trunk: STATUS.txt container/catalina/src/share/org/apache/catalina/session/ManagerBase.java

2012-07-11 Thread Mark Thomas
On 10/07/2012 17:12, j...@apache.org wrote: > Author: jim > Date: Tue Jul 10 16:12:46 2012 > New Revision: 1359751 > > URL: http://svn.apache.org/viewvc?rev=1359751&view=rev > Log: > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53050 > Fix XOR arithmetics and charset issue when calcu

svn commit: r1360047 - /tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml

2012-07-11 Thread markt
Author: markt Date: Wed Jul 11 08:08:43 2012 New Revision: 1360047 URL: http://svn.apache.org/viewvc?rev=1360047&view=rev Log: Add recently applied patches. Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml Modified: tomcat/tc5.5.x/trunk/container/webapps/docs/changelog.xml

Re: tomcat bad encoding

2012-07-11 Thread Mark Thomas
On 10/07/2012 18:03, Thushara Wijeratna wrote: > Is it possible to have tomcat treat bad URI encodings leniently? No. Sorry. > It > currently modifies a buffer in place and if a % sign is followed by > anything other than 2 hexadecimal characters, it gives up decoding and > throws an exception. B