[Bug 53391] CometEvent.close() doesn't close socket when called from different thread

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 --- Comment #9 from Lawrence Kesteloot --- Hi Mark, I made a test servlet and it worked fine: the response was properly ended when I called event.close() from another thread. I was thrown off for hours by bug 51881, and finally when I upgra

[Bug 53401] New: Request objects use too much memory!

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53401 Priority: P2 Bug ID: 53401 Assignee: dev@tomcat.apache.org Summary: Request objects use too much memory! Severity: normal Classification: Unclassified OS: All

[Bug 53266] ServletContainerInitializer will crash catalina if dependcy is not present.

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53266 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1349008 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/LocalStrings.properties webapps/docs/changelog.xml

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 20:59:49 2012 New Revision: 1349008 URL: http://svn.apache.org/viewvc?rev=1349008&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53266 Handle missing classes defined in @HandlesTypes more gracefully - the specification requires it should not st

svn commit: r1349007 - in /tomcat/trunk/java/org/apache/catalina/startup: ContextConfig.java LocalStrings.properties

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 20:57:26 2012 New Revision: 1349007 URL: http://svn.apache.org/viewvc?rev=1349007&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53266 Handle missing classes defined in @HandlesTypes more gracefully - the specification requires it should not st

[Bug 53391] CometEvent.close() doesn't close socket when called from different thread

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 --- Comment #8 from Mark Thomas --- Again, Tomcat does correctly signal the end of the response as per RFC2616. If you have a test case where it doesn't please re-open this bug. -- You are receiving this mail because: You are the assignee

[Bug 53391] CometEvent.close() doesn't close socket when called from different thread

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 --- Comment #7 from Lawrence Kesteloot --- Got it. You were right that this is an invalid bug. Other async web servers like Tornado must transparently buffer the output and set the content length themselves, so "it just works", and I expect

[Bug 53398] Incorrect tag on XML response when calling 'manager/status?XML=true'

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53398 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1348992 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml webapps/docs/manager-howto.xml webapps/manager/status.xsd

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 20:20:23 2012 New Revision: 1348992 URL: http://svn.apache.org/viewvc?rev=1348992&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53398 recieved->received Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/ap

svn commit: r1348989 - in /tomcat/trunk: java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/manager-howto.xml webapps/manager/status.xsd

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 20:09:20 2012 New Revision: 1348989 URL: http://svn.apache.org/viewvc?rev=1348989&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53398 recieved->received Modified: tomcat/trunk/java/org/apache/catalina/manager/StatusTransformer.java tom

[Bug 53391] CometEvent.close() doesn't close socket when called from different thread

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 --- Comment #6 from Mark Thomas --- You don't mean close connection either. You mean the client is unable to determine the end of the response. This is usually signalled by one of the following: - content length header plus that many bytes

[Bug 53391] CometEvent.close() doesn't close socket when called from different thread

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 --- Comment #5 from Lawrence Kesteloot --- That should say "NOT from within the event() method". -- You are receiving this mail because: You are the assignee for the bug. --

[Bug 53391] CometEvent.close() doesn't close socket when called from different thread

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 --- Comment #4 from Lawrence Kesteloot --- I think I said "close socket" when I really meant "close connection". Here's the behavior I'm seeing: If I do "curl URL" from the command line, and in BEGIN I respond and ComentEvent.close(), the c

buildbot success in ASF Buildbot on tomcat-trunk

2012-06-11 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3066 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

svn commit: r1348979 - /tomcat/jk/trunk/tools/dist/README.html

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 19:26:06 2012 New Revision: 1348979 URL: http://svn.apache.org/viewvc?rev=1348979&view=rev Log: Make verification text consistent across all components Modified: tomcat/jk/trunk/tools/dist/README.html Modified: tomcat/jk/trunk/tools/dist/README.html URL: http:

[Bug 53394] Log warning if SSLv2 is enabled

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53394 --- Comment #2 from Michael Osipov <1983-01...@gmx.net> --- (In reply to comment #1) > This is a Tomcat 6 specific issue which still includes SSLv2 by default. > > The use of SSLv2 and that it is inherently unsafe is clearly indicated in >

svn commit: r1348973 - /tomcat/trunk/webapps/docs/config/http.xml

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 19:14:36 2012 New Revision: 1348973 URL: http://svn.apache.org/viewvc?rev=1348973&view=rev Log: Update APR SSLProtocol defaults and configuration Modified: tomcat/trunk/webapps/docs/config/http.xml Modified: tomcat/trunk/webapps/docs/config/http.xml URL: http:

svn commit: r1348972 - /tomcat/trunk/build.properties.default

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 19:13:44 2012 New Revision: 1348972 URL: http://svn.apache.org/viewvc?rev=1348972&view=rev Log: Revert accidental commit of local change Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/

[Bug 53394] Log warning if SSLv2 is enabled

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53394 --- Comment #1 from Mark Thomas --- This is a Tomcat 6 specific issue which still includes SSLv2 by default. The use of SSLv2 and that it is inherently unsafe is clearly indicated in the documentation for the APR connector. -- You are re

buildbot exception in ASF Buildbot on tomcat-trunk

2012-06-11 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/3065 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

Re: svn commit: r1348612 - in /tomcat/site/trunk: docs/ xdocs/

2012-06-11 Thread Konstantin Kolinko
2012/6/10 : > Author: markt > Date: Sun Jun 10 15:09:29 2012 > New Revision: 1348612 > > URL: http://svn.apache.org/viewvc?rev=1348612&view=rev > Log: > Make verification text consistent across all components > > Modified: >    tomcat/site/trunk/docs/download-55.html >    tomcat/site/trunk/docs/do

svn commit: r1348968 - in /tomcat/trunk: build.properties.default java/org/apache/tomcat/util/net/AprEndpoint.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 19:04:09 2012 New Revision: 1348968 URL: http://svn.apache.org/viewvc?rev=1348968&view=rev Log: APR 1.1.24 is now required. Remove unnecessary code. Modified: tomcat/trunk/build.properties.default tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

svn commit: r1348965 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/ant/antlib.xml

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 18:54:53 2012 New Revision: 1348965 URL: http://svn.apache.org/viewvc?rev=1348965&view=rev Log: Clean properties Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ant/antlib.xml (props changed) Propchange: tomcat/tc7.0.x/trunk/java/org/apache/catalina/

Re: [VOTE] Release Apache Tomcat Native 1.1.24

2012-06-11 Thread Mark Thomas
On 11/06/2012 13:54, Mladen Turk wrote: > Version 1.1.24 is feature-add release containing additional > API to set per-socket timeouts inside Poller. > The proposed release artefacts can be found at [1], > and the build was done using tag [2]. > > The VOTE will remain open for at least 48 hours. >

[Bug 53071] ErrorReportValve ignores message from throwable

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #5 from Mark Thomas --- Then you have already replaced / modified the error report valve and you won't see this change. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 53071] ErrorReportValve ignores message from throwable

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #4 from Christopher Schultz --- Putting this caveat in the bug and not just on the dev list: This might end up being a security problem, depending on what information is in the exception message. Can we make this a non-default

Re: svn commit: r1348762 - in /tomcat/trunk: java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread Christopher Schultz
Mark, On 6/11/12 5:24 AM, ma...@apache.org wrote: > Author: markt > Date: Mon Jun 11 09:24:53 2012 > New Revision: 1348762 > > URL: http://svn.apache.org/viewvc?rev=1348762&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 > Stepping through the code, light dawns as t

Re: tcnative documentation is broken on tomcat.apache.org

2012-06-11 Thread Konstantin Kolinko
2012/6/11 Christopher Schultz : > Konstantin, > > On 6/7/12 5:49 PM, Konstantin Kolinko wrote: >> 2012/6/8 Konstantin Kolinko : >>> 2012/6/8 Christopher Schultz : All, http://tomcat.apache.org/native-doc/ It says that tcnative 2.0.0 has been released, has no date, and links

[Bug 53324] Starting with mod_jk 1.2.35 I cannot modify worker status using JK Status Manager

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53324 --- Comment #3 from Mladen Turk --- Is this from standard page or from 'Edit this attribute for all members' ? I presume its later cause I can modify lbfactors when directly editing a worker, so please open a new BZ. -- You are receiving

Re: tcnative documentation is broken on tomcat.apache.org

2012-06-11 Thread Christopher Schultz
Konstantin, On 6/7/12 5:49 PM, Konstantin Kolinko wrote: > 2012/6/8 Konstantin Kolinko : >> 2012/6/8 Christopher Schultz : >>> All, >>> >>> http://tomcat.apache.org/native-doc/ >>> >>> It says that tcnative 2.0.0 has been released, has no date, and links to >>> non-existent files. >>> >>> Same thi

[Bug 53398] Incorrect tag on XML response when calling 'manager/status?XML=true'

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53398 Albertico changed: What|Removed |Added Summary|Incorrect tag names on XML |Incorrect tag on XML

[Bug 53398] New: Incorrect tag names on XML response when calling 'manager/status?XML=true'

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53398 Priority: P2 Bug ID: 53398 Assignee: dev@tomcat.apache.org Summary: Incorrect tag names on XML response when calling 'manager/status?XML=true' Severity: normal Clas

[Bug 53395] Syntactically incorrect webapp context.xml breaks auto deploy

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53395 --- Comment #3 from Konstantin Kolinko --- A. If context.xml is broken, replacing a war is not going to help, as context file has priority over war. Note, that 1. in Tomcat 7 the context file is not copied to conf directory by default, so

[Bug 53324] Starting with mod_jk 1.2.35 I cannot modify worker status using JK Status Manager

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53324 r...@debian.org.pl changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FI

[Bug 53395] Syntactically incorrect webapp context.xml breaks auto deploy

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53395 --- Comment #2 from Mike Tillberg --- It looks like auto deploy is implemented as a undeploy followed by deploy: Jun 11, 2012 10:15:26 AM org.apache.catalina.startup.HostConfig checkResources INFO: Undeploying context [/webapp] Jun 11, 201

svn commit: r1348865 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/comet/TestCometProcessor.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 14:23:14 2012 New Revision: 1348865 URL: http://svn.apache.org/viewvc?rev=1348865&view=rev Log: Additional Comet test cases for connection closing Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/test/org/apache/catalina/comet/TestComet

[Bug 53391] CometEvent.close() doesn't close socket when called from different thread

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1348859 - /tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 14:19:19 2012 New Revision: 1348859 URL: http://svn.apache.org/viewvc?rev=1348859&view=rev Log: Additional Comet tests to confirm / deny the behaviour claimed in https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 The bug report is incorrect Modified: tomc

[Bug 53395] Syntactically incorrect webapp context.xml breaks auto deploy

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53395 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 53395] New: Syntactically incorrect webapp context.xml breaks auto deploy

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53395 Priority: P2 Bug ID: 53395 Assignee: dev@tomcat.apache.org Summary: Syntactically incorrect webapp context.xml breaks auto deploy Severity: normal Classification: U

[VOTE] Release Apache Tomcat Native 1.1.24

2012-06-11 Thread Mladen Turk
Version 1.1.24 is feature-add release containing additional API to set per-socket timeouts inside Poller. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The VOTE will remain open for at least 48 hours. The Apache Tomcat Native 1.1.24 is [ ] Stable, go

svn commit: r1348812 - /tomcat/native/tags/TOMCAT_NATIVE_1_1_24/

2012-06-11 Thread mturk
Author: mturk Date: Mon Jun 11 12:16:35 2012 New Revision: 1348812 URL: http://svn.apache.org/viewvc?rev=1348812&view=rev Log: Tag 1.2.34 Added: tomcat/native/tags/TOMCAT_NATIVE_1_1_24/ (props changed) - copied from r1348811, tomcat/native/branches/1.1.x/ Propchange: tomcat/native/ta

svn commit: r1348811 - in /tomcat/native/branches/1.1.x: build.properties.default native/include/tcn_version.h xdocs/miscellaneous/changelog.xml xdocs/miscellaneous/project.xml

2012-06-11 Thread mturk
Author: mturk Date: Mon Jun 11 12:13:04 2012 New Revision: 1348811 URL: http://svn.apache.org/viewvc?rev=1348811&view=rev Log: Add changelog entry and prepare for tag Modified: tomcat/native/branches/1.1.x/build.properties.default tomcat/native/branches/1.1.x/native/include/tcn_version.h

[Bug 53394] New: Log warning if SSLv2 is enabled

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53394 Priority: P2 Bug ID: 53394 Assignee: dev@tomcat.apache.org Summary: Log warning if SSLv2 is enabled Severity: major Classification: Unclassified OS: All Repor

[Bug 53071] ErrorReportValve ignores message from throwable

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #3 from Michael Osipov <1983-01...@gmx.net> --- (In reply to comment #2) > Fixed in trunk and 7.0.x and will be included in 7.0.28 onwards. > > Proposed for 6.0.x > > Notes: > 1. The message from the Throwable was displayed in

Re: Need a native connector release

2012-06-11 Thread Mark Thomas
On 11/06/2012 11:24, Mladen Turk wrote: > On 06/10/2012 05:11 PM, Mark Thomas wrote: >> On 10/06/2012 16:09, Mladen Turk wrote: >>> Sure. Need to double check few things, but Monday or Tuesday we should >>> have RC. >> >> Excellent. Thanks. >> > > Could you check binaries from > http://people.apac

[Bug 53391] CometEvent.close() doesn't close socket when called from different thread

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53391 --- Comment #2 from Mark Thomas --- I'm not convinced that the behaviour you are seeing is a bug. Currently: a) END if called from within event() closes the connection b) END if called from a separate thread does not close the connection

svn commit: r1348791 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMapEntry.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 10:49:50 2012 New Revision: 1348791 URL: http://svn.apache.org/viewvc?rev=1348791&view=rev Log: Javadoc fixes Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMapEntry.java Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/

svn commit: r1348790 - in /tomcat/trunk/java/org/apache: catalina/tribes/tipis/ReplicatedMapEntry.java tomcat/spdy/SpdyConnection.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 10:49:18 2012 New Revision: 1348790 URL: http://svn.apache.org/viewvc?rev=1348790&view=rev Log: Javadoc fixes Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/ReplicatedMapEntry.java tomcat/trunk/java/org/apache/tomcat/spdy/SpdyConnection.java M

[Bug 53393] tomcat-connectors-1.2.37-src Crashing web server segmentation fault

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53393 --- Comment #2 from Mladen Turk --- Any chance to get a backtrace? See http://httpd.apache.org/dev/debugging.html -- You are receiving this mail because: You are the assignee for the bug. -

svn commit: r1348786 - /tomcat/native/branches/1.1.x/native/srclib/VERSIONS

2012-06-11 Thread mturk
Author: mturk Date: Mon Jun 11 10:27:13 2012 New Revision: 1348786 URL: http://svn.apache.org/viewvc?rev=1348786&view=rev Log: Fix typo. Thanks Mark ;) Modified: tomcat/native/branches/1.1.x/native/srclib/VERSIONS Modified: tomcat/native/branches/1.1.x/native/srclib/VERSIONS URL: http://svn

Re: svn commit: r1348780 - in /tomcat/native/branches/1.1.x/native/srclib: VERSIONS openssl/openssl-msvcrt.patch

2012-06-11 Thread Mladen Turk
On 06/11/2012 11:58 AM, Mark Thomas wrote: On 11/06/2012 10:56, mt...@apache.org wrote: Author: mturk Date: Mon Jun 11 09:56:31 2012 New Revision: 1348780 URL: http://svn.apache.org/viewvc?rev=1348780&view=rev Log: Update openssl version and patch Modified: tomcat/native/branches/1.1.x/na

Re: Need a native connector release

2012-06-11 Thread Mladen Turk
On 06/10/2012 05:11 PM, Mark Thomas wrote: On 10/06/2012 16:09, Mladen Turk wrote: Sure. Need to double check few things, but Monday or Tuesday we should have RC. Excellent. Thanks. Could you check binaries from http://people.apache.org/~mturk/tomcat/ If they are OK, I'll T&R Cheers -- ^T

Re: svn commit: r1348780 - in /tomcat/native/branches/1.1.x/native/srclib: VERSIONS openssl/openssl-msvcrt.patch

2012-06-11 Thread Mark Thomas
On 11/06/2012 10:56, mt...@apache.org wrote: > Author: mturk > Date: Mon Jun 11 09:56:31 2012 > New Revision: 1348780 > > URL: http://svn.apache.org/viewvc?rev=1348780&view=rev > Log: > Update openssl version and patch > > Modified: > tomcat/native/branches/1.1.x/native/srclib/VERSIONS >

svn commit: r1348780 - in /tomcat/native/branches/1.1.x/native/srclib: VERSIONS openssl/openssl-msvcrt.patch

2012-06-11 Thread mturk
Author: mturk Date: Mon Jun 11 09:56:31 2012 New Revision: 1348780 URL: http://svn.apache.org/viewvc?rev=1348780&view=rev Log: Update openssl version and patch Modified: tomcat/native/branches/1.1.x/native/srclib/VERSIONS tomcat/native/branches/1.1.x/native/srclib/openssl/openssl-msvcrt.p

svn commit: r1348777 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/ErrorReportValve.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 09:50:03 2012 New Revision: 1348777 URL: http://svn.apache.org/viewvc?rev=1348777&view=rev Log: Fix logic Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Propchange: tomcat/tc7.0.x

svn commit: r1348776 - /tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 09:49:21 2012 New Revision: 1348776 URL: http://svn.apache.org/viewvc?rev=1348776&view=rev Log: Fix logic Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java U

[Bug 53393] tomcat-connectors-1.2.37-src Crashing web server segmentation fault

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53393 satyapal changed: What|Removed |Added Priority|P2 |P1 --- Comment #1 from satyapal --- ch

[Bug 53393] New: tomcat-connectors-1.2.37-src Crashing web server segmentation fault

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53393 Priority: P2 Bug ID: 53393 Assignee: dev@tomcat.apache.org Summary: tomcat-connectors-1.2.37-src Crashing web server segmentation fault Severity: normal Classificat

Re: svn commit: r1348772 - /tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

2012-06-11 Thread Mark Thomas
On 11/06/2012 10:42, Konstantin Kolinko wrote: > 2012/6/11 : >> Author: markt >> Date: Mon Jun 11 09:37:00 2012 >> New Revision: 1348772 >> >> URL: http://svn.apache.org/viewvc?rev=1348772&view=rev >> Log: >> Throwable.getMessage() might be null >> >> Modified: >>tomcat/trunk/java/org/apache/c

Re: svn commit: r1348772 - /tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

2012-06-11 Thread Konstantin Kolinko
2012/6/11 : > Author: markt > Date: Mon Jun 11 09:37:00 2012 > New Revision: 1348772 > > URL: http://svn.apache.org/viewvc?rev=1348772&view=rev > Log: > Throwable.getMessage() might be null > > Modified: >    tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java > > Modified: tomcat/t

svn commit: r1348773 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/ErrorReportValve.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 09:37:55 2012 New Revision: 1348773 URL: http://svn.apache.org/viewvc?rev=1348773&view=rev Log: Throwable.getMessage() might be null Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

svn commit: r1348772 - /tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 09:37:00 2012 New Revision: 1348772 URL: http://svn.apache.org/viewvc?rev=1348772&view=rev Log: Throwable.getMessage() might be null Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Modified: tomcat/trunk/java/org/apache/catalina/val

Re: svn commit: r1348762 - in /tomcat/trunk: java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread Mark Thomas
On 11/06/2012 10:33, Konstantin Kolinko wrote: > 2012/6/11 : >> Author: markt >> Date: Mon Jun 11 09:24:53 2012 >> New Revision: 1348762 >> >> URL: http://svn.apache.org/viewvc?rev=1348762&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 >> Stepping through the code

Re: svn commit: r1348762 - in /tomcat/trunk: java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread Konstantin Kolinko
2012/6/11 : > Author: markt > Date: Mon Jun 11 09:24:53 2012 > New Revision: 1348762 > > URL: http://svn.apache.org/viewvc?rev=1348762&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 > Stepping through the code, light dawns as to what the bug report was getting > at

[Bug 53071] ErrorReportValve ignores message from throwable

2012-06-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #2 from Mark Thomas --- Fixed in trunk and 7.0.x and will be included in 7.0.28 onwards. Proposed for 6.0.x Notes: 1. The message from the Throwable was displayed in the stack trace. 2. I modified the patch. The message from t

svn commit: r1348767 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 09:31:13 2012 New Revision: 1348767 URL: http://svn.apache.org/viewvc?rev=1348767&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1348765 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 09:28:46 2012 New Revision: 1348765 URL: http://svn.apache.org/viewvc?rev=1348765&view=rev Log: Update changelog Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/view

svn commit: r1348763 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 09:25:50 2012 New Revision: 1348763 URL: http://svn.apache.org/viewvc?rev=1348763&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 Stepping through the code, light dawns as to what the bug report was getting at. Use the message from the Thro

svn commit: r1348762 - in /tomcat/trunk: java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 09:24:53 2012 New Revision: 1348762 URL: http://svn.apache.org/viewvc?rev=1348762&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 Stepping through the code, light dawns as to what the bug report was getting at. Use the message from the Thro

svn commit: r1348755 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 08:53:03 2012 New Revision: 1348755 URL: http://svn.apache.org/viewvc?rev=1348755&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 Add a test case that confirms this issue does not occur in trunk Added: tomcat/tc7.0.x/trunk/test/org/ap

svn commit: r1348752 - /tomcat/trunk/test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread markt
Author: markt Date: Mon Jun 11 08:50:42 2012 New Revision: 1348752 URL: http://svn.apache.org/viewvc?rev=1348752&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 Add a test case that confirms this issue does not occur in trunk Added: tomcat/trunk/test/org/apache/cata