Re: WebSocket progress report

2012-02-15 Thread Petr Praus
Hello, attached is our patch. It applies cleanly on top of current trunk rev. 1244719. It has rudimentary support for fragmentation (callback after last frame), supports close messages and ping/pong. Sorry for not sending a patchset but I thought it wouldn't really make sense, since there were quit

[Tomcat Wiki] Trivial Update of "GettingStarted" by Keith Woodward

2012-02-15 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "GettingStarted" page has been changed by Keith Woodward: http://wiki.apache.org/tomcat/GettingStarted?action=diff&rev1=14&rev2=15 Comment: Important info for new starters about ser

[GUMP@vmgump]: Project tomcat-trunk-validate-eoln (in module tomcat-trunk) failed

2012-02-15 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate-eoln has an issue affecting its community integrati

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 12:10 PM, Mark Thomas wrote: > On 15/02/2012 19:58, Costin Manolache wrote: > > In spdy I'm using a SpdyFrame class ( spdy allow data frames to be > > fragmented any > > way you want by intermediary - so even if I receive a huge frame, I can > > split it > > in buffer-size

DO NOT REPLY [Bug 52677] embedded SetCharacterEncodingFilter in org.apache.catalina.filters is not usable as it does not implement javax.servlet.Filter

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52677 Gary Timuss changed: What|Removed |Added Priority|P2 |P3 CC|

DO NOT REPLY [Bug 52677] New: embedded SetCharacterEncodingFilter in org.apache.catalina.filters is not usable as it does not implement javax.servlet.Filter

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52677 Bug #: 52677 Summary: embedded SetCharacterEncodingFilter in org.apache.catalina.filters is not usable as it does not implement javax.servlet.Filter Product: Tomcat 5

Re: WebSocket progress report

2012-02-15 Thread Petr Praus
Hi, sorry for the delay, we got stalled a little bit, I'll post the patch today (US central time) after I manage to merge it (oh the cursed newlines). Thanks, Petr On Mon, Feb 13, 2012 at 14:18, Christopher Schultz < ch...@christopherschultz.net> wrote: > Jeremy, > > On 2/10/12 12:08 PM, Jeremy B

Re: AccessLogValve enhancement

2012-02-15 Thread Konstantin Kolinko
2012/2/16 Mark Claassen : > We would like to use the flexibility of the standard logging mechanism for > the AccessLogValue.  I could find no way to do this.  Looking at the > AccessLogValve code in Tomcat 7, it seems it would really would not be hard > to add. > > There already is standard logger

Re: AccessLogValve enhancement

2012-02-15 Thread Mark Claassen
Awesome. Thanks for the immediate response! I see that the ExtendedAccessLogValve would need to be tweaked as well, and that one would loose the repeating header bit when using the system logger (or "outputLogger") I guess th header could still be written on init (and maybe when the pattern chan

DO NOT REPLY [Bug 52640] Installer sets endorsed dirs with /common/ missing from path

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52640 Mark Thomas changed: What|Removed |Added OS/Version||All --- Comment #1 from Mark Thomas

svn commit: r1244747 - /tomcat/tc5.5.x/trunk/STATUS.txt

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 21:48:58 2012 New Revision: 1244747 URL: http://svn.apache.org/viewvc?rev=1244747&view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1

DO NOT REPLY [Bug 52671] NIO Connector: Exception invoking method readBufSize / writeBufSize in the JMX Proxy Servlet

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52671 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1244746 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/mbeans/MBeanDumper.java webapps/docs/changelog.xml

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 21:41:49 2012 New Revision: 1244746 URL: http://svn.apache.org/viewvc?rev=1244746&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52671 Log NPEs for attributes that are not set at debug. Modified: tomcat/tc7.0.x/trunk/ (props changed)

DO NOT REPLY [Bug 52669] Annotation processing, in WEB-INF/classes, for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scen

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: AccessLogValve enhancement

2012-02-15 Thread Mark Thomas
On 15/02/2012 21:23, Mark Claassen wrote: > We would like to use the flexibility of the standard logging mechanism for > the AccessLogValue. I could find no way to do this. Looking at the > AccessLogValve code in Tomcat 7, it seems it would really would not be hard > to add. I added org.apache.j

AccessLogValve enhancement

2012-02-15 Thread Mark Claassen
We would like to use the flexibility of the standard logging mechanism for the AccessLogValue. I could find no way to do this. Looking at the AccessLogValve code in Tomcat 7, it seems it would really would not be hard to add. There already is standard logger in the AccessLogValve class, which is

svn commit: r1244737 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java java/org/apache/catalina/startup/LocalStrings.properties webapps/docs/changelog.xml

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 21:22:19 2012 New Revision: 1244737 URL: http://svn.apache.org/viewvc?rev=1244737&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 Correct regression introduced by the invalid assumptions made in the hack for Eclipse to address https://issu

svn commit: r1244719 - /tomcat/trunk/java/org/apache/catalina/mbeans/MBeanDumper.java

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 20:58:16 2012 New Revision: 1244719 URL: http://svn.apache.org/viewvc?rev=1244719&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52671 Log NPEs for attributes that are not set at debug. Modified: tomcat/trunk/java/org/apache/catalina/mbeans

svn commit: r1244718 - in /tomcat/trunk/java/org/apache/catalina/startup: ContextConfig.java LocalStrings.properties

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 20:57:36 2012 New Revision: 1244718 URL: http://svn.apache.org/viewvc?rev=1244718&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 Correct regression introduced by the invalid assumptions made in the hack for Eclipse to address https://issu

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 19:58, Costin Manolache wrote: > In spdy I'm using a SpdyFrame class ( spdy allow data frames to be > fragmented any > way you want by intermediary - so even if I receive a huge frame, I can > split it > in buffer-sized frames - I believe you can do the same for websocket, as > long

Re: Tomcat web site UI update

2012-02-15 Thread Jeremy Brown
>That is a comment that the layout needs to be >cleaner (a comment I agree with). I agree too. I tried to create a cleaner layout and I posted a mockup for all to see and voice their opinions. https://s3.amazonaws.com/jjbosstracker/TomcatMockup.jpg I'll leave it to Mark, Konstantin, Wesley and w

DO NOT REPLY [Bug 52669] Annotation processing, in WEB-INF/classes, for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scen

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 Mike Youngstrom changed: What|Removed |Added CC||you...@gmail.com -- Configure b

DO NOT REPLY [Bug 51741] Eclipse WTP "Serve modules without publishing" broken with tc7, needs patch in tomcat

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51741 --- Comment #12 from Mark Thomas 2012-02-15 19:59:18 UTC --- Note that the patch to ContextConfig contained invalid assumptions that triggered regressions (see bug 52669). Namely: - the patch assumed that web applications were always deploy

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 10:31 AM, Mark Thomas wrote: > On 15/02/2012 16:11, Costin Manolache wrote: > > After I submit, I'll give a try to changing SocketWrapper (non-generic, > > add read/write), in the git. If you don't like it - easy to drop the > branch, > > but I think it'll simplify the old

svn commit: r1244639 - in /tomcat/trunk/java/org/apache/coyote/http11/upgrade: UpgradeAprProcessor.java UpgradeBioProcessor.java UpgradeNioProcessor.java UpgradeOutbound.java

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 18:40:19 2012 New Revision: 1244639 URL: http://svn.apache.org/viewvc?rev=1244639&view=rev Log: UCDetector warnings Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeAprProcessor.java tomcat/trunk/java/org/apache/coyote/http11/upgrade/Upgra

svn commit: r1244638 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcessor.java

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 18:39:29 2012 New Revision: 1244638 URL: http://svn.apache.org/viewvc?rev=1244638&view=rev Log: Fix refactoring snafu Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/UpgradeProcessor.java Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrad

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 16:11, Costin Manolache wrote: > After I submit, I'll give a try to changing SocketWrapper (non-generic, > add read/write), in the git. If you don't like it - easy to drop the branch, > but I think it'll simplify the old connectors enough to compensate for the > extra complexity I'm a

DO NOT REPLY [Bug 52666] EL should coerce String to Integer in equals operation

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52666 Mark Thomas changed: What|Removed |Added Component|Jasper |Jasper Version|7.0.25

svn commit: r1244575 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 16:31:36 2012 New Revision: 1244575 URL: http://svn.apache.org/viewvc?rev=1244575&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1244574 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/el/lang/ELSupport.java test/org/apache/el/lang/TestELSupport.java webapps/docs/changelog.xml

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 16:30:37 2012 New Revision: 1244574 URL: http://svn.apache.org/viewvc?rev=1244574&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52666 Correct coercion order in EL for A {==,!=,eq,ne} B Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1244567 - in /tomcat/trunk: java/org/apache/el/lang/ELSupport.java test/org/apache/el/lang/TestELSupport.java

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 16:26:08 2012 New Revision: 1244567 URL: http://svn.apache.org/viewvc?rev=1244567&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52666 Correct coercion order in EL for A {==,!=,eq,ne} B Modified: tomcat/trunk/java/org/apache/el/lang/ELSuppo

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 12:34 AM, Mark Thomas wrote: > > > Processor is tied to one request/response - Spdy protocol is a > multiplexing > > protocol, so one spdy connection will have 100s of Requests. > > I am using Processor interface for each muxed spdy stream. > > Hmm. I wonder if we need a d

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 12:56 AM, Mladen Turk wrote: > On 02/15/2012 04:53 AM, Costin Manolache wrote: > >> Uploaded another take. >> >> >> For non-SSL ( JIO, and apr without ssl ) -> SPDY just kicks in on all >> connections, >> this is just a short-cut for testing. I could also define a SpdyPro

Re: SPDY support

2012-02-15 Thread Costin Manolache
On Wed, Feb 15, 2012 at 6:33 AM, Mark Thomas wrote: > On 15/02/2012 03:53, Costin Manolache wrote: > > Uploaded another take. > > > > This time I'm just adding > > > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.java > > > > which is just a Handler - li

DO NOT REPLY [Bug 52548] service.bat fails to set catalina.base and catalina.home due to apparent procrun bug

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52548 Mark Thomas changed: What|Removed |Added Component|Integration |Native:Packaging Version|

svn commit: r1244524 - /tomcat/tc5.5.x/trunk/STATUS.txt

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 15:00:25 2012 New Revision: 1244524 URL: http://svn.apache.org/viewvc?rev=1244524&view=rev Log: Proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1

svn commit: r1244520 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 14:59:05 2012 New Revision: 1244520 URL: http://svn.apache.org/viewvc?rev=1244520&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1244519 - in /tomcat/tc7.0.x/trunk: ./ build.properties.default webapps/docs/changelog.xml

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 14:57:06 2012 New Revision: 1244519 URL: http://svn.apache.org/viewvc?rev=1244519&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52548 Update Commons Daemon to 1.0.9 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk

svn commit: r1244511 - /tomcat/trunk/build.properties.default

2012-02-15 Thread markt
Author: markt Date: Wed Feb 15 14:48:52 2012 New Revision: 1244511 URL: http://svn.apache.org/viewvc?rev=1244511&view=rev Log: Update to Commons Daemon 1.0.9 Modified: tomcat/trunk/build.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tom

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 03:53, Costin Manolache wrote: > Uploaded another take. > > This time I'm just adding > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.java > > which is just a Handler - like AjpConnectionHandler, > Http11ConnectionHandler. > > I believe t

DO NOT REPLY [Bug 52671] New: NIO Connector: Exception invoking method readBufSize / writeBufSize in the JMX Proxy Servlet

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52671 Bug #: 52671 Summary: NIO Connector: Exception invoking method readBufSize / writeBufSize in the JMX Proxy Servlet Product: Tomcat 7 Version: 7.0.25 Platform: PC

DO NOT REPLY [Bug 52669] Annotation processing, in WEB-INF/classes, for Servlets/Listeners/Filters is skipped when the web app is not extracted, classes do not have packages and for some embedded scen

2012-02-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52669 violet...@apache.org changed: What|Removed |Added Summary|Annotation processing for |Annotation processing, in

Re: SPDY support

2012-02-15 Thread Mladen Turk
On 02/15/2012 04:53 AM, Costin Manolache wrote: Uploaded another take. For non-SSL ( JIO, and apr without ssl ) -> SPDY just kicks in on all connections, this is just a short-cut for testing. I could also define a SpdyProtocol and set it directly on the connector - but seems too much overhead

Re: SPDY support

2012-02-15 Thread Mark Thomas
On 15/02/2012 03:53, Costin Manolache wrote: > Uploaded another take. > > This time I'm just adding > https://github.com/costinm/tomcat/blob/trunk/java/org/apache/tomcat/util/net/LightHandler.java > > which is just a Handler - like AjpConnectionHandler, > Http11ConnectionHandler. > > I believe t