Re: [VOTE] Apache Tomcat Maven plugin 2.0-beta-1

2012-01-29 Thread Olivier Lamy
Hello, After the usual 72H vote time, it's still missing 2 binding votes. As this release has new awaited features, I wonder if some PMCs could have a look and push a +1. IMHO a lot of users will be happy with a releasing containing the tomcat7 support and the other feature (executable jar/war).

DO NOT REPLY [Bug 52444] Classloading-based ServletContainerInitializer @HandlesTypes processing can result in long startup times

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52444 --- Comment #7 from Mark Thomas 2012-01-29 23:23:15 UTC --- I think I have a patch for this. The unit tests pass but I want to run the TCK as well before I commit anything. That'll be tomorrow at the earliest now. -- Configure bugmail: ht

Re: WebSocket progress report

2012-01-29 Thread Mark Thomas
On 29/01/2012 22:49, Costin Manolache wrote: > On Sun, Jan 29, 2012 at 2:19 AM, Mark Thomas wrote: > >> On 29/01/2012 01:20, Costin Manolache wrote: >>> On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas wrote: >>> >>> Not complaining - it's great to add this feature, please commit it - but >>> I'm wo

Re: WebSocket progress report

2012-01-29 Thread Costin Manolache
On Sun, Jan 29, 2012 at 2:19 AM, Mark Thomas wrote: > On 29/01/2012 01:20, Costin Manolache wrote: > > On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas wrote: > > > > Not complaining - it's great to add this feature, please commit it - but > > I'm wondering > > if a lighter interface wouldn't be bet

DO NOT REPLY [Bug 52444] Classloading-based ServletContainerInitializer @HandlesTypes processing can result in long startup times

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52444 --- Comment #6 from Mark Thomas 2012-01-29 22:05:05 UTC --- (In reply to comment #5) > I was looking at using the bcel.util.SyntheticRepository when you fixed the > annotations... That would work but you'd need an additional cache to save

DO NOT REPLY [Bug 52444] Classloading-based ServletContainerInitializer @HandlesTypes processing can result in long startup times

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52444 --- Comment #5 from Pid 2012-01-29 21:51:17 UTC --- > In summary, b) is the only remaining problem to solve. The solution looks like > requiring caching all the javaClass instances and then doing the HandlesTypes > processing (and then thro

DO NOT REPLY [Bug 52549] scanning HandlesTypes causes aggressive classloading

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52549 --- Comment #5 from Costin Leau 2012-01-29 21:47:04 UTC --- You're right, I mixed the various types that trigger/are part of the scanning process but hopefully my suggestions (to try to eliminate loading by looking at the class content/dep

DO NOT REPLY [Bug 52444] Classloading-based ServletContainerInitializer @HandlesTypes processing can result in long startup times

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52444 --- Comment #4 from Costin Leau 2012-01-29 21:37:58 UTC --- Thanks for looking at this Mark. The more classes can be eliminated from loading, the better. Cheers! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab

Re: DO NOT REPLY [Bug 52543] Exception

2012-01-29 Thread Pid
On 27/01/2012 17:37, Pid wrote: > On 27/01/2012 15:18, sebb wrote: >> On 27 January 2012 13:38, wrote: >>> https://issues.apache.org/bugzilla/show_bug.cgi?id=52543 >>> >>> Pid changed: >>> >>> What|Removed |Added >>> -

Re: svn commit: r1237428 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-29 Thread Konstantin Kolinko
2012/1/29 : > Author: markt > Date: Sun Jan 29 19:31:42 2012 > New Revision: 1237428 > > URL: http://svn.apache.org/viewvc?rev=1237428&view=rev > Log: > Remove deprecated code > > Modified: >    tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java > 1. The mbeans-descriptors.xml file

svn commit: r1237431 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java

2012-01-29 Thread markt
Author: markt Date: Sun Jan 29 19:34:45 2012 New Revision: 1237431 URL: http://svn.apache.org/viewvc?rev=1237431&view=rev Log: Deprecate code that has been removed in 8.0.x Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/ContextConfi

svn commit: r1237428 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-29 Thread markt
Author: markt Date: Sun Jan 29 19:31:42 2012 New Revision: 1237428 URL: http://svn.apache.org/viewvc?rev=1237428&view=rev Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConf

svn commit: r1237427 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-29 Thread markt
Author: markt Date: Sun Jan 29 19:31:05 2012 New Revision: 1237427 URL: http://svn.apache.org/viewvc?rev=1237427&view=rev Log: Deprecate code that is going to be removed Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina

svn commit: r1237426 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-29 Thread markt
Author: markt Date: Sun Jan 29 19:30:27 2012 New Revision: 1237426 URL: http://svn.apache.org/viewvc?rev=1237426&view=rev Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConf

svn commit: r1237425 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-29 Thread markt
Author: markt Date: Sun Jan 29 19:29:50 2012 New Revision: 1237425 URL: http://svn.apache.org/viewvc?rev=1237425&view=rev Log: Deprecate unused/unnecessary code Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/startup/

svn commit: r1237424 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-29 Thread markt
Author: markt Date: Sun Jan 29 19:29:11 2012 New Revision: 1237424 URL: http://svn.apache.org/viewvc?rev=1237424&view=rev Log: UCDetector. Add finals where appropriate Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org/apache/catalina/s

DO NOT REPLY [Bug 52517] Server affecting URLConnector's defaultUseCache settings

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52517 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 52545] Annotations are processed for servlet 2.4 applications

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52545 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 52545] Annotations are processed for servlet 2.4 applications

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52545 Eugene Petrenko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|INVA

DO NOT REPLY [Bug 52547] incorrect byeswritten log after completed async request under http1.0

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52547 --- Comment #2 from David 2012-01-29 18:56:37 UTC --- Thank you Mark. Additionally, I think there is a "bug" in that the recycle() happens immediatley after the nextRequest() even when keepalive is true (I can see from an iptables log that

DO NOT REPLY [Bug 52549] scanning HandlesTypes causes aggressive classloading

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52549 --- Comment #4 from Mark Thomas 2012-01-29 17:45:17 UTC --- Just for the record, you appear to have missed the point of this code. The list of ServletContainerInitializer is obtained from META-INF/services/javax.servlet.ServletContainerIni

DO NOT REPLY [Bug 52444] Classloading-based ServletContainerInitializer @HandlesTypes processing can result in long startup times

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52444 --- Comment #3 from Mark Thomas 2012-01-29 17:36:02 UTC --- Bringing across the list of suggestions from the duplicate... > a. if the class is an annotation, skip it Fixed in trunk and 7.0.x and will be included in 7.0.26 onwards. > b. if

svn commit: r1237336 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/ContextConfig.java java/org/apache/tomcat/util/bcel/Constants.java java/org/apache/tomcat/util/bcel/classfile/Acces

2012-01-29 Thread markt
Author: markt Date: Sun Jan 29 16:43:45 2012 New Revision: 1237336 URL: http://svn.apache.org/viewvc?rev=1237336&view=rev Log: Restore some previously removed BCEL code that is required for fixing BZ52444. Use it to determine if a class is an annotation without loading the class. Modified: t

svn commit: r1237334 - /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java

2012-01-29 Thread markt
Author: markt Date: Sun Jan 29 16:39:26 2012 New Revision: 1237334 URL: http://svn.apache.org/viewvc?rev=1237334&view=rev Log: No need to load class to determine if it is an annotation. Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Modified: tomcat/trunk/java/org

svn commit: r1237332 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel: Constants.java classfile/AccessFlags.java

2012-01-29 Thread markt
Author: markt Date: Sun Jan 29 16:38:45 2012 New Revision: 1237332 URL: http://svn.apache.org/viewvc?rev=1237332&view=rev Log: Restore some previously removed code that is required for fixing BZ52444. Need to be able to determine if a class is an annotation without loading the class. Modified:

Re: WebSocket progress report

2012-01-29 Thread sebb
On 29 January 2012 10:19, Mark Thomas wrote: > On 29/01/2012 01:20, Costin Manolache wrote: >> On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas wrote: >> >> Not complaining - it's great to add this feature, please commit it - but >> I'm wondering >> if a lighter interface wouldn't be better. From loo

DO NOT REPLY [Bug 52549] scanning HandlesTypes causes aggressive classloading

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52549 --- Comment #3 from Costin Leau 2012-01-29 14:26:45 UTC --- I'm not sure why this issue has been marked as a duplicate. This is not about long startup times or memory consumption, but rather unneeded class loading that simply breaks existi

DO NOT REPLY [Bug 52444] Classloading-based ServletContainerInitializer @HandlesTypes processing can result in long startup times

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52444 Mark Thomas changed: What|Removed |Added CC||costin.l...@gmail.com --- Comment #2

DO NOT REPLY [Bug 52549] scanning HandlesTypes causes aggressive classloading

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52549 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 52549] scanning HandlesTypes causes aggressive classloading

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52549 Costin Leau changed: What|Removed |Added OS/Version||All --- Comment #1 from Costin Leau

DO NOT REPLY [Bug 52326] Lower log level for failed class loading

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52326 --- Comment #8 from Costin Leau 2012-01-29 11:33:15 UTC --- Another +1 regarding skipping class loading - it simply has too many bad side effects (including initializing static blocks way too early). See bug 52549 for more info. -- Confi

DO NOT REPLY [Bug 52549] New: scanning HandlesTypes causes aggressive classloading

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52549 Bug #: 52549 Summary: scanning HandlesTypes causes aggressive classloading Product: Tomcat 7 Version: 7.0.25 Platform: PC Status: NEW Severity: normal Pr

DO NOT REPLY [Bug 52235] Please do a bit of SEO tuning for the web site

2012-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52235 --- Comment #11 from Pid 2012-01-29 11:15:42 UTC --- I've never seen this work immediately, it may take Google some time to resort the results. The Google Webmaster Tools site will allow an authorised user to monitor sitemap processing. h

Re: WebSocket progress report

2012-01-29 Thread Mark Thomas
On 29/01/2012 01:20, Costin Manolache wrote: > On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas wrote: > > Not complaining - it's great to add this feature, please commit it - but > I'm wondering > if a lighter interface wouldn't be better. From looking at the > implementation, it seems > after the