DO NOT REPLY [Bug 52384] URL parameter without value should be parsed successfully when logging level = DEBUG

2012-01-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52384 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1229027 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/tomcat/util/http/LocalStrings.properties java/org/apache/tomcat/util/http/Parameters.java webapps/docs/changelog.xml

2012-01-08 Thread kkolinko
Author: kkolinko Date: Mon Jan 9 04:50:17 2012 New Revision: 1229027 URL: http://svn.apache.org/viewvc?rev=1229027&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52384 Do not fail in Parameter parsing when debug logging is enabled. Also do not flag extra '&' in parameters as

Re: ant build failing: could not find file modules/jdbc-pool/doc/jdbc-pool.xml to copy

2012-01-08 Thread Konstantin Kolinko
2012/1/9 S Ahmed : > Well the readme said it may fail on mac osx because it tries to write to > /usr/share/java to store the libraries etc. Eh, which readme? It is a bad idea to let them been written to /usr/share/java. That is just a default value. You should really reconfigure it to use some ot

Re: ant build failing: could not find file modules/jdbc-pool/doc/jdbc-pool.xml to copy

2012-01-08 Thread S Ahmed
svn worked fine. Sorry about this, but I'm new to Eclipse kinda. So I when to file, import, general | existing projects into workspace. Now which is the root folder in the source? On Sun, Jan 8, 2012 at 6:44 PM, S Ahmed wrote: > Well the readme said it may fail on mac osx because it tries to

Re: ant build failing: could not find file modules/jdbc-pool/doc/jdbc-pool.xml to copy

2012-01-08 Thread S Ahmed
Well the readme said it may fail on mac osx because it tries to write to /usr/share/java to store the libraries etc. When I ran ant, the build didn't work, running sudo allowed it continue (but from now on running just ant w/o sudo is fine, I guess it was just initially to write to that folder).

Re: ant build failing: could not find file modules/jdbc-pool/doc/jdbc-pool.xml to copy

2012-01-08 Thread Konstantin Kolinko
2012/1/9 S Ahmed : > 2. sudo ant Just curious regarding the above command: you do not need root rights to build Tomcat! Actually you should never be using root rights when building, testing and using Tomcat. (The only exception is running it with jsvc service wrapper). http://xkcd.com/149/ Be

Re: ant build failing: could not find file modules/jdbc-pool/doc/jdbc-pool.xml to copy

2012-01-08 Thread Konstantin Kolinko
2012/1/9 S Ahmed : > Hi, > Exciting to get the source working locally! > > I'm on Mac osx lion. > > 1. I did a git clone from:https://github.com/apache/tomcat70 > 2. sudo ant > And I got: > > compile-prepare: > > BUILD FAILED > /Users/me/dev/sources/tomcat70/build.xml:493: Warning: Could not find f

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2012-01-08 Thread Konstantin Kolinko
>> 2012/1/7 Rainer Jung : >>> >>> Maybe enable the accesslog during testing with test.accesslog=true, so one >>> can check after the next failure whether the contents agree with your >>> assumption. Not sure, whether Gump offers access to the access log for >>> checking. >> >> +1, but needs some fi

ant build failing: could not find file modules/jdbc-pool/doc/jdbc-pool.xml to copy

2012-01-08 Thread S Ahmed
Hi, Exciting to get the source working locally! I'm on Mac osx lion. 1. I did a git clone from:https://github.com/apache/tomcat70 2. sudo ant And I got: compile-prepare: BUILD FAILED /Users/me/dev/sources/tomcat70/build.xml:493: Warning: Could not find file /Users/me/dev/sources/tomcat70/module

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2012-01-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #24 from gober...@msn.com 2012-01-08 22:38:44 UTC --- I actually played with Jetty WebSocket API last Friday and was able to embed it into Tomcat quite easily. The only issue is that it has to be on a separate port. As I mentione

svn commit: r1228983 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/core/TestAsyncContextImpl.java

2012-01-08 Thread kkolinko
Author: kkolinko Date: Sun Jan 8 22:27:15 2012 New Revision: 1228983 URL: http://svn.apache.org/viewvc?rev=1228983&view=rev Log: Merged revision 1228969 from tomcat/trunk: Update TestAsyncContextImpl, so that the test logic does not need to change when the tests are run with "test.accesslog=true

svn commit: r1228981 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Connector.java test/org/apache/catalina/mbeans/TestRegistration.java

2012-01-08 Thread kkolinko
Author: kkolinko Date: Sun Jan 8 22:25:00 2012 New Revision: 1228981 URL: http://svn.apache.org/viewvc?rev=1228981&view=rev Log: Merged revision 1228929 from tomcat/trunk: Followup to Mark's r1228724 The ObjectName.quote() must always be called with address, because ip6 addresses have characters

svn commit: r1228980 - in /tomcat/tc7.0.x/trunk: ./ build.properties.default build.xml

2012-01-08 Thread kkolinko
Author: kkolinko Date: Sun Jan 8 22:21:39 2012 New Revision: 1228980 URL: http://svn.apache.org/viewvc?rev=1228980&view=rev Log: Merged revision 1228920 from tomcat/trunk: Re-enable TestCometProcessor test. It reverts r1225632 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.

svn commit: r1228979 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/comet/TestCometProcessor.java

2012-01-08 Thread kkolinko
Author: kkolinko Date: Sun Jan 8 22:19:49 2012 New Revision: 1228979 URL: http://svn.apache.org/viewvc?rev=1228979&view=rev Log: Merged revision 1228918 from tomcat/trunk: Change TestCometProcessor#testCometConnectorStop() to test whether END event was processed by servlet and write other inform

Re: [VOTE] Release Tomcat 5.5.35 Build

2012-01-08 Thread Jim Jagielski
Done On Jan 7, 2012, at 5:54 PM, Rainer Jung wrote: > The signature files for all bin tarballs are missing. Can you please add them? > > src and zip/exe are OK. > > Thanks! > > Rainer > > - > To unsubscribe, e-mail: dev-unsubs

svn commit: r1228969 - /tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java

2012-01-08 Thread kkolinko
Author: kkolinko Date: Sun Jan 8 22:03:24 2012 New Revision: 1228969 URL: http://svn.apache.org/viewvc?rev=1228969&view=rev Log: Update TestAsyncContextImpl: Always add a host-level AccessLogValve, so that the test logic does not need to change when the tests are run with "test.accesslog=true".

DO NOT REPLY [Bug 52318] Version in tomcat-jdbc POM is conflicted with Version in MANIFEST for JULI JAR

2012-01-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52318 --- Comment #3 from Pid 2012-01-08 21:55:56 UTC --- *** Bug 52429 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because

DO NOT REPLY [Bug 52429] Wrong exports in tomcat-jdbc MANIFEST

2012-01-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52429 Pid changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: svn commit: r1228929 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java test/org/apache/catalina/mbeans/TestRegistration.java

2012-01-08 Thread Konstantin Kolinko
2012/1/8 : > Author: kkolinko > Date: Sun Jan  8 19:33:57 2012 > New Revision: 1228929 > > URL: http://svn.apache.org/viewvc?rev=1228929&view=rev > Log: > Followup to Mark's r1228724 > The ObjectName.quote() must always be called with address, because ip6 > addresses have characters that are must

svn commit: r1228929 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java test/org/apache/catalina/mbeans/TestRegistration.java

2012-01-08 Thread kkolinko
Author: kkolinko Date: Sun Jan 8 19:33:57 2012 New Revision: 1228929 URL: http://svn.apache.org/viewvc?rev=1228929&view=rev Log: Followup to Mark's r1228724 The ObjectName.quote() must always be called with address, because ip6 addresses have characters that are must be quoted in QName. The Conn

svn commit: r1228926 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: C2BConverter.java MessageBytes.java

2012-01-08 Thread markt
Author: markt Date: Sun Jan 8 19:22:05 2012 New Revision: 1228926 URL: http://svn.apache.org/viewvc?rev=1228926&view=rev Log: Use final Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/C2BConverter.java tomcat/trunk/java/org/apache/tomcat/util/buf/MessageBytes.java Modified: tomca

svn commit: r1228925 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/buf/

2012-01-08 Thread markt
Author: markt Date: Sun Jan 8 19:21:21 2012 New Revision: 1228925 URL: http://svn.apache.org/viewvc?rev=1228925&view=rev Log: Mark unused code as deprecated. It has been removed for 8.0.x onwards. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomc

svn commit: r1228924 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: Ascii.java ByteChunk.java C2BConverter.java CharChunk.java MessageBytes.java

2012-01-08 Thread markt
Author: markt Date: Sun Jan 8 19:15:52 2012 New Revision: 1228924 URL: http://svn.apache.org/viewvc?rev=1228924&view=rev Log: Remove unused code Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/Ascii.java tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java tomcat/trunk/

svn commit: r1228922 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: Ascii.java ByteChunk.java C2BConverter.java MessageBytes.java

2012-01-08 Thread markt
Author: markt Date: Sun Jan 8 19:12:14 2012 New Revision: 1228922 URL: http://svn.apache.org/viewvc?rev=1228922&view=rev Log: Deprecate unused code Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/Ascii.java tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java tomcat/tru

svn commit: r1228920 - in /tomcat/trunk: build.properties.default build.xml

2012-01-08 Thread kkolinko
Author: kkolinko Date: Sun Jan 8 19:04:55 2012 New Revision: 1228920 URL: http://svn.apache.org/viewvc?rev=1228920&view=rev Log: Re-enable TestCometProcessor test. It reverts r1225632 Modified: tomcat/trunk/build.properties.default tomcat/trunk/build.xml Modified: tomcat/trunk/build.pro

svn commit: r1228918 - /tomcat/trunk/test/org/apache/catalina/comet/TestCometProcessor.java

2012-01-08 Thread kkolinko
Author: kkolinko Date: Sun Jan 8 19:02:55 2012 New Revision: 1228918 URL: http://svn.apache.org/viewvc?rev=1228918&view=rev Log: Change TestCometProcessor#testCometConnectorStop() to test whether END event was processed by servlet and write other information as a log message. The old test was no

svn commit: r1228910 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: B2CConverter.java StringCache.java

2012-01-08 Thread markt
Author: markt Date: Sun Jan 8 18:44:21 2012 New Revision: 1228910 URL: http://svn.apache.org/viewvc?rev=1228910&view=rev Log: Add final where necessary. Remove some unused code. Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java tomcat/trunk/java/org/apache/tomcat/u

svn commit: r1228909 - in /tomcat/trunk: java/org/apache/tomcat/util/buf/ test/org/apache/tomcat/util/buf/

2012-01-08 Thread markt
Author: markt Date: Sun Jan 8 18:43:32 2012 New Revision: 1228909 URL: http://svn.apache.org/viewvc?rev=1228909&view=rev Log: Removed deprecated and unused code Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/Ascii.java tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

svn commit: r1228908 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: Ascii.java B2CConverter.java ByteChunk.java C2BConverter.java CharChunk.java HexUtils.java MessageBytes.java UDecoder.java UEnc

2012-01-08 Thread markt
Author: markt Date: Sun Jan 8 18:42:10 2012 New Revision: 1228908 URL: http://svn.apache.org/viewvc?rev=1228908&view=rev Log: Mark unused code as deprecated Based on the UCDector report Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/Ascii.java tomcat/trunk/java/org/apache/tomcat/

DO NOT REPLY [Bug 51181] Add support for Web Sockets

2012-01-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #23 from Mark Thomas 2012-01-08 13:03:42 UTC --- (In reply to comment #22) > Is there any estimate when WebSockets support will be implemented? No. The preparatory work of aligning the connectors is pretty much complete which

DO NOT REPLY [Bug 41697] make visible in debug output if charset from browser ignored

2012-01-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=41697 Mark Thomas changed: What|Removed |Added Status|VERIFIED|CLOSED --- Comment #5 from Mark Thom